Граф коммитов

322 Коммитов

Автор SHA1 Сообщение Дата
Nobuyoshi Nakada 689b5ae752
Split YJIT rules for CODEOWNERS 2022-06-02 10:12:34 +09:00
Nobuyoshi Nakada 7d9da4c33d
Use `$(CHDIR)` so works with symlink [ci skip] 2022-05-27 09:56:01 +09:00
Nobuyoshi Nakada be26f40682
Revert "Stop rebuilding miniruby always [ci skip]"
This reverts commit 2f5edfa47d.
2022-05-27 09:54:45 +09:00
Nobuyoshi Nakada 2f5edfa47d
Stop rebuilding miniruby always [ci skip] 2022-05-26 15:26:33 +09:00
Alan Wu f90549cd38 Rust YJIT
In December 2021, we opened an [issue] to solicit feedback regarding the
porting of the YJIT codebase from C99 to Rust. There were some
reservations, but this project was given the go ahead by Ruby core
developers and Matz. Since then, we have successfully completed the port
of YJIT to Rust.

The new Rust version of YJIT has reached parity with the C version, in
that it passes all the CRuby tests, is able to run all of the YJIT
benchmarks, and performs similarly to the C version (because it works
the same way and largely generates the same machine code). We've even
incorporated some design improvements, such as a more fine-grained
constant invalidation mechanism which we expect will make a big
difference in Ruby on Rails applications.

Because we want to be careful, YJIT is guarded behind a configure
option:

```shell
./configure --enable-yjit # Build YJIT in release mode
./configure --enable-yjit=dev # Build YJIT in dev/debug mode
```

By default, YJIT does not get compiled and cargo/rustc is not required.
If YJIT is built in dev mode, then `cargo` is used to fetch development
dependencies, but when building in release, `cargo` is not required,
only `rustc`. At the moment YJIT requires Rust 1.60.0 or newer.

The YJIT command-line options remain mostly unchanged, and more details
about the build process are documented in `doc/yjit/yjit.md`.

The CI tests have been updated and do not take any more resources than
before.

The development history of the Rust port is available at the following
commit for interested parties:
1fd9573d8b

Our hope is that Rust YJIT will be compiled and included as a part of
system packages and compiled binaries of the Ruby 3.2 release. We do not
anticipate any major problems as Rust is well supported on every
platform which YJIT supports, but to make sure that this process works
smoothly, we would like to reach out to those who take care of building
systems packages before the 3.2 release is shipped and resolve any
issues that may come up.

[issue]: https://bugs.ruby-lang.org/issues/18481

Co-authored-by: Maxime Chevalier-Boisvert <maximechevalierb@gmail.com>
Co-authored-by: Noah Gibbs <the.codefolio.guy@gmail.com>
Co-authored-by: Kevin Newton <kddnewton@gmail.com>
2022-04-27 11:00:22 -04:00
Nobuyoshi Nakada bb0a22a8c0 Obey spec file locations to rubygems 2022-04-07 09:47:10 +09:00
Nobuyoshi Nakada abfd859b13
Remove github and git related files from extracted bundled gems 2022-03-31 10:49:55 +09:00
Jean Boussier 8d05047d72 Add a Module#const_added callback
[Feature #17881]

Works similarly to `method_added` but for constants.

```ruby
Foo::BAR = 42 # call Foo.const_added(:FOO)
class Foo::Baz; end # call Foo.const_added(:Baz)
Foo.autoload(:Something, "path") # call Foo.const_added(:Something)
```
2022-01-14 11:30:07 +01:00
Nobuyoshi Nakada abc4a46046
Get rid of building main again when test-bundled-gems 2022-01-14 14:54:29 +09:00
Nobuyoshi Nakada 071653ecd7
Run the prerequisites of test-bundled-gems in order 2022-01-02 02:04:05 +09:00
Nobuyoshi Nakada 4a6ca12904
Remove unversioned phony target for pkgconfig file [Bug #18374]
It results in a circular dependency when `--with-ruby-pc=ruby.pc`
is given.  [ci skip]
2021-12-04 16:20:30 +09:00
Nobuyoshi Nakada a4964174e2
Fix circular dependencies specific to in-place build [Bug #18374]
* Move the rubyspec running recipe after the rule for rubyspec
  C-API extension library, so that separate dummy recipe is not
  needed.

* Add a dummy recipe for rubyspec.h before the rubyspec running
  recipe, so that the dependency of extensions do not fire the
  latter.
2021-12-04 10:40:15 +09:00
Nobuyoshi Nakada a7d0c2c448
Needs to update revision.h unless existing [ci skip] 2021-12-02 12:28:49 +09:00
Nobuyoshi Nakada 179aa26f4f
Prune stale worktrees before checking out a new pull request [ci skip] 2021-10-28 13:14:31 +09:00
Nobuyoshi Nakada be9cc6c758
Fix rubyspec_capiext dependency and flags
- The file needed to link may be the import library.
- Remove duplicate flags.
2021-08-30 12:03:44 +09:00
Nobuyoshi Nakada 9227989343
Use proper suffix 2021-08-30 00:18:16 +09:00
Yuta Saito 01be881f35 Use `empty` instead of NOOP in mk file to make it safer
This would avoid unintentional use of the `NOOP` environment variable

Co-authored-by: Nobuyoshi Nakada <nobu@ruby-lang.org>
2021-08-25 18:47:44 +09:00
Yuta Saito d1f0d1ca2e Fix build failure on macOS with --enable-shared
./spec/ruby/optional/capi/ext/array_spec.c can match with spec/%/ if
using GNU Make under version 3.81. make command installed on macOS is
3.81, so ruby can't be built with default make on macOS with
  --enable-shared option since bda56a03a6
2021-08-25 18:47:44 +09:00
Kazuki Tsujimoto 4568ba0711
Show verbose error messages when single pattern match fails
[0] => [0, *, a]
    #=> [0] length mismatch (given 1, expected 2+) (NoMatchingPatternError)

Ignore test failures of typeprof caused by this change for now.
2021-08-15 09:38:24 +09:00
Nobuyoshi Nakada 2e49e4330d
Disable debug flag for executable files when LTO [ci skip]
Get rid of tons of linker warnings that it could not find object
file symbol for every symbols, when targeting darwin.
2021-08-14 23:22:04 +09:00
Nobuyoshi Nakada e3dcb6204d
Run only directories or *_spec.rb files only by mspec [Bug #18072]
Not to match *.c files under spec/ruby/optional/capi/ext, in the
case of in-place build.
2021-08-10 14:22:44 +09:00
Nobuyoshi Nakada 6e60fc2945
Group commands on GitHub Actions 2021-08-07 18:32:24 +09:00
Nobuyoshi Nakada d868c8f08f
Make jobserver available 2021-08-06 20:58:13 +09:00
Nobuyoshi Nakada bda56a03a6
Build rubyspec CAPI extensions 2021-08-05 22:30:48 +09:00
Nobuyoshi Nakada 82191da2a2 Predefine recursive key ID 2021-07-27 15:40:27 +09:00
Nobuyoshi Nakada 0754cc4888 Added intern_ids.rb 2021-07-27 15:40:27 +09:00
Nobuyoshi Nakada 9edad0df74
Remove short options with argument [Bug #17870]
Remove GNU make `-O` and `-W` options which are short but followed
by an argument, so that `$mflags.set?(?n)` does not return `true`
wrongly.
2021-05-21 10:34:28 +09:00
Nobuyoshi Nakada 68a6f6c4ab
mac: ignore SDKROOT at installation 2021-04-10 11:57:45 +09:00
Nobuyoshi Nakada 44f038bd7f
gmake.mk: renamed BUNDLED_GEMS as bundled-gems
Hyphenated names are safe in GNU make.
2020-12-02 17:04:33 +09:00
Nobuyoshi Nakada 75d48a533d
rubyspec-capiext: Use plain DLDFLAGS without flags for libruby 2020-11-22 19:09:58 +09:00
Nobuyoshi Nakada ece917bab3
Added rubyspec-capiext target
This target builds extensions for rubyspec optional C-API tests.
2020-11-21 23:17:48 +09:00
Nobuyoshi Nakada a9ff390870
Fixed installation failure [Bug #17191]
Try update and extract bundled gems only when baseruby is
available.  It should be done only when installing from
developemental build and not from the tarball, but it is not
obvious to differentiate them.
2020-09-29 13:41:59 +09:00
Nobuyoshi Nakada 4ea57c2a39
Escape `#` for GNU make 3 2020-07-05 19:15:03 +09:00
Nobuyoshi Nakada 358f91bf6f
Skip comment and empty lines in gems/bundled_gems file 2020-07-05 18:59:06 +09:00
Nobuyoshi Nakada 6fdd5e26c6
Removed duplicate target
While `spec/bundler` and `spec/bundler/` are treated different
targets by GNU make 4, the same target by GNU make 3.  The latter
target, ending with a slash, was to run `test-bundler-parallel`,
instead of `spec/bundler/%`.
2020-06-25 18:21:41 +09:00
Nobuyoshi Nakada 96d184aa49
Run spec/bundler without a sub-make 2020-06-10 23:30:13 +09:00
Nobuyoshi Nakada 73ca989a81
spec/bundler must not be run by mspec 2020-06-10 21:56:36 +09:00
Nobuyoshi Nakada 964829495c
Removed + token from single test runner recipes [ci skip]
These test runners do not deal with `-n` make flag.
2020-06-09 18:52:31 +09:00
Nobuyoshi Nakada d0b2332e93
Defaulted benchmark output to markdown with comarison 2020-06-08 09:25:22 +09:00
Nobuyoshi Nakada e38a2ecffd
Run tests in more parallel 2020-06-06 00:35:45 +09:00
Nobuyoshi Nakada cf1adf985a
Aligned test-bundler-parallel at the end of the test order 2020-06-05 21:54:39 +09:00
Nobuyoshi Nakada 3fa4fd4780
Pass MAKE value to configure for non-default name case
GNU make does not export it by default.
2020-05-11 00:18:06 +09:00
Nobuyoshi Nakada 21d0b40de2 Added tooldir variable 2020-04-05 09:26:57 +09:00
Nobuyoshi Nakada 0540df3ed7
Ensure the cache directory to be shared exists 2020-04-02 22:30:17 +09:00
Nobuyoshi Nakada 03ca90c732
Share download cache with bundler 2020-03-31 17:36:52 +09:00
Nobuyoshi Nakada 476ac00e49
Deal with bundled gems by BASERUBY
As the currently released/snapshot tarballs should contain the
bundled gems extracted already, RUNRUBY is not required when
building from them with GNU make.
2020-03-28 18:09:27 +09:00
Nobuyoshi Nakada 88f4ebac83
Update and extract for each gem 2020-03-13 15:34:50 +09:00
Nobuyoshi Nakada 46f4cfb162
`update-gems` should wait for `update-bundled_gems` 2020-03-13 00:27:19 +09:00
Nobuyoshi Nakada 289bdb64d9
Add prepare-gems to download and extract bundled gems 2020-03-12 22:58:04 +09:00
Nobuyoshi Nakada 23218d4ab2
config.status should be newer than config.cache if exists 2020-01-08 18:35:21 +09:00
Nobuyoshi Nakada db16629008
Fixed misspellings
Fixed misspellings reported at [Bug #16437], only in ruby and rubyspec.
2019-12-20 09:32:42 +09:00
Nobuyoshi Nakada aedbee52c0
Prefer $(CHDIR) for the case srcdir contains symlinks 2019-12-10 18:49:53 +09:00
Kazuhiro NISHIYAMA 271cb9acd2
Suppress git error message
`fatal: not a git repository (or any of the parent directories): .git`
2019-11-23 01:57:19 +09:00
Nobuyoshi Nakada ffab1bfdfc
Fixed for old git 2019-11-21 15:17:34 +09:00
Nobuyoshi Nakada 97a5af62a3
Skip updating revision.h when the revision is unchanged
note: GNU make only.
2019-11-21 10:57:36 +09:00
Nobuyoshi Nakada fb6a489af2
Revert "Method reference operator"
This reverts commit 67c5747369.
[Feature #16275]
2019-11-12 17:24:48 +09:00
Nobuyoshi Nakada f1d4216bd9
Added refresh-gems
Refreshes bundled gems to the latest version, and extracts them.
2019-10-24 01:42:48 +09:00
Nobuyoshi Nakada 33c5ad3154
Removed idNUMPARAM_0 2019-09-25 13:52:53 +09:00
Lourens Naudé cadfaacb25 Lazy init thread local storage 2019-09-23 02:14:44 +09:00
Nobuyoshi Nakada 45bac62845
Added the target to run a benchmark 2019-09-20 09:31:55 +09:00
Nobuyoshi Nakada d3c6fe65e3
Fixed a variable in checkout-github-% 2019-09-20 09:25:30 +09:00
Nobuyoshi Nakada 8d53b2cdf8
Use target-specific variable instead of a conditional [ci skip]
And test-rubyspec is deprecated.
2019-09-09 00:21:54 +09:00
Nobuyoshi Nakada 3754e15530
Warn local variables which conflict with new numbered parameters 2019-09-06 09:02:12 +09:00
Nobuyoshi Nakada e80a6f65c8
Made :nil static ID 2019-09-01 13:37:28 +09:00
Nobuyoshi Nakada 2ed68d0ff9
Revert "Add pipeline operator [Feature #15799]"
This reverts commits:
* d365fd5a02
* d780c36624
* aa7211836b
* 043f010c28
* bb4dd7c6af05c7821d572e2592ea3d0cc748d81f
* 043f010c28
* f169043d81

http://blade.nagaokaut.ac.jp/cgi-bin/scat.rb/ruby/ruby-core/94645
2019-08-29 15:27:59 +09:00
Nobuyoshi Nakada 2614653622
Moved INCFLAGS to XCFLAGS from CPPFLAGS as well as mswin
Rules which have used CPPFLAGS will need XCFLAGS or INCFLAGS now.
2019-08-26 16:54:10 +09:00
Nobuyoshi Nakada 1581249de3
Added in-srcdir macro [ci skip] 2019-08-26 13:13:19 +09:00
Nobuyoshi Nakada 64bffddda1
exit accepts true and false [ci skip] 2019-08-16 10:25:27 +09:00
Nobuyoshi Nakada 12074ad01c
Use GNU make built-in funtion [ci skip] 2019-08-16 10:25:27 +09:00
Takashi Kokubun 409ce8c3da
Also clean up branch for worktree 2019-08-16 01:51:22 +09:00
Takashi Kokubun d21616eeb0
Clean up temporary git resources
after `make update-github`
2019-08-16 01:45:11 +09:00
Takashi Kokubun 2f919a92ba
Improve `make update-github` to avoid configure
after doing it once.
2019-08-16 01:37:22 +09:00
Takashi Kokubun 789f17665e
Make `make update-github` idempotent 2019-08-16 01:18:28 +09:00
Takashi Kokubun d013d8e02e
Fix crash on $(PULL_REQUEST) expansion
by directly passing it to Ruby without passing a shell.
Formerly it was broken when $(PULL_REQUEST) included quotes.
2019-08-16 01:11:19 +09:00
Nobuyoshi Nakada c4152b11a7
Prepare to pull commits notes [ci skip] 2019-08-15 21:34:34 +09:00
Nobuyoshi Nakada fff2b231a3
Simplified GITHUB_TOKEN argument [ci skip] 2019-08-15 21:26:51 +09:00
Takashi Kokubun 938e075273
Add `make update-github PR=1234` to refresh PR (#2368) 2019-08-15 01:00:26 +09:00
Takashi Kokubun e173012f44
Drop obsoleted `make merge-github` task 2019-08-14 23:41:41 +09:00
Nobuyoshi Nakada e75e548cf9
spec/bundler needs the specific command [ci skip] 2019-08-13 21:11:58 +09:00
Nobuyoshi Nakada b8b5e7d5be
Stop rewriting message to include PR URL 2019-08-13 00:48:52 +09:00
Nobuyoshi Nakada 2b3d84d584
Use rev-parse
Use simpler rev-parse to check if pull request was fetched.
2019-08-12 14:11:41 +09:00
Nobuyoshi Nakada 9fe7e042f5
Note the reference to the pull request [ci skip] 2019-08-11 16:20:11 +09:00
Nobuyoshi Nakada 51d9d0f888
Use already fetched pull request [ci skip] 2019-08-11 15:47:39 +09:00
Nobuyoshi Nakada 46df7fe91f
prereq.status deals with removal of nmake VPATH notations [ci skip] 2019-08-11 00:44:13 +09:00
Nobuyoshi Nakada a206738762
Remove temporary directory [ci skip] 2019-08-08 22:40:20 +09:00
Nobuyoshi Nakada 4ea5c5610a
Predefine some IDs 2019-08-03 10:18:39 +09:00
Yusuke Endoh 086ffe72c7 Revert "Revert "Add a specialized instruction for `.nil?` calls""
This reverts commit a0980f2446.

Retry for macOS Mojave.
2019-08-02 23:25:38 +09:00
Yusuke Endoh a0980f2446 Revert "Add a specialized instruction for `.nil?` calls"
This reverts commit 9faef3113f.

It seemed to cause a failure on macOS Mojave, though I'm unsure how.
https://rubyci.org/logs/rubyci.s3.amazonaws.com/osx1014/ruby-master/log/20190802T034503Z.fail.html.gz

This tentative revert is to check if the issue is actually caused by the
change or not.
2019-08-02 15:03:34 +09:00
Aaron Patterson 9faef3113f
Add a specialized instruction for `.nil?` calls
This commit adds a specialized instruction for called to `.nil?`.  It is
about 27% faster than master in the case where the object is nil or not
nil.  In the case where an object implements `nil?`, I think it may be
slightly slower.  Here is a benchmark:

```ruby
require "benchmark/ips"

class Niller
  def nil?; true; end
end

not_nil = Object.new
xnil = nil
niller = Niller.new

Benchmark.ips do |x|
  x.report("nil?")    { xnil.nil? }
  x.report("not nil") { not_nil.nil? }
  x.report("niller")   { niller.nil? }
end
```

On Ruby master:

```
[aaron@TC ~/g/ruby (master)]$ ./ruby compil.rb
Warming up --------------------------------------
                nil?   429.195k i/100ms
             not nil   437.889k i/100ms
              niller   437.935k i/100ms
Calculating -------------------------------------
                nil?     20.166M (± 8.1%) i/s -    100.002M in   5.002794s
             not nil     20.046M (± 7.6%) i/s -     99.839M in   5.020086s
              niller     22.467M (± 6.1%) i/s -    112.111M in   5.013817s
[aaron@TC ~/g/ruby (master)]$ ./ruby compil.rb
Warming up --------------------------------------
                nil?   449.660k i/100ms
             not nil   433.836k i/100ms
              niller   443.073k i/100ms
Calculating -------------------------------------
                nil?     19.997M (± 8.8%) i/s -     99.375M in   5.020458s
             not nil     20.529M (± 7.0%) i/s -    102.385M in   5.020689s
              niller     21.796M (± 8.0%) i/s -    108.110M in   5.002300s
[aaron@TC ~/g/ruby (master)]$ ./ruby compil.rb
Warming up --------------------------------------
                nil?   402.119k i/100ms
             not nil   438.968k i/100ms
              niller   398.226k i/100ms
Calculating -------------------------------------
                nil?     20.050M (±12.2%) i/s -     98.519M in   5.008817s
             not nil     20.614M (± 8.0%) i/s -    102.280M in   5.004531s
              niller     22.223M (± 8.8%) i/s -    110.309M in   5.013106s

```

On this branch:

```
[aaron@TC ~/g/ruby (specialized-nilp)]$ ./ruby compil.rb
Warming up --------------------------------------
                nil?   468.371k i/100ms
             not nil   456.517k i/100ms
              niller   454.981k i/100ms
Calculating -------------------------------------
                nil?     27.849M (± 7.8%) i/s -    138.169M in   5.001730s
             not nil     26.417M (± 8.7%) i/s -    131.020M in   5.011674s
              niller     21.561M (± 7.5%) i/s -    107.376M in   5.018113s
[aaron@TC ~/g/ruby (specialized-nilp)]$ ./ruby compil.rb
Warming up --------------------------------------
                nil?   477.259k i/100ms
             not nil   428.712k i/100ms
              niller   446.109k i/100ms
Calculating -------------------------------------
                nil?     28.071M (± 7.3%) i/s -    139.837M in   5.016590s
             not nil     25.789M (±12.9%) i/s -    126.470M in   5.011144s
              niller     20.002M (±12.2%) i/s -     98.144M in   5.001737s
[aaron@TC ~/g/ruby (specialized-nilp)]$ ./ruby compil.rb
Warming up --------------------------------------
                nil?   467.676k i/100ms
             not nil   445.791k i/100ms
              niller   415.024k i/100ms
Calculating -------------------------------------
                nil?     26.907M (± 8.0%) i/s -    133.755M in   5.013915s
             not nil     25.319M (± 7.9%) i/s -    125.713M in   5.007758s
              niller     19.569M (±11.8%) i/s -     96.286M in   5.008533s
```

Co-Authored-By: Ashe Connor <kivikakk@github.com>
2019-07-31 16:21:25 -07:00
Nobuyoshi Nakada c94cc6d968
run single spec [ci skip] 2019-07-31 20:46:01 +09:00
Nobuyoshi Nakada 8e53d18e67
Separated tool/test/runner.rb and test/runner.rb
As `make test-tool` does not use gems, and no Rubygems stuffs is
needed, so moved such things to test/runner.rb.  Also no longer
nees `--test-target-dir` option.
2019-07-25 16:57:38 +09:00
Nobuyoshi Nakada 3a227b99e7
Adjusted test runner 2019-07-24 12:25:02 +09:00
Nobuyoshi Nakada 28ae30b6ac
Run test-tool in the order of the tests 2019-07-22 10:10:28 +09:00
Nobuyoshi Nakada 0b826418af
Update before commit 2019-07-19 07:51:48 +09:00
Nobuyoshi Nakada af07e07ac9
Separate pull-github from merge-github [ci skip] 2019-07-17 11:57:09 +09:00
Nobuyoshi Nakada 71d5b4c32e
Fixed the library path for tools 2019-07-16 08:25:39 +09:00
Nobuyoshi Nakada c781b1b7a3
update-deps for dependencies 2019-07-15 17:06:35 +09:00
Hiroshi SHIBATA eed9db39e5
Followed up e8ddbc0239. 2019-07-15 10:11:07 +09:00
Nobuyoshi Nakada 8a831e5cb6
Do not make Unicode tables timestamp phony 2019-07-09 13:15:51 +09:00
Nobuyoshi Nakada dcedf0a008
Fix order of tests
`check` includes `test-testframework`, `test-short` and its
preceeding tests, but `test-all` does not.
2019-07-03 14:28:25 +09:00