ab7f54688b
Stir the hash value more with encoding index
2023-12-17 00:30:00 +09:00
b710f96b5a
[Bug #20068 ] Encoding does not matter to empty strings
2023-12-16 16:00:12 +09:00
d242e8416e
Revert all of commits after Prism 0.19.0 release
...
We should bundle released version of Prism for Ruby 3.3.0
2023-12-16 11:08:51 +08:00
161787f9be
[PRISM] Compile CallTargetNode
2023-12-15 16:15:10 -05:00
5b6a4d8c12
[PRISM] Compile IndexTargetNode
2023-12-15 16:15:10 -05:00
2e8cfcac91
[ruby/prism] String literal hash keys should be frozen
...
String literal hash keys can't be mutated by the user so we should mark
them as frozen. We were seeing instructions for hashes with string
literal keys using two `putstring` instructions when it should be a
`putobject` and `putstring`.
Code example:
```ruby
{ "a" => "b" }
```
Instructions before:
```
"********* Ruby *************"
== disasm: #<ISeq:<compiled>@<compiled>:1 (1,0)-(2,14)>
0000 putobject "a" ( 2)[Li]
0002 putstring "b"
0004 newhash 2
0006 leave
"********* PRISM *************"
== disasm: #<ISeq:<compiled>@<compiled>:1 (1,0)-(1,14)>
0000 putstring "a" ( 1)[Li]
0002 putstring "b"
0004 newhash 2
0006 leave
```
Instructions after:
```
"********* Ruby *************"
== disasm: #<ISeq:<compiled>@<compiled>:1 (1,0)-(2,14)>
0000 putobject "a" ( 2)[Li]
0002 putstring "b"
0004 newhash 2
0006 leave
"********* PRISM *************"
== disasm: #<ISeq:<compiled>@<compiled>:1 (1,0)-(1,14)>
0000 putobject "a" ( 1)[Li]
0002 putstring "b"
0004 newhash 2
0006 leave
```
https://github.com/ruby/prism/commit/b14ae55385
2023-12-15 20:55:13 +00:00
0a31cb1a37
[ruby/prism] Finish keyword hash node flag refactor by renaming flag
...
https://github.com/ruby/prism/commit/7f812389f8
2023-12-15 18:45:36 +00:00
b418e5a580
Update error message in test_rubyoptions
2023-12-15 13:42:19 -05:00
55326a915f
Introduce --parser runtime flag
...
Introduce runtime flag for specifying the parser,
```
ruby --parser=prism
```
also update the description:
```
$ ruby --parser=prism --version
ruby 3.3.0dev (2023-12-08T04:47:14Z add-parser-runtime.. 0616384c9f) +PRISM [x86_64-darwin23]
```
[Bug #20044 ]
2023-12-15 13:42:19 -05:00
92b10f5be7
[Bug #20062 ] Fixed numbered parameter syntax error
...
At the method definition, the local scope that saves the context of
the numbered parameters needs to be pushed before saving.
2023-12-16 02:11:51 +09:00
049a9bd62f
[PRISM] Fix `compile_prism` when src is a file
...
`compile_prism` can take a source and file (and other arguments) or a
file as the source. `compile` checks if the source is a file and if it
is converts it. `compile_prism` is now doing the same thing.
On the Ruby side `compile` handles a file
[here](https://github.com/ruby/ruby/blob/master/iseq.c#L1159-L1162 ).
Before:
```
"********* Ruby *************"
== disasm: #<ISeq:<compiled>@<compiled>:1 (1,0)-(26,21)>
local table (size: 1, argc: 0 [opts: 0, rest: -1, post: 0, block: -1, kw: -1@-1, kwrest: -1])
[ 1] name@0
0000 putstring "Prism" ( 25)[Li]
0002 setlocal name@0, 0
0005 putself ( 26)[Li]
0006 putobject "hello, "
0008 getlocal name@0, 0
0011 dup
0012 objtostring <calldata!mid:to_s, argc:0, FCALL|ARGS_SIMPLE>
0014 anytostring
0015 concatstrings 2
0017 send <calldata!mid:puts, argc:1, FCALL|ARGS_SIMPLE>, nil
0020 leave
hello, Prism
"********* PRISM *************"
./test.rb:13:in `compile_prism': wrong argument type File (expected String) (TypeError)
from ./test.rb:13:in `<main>'
make: *** [run] Error 1
```
After:
```
"********* Ruby *************"
== disasm: #<ISeq:<compiled>@<compiled>:1 (1,0)-(26,21)>
local table (size: 1, argc: 0 [opts: 0, rest: -1, post: 0, block: -1, kw: -1@-1, kwrest: -1])
[ 1] name@0
0000 putstring "Prism" ( 25)[Li]
0002 setlocal name@0, 0
0005 putself ( 26)[Li]
0006 putobject "hello, "
0008 getlocal name@0, 0
0011 dup
0012 objtostring <calldata!mid:to_s, argc:0, FCALL|ARGS_SIMPLE>
0014 anytostring
0015 concatstrings 2
0017 send <calldata!mid:puts, argc:1, FCALL|ARGS_SIMPLE>, nil
0020 leave
"********* PRISM *************"
== disasm: #<ISeq:<compiled>@test_code.rb:24 (24,0)-(25,21)>
local table (size: 1, argc: 0 [opts: 0, rest: -1, post: 0, block: -1, kw: -1@-1, kwrest: -1])
[ 1] name@0
0000 putstring "Prism" ( 24)[Li]
0002 setlocal name@0, 0
0005 putself ( 25)[Li]
0006 putobject "hello, "
0008 getlocal name@0, 0
0011 dup
0012 objtostring <calldata!mid:to_s, argc:0, FCALL|ARGS_SIMPLE>
0014 anytostring
0015 concatstrings 2
0017 send <calldata!mid:puts, argc:1, FCALL|ARGS_SIMPLE>, nil
0020 leave ( 24)
```
Fixes ruby/prism#1609
2023-12-15 10:27:44 -05:00
f38814564b
[ruby/prism] Fix eval parsing depth
...
https://github.com/ruby/prism/commit/89bf7a4948
2023-12-15 15:19:50 +00:00
fe9b42f024
[ruby/prism] Invalid pinned locals in pattern matching
...
https://github.com/ruby/prism/commit/3a67b37a56
2023-12-15 15:03:49 +00:00
16830a4783
[ruby/prism] Add an error for `in` keyword in arguments
...
Fix https://github.com/ruby/prism/pull/2026
https://github.com/ruby/prism/commit/c4b41cd477
2023-12-15 13:25:54 +00:00
04f7be6126
loading/testing in different processes for multiple runs
2023-12-15 21:36:27 +09:00
406d4bb599
add a test
...
proposed at https://bugs.ruby-lang.org/issues/20050#note-5
2023-12-15 11:58:43 +09:00
29e99c84ae
Remove unused variables in test_call_op_asgn_keywords_mutable
2023-12-14 18:44:13 -08:00
5587bd4b37
[PRISM] Implement safe navigation in CallNodes
...
This commit implements safe navigation for CallNodes,
CallAndWriteNodes and CallOperatorWriteNodes
2023-12-14 17:11:54 -05:00
d07fdc5ede
[PRISM] Fix keyword hash handling in method calls
...
* Start using the renamed `PM_KEYWORD_HASH_NODE_FLAGS_SYMBOL_KEYS` flag
to check if all keys of the keyword hash node are symbols.
* For arguments passed as a hash, start marking them as `KW_SPLAT_MUT` only if the number of entries in the hash is greater than 1 (which is what the old compiler used to do).
2023-12-14 14:08:37 -05:00
295d97ab4d
Pattern matching
2023-12-14 14:06:26 -05:00
019fff3a86
[ruby/prism] Fix parse result for nesting pattern matching
...
https://github.com/ruby/prism/commit/ee6fc9ee87
2023-12-14 18:54:46 +00:00
7ac93e99a3
[PRISM] Account for multiple anonymous locals
...
This commit adjusts the local table size to be consistent regardless
of the number of anonymous locals.
2023-12-14 13:45:41 -05:00
01f21d5729
[ruby/prism] Fix the implementation of the flag on keyword hash nodes
...
The previous implementation was incorrect since it was just checking for all keys in assoc nodes to be static literals but the actual check is that all keys in assoc nodes must be symbol nodes.
This commit fixes that implementation, and, also, aliases the flag to `PM_KEYWORD_HASH_NODE_FLAGS_SYMBOL_KEYS` so that ruby/ruby can start using the new flag name.
I intend to later change the real flag name to `PM_KEYWORD_HASH_NODE_FLAGS_SYMBOL_KEYS` and remove the alias.
https://github.com/ruby/prism/commit/f5099c79ce
2023-12-14 18:05:54 +00:00
e71f011713
[PRISM] Fix bugs in compiling optional keyword parameters
...
This PR fixes two bugs when compiling optional keyword parameters:
- It moves keyword parameter compilation to STEP 5 in the parameters
sequence, where the rest of compilation happens. This is important
because keyword parameter compilation relies on the value of
body->param.keyword->bits_start which gets set in an earlier step
- It compiles array and hash values for keyword parameters, which
it didn't previously
2023-12-14 11:46:54 -05:00
3658798dbb
[ruby/prism] Make equality operators non-associative
...
Fix https://github.com/ruby/prism/pull/2073
https://github.com/ruby/prism/commit/0f747d9240
2023-12-14 16:39:05 +00:00
8e1c148fd9
[PRISM] Use frozen flag on StringNode
2023-12-14 11:14:45 -05:00
a18819e65f
Fix op asgn method calls passing mutable keyword splats
...
When passing the keyword splat to [], it cannot be mutable, because
mutating the keyword splat inside [] would result in changes to the
keyword splat passed to []=.
2023-12-14 08:13:43 -08:00
a10c11a66b
[PRISM] Add anon KW args to the block local table
2023-12-14 07:01:19 -05:00
e51f9e9f75
rb_ext_resolve_symbol: C API to resolve and return externed symbols [Feature #20005 ]
...
This is a C API for extensions to resolve and get function symbols of other extensions.
Extensions can check the expected symbol is correctly loaded and accessible, and
use it if it is available.
Otherwise, extensions can raise their own error to guide users to setup their
environments correctly and what's missing.
2023-12-14 17:39:42 +09:00
b7e89d4b17
[ruby/prism] Fix hash pattern rest
...
https://github.com/ruby/prism/commit/43c4232cfc
2023-12-14 02:43:32 +00:00
beefce1444
[rubygems/rubygems] Warn for duplicate meta data links
...
Match order of METADATA_LINK_KEYS to order used by rubygems.org in Links model.
Add missing download_uri key.
https://github.com/rubygems/rubygems/commit/d2922cd6e9
2023-12-14 00:06:05 +00:00
baf2ec2ca8
[rubygems/rubygems] Use match? when regexp match data is unused
...
Improved performance / reduced allocations
https://github.com/rubygems/rubygems/commit/b04726c9a7
2023-12-13 22:00:26 +00:00
31c0ea20e5
[PRISM] Add a test with a non-static-literal hash key
2023-12-13 14:15:09 -05:00
110dbf62ac
[Prism] Fix InterpolatedMatchLastLine Instructions
...
I looked at this at RubyConf with Kevin, and we noticed that there was a
`putobject` empty string missing from the instructions. I just got back
around to implementing this and pushing a PR and while doing that
noticed that we also have a `getspecial` when we want a `getglobal`.
This change adds the `putobject` instruction and replaces the
`getspecial` with a `getglobal`. If we look at the parsetree for the
following code:
```ruby
$pit = '.oo'; if /"#{$pit}"/mix; end
```
We can see it has a `NODE_GVAR` and the [Ruby
compiler](a4b43e9264/compile.c (L10024-L10030)
2023-12-13 13:42:17 -05:00
a3b48ac9ad
Fix memory leak in Hash#compare_by_identity
...
We didn't free the old ST before overwriting it which caused a leak.
Found with RUBY_FREE_ON_EXIT.
Co-authored-by: Peter Zhu <peter@peterzhu.ca>
2023-12-13 09:43:09 -08:00
cc86fa8416
Skip an unstable test on MinGW
...
This test fails fairly frequently on MinGW:
https://github.com/ruby/ruby/actions/runs/7195712496/job/19598924253#step:11:168
https://github.com/ruby/ruby/actions/runs/7191246799/job/19585627182#step:11:168
and we aren't actively working on stabilizing tests for MinGW.
2023-12-13 09:40:54 -08:00
c83a648fc8
[ruby/irb] Remove unused lvar in mesure command test
...
(https://github.com/ruby/irb/pull/814 )
https://github.com/ruby/irb/commit/320178b120
2023-12-13 17:05:35 +00:00
0d53dba7ce
Make String#chomp! raise ArgumentError for 2+ arguments if string is empty
...
String#chomp! returned nil without checking the number of passed
arguments in this case.
2023-12-13 07:05:21 -08:00
9267dbdd7a
[PRISM] Generate instruction for when redo_label is set
2023-12-13 09:33:07 -05:00
798a89fae1
[PRISM] If receiver on CallNode is SelfNode, use FCALL flags
2023-12-13 08:11:45 -05:00
1ad991c54d
[PRISM] Fix attrset edge cases
...
In some cases code may look like an attrset ID but should actually
return the value of the method, not the passed values.
In ruby/prism#2051 a flag was added when we have a attribute write call.
I used this flag to add the proper instructions when we have a real
attrset instead of using `rb_is_attrset_id` which was kind of hacky
anyway.
The value that should be returned in the newly added test is 42, not 2.
Previously the changes we had made returned 2.
Related to ruby/prism#1715
2023-12-13 08:11:21 -05:00
745ab3e4c7
[ruby/irb] Warn and do nothing if block is passed to measure command
...
(https://github.com/ruby/irb/pull/813 )
https://github.com/ruby/irb/commit/e79a90a1e6
2023-12-13 11:06:26 +00:00
20a09387d1
Skip a GC test for RJIT
...
It randomly fails like this:
https://github.com/ruby/ruby/actions/runs/7191443542/job/19586164973
2023-12-12 23:24:19 -08:00
1fa5dd883e
[rubygems/rubygems] Test if the user dir is used for auto user installation
...
This is mainly to align this test case with the
`test_process_options_does_not_fallback_to_user_install_when_gem_home_
not_writable_and_no_user_install`, where the `install_dir` is checked
already.
https://github.com/rubygems/rubygems/commit/02b1884b61
2023-12-13 12:16:55 +09:00
402fd96ddc
[rubygems/rubygems] Make sure `--no-user-install` is respected for auto user installation
...
The `options[:user_install]` might have three states:
* `true`: `--user-install`
* `false`: `--no-user-install` and
* `nil`: option was not specified
However, this had not been respected previously and the `false` and `nil`
were treated the same. This could lead to auto user installation despite
`--no-user-install` being specified on the command line.
Fixes https://github.com/rubygems/rubygems/pull/7237
https://github.com/rubygems/rubygems/commit/9281545474
2023-12-13 12:16:55 +09:00
a7c9163b5d
[rubygems/rubygems] Vendor timeout in RubyGems too
...
https://github.com/rubygems/rubygems/commit/e2e7440ede
2023-12-13 12:16:55 +09:00
ce924ce1fb
[rubygems/rubygems] Vendor net-http and net-protocol in RubyGems
...
https://github.com/rubygems/rubygems/commit/99d91c9ed2
2023-12-13 12:16:55 +09:00
196c24620e
[PRISM] Correctly parse non-base 10 integers in Prism
...
This commit passes an `end` to rb_int_parse_cstr which allows us
to correctly parse non-base 10 integers which are enclosed in
parenthesis. Prior to this commit, we were getting a putobject nil
when compiling `(0o0)` for example.
2023-12-12 22:00:50 -05:00
a8d2d93aff
Add a test case for preregistering with different data
...
We want to make sure that if preregister is called with different data,
that the postponed job table is updated.
2023-12-13 13:35:05 +11:00
a6526342f3
[PRISM] Fix segv with regex once flag
...
When you have an interpolated regex with a `once` flag and local
variable is outside the block created by the `once` flag, Prism would
see a segv. This is because it was not taking the depth into account.
To fix this, we need to add 1 to the `local_depth_offset` on the
`scope`.
Fixes : ruby/prism#2047
2023-12-12 15:15:02 -05:00
Nobuyoshi Nakada
Hiroshi SHIBATA
Matt Valentine-House
eileencodes
Ufuk Kayserilioglu
Kevin Newton
HParker
TSUYUSATO Kitsune
Satoshi Tagomori
Koichi Sasada
Jeremy Evans
Jemma Issroff
Drew Stevenson
Samuel Giddins
Alan Wu
Takashi Kokubun
tomoya ishida
Vít Ondruch
David Rodríguez
KJ Tsanaktsidis