Jeremy Evans
869e2dd8c8
Warn for URI.{,un}{escape,encode}, even if not in verbose mode
...
The verbose mode warning has been present for almost 10 years.
If we ever plan to remove these methods, we should make the warning
a regular deprecation warning so that people are aware.
Implements [Feature #15961 ]
2019-09-27 07:43:32 -07:00
Jeremy Evans
a2c26fe1c6
Fix fallback in URI.encode_www_form_component to include #
...
Patch from Matthew Kerwin.
Fixes [Bug #14358 ]
2019-09-27 07:43:32 -07:00
marcandre
e859e668d2
lib/*: Prefer require_relative over require.
...
[#15206 ] [Fix GH-1976]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65505 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-11-02 17:52:33 +00:00
nobu
27e972854c
common.rb: unused constant
...
* lib/uri/common.rb (URI::HTML5ASCIIINCOMPAT): remove the constant
which has been unused since r40460, and wrong since r49069 due
to the operator precedence. [ruby-core:86678] [Bug #14711 ]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63259 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-04-25 11:56:58 +00:00
stomar
300b22dc22
Improve docs for URI library
...
* lib/uri/generic.rb: [DOC] fix invalid example code to make it
syntax highlighted; drop unnecessary `puts', `p'; adapt to current
inspect format without Object id; do not display unnecessary return
values in examples; fix or prevent unintended description lists;
fix broken RDoc; fix grammar and typos.
* lib/uri.rb: ditto.
* lib/uri/common.rb: ditto.
* lib/uri/file.rb: ditto.
* lib/uri/ftp.rb: ditto.
* lib/uri/http.rb: ditto.
* lib/uri/ldap.rb: ditto.
* lib/uri/mailto.rb: ditto.
* lib/uri/rfc2396_parser.rb: ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63228 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-04-21 20:04:05 +00:00
normal
26b3dc4922
uri/common: reduce allocations and retained objects
...
Thanks to Sam Saffron for this patch, it shows
a nice reduction which affects many web applications:
require 'memory_profiler'
MemoryProfiler.report do
require 'uri'
end.pretty_print
Before:
Total allocated: 986643 bytes (15159 objects)
Total retained: 246370 bytes (2532 objects)
After:
Total allocated: 926903 bytes (13665 objects)
Total retained: 208570 bytes (1587 objects)
* lib/uri/common.rb: reduce allocations and retained objects
[ruby-core:85161] [Feature #14410 ]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62081 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-01-28 21:07:13 +00:00
shyouhei
f2a91397fd
Add uplevel keyword to Kernel#warn and use it
...
If uplevel keyword is given, the warning message is prepended
with caller file and line information and the string "warning: ".
The use of the uplevel keyword makes Kernel#warn format output
similar to how rb_warn formats output.
This patch modifies net/ftp and net/imap to use Kernel#warn
instead of $stderr.puts or $stderr.printf, since they are used
for printing warnings.
This makes lib/cgi/core and tempfile use $stderr.puts instead of
warn for debug logging, since they are used for debug printing
and not for warning.
This does not modify bundler, rubygems, or rdoc, as those are
maintained outside of ruby and probably wish to remain backwards
compatible with older ruby versions.
rb_warn_m code is originally from nobu, but I've changed it
so that it only includes the path and lineno from uplevel
(not the method), and also prepends the string "warning: ",
to make it more similar to rb_warn.
From: Jeremy Evans code@jeremyevans.net
Signed-off-by: Urabe Shyouhei shyouhei@ruby-lang.org
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61155 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2017-12-12 11:56:25 +00:00
kazu
dabdec31e4
Use caller with length to reduce unused strings
...
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60288 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2017-10-21 14:40:03 +00:00
sonots
10ee38b6bc
* lib/uri/common.rb: [DOC] add rdoc to describe
...
URI.unescape is obsolete [ci-skip] [fix GH-1630]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58899 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2017-05-26 06:42:11 +00:00
naruse
6219b68fb5
Fix typo of URI#escape [Bug #13147 ]
...
patched by Steve Hill <sghill.dev@gmail.com>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57411 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2017-01-23 17:02:08 +00:00
a_matsuda
41cc7eaa7e
Update comment about default constant
...
Patch by: Dave Takahashi <dtcello@gmail.com> (@dtakahas)
Signed-off-by: Akira Matsuda <ronnie@dio.jp>
closes #1151
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56674 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2016-11-08 11:57:00 +00:00
hsbt
13e474f035
* lib/uri/common.rb: added documentation for deprecated method.
...
[Misc #11960 ][ruby-core:72733][ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56458 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2016-10-20 08:03:01 +00:00
nobu
a566bc0a38
uri/common.rb: Update URI::WEB_ENCODINGS_ [ci skip]
...
* lib/uri/common.rb (WEB_ENCODINGS_): split command lines and
append a trailing comma.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56357 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2016-10-06 02:04:28 +00:00
nobu
48f9118253
Update URI WEB_ENCODINGS_ hash, and fix documented cmd to
...
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56356 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2016-10-06 02:01:51 +00:00
naruse
3e92b635fb
Add frozen_string_literal: false for all files
...
When you change this to true, you may need to add more tests.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53141 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2015-12-16 05:07:31 +00:00
hsbt
68b69178f4
* lib/uri/common.rb: make code block for rdoc.
...
[ci skip][fix GH-1152] Patch by @Tonkpils
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53119 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2015-12-15 02:56:38 +00:00
marcandre
0c4631b880
* lib/uri: [doc] Update common.rb [ci-skip] [fixes GH-838]
...
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@49728 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2015-02-24 18:09:10 +00:00
duerst
b1cf08496b
lib/uri/common.rb: Initialize HTML5ASCIIINCOMPAT to empty Array
...
to avoid error during bootstrap when encodings are not yet defined. [Bug #10678 ]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@49069 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-12-30 04:17:10 +00:00
hsbt
e47fec1f86
* lib/drb/acl.rb: Removed meaningless #to_s methods in interpolation.
...
[Feature #10174 ][ruby-core:64584]
* lib/erb.rb: ditto.
* lib/observer.rb: ditto.
* lib/rake/invocation_chain.rb: ditto.
* lib/rubygems/command_manager.rb: ditto.
* lib/rubygems/config_file.rb: ditto.
* lib/uri/common.rb: ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47299 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-08-27 12:21:41 +00:00
nobu
682f3a7881
uri/common.rb: use negative look-ahead
...
* lib/uri/common.rb (URI.decode_www_form_component): use negative
look-ahead instead of nested repeat operators, to get rid of
backtrack explosion.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47273 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-08-25 07:29:50 +00:00
zzak
747243cc0e
* lib/uri/common.rb: [DOC] [Bug #9563 ] Recommend using URI.escape
...
before parsing a uri to avoid invalid characters. Reported by
Evgeniy Serykh.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46984 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-07-27 21:27:10 +00:00
zzak
37fd832f3c
* lib/uri/common.rb: [DOC] [Bug #10075 ] Clarify how URI.join arguments
...
are handled by RFC3986, originall reported by John Feminella.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46979 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-07-27 20:34:18 +00:00
naruse
bb83f32dc3
support RFC3986 [Feature #2542 ]
...
* lib/uri/common.rb (URI::REGEXP): move to lib/uri/rfc2396_parser.rb.
* lib/uri/common.rb (URI::Parser): ditto.
* lib/uri/common.rb (URI.split): use RFC3986_Parser.
* lib/uri/common.rb (URI.parse): ditto.
* lib/uri/common.rb (URI.join): ditto.
* lib/uri/common.rb (URI.extract): deprecated.
* lib/uri/common.rb (URI.regexp): ditto.
* lib/uri/rfc2396_parser.rb: added.
* lib/uri/rfc3986_parser.rb: added.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46491 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-06-22 00:22:19 +00:00
zzak
63da4ce3bc
* lib/uri/common.rb: [DOC] Use static w3.org uri [ci skip]
...
Patch by @ykzts [Fix GH-484] https://github.com/ruby/ruby/pull/484
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@44674 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-01-21 08:56:15 +00:00
hsbt
690be750cb
* lib/cgi/html.rb: fix typo by @windwiny [fix GH-506]
...
* lib/net/http.rb: ditto
* lib/rexml/attribute.rb: ditto
* lib/rexml/element.rb: ditto
* lib/rexml/source.rb: ditto
* lib/rexml/streamlistener.rb: ditto
* lib/rss/xmlparser.rb: ditto
* lib/rubygems/commands/generate_index_command.rb: ditto
* lib/shell.rb: ditto
* lib/uri/common.rb:ditto
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@44650 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-01-19 05:43:26 +00:00
hsbt
967677aba0
* lib/uri/common.rb: [DOC] Fix a broken link by @namusyaka [fix GH-478]
...
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@44187 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2013-12-13 23:22:41 +00:00
zzak
217d37a64a
* lib/uri/common.rb: [DOC] typo fixes by @vipulnsward [Fixes GH-456]
...
https://github.com/ruby/ruby/pull/456
* lib/uri/generic.rb: [DOC] ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43843 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2013-11-25 10:49:29 +00:00
knu
601f783827
* lib/uri/common.rb (URI.decode_www_form_component): Use String#b.
...
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@42273 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2013-07-31 09:34:34 +00:00
sorah
b30a172385
* lib/uri/common.rb (URI.decode_www_form_component):
...
Don't raise error when str includes multibyte characters.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@42271 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2013-07-31 09:00:18 +00:00
naruse
53fdb30e7f
* lib/uri/common.rb (URI.decode_www_form): scrub string if decoded
...
bytes are invalid for the encoding.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@40820 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2013-05-18 18:58:13 +00:00
naruse
4a50d447d9
* lib/uri/common.rb (URI.decode_www_form): follow current URL Standard.
...
It gets encoding argument to specify the character encoding.
It now allows loose percent encoded strings, but denies ;-separator.
[ruby-core:53475] [Bug #8103 ]
* lib/uri/common.rb (URI.decode_www_form): follow current URL Standard.
It gets encoding argument to convert before percent encode.
Now UTF-16 strings aren't converted to UTF-8 before percent encode
by default.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@40460 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2013-04-25 05:27:41 +00:00
hsbt
e9a61266fc
fix typo by @zsalzbank [fix GH-289]
...
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@40327 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2013-04-17 01:16:58 +00:00
naruse
edb7cdf1ea
* lib/uri/common.rb (URI.encode_www_form_component): initialize on
...
requiring to support JRuby, which runs parallel multithreads.
[ruby-core:42222] [Bug #5925 ]
* lib/uri/common.rb (URI.decode_www_form_component): initialize on
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@34364 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2012-01-24 02:52:09 +00:00
naruse
87fe448091
* lib/uri/common.rb (URI::Parser#initialize_regexp):
...
use \A \z instead of ^ $. [Bug #5843 ]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@34214 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2012-01-05 02:57:21 +00:00
tenderlove
7cabeff61a
updating documentation link
...
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@34068 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2011-12-18 03:16:05 +00:00
ktsj
c3749b6a6d
* ext/pathname/lib/pathname.rb, ext/tk/lib/multi-tk.rb,
...
ext/tk/sample/demos-en/widget, lib/benchmark.rb, lib/irb/cmd/fork.rb,
lib/mkmf.rb, lib/net/ftp.rb, lib/net/smtp.rb, lib/open3.rb,
lib/pstore.rb, lib/rexml/element.rb, lib/rexml/light/node.rb,
lib/rinda/tuplespace.rb, lib/rss/maker/base.rb,
lib/rss/maker/entry.rb, lib/scanf.rb, lib/set.rb, lib/shell.rb,
lib/shell/command-processor.rb, lib/shell/process-controller.rb,
lib/shell/system-command.rb, lib/uri/common.rb: remove unused block
arguments to avoid creating Proc objects.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@33638 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2011-11-05 07:37:47 +00:00
naruse
32618ba743
Add a missing parenthesis in the example.
...
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@33047 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2011-08-24 07:28:12 +00:00
drbrain
ee13ed7e84
* lib/uri/common.rb: Fix documentation of URI::Parser.new. Patch by
...
Steve Klabnik. [Ruby 1.9 - Bug #5177 ]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@32953 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2011-08-12 18:41:57 +00:00
naruse
93177c1e5c
Fix r32622.
...
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@32631 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2011-07-22 21:16:50 +00:00
naruse
b5f91deee0
* lib/uri/generic.rb (WFKV_): unroll the loop of regexp.
...
* lib/uri/generic.rb (URI.decode_www_form_component): ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@32622 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2011-07-22 12:29:13 +00:00
marcandre
c2dfaa7d40
* lib/uri/common.rb (module): Remove optional parser argument to Kernel#URI
...
[ruby-core:38061]
* lib/uri/generic.rb (module): ditto
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@32559 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2011-07-15 21:28:10 +00:00
nobu
d371e3583e
* lib: revert r31635-r31638 and untabify with expand(1).
...
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31641 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2011-05-19 00:07:25 +00:00
drbrain
7bbf2f3085
* lib: Convert tabs to spaces for ruby files per
...
http://redmine.ruby-lang.org/projects/ruby/wiki/DeveloperHowto#coding-style
Patch by Steve Klabnik [Ruby 1.9 - Bug #4730 ]
Patch by Jason Dew [Ruby 1.9 - Feature #4718 ]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31635 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2011-05-18 21:19:18 +00:00
nobu
3a47cf3395
* remove trailing spaces.
...
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31573 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2011-05-15 11:55:52 +00:00
drbrain
10219ff621
* lib/uri.rb: Add toplevel documentation. Patch by Vincent Batts.
...
[Ruby 1.9 - Bug #4690 ]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31555 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2011-05-13 20:03:21 +00:00
nagachika
58355ea52a
* lib/logger.rb: format comments to keep 80 columns in a line.
...
* lib/uri/common.rb: ditto.
* lib/uri/ftp.rb: ditto.
* lib/uri/ldap.rb: ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31548 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2011-05-13 12:54:57 +00:00
drbrain
e2b3183fc2
* re.c (Init_Regexp): Document option constants. Patch by Vincent
...
Batts. [Ruby 1.9 - Bug #4677 ]
* lib/uri/common.rb (module URI): Documentation for URI. Patch by
Vincent Batts. [Ruby 1.9- Bug #4677 ]
* lib/uri/ftp.rb (module URI): ditto
* lib/uri/generic.rb (module URI): ditto
* lib/uri/http.rb (module URI): ditto
* lib/uri/https.rb (module URI): ditto
* lib/uri/ldap.rb (module URI): ditto
* lib/uri/ldaps.rb (module URI): ditto
* lib/uri/mailto.rb (module URI): ditto
* process.c (Init_process): Document Process constants. Patch by
Vincent Batts. [Ruby 1.9- Bug #4677 ]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31536 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2011-05-12 20:39:11 +00:00
naruse
8553b70a39
* lib/uri/common.rb: avoid race condition. fixes #4572
...
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31266 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2011-04-12 10:20:50 +00:00
naruse
68b18291ac
* lib/uri/common.rb (URI::Parser#initialize_pattern):
...
refix for restrict the pattern.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@30091 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2010-12-06 01:41:10 +00:00
naruse
2a35a782ab
* lib/uri/common.rb (URI::Parser#initialize_pattern):
...
workaround fix pattern of hostname for RFC 3986. [ruby-dev:42672]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@30089 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2010-12-06 00:19:28 +00:00