e626da82ea
Don't pin named structs defined in Ruby
...
[Bug #20311 ]
`rb_define_class_under` assumes it's called from C and that the
reference might be held in a C global variable, so it adds the
class to the VM root.
In the case of `Struct.new('Name')` it's wasteful and make
the struct immortal.
2024-03-01 08:23:38 +01:00
25d74b9527
Do not include a backtick in error messages and backtraces
...
[Feature #16495 ]
2024-02-15 18:42:31 +09:00
8c5b9ebf71
[DOC] Improve doc guide compliance ( #8221 )
2023-08-15 14:43:58 -04:00
1e7b67f733
[Feature #19730 ] Remove transient heap
2023-07-13 09:27:33 -04:00
9c1fe9064c
[Feature #19757 ] Add new API `rb_data_define`
2023-07-13 17:55:55 +09:00
b934976024
Prefer `0` over `NULL` as function pointers
...
SunC warns use of `NULL`, pointer to data as function pointers.
2023-06-23 03:15:55 +09:00
6fe46ff967
When alloc size is too large, only allocate struct
2023-06-12 16:20:05 +02:00
2543a6573f
Implement Struct on VWA
...
The benchmark results show that this feature has either a positive or
no impact on performance. The memory usage is also mostly unchanged,
except in hexapdf, where there is a decrease in RSS.
-------------- ----------- ---------- --------- ----------- ---------- --------- -------------- -------------
bench master (ms) stddev (%) RSS (MiB) branch (ms) stddev (%) RSS (MiB) branch 1st itr master/branch
activerecord 70.8 2.2 56.0 71.7 2.2 56.0 0.99 0.99
erubi_rails 20.5 13.6 94.7 20.5 14.3 94.2 0.93 1.00
hexapdf 2541.0 0.7 212.8 2544.4 0.7 203.4 1.00 1.00
liquid-c 65.6 0.3 38.9 65.3 0.3 38.9 1.01 1.01
liquid-compile 63.7 0.3 34.6 61.1 0.2 34.6 1.04 1.04
liquid-render 163.1 0.1 37.1 163.3 0.1 37.1 1.00 1.00
mail 139.3 0.1 50.5 137.0 0.1 50.1 0.99 1.02
psych-load 2065.7 0.1 36.9 2068.2 0.1 37.3 1.00 1.00
railsbench 2034.6 0.5 103.9 2031.9 0.5 103.8 1.02 1.00
ruby-lsp 65.3 3.1 89.8 66.2 3.0 89.7 1.01 0.99
sequel 73.2 1.0 40.3 73.4 1.0 40.3 1.00 1.00
-------------- ----------- ---------- --------- ----------- ---------- --------- -------------- -------------
2023-06-05 15:47:16 -04:00
f8e7048348
Allow anonymous memberless Struct
...
Previously, named memberless Structs were allowed, but anonymous
memberless Structs were not.
Fixes [Bug #19416 ]
2023-04-24 07:37:20 -07:00
026321c5b9
[Feature #19474 ] Refactor NEWOBJ macros
...
NEWOBJ_OF is now our canonical newobj macro. It takes an optional ec
2023-04-06 11:07:16 +01:00
ae2dbdf11e
[DOC] Fix broken link Data#deconstruct_keys
2023-03-08 12:26:26 +09:00
c43fbe4ebd
Fix spelling ( #7405 )
2023-02-28 10:05:30 -08:00
3b239d2480
Remove (newly unneeded) remarks about aliases
2023-02-19 14:26:34 -08:00
45f0e3a673
[Bug #19259 ] `Data#with` should call `initialize` method
2023-02-14 12:02:07 +09:00
cc9d96b259
Avoid using OBJ_WB_UNPROTECT
...
Not that it makes a big difference here, but it's
just unecessary.
2023-02-03 23:31:08 +01:00
3fefe660f8
[DOC] Fix call-seq of Struct.new ( #7246 )
2023-02-03 14:26:39 -08:00
cada537040
[DOC] Fix call-seq for Data.define
2022-12-28 18:43:05 +02:00
b3d57fdd64
Docs: Update Struct docs about keyword initialization
2022-12-23 18:09:49 +02:00
99cee85775
Add copy with changes functionality for Data objects ( #6766 )
...
Implements [Feature #19000 ]
This commit adds copy with changes functionality for `Data` objects
using a new method `Data#with`.
Since Data objects are immutable, the only way to change them is by
creating a copy. This PR adds a `with` method for `Data` class instances
that optionally takes keyword arguments.
If the `with` method is called with no arguments, the behaviour is the
same as the `Kernel#dup` method, i.e. a new shallow copy is created
with no field values changed.
However, if keyword arguments are supplied to the `with` method, then
the copy is created with the specified field values changed. For
example:
```ruby
Point = Data.define(:x, :y)
point = Point.new(x: 1, y: 2)
point.with(x: 3) # => #<data Point x: 3, y: 2>
```
Passing positional arguments to `with` or passing keyword arguments to
it that do not correspond to any of the members of the Data class will
raise an `ArgumentError`.
Co-authored-by: Alan Wu <XrXr@users.noreply.github.com>
2022-12-21 16:27:38 -08:00
5872fd6f6c
[Feature #19163 ] Marshal-loaded Data object also should be frozen
2022-12-02 00:56:52 +09:00
a14a1a5626
[Feature #19163 ] Data object should be frozen
2022-12-02 00:56:52 +09:00
5752d11f1f
Use RTEST and add test for GH-6832
...
Technically we shouldn't see Qfalse now, but RTEST also compiles down to
just one branch anyways. Pretty contrived issue, but easy to fix.
2022-11-30 16:27:39 -05:00
4b9d10b833
struct.c (struct_ivar_get): add conditional for potential Qnil returned by rb_class_superclass
...
struct_ivar_get recently started using rb_class_superclass to
resolve super instead of RCLASS_SUPER. This change made
Qnil a possible case we need to return from within the
struct_ivar_get for loop.
2022-11-30 16:27:39 -05:00
1f4f6c9832
Using UNDEF_P macro
2022-11-16 18:58:33 +09:00
13e87e5049
fix Data docs ( #6497 )
2022-10-06 10:13:17 -07:00
cbd82f5250
Cannot `define` from defined `Data` class again
2022-10-03 23:28:01 +09:00
56f2fd3bc9
Use the dedicated function to check arity
2022-10-01 16:24:36 +09:00
15d3b7fe6d
Fix an out of bound access
2022-10-01 16:20:22 +09:00
c767618d4c
Do not define the method only for RDoc
...
`Data.members` fails an assertion.
2022-10-01 15:36:01 +09:00
ad651925e3
Add Data class implementation: Simple immutable value object
2022-09-30 18:23:19 +09:00
cfe10e482e
[DOC] Update `Struct#new` behavior with `keyword_init: true`
2022-09-09 18:58:07 +09:00
efb91ff19b
Rename rb_ary_tmp_new to rb_ary_hidden_new
...
rb_ary_tmp_new suggests that the array is temporary in some way, but
that's not true, it just creates an array that's hidden and not on the
transient heap. This commit renames it to rb_ary_hidden_new.
2022-07-26 09:12:09 -04:00
5b21e94beb
Expand tabs [ci skip]
...
[Misc #18891 ]
2022-07-21 09:42:04 -07:00
adc709adb8
Don't attempt to read ivars on T_ICLASS in struct ( #5664 )
2022-05-26 11:54:15 -07:00
54b53e2c8f
[ci skip] Fix docs
2022-04-13 10:43:23 -04:00
ffcdbedbfb
Repaired What's Here sections for Range, String, Symbol, Struct ( #5735 )
...
Repaired What's Here sections for Range, String, Symbol, Struct.
2022-03-30 13:46:24 -05:00
e660b934b9
A positional Hash is not keyword arguments [Bug #18632 ]
2022-03-17 20:53:41 +09:00
50c972a1ae
[DOC] Simplify operator method references
2022-02-12 12:38:36 +09:00
a32e5e1b97
[DOC] Use RDoc link style for links in the same class/module
...
I used this regex:
(?<=\[)#(?:class|module)-([A-Za-z]+)-label-([A-Za-z0-9\-\+]+)
And performed a global find & replace for this:
rdoc-ref:$1@$2
2022-02-07 09:52:06 -05:00
f9a2802bc5
[DOC] Use RDoc link style for links to other classes/modules
...
I used this regex:
([A-Za-z]+)\.html#(?:class|module)-[A-Za-z]+-label-([A-Za-z0-9\-\+]+)
And performed a global find & replace for this:
rdoc-ref:$1@$2
2022-02-07 09:52:06 -05:00
a07fa198a6
Improve links to labels in string.c and struct.c ( #5531 )
2022-02-06 09:44:40 -06:00
c956f979e5
Initialize Struct by calling with keyword arguments
2021-12-26 23:28:54 +09:00
04f07713d1
Fix typos [ci skip]
2021-12-25 10:33:49 +09:00
fed1629ada
Fix StructClass:: class method docs
2021-12-24 10:29:31 +09:00
c5ec05d047
`struct_pos_num` is no longer used
2021-11-20 21:32:57 +09:00
82ea287018
optimize `Struct` getter/setter
...
Introduce new optimized method type
`OPTIMIZED_METHOD_TYPE_STRUCT_AREF/ASET` with index information.
2021-11-19 08:32:39 +09:00
4fb71575e2
[DOC] Fix code markup [ci skip]
...
Code markup in RDoc must not be concatenated with anothr word.
2021-10-25 01:04:51 +09:00
dc9112cf10
Using NIL_P macro instead of `== Qnil`
2021-10-03 22:34:45 +09:00
2cf1014362
Enhanced RDoc for Struct ( #4895 )
...
Revises introductory material.
Adds section "What's Here".
Adds previously missing documentation for method #deconstruct_keys.
2021-09-27 18:17:47 -05:00
39a6bf5513
Enhanced RDoc for Struct ( #4891 )
...
Treats:
#values_at
#select
#==
#hash
#eql?
#size
#dig
2021-09-24 18:41:02 -05:00
Jean Boussier
Yusuke Endoh
Burdette Lamar
Peter Zhu
Nobuyoshi Nakada
Matt Valentine-House
Jeremy Evans
Sampat Badhe
John Bampton
Kouhei Yanagita
zverok
Ufuk Kayserilioglu
Alan Wu
Zack Deveau
S-H-GAMELINKS
Yuri Smirnov
Takashi Kokubun
John Hawthorn
Kazuhiro NISHIYAMA
Koichi Sasada