Граф коммитов

35 Коммитов

Автор SHA1 Сообщение Дата
Yusuke Endoh 25d74b9527 Do not include a backtick in error messages and backtraces
[Feature #16495]
2024-02-15 18:42:31 +09:00
Yusuke Endoh 4dc2cb3c1a [ruby/did_you_mean] Support the new message format of NameError in
Ruby 3.3
(https://github.com/ruby/did_you_mean/pull/184)

This change accepts the following change of the message of NameError in
a test.

https://bugs.ruby-lang.org/issues/18285#note-37

```
old: undefined method `sizee' for #<File:...>
new: undefined method `sizee' for an instance of File
```
2023-02-19 07:10:47 +00:00
Matthew Boeh 1602d75c34 [ruby/did_you_mean] Do not suggest #name= for #name and vice versa
(https://github.com/ruby/did_you_mean/pull/180)

* Do not suggest #name= for #name and vice versa
* Avoid allocating unnecessary MatchData

Co-authored-by: Jean byroot Boussier <jean.boussier+github@shopify.com>
Co-authored-by: Jean byroot Boussier <jean.boussier+github@shopify.com>
2022-12-05 13:16:33 +00:00
Imir Kiyamov f67ab7f30c [ruby/did_you_mean] Fixed correction duplicates in VariableNameChecker
https://github.com/ruby/did_you_mean/commit/c3fc412f6f
2022-09-01 19:47:39 +09:00
Hiroshi SHIBATA 11b9dd8ccb
Manually merged https://github.com/ruby/did_you_mean/pull/177 2022-06-07 15:24:48 +09:00
Hiroshi SHIBATA 4146fd284b
Rewrite with assert_ractor for multiple ractor environment 2022-05-20 19:48:28 +09:00
Hiroshi SHIBATA b6649797ee
Picked the missing test file from 8faba54b2d 2022-05-20 18:53:16 +09:00
Yuki Nishijima f9712b029b Sync did_you_mean 2021-12-24 23:20:30 +09:00
Yuki Nishijima de841e2e28 Revert the commits for did_you_mean
This reverts commit feaf4fbc3f.
This reverts commit 0d4bfbdbe1.
This reverts commit ac4e0978ee.
2021-12-23 10:09:10 +09:00
Yuki Nishijima feaf4fbc3f Remove test that activates Ractor unexpectedly 2021-12-23 09:43:39 +09:00
Yuki Nishijima ac4e0978ee * gems/default_gems: Sync did_you_mean 2021-12-22 20:29:18 +09:00
Yuki Nishijima cdb7d699d0 Revert commits for did_you_mean
This reverts commit 4560091b1c.
This reverts commit a6f76122a2.
This reverts commit e59b18a637.
This reverts commit 505dfae05d.
2021-12-21 22:10:03 +09:00
Yuki Nishijima a6f76122a2 * gems/default_gems: Fix CI builds 2021-12-21 20:03:47 +09:00
Yuki Nishijima 505dfae05d * gems/default_gems: Sync did_you_mean 2021-12-21 19:03:25 +09:00
Yuki Nishijima 66df18c55e Sync did_you_mean again 2021-10-22 21:00:23 -04:00
Yuki Nishijima 22249bbb37 Revert "Sync did_you_mean"
This reverts commit e22d293e06.
2021-10-22 20:56:26 -04:00
Yuki Nishijima e22d293e06 Sync did_you_mean 2021-10-22 20:35:40 -04:00
Yusuke Endoh be51f4ce83 [ruby/did_you_mean] Disable error_highlight when testing did_you_mean
Fixes #160

https://github.com/ruby/did_you_mean/commit/93df310873
2021-09-28 17:48:57 +09:00
Peter Zhu 682f58a933 Fix typo in test name 2021-09-02 09:57:02 -04:00
Yusuke Endoh 91ffce8f24 [ruby/did_you_mean] Prevent "warning: ambiguity between regexp and two divisions"
```
test/did_you_mean/spell_checking/test_uncorrectable_name_check.rb:13: warning: ambiguity between regexp and two divisions: wrap regexp in parentheses or add a space after `/' operator
```
http://rubyci.s3.amazonaws.com/ubuntu/ruby-master/log/20210630T033005Z.log.html.gz#test-all

https://github.com/ruby/did_you_mean/commit/842ede4186
2021-07-19 10:34:38 +09:00
Yusuke Endoh 39f99b8176 Use assert_not_match "Did you mean?" for UncorrectableNameCheckTest
... instead of exact matching. I'm now creating a built-in gem that
modifies Exception's error message, so the expectation value is changed.

IMO, it is good to check that did_you_mean suggestion is NOT added in
the uncorrectable case.

https://github.com/ruby/did_you_mean/commit/ebe88ec4d2
2021-06-29 15:49:51 +09:00
Nobuyoshi Nakada 8e06075442
Revert "Fixed typo"
This reverts commit 379a5ca539.
This "typo" is intentional to test the transposition detection by
did_you_mean.
2020-10-27 23:26:38 +09:00
Hiroshi SHIBATA 379a5ca539
Fixed typo 2020-10-27 22:59:43 +09:00
Yuki Nishijima e5f5446528 Sync did_you_mean 2020-06-06 13:02:08 -04:00
Nobuyoshi Nakada ee518cf077
Revert "Sync did_you_mean"
This reverts commit 946dadd3f4,
which broke `TestGemRequire` and others.
2020-05-12 16:27:25 +09:00
Yuki Nishijima 946dadd3f4 Sync did_you_mean 2020-05-11 23:25:04 -04:00
S-H-GAMELINKS b1b155ff03 support multi-run test for test/did_you_mean/test_verbose_formatter.rb 2020-02-13 11:07:38 +09:00
S-H-GAMELINKS b76a21aa45 support multi-run test for test/did_you_mean/spell_checking/test_class_name_check.rb 2020-02-07 09:30:43 -05:00
Yuki Nishijima 672a61b97f Port dd1dd86e6c 2019-12-23 00:47:41 -05:00
Nobuyoshi Nakada e68999c82c
Fixed misspellings
Fixed misspellings reported at [Bug #16437], for default gems.
2019-12-20 12:19:45 +09:00
Kazuhiro NISHIYAMA 1a88adcd75 Fix Leaked file descriptor in test/did_you_mean
de74d2c3b0/checks?check_suite_id=336910877#step:19:131
```
Leaked file descriptor: NameErrorExtensionTest#test_correctable_error_objects_are_dumpable: 7 : #<File:test_name_error_extension.rb>
```
2019-12-02 16:25:43 +09:00
Yuki Nishijima cc7455dd1e Relax test requirements for DYM's verbose formatter 2019-11-30 22:29:02 -05:00
Koichi Sasada 56faa13a1c remove spaces to pass a test.
23d7f4c5e1 breaks a test which expect
to match error message. To avoid this failure, use #strip for expect
and actual results.
2019-12-01 12:24:50 +09:00
git 23d7f4c5e1 * remove trailing spaces. [ci skip] 2019-12-01 11:08:39 +09:00
Kevin Deisz 171803d5d3 Promote did_you_mean to default gem
At the moment, there are some problems with regard to bundler + did_you_mean because of did_you_mean being a bundled gem. Since the vendored version of thor inside bundler and ruby itself explicitly requires did_you_mean, it can become difficult to load it when using Bundler.setup. See this issue: https://github.com/yuki24/did_you_mean/issues/117#issuecomment-482733159 for more details.
2019-11-30 21:08:19 -05:00