Граф коммитов

951 Коммитов

Автор SHA1 Сообщение Дата
David Rodríguez 4756c5f7e7 [bundler/bundler] Remove unnecessary rubygems monkeypatch
Instead, make sure we always load the local copy of bundler during
specs, and never end up using the default copy.

https://github.com/bundler/bundler/commit/ac655ffeda
2019-08-18 13:45:35 +09:00
David Rodríguez 5a69a23afc [bundler/bundler] Don't use system bundler on this spec
If we use system bundler, when booting the "outermost" bundler process,
bundler will save the path to the system bundler in BUNDLE_BIN_PATH, and
use it again when booting the "innermost" bundler process (`bundle exec
echo foo`).

That means that second process will use the system bundler path again.
However, we have `-rsupport/hax` in RUBYOPT, so that file will load from
the local copy of bundler, and that file will load `bundler/version`
from the project (not from system), because -Ilib is in the LOAD_PATH.

That will end up causing redefinition errors because the same constant
will be loaded from two different locations.

In general, this is expected behavior, normally you will wrap the
process with `Bundler.with_original_env` to reset the environment.
However, the easiest fix here is to not use system bundler, because it's
not really necessary and thus doesn't help the readability of the spec.

https://github.com/bundler/bundler/commit/a3d72a34ab
2019-08-18 13:45:25 +09:00
David Rodríguez 0653d8c601 [bundler/bundler] Fix spec using the deprecated `bundle config` mode
https://github.com/bundler/bundler/commit/789dd1864f
2019-08-18 13:45:15 +09:00
David Rodríguez f753961611 [bundler/bundler] Remove a bunch of unneeded rubygems requires
https://github.com/bundler/bundler/commit/f9cb39e614
2019-08-18 13:44:46 +09:00
Zehan Zhao d80f5399ad [bundler/bundler] Fix open default gem error
https://github.com/bundler/bundler/commit/792d724752
2019-08-18 13:44:26 +09:00
David Rodríguez 98841b2b19 [bundler/bundler] Wrap `open` specs with a context
So I can add another context that doesn't run the `before` block.

https://github.com/bundler/bundler/commit/06d0acc45a
2019-08-18 13:44:22 +09:00
David Rodríguez e6e8d2d8c0 [bundler/bundler] Prefer `before` to `before :each`
https://github.com/bundler/bundler/commit/6678747fae
2019-08-18 13:44:13 +09:00
David Rodríguez cc644c7116 [bundler/bundler] Fix `bundle doctor` command
Previously `bundle doctor` would fail on any bundle that does not
include git gems or plugins. This is because the previously used
`Bundler.home` does not exist unless the bundle includes git gems or
plugins. For example, with `bundle config set path .bundle`, it points
to which does not exist unless this kind of gems exist in the Gemfile.

The name `Bundler.home` is really unfortunate, it should probably be
have more descriptive name, and be private. But for now I just want to
make `bundle doctor` usable.

https://github.com/bundler/bundler/commit/5531a18c1e
2019-08-18 13:44:03 +09:00
David Stosik a02dbcecb1 [bundler/bundler] Bundler displays a duplicate gem entries warning even if gems only appear once per group
https://github.com/bundler/bundler/commit/d18a83109e
2019-08-18 13:43:59 +09:00
David Rodríguez 08c58e3c0d
[bundler/bundler] Extract a `gemspec_dir` helper
https://github.com/bundler/bundler/commit/71a29e286a
2019-08-17 17:08:51 +09:00
David Rodríguez a2d7c97a91
[bundler/bundler] Extract yet another helper method
https://github.com/bundler/bundler/commit/948a863bd8
2019-08-17 17:08:51 +09:00
David Rodríguez 4318405609
[bundler/bundler] Extract a `root_gemspec` local variable
https://github.com/bundler/bundler/commit/a4beba4cbf
2019-08-17 17:08:51 +09:00
David Rodríguez 09455301ef
[bundler/bundler] Extract a `with_root_gemspec` helper
https://github.com/bundler/bundler/commit/f20c2bdf6a
2019-08-17 17:08:51 +09:00
David Rodríguez 20c5154f0b
[bundler/bundler] Only chdir when necessary
https://github.com/bundler/bundler/commit/07161ebc1a
2019-08-17 17:08:51 +09:00
David Rodríguez 580e093fdd
[bundler/bundler] Make sure gem has been built before deleteng it
https://github.com/bundler/bundler/commit/32520c7020
2019-08-17 17:08:51 +09:00
David Rodríguez a56bf5bfde
[bundler/bundler] Cleanup in a location independent way
https://github.com/bundler/bundler/commit/5b503a4bf1
2019-08-17 17:08:51 +09:00
David Rodríguez 9c0fcd1d0f
[bundler/bundler] Remove obvious comment
https://github.com/bundler/bundler/commit/91e7fe1b2f
2019-08-17 17:08:51 +09:00
David Rodríguez adfca752d6
[bundler/bundler] Remve another unneeded `to_s`
`FileUtils.rm` supports a `Pathname` argument.

https://github.com/bundler/bundler/commit/7d982a5be9
2019-08-17 17:08:51 +09:00
David Rodríguez 9925e1a10f
[bundler/bundler] Remove unneeded `to_s` calls
They are implicit inside `gem_command!`.

https://github.com/bundler/bundler/commit/6bdb13c899
2019-08-17 17:08:51 +09:00
David Rodríguez f88237623f
[bundler/bundler] Consistently use `Path` over `Spec::Path`
https://github.com/bundler/bundler/commit/a4cca66b79
2019-08-17 17:08:51 +09:00
David Rodríguez aef5509139
[bundler/bundler] Extract single gem installation logic
https://github.com/bundler/bundler/commit/7888d621c8
2019-08-17 17:08:51 +09:00
David Rodríguez 20af44c277
[bundler/bundler] Unalias `install_gem`
Since I plan to reuse it for something else.

https://github.com/bundler/bundler/commit/5379382198
2019-08-17 17:08:50 +09:00
David Rodríguez 6506993462
[bundler/bundler] Use `join` consistently
https://github.com/bundler/bundler/commit/096e53dfe6
2019-08-17 17:08:50 +09:00
David Rodríguez 6a299906b4
[bundler/bundler] Extract a `lib_tracked_files` path helper
https://github.com/bundler/bundler/commit/028dc46f5a
2019-08-17 17:08:50 +09:00
David Rodríguez 19dabfbe57
[bundler/bundler] Rename a variable
Otherwise I get conflicts when extracting the helper.

https://github.com/bundler/bundler/commit/314c64cd07
2019-08-17 17:08:50 +09:00
David Rodríguez c896f71577
[bundler/bundler] Extract a `tracked_files` path helper
https://github.com/bundler/bundler/commit/d35e31d2e0
2019-08-17 17:08:50 +09:00
David Rodríguez b43f4bd218
[bundler/bundler] Rename some variables
I want to extract these to path helper methods, but the name `files`
conflict with some builder methods that are also available at the same
level.

https://github.com/bundler/bundler/commit/7844096af0
2019-08-17 17:08:50 +09:00
David Rodríguez 334e615022
[bundler/bundler] Reconcile test
The `:bundler` gem is not needed in the regular repo either.

https://github.com/bundler/bundler/commit/ca5ce01a9b
2019-08-17 17:08:50 +09:00
David Rodríguez 122bc65042
[bundler/bundler] Reuse `gem_bin` helper inside `gem_command`
The logic for choosing `gem_bin` should work here too even if it's not
identical.

https://github.com/bundler/bundler/commit/6ca0271b27
2019-08-17 17:08:50 +09:00
David Rodríguez 30a4ec1fee
[bundler/bundler] Always use `--backtrace` when invoking `gem` CLI
For debuggability.

https://github.com/bundler/bundler/commit/ac3e8db658
2019-08-17 17:08:50 +09:00
David Rodríguez 91c63828f7
[bundler/bundler] Extract a `gem_bin` path helper
https://github.com/bundler/bundler/commit/8eedbecac0
2019-08-17 17:08:50 +09:00
David Rodríguez e38994d2f7
[bundler/bundler] Reuse `gem_command!` helper
https://github.com/bundler/bundler/commit/37d5dedffe
2019-08-17 17:08:50 +09:00
David Rodríguez 63d78afc2d
[bundler/bundler] Remove more dead code
https://github.com/bundler/bundler/commit/17d4d0de8e
2019-08-17 17:08:50 +09:00
David Rodríguez 2e6509498c
[bundler/bundler] Remove dead code
https://github.com/bundler/bundler/commit/cae948f514
2019-08-17 17:08:50 +09:00
David Rodríguez 3bebdda649
[bundler/bundler] Remove unnecessary rubygems require
https://github.com/bundler/bundler/commit/039604ff95
2019-08-17 17:08:50 +09:00
David Rodríguez 7af12a92c8
[bundler/bundler] Use path helpers to find bundle bin
https://github.com/bundler/bundler/commit/7985bb8e92
2019-08-17 17:08:50 +09:00
David Rodríguez 6357540945
[bundler/bundler] Fix bundle bin location in core repo
https://github.com/bundler/bundler/commit/9437568ab4
2019-08-17 17:08:49 +09:00
David Rodríguez 7551117c70
[bundler/bundler] Reuse more shared path helpers
https://github.com/bundler/bundler/commit/79fdebd868
2019-08-17 17:08:49 +09:00
David Rodríguez 9995ce64a2
[bundler/bundler] Remove unnecessary assignment
https://github.com/bundler/bundler/commit/e483322519
2019-08-17 17:08:49 +09:00
David Rodríguez a2ca3a12ba
[bundler/bundler] Remove unnecessary `let`
Use shared helper instead.

https://github.com/bundler/bundler/commit/ef55470cc6
2019-08-17 17:08:49 +09:00
David Rodríguez 745b286161
[bundler/bundler] Move `lib` helper together with path helpers
https://github.com/bundler/bundler/commit/f2df73bdb4
2019-08-17 17:08:49 +09:00
David Rodríguez 50a91fcd10
[bundler/bundler] Reuse `lib` method
https://github.com/bundler/bundler/commit/4589a57852
2019-08-17 17:08:49 +09:00
David Rodríguez ef2d415802
[bundler/bundler] Remove duplicated method
https://github.com/bundler/bundler/commit/afdacd62ac
2019-08-17 17:08:49 +09:00
Hiroshi SHIBATA 273f1f4498
Move fixture path to last path 2019-08-17 15:12:45 +09:00
Kazuhiro NISHIYAMA ccbfb054b1
Fix typos 2019-08-17 13:57:12 +09:00
Hiroshi SHIBATA 02d0d424be
Revert "[bundler/bundler] Fixup #7297"
This reverts commit b8d759806f.

  It's accidentally picked from the upstream repository.
2019-08-16 14:52:03 +09:00
Hiroshi SHIBATA b8d759806f [bundler/bundler] Fixup #7297
https://github.com/bundler/bundler/commit/1a0161b970
2019-08-16 14:30:23 +09:00
Hiroshi SHIBATA 8cf90a2f80 [bundler/bundler] Fixed rubocop error
https://github.com/bundler/bundler/commit/9256177446
2019-08-16 14:30:23 +09:00
tommy 3b61019a89 [bundler/bundler] Add initial Bundler::BuildMetadata Spec
https://github.com/bundler/bundler/commit/c6458b2727
2019-08-16 14:30:23 +09:00
David Rodríguez b587e8c7f1 [bundler/bundler] Add `--[no-]git` option to `bundle gem`
I think using `--no-git` can be useful when creating gems inside
monorepos.

https://github.com/bundler/bundler/commit/154c687310
2019-08-16 14:30:23 +09:00
David Rodríguez cb71930351 [bundler/bundler] Remove unexistent folder from exemptions
https://github.com/bundler/bundler/commit/0b6d973543
2019-08-16 14:30:23 +09:00
David Rodríguez f48a61fb46 [bundler/bundler] Commit man pages to source control
This has the benefit that:

* Allows the installation of bundler as a default gem from rubygems to
include man pages.
* Removes the need to build man pages during our tests.
* Makes working with the manifest easier, because we only have source
controlled files, and not a mix of source control and generated files.

To make sure they never fall out of sync, we replace the previous
`man:build` CI task with a `man:check` task that makes sure the
generated man pages are up to date.

https://github.com/bundler/bundler/commit/23de1d0177
2019-08-16 14:30:23 +09:00
David Rodríguez 4913c9b6bf [bundler/bundler] Remove unexistent file from exemptions
https://github.com/bundler/bundler/commit/8601575490
2019-08-16 14:30:23 +09:00
David Rodríguez 94e26a97a1 [bundler/bundler] Bump rspec dependency to 3.8
Because we're using `config.bisect_runner` which is only available from
3.8.

https://github.com/bundler/bundler/commit/304a187f72
2019-08-16 14:30:23 +09:00
David Rodríguez 521a2d2beb [bundler/bundler] Revert "make system_bundle_bin_path helper and resolve failing tests for ruby < 2.6"
This reverts commit e63e844bc7444c6a489fcde0dc7011c6c4807edd.

It was introduced to resolve some failing tests at the cost of making
the intention of the spec much less clear.

Thanks to the previous fixes we have added to this spec, we can revert
that patch now.

https://github.com/bundler/bundler/commit/b29a40820f
2019-08-16 14:30:23 +09:00
David Rodríguez 5bff72c912 [bundler/bundler] Make sure spec fails if `bundle install` fails
https://github.com/bundler/bundler/commit/2ed2bbfdec
2019-08-16 14:30:23 +09:00
David Rodríguez 7ff0b4fec4 [bundler/bundler] Fix installation of system bundler
Previously it was being installed to the :bundle_path
(`/tmp/bundled_app/.bundle`), but the `bundle` helper uses the
`system_gem_path("bin/bundle")`. That means the first `bundle install`in
the spec was actually failing, but not affecting the test status because
of not being called as `bundle!`.

https://github.com/bundler/bundler/commit/ad75f75539
2019-08-16 14:30:23 +09:00
David Rodríguez 6c6c4c7388 [bundler/bundler] Use non deprecated way of setting bundler path
https://github.com/bundler/bundler/commit/6013c93e81
2019-08-16 14:30:23 +09:00
David Rodríguez ee1f3038f1 [bundler/bundler] Clarify spec description
https://github.com/bundler/bundler/commit/b2abde04aa
2019-08-16 14:30:23 +09:00
David Rodríguez 0aed0bd9ed [bundler/bundler] Bump rack and sinatra to latest versions
https://github.com/bundler/bundler/commit/09ecaf04fa
2019-08-16 14:30:23 +09:00
David Rodríguez 129657ab6a [bundler/bundler] Normalize style with other artifice files
https://github.com/bundler/bundler/commit/f11c9a2b3f
2019-08-16 14:30:23 +09:00
David Rodríguez 41534ce327 [bundler/bundler] Make spec pass more resiliently
Previously, if bundler-2.1.0.pre.1 would be installed globally, it would
fail. Now we force that a locally installed version of bundler is used,
so it always passed regardless of which bundler is installed globally.

https://github.com/bundler/bundler/commit/764d8e8fd1
2019-08-16 14:30:23 +09:00
David Rodríguez 3c23bb29ec [bundler/bundler] Remove unnecessary exclusions
https://github.com/bundler/bundler/commit/c189dfdde0
2019-08-16 14:30:23 +09:00
David Rodríguez 3f0e19c9fa [bundler/bundler] Enable retries on flaky spec
https://github.com/bundler/bundler/commit/da360659f7
2019-08-16 14:30:23 +09:00
Benoit Daloze 2b0f3aa095 [bundler/bundler] Use the standard RUBY_ENGINE_VERSION instead of JRUBY_VERSION
* RUBY_ENGINE and RUBY_ENGINE_VERSION are defined on every modern Ruby.
* There is no such constant as TRUFFLERUBY_VERSION or RBX_VERSION.

https://github.com/bundler/bundler/commit/f9d910403b
2019-08-16 14:30:23 +09:00
David Rodríguez 6711343d5a [bundler/bundler] Fix inconsistent lockfile order
When Gemfile would specify path sources as relative paths starting with
"./", the lockfile would have inconsistent order on `bundle install` and
`bundle update`.

https://github.com/bundler/bundler/commit/c7532ced89
2019-08-16 14:30:23 +09:00
David Rodríguez c11c8b69ea [bundler/bundler] Indentation tweak
https://github.com/bundler/bundler/commit/5978a88f33
2019-08-16 14:30:23 +09:00
Koichi Sasada 182a408c2c
change Proc#to_s format ('@...' -> ' ...') (#2362)
Now Proc#to_s returns
"#<Proc:0x00000237a0f5f170@t.rb:1>".
However, it is convenient to select a file name by (double-)clicking
on some terminals by separating ' ' instead of '@' like
"#<Proc:0x00000237a0f5f170 t.rb:1>"
[Feature #16101]
2019-08-14 16:25:15 +09:00
Hiroshi SHIBATA ed9d59afc8
Added example filter for Linux of GitHub Actions. 2019-08-12 12:14:39 +09:00
Hiroshi SHIBATA 8a8f680f01
Re-use GITHUB_ACTION variables for filtering bundler examples. 2019-08-12 12:14:39 +09:00
Hiroshi SHIBATA bb2f24251f
GitHub Actions does not support ANSI color code. Skip failing examples. 2019-08-11 12:17:22 +09:00
ohbarye b1678338e5
Fix typo: duplicated the [skip-ci] 2019-08-09 16:23:49 -07:00
Nobuyoshi Nakada ec0d742dd7
Suppress warnings against locations in eval 2019-08-03 14:07:10 +09:00
Hiroshi SHIBATA b3b2b55f7b
[bundler/bundler] The keys for RbConfig::CONFIG was String.
https://github.com/bundler/bundler/commit/ffc5e76335
2019-08-03 09:40:11 +09:00
Hiroshi SHIBATA 220f6aa01c
Explicitly ignored GEMRC environmental variable. 2019-08-03 09:30:00 +09:00
Hiroshi SHIBATA 4c72ca195d
Fixed up 365ee22d73ec73c119a842de271504e04bed6f45 2019-08-03 09:30:00 +09:00
Hiroshi SHIBATA 01d141938c
Fixed the broken example with ruby core structure. 2019-08-03 09:30:00 +09:00
David Rodríguez 7ed1fc527e
[bundler/bundler] Bump rubocop to 0.74.0
And reenable exclusion because the bug why we added them has been fixed.
See https://github.com/rubocop-hq/rubocop/issues/6861.

https://github.com/bundler/bundler/commit/bda63fcffc
2019-08-03 09:30:00 +09:00
David Rodríguez 1e63683795
[bundler/bundler] Bump automatiek to 0.2.0
https://github.com/bundler/bundler/commit/cd1abf8b3f
2019-08-03 09:30:00 +09:00
David Rodríguez 97f3ceeaa5
[bundler/bundler] Bump net-http-persistent to 3.0.1
* Adds an extra artifice task to vendorize new `connection_pool`
dependency.

* Cherry-pick's needed Windows fix not yet merged into master branch of
`net-http-persistent`.

* Update bundler usages to be compatible with the new version, and fix
unit specs.

https://github.com/bundler/bundler/commit/0575baa6bb
2019-08-03 09:30:00 +09:00
David Rodríguez 2b7e39f364
[bundler/bundler] Always set `cache_all` via config during tests
So that the behavior is the same regardless of the tested bundler
version.

https://github.com/bundler/bundler/commit/664549427a
2019-08-03 09:30:00 +09:00
David Rodríguez 267a72be80
[bundler/bundler] Enable `Style/UnneededInterpolation` cop
https://github.com/bundler/bundler/commit/4c6a3c3cf7
2019-08-03 09:30:00 +09:00
David Rodríguez e84e63230b
[bundler/bundler] Check for straneous quotes
And use single quotes consistenly.

https://github.com/bundler/bundler/commit/8b9fbbb2df
2019-08-03 09:30:00 +09:00
Samuel Giddins 4dea1356c3
[bundler/bundler] [CurrentRuby] Say we are ruby? when the generic local platform is Gem::Platform::RUBY
This allows us to always say we're ruby? when force_ruby_platform is
set, and fixes using gemspec & force_ruby_platform on windows.

https://github.com/bundler/bundler/commit/3cb89b7e5c
2019-08-03 09:30:00 +09:00
David Rodríguez 6fb73e6043
[bundler/bundler] Fully remove compatibility guard
https://github.com/bundler/bundler/commit/2a7a5daba0
2019-08-03 09:30:00 +09:00
David Rodríguez 452516f50f
[bundler/bundler] Remove development dependencies from gemspec
And refactor development setup.

https://github.com/bundler/bundler/commit/f288806d02
2019-08-03 09:30:00 +09:00
David Rodríguez 7255f55dba
[bundler/bundler] RUBY_ENGINE should always be defined after 1.8.7
https://github.com/bundler/bundler/commit/d6c9196d18
2019-08-03 09:30:00 +09:00
Hiroshi SHIBATA d4b1804b11
[bundler/bundler] Removed the environmental variables that are BUNDLE_USER_*.
It's affect with rspec examples and broke them.

https://github.com/bundler/bundler/commit/355a922073
2019-08-03 09:30:00 +09:00
Guillermo Guerrero e33dd659d4
[bundler/bundler] Move duplicated code to `before` blocks
https://github.com/bundler/bundler/commit/69bee117fb
2019-08-03 09:29:59 +09:00
David Rodríguez c4a2a9a381
[bundler/bundler] Remove now unused logic
https://github.com/bundler/bundler/commit/5b285685a4
2019-08-03 09:29:59 +09:00
David Rodríguez 322d4fe98d
[bundler/bundler] Remove unnecessary indirections
These specs are only run on bundler 2, so the compatibility method is
not needed.

https://github.com/bundler/bundler/commit/6cb28e3aeb
2019-08-03 09:29:59 +09:00
David Rodríguez 640dbdd155
[bundler/bundler] Better info about spec exclusions
https://github.com/bundler/bundler/commit/1ee77d9c55
2019-08-03 09:29:59 +09:00
David Rodríguez 51aaed128a
[bundler/bundler] Skip specs using `Process.fork` on Windows
https://github.com/bundler/bundler/commit/ebcb25a3c3
2019-08-03 09:29:59 +09:00
David Rodríguez d7487d6c08
[bundler/bundler] Try make some specs platform independent
https://github.com/bundler/bundler/commit/b5900e57a4
2019-08-03 09:29:59 +09:00
David Rodríguez 9d82962af3
[bundler/bundler] Check for generic lockfiles
https://github.com/bundler/bundler/commit/344a881592
2019-08-03 09:29:59 +09:00
David Rodríguez cb6abf551a
[bundler/bundler] Update error messages to be more precise
https://github.com/bundler/bundler/commit/9ddeeb1fe1
2019-08-03 09:29:59 +09:00
David Rodríguez a1c69991a5
[bundler/bundler] Use a consistent requirement in binstub
https://github.com/bundler/bundler/commit/50ccdb32c2
2019-08-03 09:29:59 +09:00
David Rodríguez 3e10b4a0be
[bundler/bundler] Indentation fixes
https://github.com/bundler/bundler/commit/2a44090cb6
2019-08-03 09:29:58 +09:00
David Rodríguez 3e83fbddfa
[bundler/bundler] Add a comment to explain the initial reset
https://github.com/bundler/bundler/commit/6d0a8f4128
2019-08-03 09:29:58 +09:00
David Rodríguez 55831647fb
[bundler/bundler] Move environment reset to the only test needing it
https://github.com/bundler/bundler/commit/6d3b809695
2019-08-03 09:29:58 +09:00
David Rodríguez 1b081cdd65
[bundler/bundler] Improve test to make it more independent from env
https://github.com/bundler/bundler/commit/038f0d7c37
2019-08-03 09:29:58 +09:00
David Rodríguez 26f651796c
[bundler/bundler] Remove unnecessary assignments
https://github.com/bundler/bundler/commit/3e5d4b2c42
2019-08-03 09:29:58 +09:00
MSP-Greg d6a2e082e6
[bundler/bundler] spec/bundler/shared_helpers_spec.rb - fixup after 7248
PR 7248 incorrectly changed a path calculation.  This reverts.

After running Azure Pipelines CI in my ruby/ruby fork and checking  the  'bundler' jobs, the error was apparent...

https://github.com/bundler/bundler/commit/811755b413
2019-08-03 09:29:58 +09:00
MSP-Greg 432285c004
[bundler/bundler] fix nested bundle exec's when bundler is a default gem
https://github.com/bundler/bundler/commit/537c0ab712
2019-08-03 09:29:58 +09:00
MSP-Greg 7b7caf9b55
[bundler/bundler] dsl_spec.rb - fix for Ruby core
https://github.com/bundler/bundler/commit/33892e1ed2
2019-08-03 09:29:58 +09:00
David Rodríguez 4f5e1b6ebf
[bundler/bundler] Remove `cache_command_is_package` feature flag
So that we handle the removal of `bundle cache` just like we'll handle
the removal of `bundle show` and `bundle console`.

https://github.com/bundler/bundler/commit/ff1a669efb
2019-08-03 09:29:58 +09:00
David Rodríguez 31541d7389
[bundler/bundler] Drop rubygems 2.5.0 and 2.5.1 support
https://github.com/bundler/bundler/commit/8ecd722b9f
2019-08-03 09:29:58 +09:00
David Rodríguez fc42423b8d
[bundler/bundler] Correct a rubygems test filter
It seems to pass under rubygems 2.5.2.

https://github.com/bundler/bundler/commit/062cd2be7c
2019-08-03 09:29:58 +09:00
David Rodríguez f5cd02f362
[bundler/bundler] Remove unnecessary test filter
Since it covers the whole range we support.

https://github.com/bundler/bundler/commit/c0b9d4e6c6
2019-08-03 09:29:58 +09:00
David Rodríguez a6ce001bab
[bundler/bundler] Change the refresh spec to not use `stubs_for`
We plan to incrementally populate this array in rubygems, so that will
break the test because the first time `find_by_name("rack")` is called
will make the `rack` gem available in the array.

We can test the same thing using some other way, which is more
appropriate anyways, because `Bundler.rubygems.find_name` is only used
inside `bundler` to look for the `bundler` gem itself whereas
`Bundler.rubygems.all_specs` is used in more places.

https://github.com/bundler/bundler/commit/49c519ef47
2019-08-03 09:29:58 +09:00
David Rodríguez a181df7542
[bundler/bundler] No need to make `Gem.refresh` a noop
The rubygems integration sets up a `post_reset` hook that resets the
specs back to what bundler knows after `Gem::Specification.reset` is
called (which is what `Gem.refresh` calls under the hood).

https://github.com/bundler/bundler/commit/3810f9945c
2019-08-03 09:29:58 +09:00
David Rodríguez f399a2b796
[bundler/bundler] Remove unnecessary line
It contains a typo, so it can't be needed.

https://github.com/bundler/bundler/commit/ef38c97fbf
2019-08-03 09:29:58 +09:00
David Rodríguez 56fd027aa6
[bundler/bundler] Tweak some quality specs to check more files
https://github.com/bundler/bundler/commit/98023e25de
2019-08-03 09:29:58 +09:00
David Rodríguez 812dfa44f0
[bundler/bundler] Refactor setting the encoding in quality specs
Instead of setting the encoding globally, set it when reading the files.

https://github.com/bundler/bundler/commit/e2a5c45e4d
2019-08-03 09:29:57 +09:00
David Rodríguez 6cbe818c66
[bundler/bundler] This seems to pass for me
https://github.com/bundler/bundler/commit/e31880b1ea
2019-08-03 09:29:57 +09:00
David Rodríguez dae6d303d5
[bundler/bundler] Remove now meaningless warning
https://github.com/bundler/bundler/commit/00b095b98f
2019-08-03 09:29:57 +09:00
David Rodríguez c1ca77281d
[bundler/bundler] Add all platforms to lockfile by default
https://github.com/bundler/bundler/commit/3dc509e645
2019-08-03 09:29:57 +09:00
David Rodríguez d8cd45cb1a
[bundler/bundler] Refactor some specs
https://github.com/bundler/bundler/commit/785c7af1f3
2019-08-03 09:29:57 +09:00
David Rodríguez cef81eb8cc
[bundler/bundler] Make some specs more explicit
https://github.com/bundler/bundler/commit/5e08e849ec
2019-08-03 09:29:57 +09:00
David Rodríguez b2baf6bb02
[bundler/bundler] Remove unnecessary begin-end block
And freeze the resulting hash to appease rubocop.

https://github.com/bundler/bundler/commit/f38ebff92f
2019-08-03 09:29:57 +09:00
David Rodríguez 0dad89c0fe
[bundler/bundler] Fix typos
https://github.com/bundler/bundler/commit/1bd9660780
2019-08-03 09:29:57 +09:00
David Rodríguez 8d9fc8466f
[bundler/bundler] Reuse `lockfile` spec helper
https://github.com/bundler/bundler/commit/e6a03f1102
2019-08-03 09:29:57 +09:00
David Rodríguez 2f1d52c266
[bundler/bundler] Remove unused filter
https://github.com/bundler/bundler/commit/102d6229d4
2019-08-03 09:29:57 +09:00
David Rodríguez aae244569b
[bundler/bundler] Reuse `gemfile` spec helper
https://github.com/bundler/bundler/commit/22de94d3b4
2019-08-03 09:29:57 +09:00
David Rodríguez 05c3b7c8a9
[bundler/bundler] More specific assertion
1.0.0 is such a common output, and it was hiding a crash in the test.

https://github.com/bundler/bundler/commit/c688337e24
2019-08-03 09:29:57 +09:00
David Rodríguez 13e5bf3454
[bundler/bundler] Remove redundant assertion
https://github.com/bundler/bundler/commit/7ac854dea1
2019-08-03 09:29:57 +09:00
David Rodríguez 2c262d137c
[bundler/bundler] Make spec easier to debug
https://github.com/bundler/bundler/commit/156629291e
2019-08-03 09:29:57 +09:00
Samuel Giddins 82bf064375
[bundler/bundler] [Package] Ensure uninstallable gems are _never_ installed
https://github.com/bundler/bundler/commit/899aeeebb0
2019-08-03 09:29:57 +09:00
Samuel Giddins d761a0f6ff
[bundler/bundler] [Package] Always resolve remotely for --all-platforms
https://github.com/bundler/bundler/commit/e45d2272ea
2019-08-03 09:29:56 +09:00
David Rodríguez 2ccb3db5fb
[bundler/bundler] Add missing mock
I'm not sure this test is useful but since it's there, it should be
complete.

https://github.com/bundler/bundler/commit/3e350089db
2019-08-03 09:29:56 +09:00
David Rodríguez e6dc7b5b5b
[bundler/bundler] Improve spec to be more realistic
https://github.com/bundler/bundler/commit/ca96316b97
2019-08-03 09:29:56 +09:00
David Rodríguez 4b1395ab4a
[bundler/bundler] Clearer MissingRevision git errors
https://github.com/bundler/bundler/commit/b47d23edf5
2019-08-03 09:29:56 +09:00
David Rodríguez bdcd1990ad
[bundler/bundler] Generate new gem development dependencies in Gemfile
https://github.com/bundler/bundler/commit/02177d0e10
2019-08-03 09:29:56 +09:00
David Rodríguez 86757abd25
[bundler/bundler] Fix local variable name
https://github.com/bundler/bundler/commit/3df138318f
2019-08-03 09:29:56 +09:00
David Rodríguez f2cc018adb
[bundler/bundler] Reuse `execute_bundle_gem` method
https://github.com/bundler/bundler/commit/773203ec5a
2019-08-03 09:29:56 +09:00
David Rodríguez 2771789302
[bundler/bundler] Don't re-resolve locked platform specific gems
https://github.com/bundler/bundler/commit/7da2bf75f5
2019-08-03 09:29:56 +09:00
David Rodríguez 72daf37dee
[bundler/bundler] Fix a typo on a spec comment
https://github.com/bundler/bundler/commit/1a853ad6ac
2019-08-03 09:29:56 +09:00
robuye 884f948a90
[bundler/bundler] bundler/inline should always install gems to system path
As discussed in the P/R, when `BUNDLE_PATH` env is set Bundler should
still install gems to the system path. `GEM_HOME` can be used to provide
different location if needed.

The test is added to document expected behavior of `bundler/inline`.

https://github.com/bundler/bundler/commit/ae419fd6f8
2019-08-03 09:29:56 +09:00
David Rodríguez 4089f8df1e
[bundler/bundler] Use real paths for `bundle clean`
https://github.com/bundler/bundler/commit/0646f9e286
2019-08-03 09:29:56 +09:00
David Rodríguez e59b57a3a7
[bundler/bundler] Fix thread leak in compact index specs
This spec was not stopping threads after itself. That would cause the
previous spec in the file (that checks that no threads are left behind)
to fail.

https://github.com/bundler/bundler/commit/81ad85b92d
2019-08-03 09:29:56 +09:00
Miklos Fazekas a12557dbfd
[bundler/bundler] Add `required_ruby_version` to gemspec template
https://github.com/bundler/bundler/commit/f47421f92d
2019-08-03 09:29:56 +09:00
David Rodríguez b014a2157f
[bundler/bundler] Factor out gemspec call inside `let`
https://github.com/bundler/bundler/commit/ae0ac190aa
2019-08-03 09:29:56 +09:00
David Rodríguez 10c0271f97
[bundler/bundler] Remove duplicated `let`'s
https://github.com/bundler/bundler/commit/43ffaab796
2019-08-03 09:29:55 +09:00
David Rodríguez a685a8643f
[bundler/bundler] Fix `rake release` not prompting for OTP code
Co-authored-by: Colby Swandale <me@colby.fyi>
Co-authored-by: Kevin Deisz <kevin.deisz@gmail.com>

https://github.com/bundler/bundler/commit/1b2bbc7364
2019-08-03 09:29:55 +09:00
David Rodríguez e111f38f34
[bundler/bundler] Fix file:// handling under Windows
Windows paths do not start with a slash, so we add an extra slash to
separate the host from the path in file:// urls. Otherwise "D:" is
parsed as the host segment in the URI.

The path for those URLs now starts with "/", so we ignore that leading
character when using the URI's path.

This reduces Windows CI spec failures from 429 to 355.

https://github.com/bundler/bundler/commit/1b7e274cbc
2019-08-03 09:29:55 +09:00
David Rodríguez c3ddd47ce7
[bundler/bundler] Normalize file:// handling in specs
https://github.com/bundler/bundler/commit/5946d62ad0
2019-08-03 09:29:55 +09:00
David Rodríguez d8d5e16305
[bundler/bundler] Use a clean gemspec for gem helper specs
https://github.com/bundler/bundler/commit/f694fe7f67
2019-08-03 09:29:55 +09:00
David Rodríguez 1c070c9c29
[bundler/bundler] Move "on releasing" to a RSpec context
So we can later add more tests with the same setup.

https://github.com/bundler/bundler/commit/21b4b6c49c
2019-08-03 09:29:55 +09:00
David Rodríguez 1a4bb80cd7
[bundler/bundler] Skip specs that need coloring on Windows
ANSI codes don't work there.

https://github.com/bundler/bundler/commit/4f05417ca7
2019-08-03 09:29:55 +09:00
David Rodríguez 38df9e18da
[bundler/bundler] Add missing no-color source specs
For consistency.

https://github.com/bundler/bundler/commit/279603ab42
2019-08-03 09:29:55 +09:00
David Rodríguez 214e992556
[bundler/bundler] Be explicit about coloring in specs that need that
https://github.com/bundler/bundler/commit/a4d04506ab
2019-08-03 09:29:55 +09:00
David Rodríguez 580e165873
[bundler/bundler] Respect color option when instantiating shells
Thor's base shell will be memoized the first time it is set. So if we
instantiate a no-color shell first, further instantiations of a bundler
shell will be initialized with a no-color shell by default. This is
caused some sources specs to fail, depending on the order they run.

See for example https://travis-ci.org/bundler/bundler/builds/500328994.

What we do to fix it is to reset the shell unless no-color is explicitly
specified. That way, further instantiations will rerun thor's internal
logic to choose the default shell.

https://github.com/bundler/bundler/commit/786b5d9894
2019-08-03 09:29:55 +09:00
Hiroshi SHIBATA 4c2255fd5c
[bundler/bundler] Added Ruby 2.6 to dsl.
https://github.com/bundler/bundler/commit/1892626858
2019-08-03 09:29:55 +09:00
Koichi Sasada a1a198d03a File.realpath can raise ENOTDIR 2019-07-31 21:16:20 +01:00
Benoit Daloze e432f5dafd Split in two spec examples 2019-07-31 11:06:54 +02:00
Benoit Daloze eab6c534ad Attempt to fix Hash#rehash spec 2019-07-31 11:04:35 +02:00
Koichi Sasada 40651cf1f5 delete a check on bad assumption.
If object was modified, but there is a case that
hash values (#hash) are same between before modified
and after modified objects.
2019-07-31 15:14:51 +09:00
Jeremy Evans aa97410b0a Warn if using return at top-level with an argument
Fixes [Bug #14062]
2019-07-29 09:01:23 -07:00
Benoit Daloze 7b727e30fc Update to ruby/spec@0526d8f 2019-07-27 12:57:46 +02:00
Benoit Daloze 5c276e1cc9 Update to ruby/spec@875a09e 2019-07-27 12:40:09 +02:00
Nobuyoshi Nakada 149e414ed5
Initialize DST flag
* time.c (zone_timelocal): initialize DST flag by asking the
  timezone object.  [Bug #15988]
2019-07-27 12:41:33 +09:00
Nobuyoshi Nakada 6ab95fb741
Removed twisted tests
Why does only Process.daemon have these tests?
2019-07-16 22:03:25 +09:00
Hiroshi SHIBATA f73ea3342b
Fixed ruby/spec for Logger::LogDevice changes. 2019-07-15 15:07:26 +09:00
Nobuyoshi Nakada cd069df365
File::Stat uses Time#inspect 2019-07-11 19:46:11 +09:00
Nobuyoshi Nakada 4e038a7e64
Revert "parse.y: Deprecate flip-flops"
This reverts commit bae638ad5b.

[Feature #5400]
2019-07-11 14:52:02 +09:00
Nobuyoshi Nakada 23c92b6f82
Revert self-referencing finalizer warning [Feature #15974]
It has caused CI failures.

* d0cd0866d8

  Disable GC during rb_objspace_reachable_object_p

* 89cef1c56b

  Version guard for [Feature #15974]

* 796eeb6339.

  Fix up [Feature #15974]

* 928260c2a6.

  Warn in verbose mode on defining a finalizer that captures the object
2019-07-04 04:01:06 +09:00
Nobuyoshi Nakada 89cef1c56b
Version guard for [Feature #15974] 2019-07-03 15:22:16 +09:00
Chris Seaton 928260c2a6
Warn in verbose mode on defining a finalizer that captures the object
[Feature #15974]

Closes: https://github.com/ruby/ruby/pull/2264
2019-07-03 04:05:22 +09:00
Takashi Kokubun dbe834ab5a
Prefer master rather than trunk in README [ci skip] 2019-07-01 01:05:29 +09:00
Nobuyoshi Nakada 9f648262f9
Fix predicate to assert if object is same 2019-06-29 21:45:59 +09:00
Nobuyoshi Nakada cbb7dc21a8
Fix predicate to assert if object is same 2019-06-29 19:17:51 +09:00
Benoit Daloze a2091c3023 Update to ruby/spec@94d98ff 2019-06-27 21:21:33 +02:00
Benoit Daloze d80e44deec Update to ruby/spec@8d74d49 2019-06-27 21:02:36 +02:00
Benoit Daloze c940397116 Update to ruby/mspec@ca2bc42 2019-06-27 21:02:33 +02:00
Benoit Daloze 9247f6fcc0 Expand and clarify documentation about version guards for specs 2019-06-27 12:06:39 +02:00
Hiroshi SHIBATA e478671e19
Added version guard for backtrace printing feature of psych to ruby/spec. 2019-06-26 09:23:02 +09:00
Hiroshi SHIBATA d7887b05d8
Fixed broken ruby/spec related a53ab897c3 2019-06-25 16:46:53 +09:00
Nobuyoshi Nakada 97a7f463f6
Max length of UNIX socket path is 104 bytes on macOS 2019-06-23 23:12:47 +09:00
Nobuyoshi Nakada 50b2807a7c
Do not lengthen UNIX socket path
* spec/ruby/library/socket/unixsocket/recvfrom_spec.rb: do not
  lengthen UNIX socket path, which is very stricted.
2019-06-23 23:10:16 +09:00
Kenichi Kamiya d01fd82187 Alias ENV.merge! as ENV.update
[Feature #15947]

Closes: https://github.com/ruby/ruby/pull/2246
2019-06-21 18:25:01 +02:00
Benoit Daloze 3b2d11ad90 Use different names for autoload constants in specs for clarity 2019-06-21 18:21:45 +02:00
Jean Boussier e5e811e4a0 Add extra spec from https://github.com/ruby/ruby/pull/2173 2019-06-21 18:21:45 +02:00
Jean Boussier fb85a42860
Add an optional `inherit` argument to Module#autoload?
[Feature #15777]

Closes: https://github.com/ruby/ruby/pull/2173
2019-06-21 17:28:37 +09:00
Jeremy Evans a0af60c7f2 Remove spec testing undefined behavior
Fixes [Bug #15432]
2019-06-19 12:20:30 -07:00
Jeremy Evans b9ef35e4c6 Implement Complex#<=>
Implement Complex#<=> so that it is usable as an argument when
calling <=> on objects of other classes (since #coerce will coerce
such numbers to Complex).  If the complex number has a zero imaginary
part, and the other argument is a real number (or complex number with
zero imaginary part), return -1, 0, or 1.  Otherwise, return nil,
indicating the objects are not comparable.

Fixes [Bug #15857]
2019-06-19 10:50:58 -07:00
Hiroshi SHIBATA e4364dbf6e
Fixed the code-style with the upstream rule. 2019-06-11 12:16:26 +09:00
Benoit Daloze 626ae5a9b6 Resolv specs should pass on Windows now 2019-06-10 12:47:08 +02:00
Benoit Daloze 60af6fef3c Fix Resolv specs to not depend on a system /etc/hosts file
* https://rubyci.org/logs/rubyci.s3.amazonaws.com/archlinux/ruby-master/log/20190609T153804Z.fail.html.gz
* Thanks @naruse for the tip.
2019-06-10 12:45:00 +02:00
Hiroshi SHIBATA 2c59c58a47 Fixed wrong BUNDLE_BIN_PATH for ruby core. 2019-06-09 12:44:31 +09:00
Hiroshi SHIBATA 44f7f093ab Added the condition for ruby_core repository. 2019-06-09 12:44:27 +09:00
Hiroshi SHIBATA 8f37629519 Merge bundler master from upstream.
Pick from 8dd59e3ba97eb80a599f8149f31bf40773b69dc0
2019-06-09 12:44:10 +09:00
Jeremy Evans 119ca4343c Make specs pass on OpenBSD
Skip Process clockres specs that don't work on either FreeBSD or
Solaris/AIX in addition to OpenBSD.

Run most current String#crypt specs on non-OpenBSD, and add a new
set of crypt specs for OpenBSD, which support bcrypt but not DES
in crypt(3).

Use @server.connect_address instead of @server.getsockname in some
socket tests, as OpenBSD does not treat connection to all zero
IPv4 or IPv6 addresses as connection to localhost.

When trying to connect using UDP on an unsupported address family,
allow Errno::EPROTONOSUPPORT in addition to Errno::EAFNOSUPPORT,
as OpenBSD raises the former.
2019-06-06 21:16:28 -07:00
Nobuyoshi Nakada 84c294eb0b
spec/bundler/bundler/dsl_spec.rb: fix exception to raise
When describing "Runtime errors", raise a `RuntimeError` as-is.
2019-06-05 15:51:48 +09:00
Nobuyoshi Nakada aa8a8d8f6d
Split an assertion for f1f04caf60 2019-06-05 12:04:11 +09:00
Nobuyoshi Nakada 22da5d71ea
`ruby -v` may no longer be ASCII-only on non-master branches 2019-06-03 12:56:36 +09:00
Benoit Daloze 1d37cc1900 Update to ruby/spec@cfe908c 2019-05-31 19:02:08 +02:00
Benoit Daloze f97979ce88 Update to ruby/mspec@a57a9af 2019-05-31 19:02:06 +02:00
Nobuyoshi Nakada 8b39df854d
Let irb use an empty file as irbrc
to get rid of side-effect by existing .irbrc file.
2019-05-31 16:32:27 +09:00
Nobuyoshi Nakada b632566d33
UNIX domain socket name length has a certain limit 2019-05-31 16:32:27 +09:00
Benoit Daloze a4161b7649 Update to ruby/spec@0ba5312 2019-05-30 22:11:24 +02:00