ruby/prism
Peter Zhu eca3680c27 [ruby/prism] Fix use of uninitialized value when parsing regexp
Parsing the regexp /\A{/ causes uses an uninitialized value because it
tries to parse it as a range quantifier, so it reads the character after
the closing curly bracket. This is using uninitialized values because
prism strings are not null terminated. This can be seen in the Valgrind
output:

    ==834710== Conditional jump or move depends on uninitialised value(s)
    ==834710==    at 0x5DA010: pm_regexp_parse_range_quantifier (regexp.c:163)
    ==834710==    by 0x5DA010: pm_regexp_parse_quantifier (regexp.c:243)
    ==834710==    by 0x5DAD69: pm_regexp_parse_expression (regexp.c:738)
    ==834710==    by 0x5DAD69: pm_regexp_parse_pattern (regexp.c:761)
    ==834710==    by 0x5DAD69: pm_regexp_parse (regexp.c:773)
    ==834710==    by 0x5A2EE7: parse_regular_expression_named_captures (prism.c:20886)
    ==834710==    by 0x5A2EE7: parse_expression_infix (prism.c:21388)
    ==834710==    by 0x5A5FA5: parse_expression (prism.c:21804)
    ==834710==    by 0x5A64F3: parse_statements (prism.c:13858)
    ==834710==    by 0x5A9730: parse_program (prism.c:22011)
    ==834710==    by 0x576F0D: parse_input_success_p (extension.c:1062)
    ==834710==    by 0x576F0D: parse_success_p (extension.c:1084)

This commit adds checks for the end of the string to
pm_regexp_parse_range_quantifier.

https://github.com/ruby/prism/commit/be6cbc23ef
2024-11-12 14:19:46 +00:00
..
templates [ruby/prism] Relocation 2024-10-16 15:56:01 +00:00
util [ruby/prism] Only read from buffer if `size` is greater than 0 2024-10-28 20:38:20 +00:00
api_pack.c
config.yml [ruby/prism] Update rescue node doc 2024-10-10 13:43:58 +00:00
defines.h [ruby/prism] Remove use of __assume to simplify 2024-09-25 16:17:08 +00:00
encoding.c
encoding.h
extension.c [ruby/prism] Supress string_query function warning 2024-10-13 12:22:58 +00:00
extension.h
node.h
options.c [ruby/prism] Accept version shorthand like 3.4 2024-09-24 13:21:36 +00:00
options.h [ruby/prism] Accept version shorthand like 3.4 2024-09-24 13:21:36 +00:00
pack.c
pack.h
parser.h [ruby/prism] Fix up multi target parsing 2024-10-04 16:22:21 +00:00
prettyprint.h
prism.c [ruby/prism] Fix splat after kwsplat 2024-11-08 15:50:54 +00:00
prism.h [ruby/prism] Prism::StringQuery 2024-10-11 19:34:57 +00:00
regexp.c [ruby/prism] Fix use of uninitialized value when parsing regexp 2024-11-12 14:19:46 +00:00
regexp.h
static_literals.c
static_literals.h
version.h