Revert "Refactor signature spec"
This commit is contained in:
Daniel55
GitHub
Родитель
3970557452
Коммит
0a5db83ea0
18
Gemfile.lock
18
Gemfile.lock
|
|
@ -6,18 +6,10 @@ PATH
|
|||
GEM
|
||||
remote: https://rubygems.org/
|
||||
specs:
|
||||
ast (2.4.2)
|
||||
binding_ninja (0.2.3)
|
||||
coderay (1.1.3)
|
||||
diff-lcs (1.4.4)
|
||||
ed25519 (1.2.4)
|
||||
method_source (1.0.0)
|
||||
parser (3.1.2.0)
|
||||
ast (~> 2.4.1)
|
||||
proc_to_ast (0.1.0)
|
||||
coderay
|
||||
parser
|
||||
unparser
|
||||
pry (0.14.0)
|
||||
coderay (~> 1.1)
|
||||
method_source (~> 1.0)
|
||||
|
|
@ -33,16 +25,7 @@ GEM
|
|||
rspec-mocks (3.10.2)
|
||||
diff-lcs (>= 1.2.0, < 2.0)
|
||||
rspec-support (~> 3.10.0)
|
||||
rspec-parameterized (0.5.0)
|
||||
binding_ninja (>= 0.2.3)
|
||||
parser
|
||||
proc_to_ast
|
||||
rspec (>= 2.13, < 4)
|
||||
unparser
|
||||
rspec-support (3.10.2)
|
||||
unparser (0.6.5)
|
||||
diff-lcs (~> 1.3)
|
||||
parser (>= 3.1.0)
|
||||
|
||||
PLATFORMS
|
||||
ruby
|
||||
|
|
@ -52,7 +35,6 @@ DEPENDENCIES
|
|||
pry (~> 0.14)
|
||||
rspec (~> 3.10)
|
||||
rspec-mocks (~> 3.10)
|
||||
rspec-parameterized (~> 0.5)
|
||||
ssh_data!
|
||||
|
||||
BUNDLED WITH
|
||||
|
|
|
|||
|
|
@ -1,23 +1,10 @@
|
|||
require_relative "./spec_helper"
|
||||
|
||||
describe SSHData::Signature do
|
||||
def read_fixture_file(name)
|
||||
fixture_file_path = File.join("spec/fixtures/signatures", name)
|
||||
File.read(fixture_file_path)
|
||||
end
|
||||
|
||||
let(:name) { File.basename(path) }
|
||||
let(:signature) { File.read(path) }
|
||||
let(:message) { read_fixture_file("message") }
|
||||
|
||||
subject { described_class.parse_pem(signature) }
|
||||
|
||||
describe "end to end" do
|
||||
context "with an Ed25519-SK git signature" do
|
||||
let(:message) { "tree ed9f16d32a89e48289d9d4becc4ff47cbd11f58c\nparent 7c6364502eceecc87b276d8b49d8eb0ae96fd9e3\nauthor Kevin Jones <octocat@github.com> 1638815753 -0500\ncommitter Kevin Jones <octocat@github.com> 1638815828 -0500\n\ntest\n" }
|
||||
|
||||
let(:signature) do
|
||||
<<~SIG
|
||||
it "can verify an Ed25519-SK git signature" do
|
||||
message= "tree ed9f16d32a89e48289d9d4becc4ff47cbd11f58c\nparent 7c6364502eceecc87b276d8b49d8eb0ae96fd9e3\nauthor Kevin Jones <octocat@github.com> 1638815753 -0500\ncommitter Kevin Jones <octocat@github.com> 1638815828 -0500\n\ntest\n"
|
||||
signature = <<~SIG
|
||||
-----BEGIN SSH SIGNATURE-----
|
||||
U1NIU0lHAAAAAQAAAEoAAAAac2stc3NoLWVkMjU1MTlAb3BlbnNzaC5jb20AAAAgnXUo8l
|
||||
URoToCMzr+Rxeia/9yy+Rn+VwTTOqXdIgf7TUAAAAEc3NoOgAAAANnaXQAAAAAAAAABnNo
|
||||
|
|
@ -26,19 +13,14 @@ describe SSHData::Signature do
|
|||
DgUAAAAG
|
||||
-----END SSH SIGNATURE-----
|
||||
SIG
|
||||
end
|
||||
|
||||
|
||||
it "verifies the message" do
|
||||
subject = described_class.parse_pem(signature)
|
||||
expect(subject.verify(message)).to be(true)
|
||||
end
|
||||
end
|
||||
|
||||
context 'with an RSA git signature' do
|
||||
let(:message) { "tree 4b825dc642cb6eb9a060e54bf8d69288fbee4904\nparent 339ca5fd2a41e29236ea793772308bb054b9d81b\nauthor Kevin Jones <vcsjones@github.com> 1637774236 -0500\ncommitter Kevin Jones <vcsjones@github.com> 1637774236 -0500\n\nWHAT\n" }
|
||||
|
||||
let(:signature) do
|
||||
<<~SIG
|
||||
it "can verify an RSA git signature" do
|
||||
message = "tree 4b825dc642cb6eb9a060e54bf8d69288fbee4904\nparent 339ca5fd2a41e29236ea793772308bb054b9d81b\nauthor Kevin Jones <vcsjones@github.com> 1637774236 -0500\ncommitter Kevin Jones <vcsjones@github.com> 1637774236 -0500\n\nWHAT\n"
|
||||
signature = <<~SIG
|
||||
-----BEGIN SSH SIGNATURE-----
|
||||
U1NIU0lHAAAAAQAAAZcAAAAHc3NoLXJzYQAAAAMBAAEAAAGBANEwkDjsYE02vY+bTFXAL9
|
||||
xaGDFRwpAYutfhl7eL1Qn6dziGnokqMz1FnwPbRkPUOtdwXbojK0W45DS8rODLhvwyEJjj
|
||||
|
|
@ -59,29 +41,34 @@ describe SSHData::Signature do
|
|||
rfqicASU/vCBEQ==
|
||||
-----END SSH SIGNATURE-----
|
||||
SIG
|
||||
end
|
||||
|
||||
it "verifies the message" do
|
||||
subject = described_class.parse_pem(signature)
|
||||
expect(subject.verify(message)).to be(true)
|
||||
end
|
||||
end
|
||||
end
|
||||
|
||||
describe "#verify" do
|
||||
where(:path) { Dir["spec/fixtures/signatures/message.*no-options-individual.sig"] }
|
||||
|
||||
with_them do
|
||||
describe do
|
||||
Dir["spec/fixtures/signatures/message.*no-options-individual.sig"].each do |path|
|
||||
name = File.basename(path)
|
||||
|
||||
describe name do
|
||||
let(:signature) { File.read(path) }
|
||||
let(:data) { File.read("spec/fixtures/signatures/message") }
|
||||
|
||||
it "verifies with data" do
|
||||
expect(subject.verify(message)).to be(true)
|
||||
subject = described_class.parse_pem(signature)
|
||||
expect(subject.verify(data)).to be(true)
|
||||
end
|
||||
|
||||
it "does not verify with tampered data" do
|
||||
bad_data = message + "bad"
|
||||
bad_data = data + "bad"
|
||||
subject = described_class.parse_pem(signature)
|
||||
expect(subject.verify(bad_data)).to be(false)
|
||||
end
|
||||
|
||||
it "parses correctly" do
|
||||
subject = described_class.parse_pem(signature)
|
||||
expect(subject.sigversion).to eq(1)
|
||||
expect(subject.namespace).to eq("file")
|
||||
expect(subject.reserved).to be_empty
|
||||
|
|
@ -93,57 +80,75 @@ describe SSHData::Signature do
|
|||
end
|
||||
|
||||
describe "#verify security keys" do
|
||||
where(:path) { Dir["spec/fixtures/signatures/message.*-sk-*no-options-individual.sig"] }
|
||||
Dir["spec/fixtures/signatures/message.*-sk-*no-options-individual.sig"].each do |path|
|
||||
name = File.basename(path)
|
||||
|
||||
describe name do
|
||||
let(:signature) { File.read(path) }
|
||||
let(:data) { File.read("spec/fixtures/signatures/message") }
|
||||
|
||||
with_them do
|
||||
describe do
|
||||
it "does not verify if user verification is required" do
|
||||
expect(subject.verify(message, user_verification_required: true)).to be(false)
|
||||
subject = described_class.parse_pem(signature)
|
||||
expect(subject.verify(data, user_verification_required: true)).to be(false)
|
||||
end
|
||||
end
|
||||
end
|
||||
end
|
||||
|
||||
describe "#verify no-touch" do
|
||||
where(:path) { Dir["spec/fixtures/signatures/message.*no-touch-required-individual.sig"] }
|
||||
Dir["spec/fixtures/signatures/message.*no-touch-required-individual.sig"].each do |path|
|
||||
name = File.basename(path)
|
||||
|
||||
describe name do
|
||||
let(:signature) { File.read(path) }
|
||||
let(:data) { File.read("spec/fixtures/signatures/message") }
|
||||
|
||||
with_them do
|
||||
describe do
|
||||
it "verifies with data" do
|
||||
expect(subject.verify(message, user_presence_required: false)).to be(true)
|
||||
subject = described_class.parse_pem(signature)
|
||||
expect(subject.verify(data, user_presence_required: false)).to be(true)
|
||||
end
|
||||
|
||||
it "does not verify with tampered data" do
|
||||
bad_data = message + "bad"
|
||||
bad_data = data + "bad"
|
||||
subject = described_class.parse_pem(signature)
|
||||
expect(subject.verify(bad_data, user_presence_required: false)).to be(false)
|
||||
end
|
||||
|
||||
it "does not verify with user presence" do
|
||||
expect(subject.verify(message, user_presence_required: true)).to be(false)
|
||||
subject = described_class.parse_pem(signature)
|
||||
expect(subject.verify(data, user_presence_required: true)).to be(false)
|
||||
end
|
||||
|
||||
it "does not verify with user presence by default" do
|
||||
expect(subject.verify(message)).to be(false)
|
||||
subject = described_class.parse_pem(signature)
|
||||
expect(subject.verify(data)).to be(false)
|
||||
end
|
||||
|
||||
it "errors on unknown verify options" do
|
||||
expect { subject.verify(message, potato: :no) }.to raise_error(SSHData::UnsupportedError)
|
||||
subject = described_class.parse_pem(signature)
|
||||
expect { subject.verify(data, potato: :no) }.to raise_error(SSHData::UnsupportedError)
|
||||
end
|
||||
end
|
||||
end
|
||||
end
|
||||
|
||||
describe "#verify verify-required" do
|
||||
where(:path) { Dir["spec/fixtures/signatures/message.*verify-required-individual.sig"] }
|
||||
|
||||
with_them do
|
||||
describe do
|
||||
Dir["spec/fixtures/signatures/message.*verify-required-individual.sig"].each do |path|
|
||||
name = File.basename(path)
|
||||
|
||||
describe name do
|
||||
let(:signature) { File.read(path) }
|
||||
let(:data) { File.read("spec/fixtures/signatures/message") }
|
||||
|
||||
it "verifies with data" do
|
||||
expect(subject.verify(message, user_verification_required: true)).to be(true)
|
||||
subject = described_class.parse_pem(signature)
|
||||
expect(subject.verify(data, user_verification_required: true)).to be(true)
|
||||
end
|
||||
|
||||
it "does not verify with tampered data" do
|
||||
bad_data = message + "bad"
|
||||
bad_data = data + "bad"
|
||||
subject = described_class.parse_pem(signature)
|
||||
expect(subject.verify(bad_data, user_verification_required: true)).to be(false)
|
||||
end
|
||||
end
|
||||
|
|
@ -151,11 +156,16 @@ describe SSHData::Signature do
|
|||
end
|
||||
|
||||
describe "#verify certificates" do
|
||||
where(:path) { Dir["spec/fixtures/signatures/message.*no-options-certificate.sig"] }
|
||||
|
||||
with_them do
|
||||
describe do
|
||||
Dir["spec/fixtures/signatures/message.*no-options-certificate.sig"].each do |path|
|
||||
name = File.basename(path)
|
||||
|
||||
describe name do
|
||||
let(:signature) { File.read(path) }
|
||||
let(:data) { File.read("spec/fixtures/signatures/message") }
|
||||
|
||||
it "parses correctly" do
|
||||
subject = described_class.parse_pem(signature)
|
||||
expect(subject.sigversion).to eq(1)
|
||||
expect(subject.namespace).to eq("file")
|
||||
expect(subject.reserved).to be_empty
|
||||
|
|
@ -164,14 +174,18 @@ describe SSHData::Signature do
|
|||
end
|
||||
|
||||
it "verifies with data" do
|
||||
expect(subject.verify(message)).to be(true)
|
||||
subject = described_class.parse_pem(signature)
|
||||
expect(subject.verify(data)).to be(true)
|
||||
end
|
||||
|
||||
it "does not verify with tampered data" do
|
||||
bad_data = message + "bad"
|
||||
bad_data = data + "bad"
|
||||
subject = described_class.parse_pem(signature)
|
||||
expect(subject.verify(bad_data)).to be(false)
|
||||
end
|
||||
|
||||
end
|
||||
end
|
||||
end
|
||||
|
||||
end
|
||||
|
|
|
|||
|
|
@ -1,6 +1,5 @@
|
|||
require "ssh_data"
|
||||
require "ed25519"
|
||||
require "rspec-parameterized"
|
||||
|
||||
RSpec.configure do |config|
|
||||
config.color_mode = :off
|
||||
|
|
|
|||
|
|
@ -15,6 +15,5 @@ Gem::Specification.new do |s|
|
|||
s.add_development_dependency "ed25519", "~> 1.2"
|
||||
s.add_development_dependency "pry", "~> 0.14"
|
||||
s.add_development_dependency "rspec", "~> 3.10"
|
||||
s.add_development_dependency "rspec-parameterized", "~> 0.5"
|
||||
s.add_development_dependency "rspec-mocks", "~> 3.10"
|
||||
end
|
||||
|
|
|
|||
Загрузка…
Ссылка в новой задаче