Move goyacc to use pflags package (#11092)

* feat: move goyacc to use pflags package

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: add meaningfule names to flag values

Signed-off-by: Manan Gupta <manan@planetscale.com>

Signed-off-by: Manan Gupta <manan@planetscale.com>

go/vt/sqlparser/Makefile

@@ -15,7 +15,7 @@
 MAKEFLAGS = -s
 
 sql.go: sql.y
-	go run ./goyacc -fast-append -o sql.go sql.y
+	go run ./goyacc -fo sql.go sql.y
 	gofmt -w sql.go
 
 clean:

go/vt/sqlparser/goyacc/goyacc.go

@@ -48,7 +48,6 @@ package main
 import (
 	"bufio"
 	"bytes"
-	"flag"
 	"fmt"
 	"go/format"
 	"os"
@@ -57,6 +56,8 @@ import (
 	"strconv"
 	"strings"
 	"unicode"
+
+	"github.com/spf13/pflag"
 )
 
 // the following are adjustable
@@ -166,11 +167,11 @@ var prefix string // name prefix for identifiers, default yy
 var allowFastAppend bool
 
 func init() {
-	flag.StringVar(&oflag, "o", "y.go", "parser output")
-	flag.StringVar(&prefix, "p", "yy", "name prefix to use in generated code")
-	flag.StringVar(&vflag, "v", "y.output", "create parsing tables")
-	flag.BoolVar(&lflag, "l", false, "disable line directives")
-	flag.BoolVar(&allowFastAppend, "fast-append", false, "enable fast-append optimization")
+	pflag.StringVarP(&oflag, "output", "o", "y.go", "parser output")
+	pflag.StringVarP(&prefix, "prefix", "p", "yy", "name prefix to use in generated code")
+	pflag.StringVarP(&vflag, "verbose-output", "v", "y.output", "create parsing tables")
+	pflag.BoolVarP(&lflag, "disable-line-directives", "l", false, "disable line directives")
+	pflag.BoolVarP(&allowFastAppend, "fast-append", "f", false, "enable fast-append optimization")
 }
 
 var initialstacksize = 16
@@ -381,8 +382,8 @@ func setup() {
 	stderr = bufio.NewWriter(os.Stderr)
 	foutput = nil
 
-	flag.Parse()
-	if flag.NArg() != 1 {
+	pflag.Parse()
+	if pflag.NArg() != 1 {
 		usage()
 	}
 	if initialstacksize < 1 {
@@ -1599,7 +1600,7 @@ loop:
 }
 
 func openup() {
-	infile = flag.Arg(0)
+	infile = pflag.Arg(0)
 	finput = open(infile)
 	if finput == nil {
 		errorf("cannot open %v", infile)

go/vt/sqlparser/sql.go

@@ -1,4 +1,4 @@
-// Code generated by goyacc -fast-append -o sql.go sql.y. DO NOT EDIT.
+// Code generated by goyacc -fo sql.go sql.y. DO NOT EDIT.
 
 //line sql.y:18
 package sqlparser

tools/check_make_parser.sh

@@ -19,7 +19,7 @@ if ! cd go/vt/sqlparser/ ; then
 fi
 
 mv $CUR $TMP
-output=$(go run ./goyacc -fast-append -o $CUR sql.y)
+output=$(go run ./goyacc -fo $CUR sql.y)
 expectedOutput=$'\nconflicts: 3 shift/reduce'
 
 if [[ "$output" != "$expectedOutput" ]]; then