Merge pull request #4443 from trevex/fix-minor-bugs

Helm: Fix minor bugs

helm/vitess/templates/_cron-jobs.tpl

@@ -74,6 +74,8 @@ spec:
               requests:
                 cpu: 10m
                 memory: 20Mi
+          volumes:
+{{ include "user-secret-volumes" $defaultVtctlclient.secrets | indent 12 }}
 
 {{ end }}
 

helm/vitess/templates/_orchestrator.tpl

@@ -89,7 +89,7 @@ spec:
       containers:
         - name: orchestrator
           image: {{ $orc.image | quote }}
-          ImagePullPolicy: IfNotPresent
+          imagePullPolicy: IfNotPresent
           ports:
             - containerPort: 3000
               name: web
@@ -124,7 +124,7 @@ spec:
 
         - name: recovery-log
           image: vitess/logtail:latest
-          ImagePullPolicy: IfNotPresent
+          imagePullPolicy: IfNotPresent
           env:
           - name: TAIL_FILEPATH
             value: /tmp/recovery.log
@@ -134,7 +134,7 @@ spec:
 
         - name: audit-log
           image: vitess/logtail:latest
-          ImagePullPolicy: IfNotPresent
+          imagePullPolicy: IfNotPresent
           env:
           - name: TAIL_FILEPATH
             value: /tmp/orchestrator-audit.log

helm/vitess/templates/_pmm.tpl

@@ -138,7 +138,7 @@ spec:
 
 - name: "pmm-client"
   image: "vitess/pmm-client:{{ $pmm.pmmTag }}"
-  ImagePullPolicy: IfNotPresent
+  imagePullPolicy: IfNotPresent
   volumeMounts:
     - name: vtdataroot
       mountPath: "/vtdataroot"
@@ -219,7 +219,7 @@ spec:
 
 - name: pmm-client-metrics-log
   image: vitess/logtail:latest
-  ImagePullPolicy: IfNotPresent
+  imagePullPolicy: IfNotPresent
   env:
   - name: TAIL_FILEPATH
     value: /vtdataroot/pmm/pmm-mysql-metrics-42002.log

helm/vitess/templates/_vtctld.tpl

@@ -60,7 +60,7 @@ spec:
       containers:
         - name: vtctld
           image: vitess/vtctld:{{$vitessTag}}
-          ImagePullPolicy: IfNotPresent
+          imagePullPolicy: IfNotPresent
           readinessProbe:
             httpGet:
               path: /debug/health

helm/vitess/templates/_vtgate.tpl

@@ -75,7 +75,7 @@ spec:
       containers:
         - name: vtgate
           image: vitess/vtgate:{{$vitessTag}}
-          ImagePullPolicy: IfNotPresent
+          imagePullPolicy: IfNotPresent
           readinessProbe:
             httpGet:
               path: /debug/health
@@ -224,7 +224,7 @@ affinity:
 
 - name: init-mysql-creds
   image: "vitess/vtgate:{{$vitessTag}}"
-  ImagePullPolicy: IfNotPresent
+  imagePullPolicy: IfNotPresent
   volumeMounts:
     - name: creds
       mountPath: "/mysqlcreds"

helm/vitess/templates/_vttablet.tpl

@@ -167,7 +167,7 @@ spec:
 
 - name: "init-mysql"
   image: "vitess/mysqlctld:{{$vitessTag}}"
-  ImagePullPolicy: IfNotPresent
+  imagePullPolicy: IfNotPresent
   volumeMounts:
     - name: vtdataroot
       mountPath: "/vtdataroot"
@@ -211,7 +211,7 @@ spec:
 
 - name: init-vttablet
   image: "vitess/vtctl:{{$vitessTag}}"
-  ImagePullPolicy: IfNotPresent
+  imagePullPolicy: IfNotPresent
   volumeMounts:
     - name: vtdataroot
       mountPath: "/vtdataroot"
@@ -276,7 +276,7 @@ spec:
 
 - name: vttablet
   image: "vitess/vttablet:{{$vitessTag}}"
-  ImagePullPolicy: IfNotPresent
+  imagePullPolicy: IfNotPresent
   readinessProbe:
     httpGet:
       path: /debug/health
@@ -436,7 +436,7 @@ spec:
 
 - name: mysql
   image: {{.mysqlImage | default $defaultVttablet.mysqlImage | quote}}
-  ImagePullPolicy: IfNotPresent
+  imagePullPolicy: IfNotPresent
   readinessProbe:
     exec:
       command: ["mysqladmin", "ping", "-uroot", "--socket=/vtdataroot/tabletdata/mysql.sock"]
@@ -514,7 +514,7 @@ spec:
 
 - name: logrotate
   image: vitess/logrotate:latest
-  ImagePullPolicy: IfNotPresent
+  imagePullPolicy: IfNotPresent
   volumeMounts:
     - name: vtdataroot
       mountPath: /vtdataroot
@@ -528,7 +528,7 @@ spec:
 
 - name: error-log
   image: vitess/logtail:latest
-  ImagePullPolicy: IfNotPresent
+  imagePullPolicy: IfNotPresent
 
   env:
   - name: TAIL_FILEPATH
@@ -546,7 +546,7 @@ spec:
 
 - name: slow-log
   image: vitess/logtail:latest
-  ImagePullPolicy: IfNotPresent
+  imagePullPolicy: IfNotPresent
 
   env:
   - name: TAIL_FILEPATH
@@ -564,7 +564,7 @@ spec:
 
 - name: general-log
   image: vitess/logtail:latest
-  ImagePullPolicy: IfNotPresent
+  imagePullPolicy: IfNotPresent
 
   env:
   - name: TAIL_FILEPATH