зеркало из https://github.com/github/vitess-gh.git
Update for new errcheck violations after rebase
Signed-off-by: Andrew Mason <amason@slack-corp.com>
This commit is contained in:
Родитель
12188233e3
Коммит
81a2396f28
|
@ -109,6 +109,9 @@ issues:
|
||||||
- path: '^go/vt/vtgate/.*_test.go'
|
- path: '^go/vt/vtgate/.*_test.go'
|
||||||
linters:
|
linters:
|
||||||
- errcheck
|
- errcheck
|
||||||
|
- path: '^go/vt/vtgr/'
|
||||||
|
linters:
|
||||||
|
- errcheck
|
||||||
- path: '^go/vt/vttablet/(customrule|filelogger|grpctmserver|onlineddl|sandboxconn|tabletserver)/'
|
- path: '^go/vt/vttablet/(customrule|filelogger|grpctmserver|onlineddl|sandboxconn|tabletserver)/'
|
||||||
linters:
|
linters:
|
||||||
- errcheck
|
- errcheck
|
||||||
|
|
|
@ -109,7 +109,7 @@ func newBuildSelectPlan(sel *sqlparser.Select, reservedVars *sqlparser.ReservedV
|
||||||
|
|
||||||
directives := sqlparser.ExtractCommentDirectives(sel.Comments)
|
directives := sqlparser.ExtractCommentDirectives(sel.Comments)
|
||||||
if directives.IsSet(sqlparser.DirectiveScatterErrorsAsWarnings) {
|
if directives.IsSet(sqlparser.DirectiveScatterErrorsAsWarnings) {
|
||||||
visit(plan, func(logicalPlan logicalPlan) (bool, logicalPlan, error) {
|
_, _ = visit(plan, func(logicalPlan logicalPlan) (bool, logicalPlan, error) {
|
||||||
switch plan := logicalPlan.(type) {
|
switch plan := logicalPlan.(type) {
|
||||||
case *route:
|
case *route:
|
||||||
plan.eroute.ScatterErrorsAsWarnings = true
|
plan.eroute.ScatterErrorsAsWarnings = true
|
||||||
|
|
|
@ -451,7 +451,7 @@ func (vs *vstream) streamFromTablet(ctx context.Context, sgtid *binlogdatapb.Sha
|
||||||
|
|
||||||
errCh := make(chan error, 1)
|
errCh := make(chan error, 1)
|
||||||
go func() {
|
go func() {
|
||||||
tabletConn.StreamHealth(ctx, func(shr *querypb.StreamHealthResponse) error {
|
_ = tabletConn.StreamHealth(ctx, func(shr *querypb.StreamHealthResponse) error {
|
||||||
var err error
|
var err error
|
||||||
if ctx.Err() != nil {
|
if ctx.Err() != nil {
|
||||||
err = fmt.Errorf("context has ended")
|
err = fmt.Errorf("context has ended")
|
||||||
|
|
Загрузка…
Ссылка в новой задаче