From 82cb07de1ce4bb3fbca661517c568c29892d3831 Mon Sep 17 00:00:00 2001 From: sougou Date: Fri, 4 Nov 2016 15:32:04 -0700 Subject: [PATCH] b/32560113: Remove false alarm (#2220) RollbackNonBusy gets called if a tablet was externally reparented. If so, it's normal for transactions to still be outstanding. So, they should be simply rolled back without raising any alarms, --- go/vt/tabletserver/tx_pool.go | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/go/vt/tabletserver/tx_pool.go b/go/vt/tabletserver/tx_pool.go index 68c91822e3..40a1b7aeb9 100644 --- a/go/vt/tabletserver/tx_pool.go +++ b/go/vt/tabletserver/tx_pool.go @@ -116,10 +116,7 @@ func (axp *TxPool) Close() { // or in prepared state. func (axp *TxPool) RollbackNonBusy(ctx context.Context) { for _, v := range axp.activePool.GetOutdated(time.Duration(0), "for transition") { - conn := v.(*TxConnection) - log.Warningf("rolling back transaction for transition: %s", conn.Format(nil)) - axp.queryServiceStats.InternalErrors.Add("StrayTransactions", 1) - axp.LocalConclude(ctx, conn) + axp.LocalConclude(ctx, v.(*TxConnection)) } }