7ac5c3939b
Fix `vtctldclient`'s Root command to return an error on unknown command ( #12481 ) ( #12531 )
...
* Add a Run func to `vtctldclient`'s Root command to return an error on unknown command
Closes #12480 .
* Add test
* flags test data
---------
Signed-off-by: Andrew Mason <andrew@planetscale.com>
2023-03-01 15:14:01 -05:00
6b2208beda
[15.0] Deprecate InitShardPrimary command ( #11557 )
...
* feat: deprecate initshardprimary
Signed-off-by: Manan Gupta <manan@planetscale.com>
* feat: add summary docs
Signed-off-by: Manan Gupta <manan@planetscale.com>
* feat: deprecate the correct command
Signed-off-by: Manan Gupta <manan@planetscale.com>
* test: fix expected output
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
2022-10-21 14:38:43 -07:00
dab32ddc55
[VTAdmin] Cherry Pick Topology Browser ( #11518 )
...
* Add web side of topology components
Signed-off-by: notfelineit <notfelineit@gmail.com>
* Add GetTopologyPath
Signed-off-by: notfelineit <notfelineit@gmail.com>
* Add protos
Signed-off-by: notfelineit <notfelineit@gmail.com>
* Add comment explaining why name is not needed at toplevel topo path
Signed-off-by: notfelineit <notfelineit@gmail.com>
* Add GetTopologyPath to vtadmin
Signed-off-by: notfelineit <notfelineit@gmail.com>
* Modify node code for non recursive
Signed-off-by: notfelineit <notfelineit@gmail.com>
* Update logic for GetTopologyPath
Signed-off-by: notfelineit <notfelineit@gmail.com>
* Render correct depth for nodes
Signed-off-by: notfelineit <notfelineit@gmail.com>
* Add tests TestGetTopologyPath
Signed-off-by: notfelineit <notfelineit@gmail.com>
* Add GetTopologyPath command
Signed-off-by: notfelineit <notfelineit@gmail.com>
* Run lint prettier fix
Signed-off-by: notfelineit <notfelineit@gmail.com>
* Consolidate DecodeContent to vt/topo package - can't put in vt/topo/topoproto because of import cycle
Signed-off-by: notfelineit <notfelineit@gmail.com>
* Add rbac check for TopologyResource
Signed-off-by: notfelineit <notfelineit@gmail.com>
* Update DecodeContent of zkcmd.go
Signed-off-by: notfelineit <notfelineit@gmail.com>
* Update help text
Signed-off-by: notfelineit <notfelineit@gmail.com>
* Run make proto again
Signed-off-by: notfelineit <notfelineit@gmail.com>
* Run lint prettier fix
Signed-off-by: notfelineit <notfelineit@gmail.com>
Signed-off-by: notfelineit <notfelineit@gmail.com>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>
2022-10-18 16:14:30 -07:00
bd8d5c8577
[release-15.0] [VTAdmin] `Validate`, `ValidateShard`, `ValidateVersionShard`, `GetFullStatus` ( #11438 ) ( #11452 )
...
* Add validate
Signed-off-by: notfelineit <notfelineit@gmail.com>
* Add validate to cluster page
Signed-off-by: notfelineit <notfelineit@gmail.com>
* Run lint prettier fix
Signed-off-by: notfelineit <notfelineit@gmail.com>
* Add UI for validate shard
Signed-off-by: notfelineit <notfelineit@gmail.com>
* Add validateShard
Signed-off-by: notfelineit <notfelineit@gmail.com>
* Run make web proto
Signed-off-by: notfelineit <notfelineit@gmail.com>
* Refactor validation results and implement validateShard
Signed-off-by: notfelineit <notfelineit@gmail.com>
* add http shards
Signed-off-by: notfelineit <notfelineit@gmail.com>
* Add GetFullStatus
Signed-off-by: notfelineit <notfelineit@gmail.com>
* Add keys and comment
Signed-off-by: notfelineit <notfelineit@gmail.com>
* Run lint prettier fix
Signed-off-by: notfelineit <notfelineit@gmail.com>
* Add ValidateVersionShard to vtctldclient
Signed-off-by: notfelineit <notfelineit@gmail.com>
* Add ValidateVersionShard
Signed-off-by: notfelineit <notfelineit@gmail.com>
* Update test for vtctldclient
Signed-off-by: notfelineit <notfelineit@gmail.com>
* Add test for ValidateVersionShard
Signed-off-by: notfelineit <notfelineit@gmail.com>
* run lint prettier fix again
Signed-off-by: notfelineit <notfelineit@gmail.com>
* Modify during 1:1 with gomez
Signed-off-by: notfelineit <notfelineit@gmail.com>
* Run lint prettier fix
Signed-off-by: notfelineit <notfelineit@gmail.com>
* Address PR review comments
Signed-off-by: notfelineit <notfelineit@gmail.com>
* Update indentation
Signed-off-by: notfelineit <notfelineit@gmail.com>
Signed-off-by: notfelineit <notfelineit@gmail.com>
Co-authored-by: notfelineit <notfelineit@gmail.com>
2022-10-12 11:47:15 +02:00
3ec636f719
Include stats flags in servenv so that those flags are included in the correct binary. ( #11450 )
...
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
2022-10-06 22:31:25 +02:00
0f310322f3
[cli] [topo] Migrate topo flags to pflags ( #11393 )
...
* [cli] [topo] Migrate topo flags to pflags
Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>
* fix vtorc test
Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>
* feat: fix VTOrc test
Signed-off-by: Manan Gupta <manan@planetscale.com>
* feat: remove binaries from the list that don't need the flags
Signed-off-by: Manan Gupta <manan@planetscale.com>
* test: update flag help outputs
Signed-off-by: Manan Gupta <manan@planetscale.com>
* code review
Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>
* fix import formatting
Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>
Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Co-authored-by: Manan Gupta <manan@planetscale.com>
2022-09-30 19:19:38 -07:00
c82dd87fc3
Move dbconfigs to pflag and remove deprecated flags ( #11336 )
...
* Migrate dbconfigs to pflag
And remove deprecated flags
Signed-off-by: Matt Lord <mattalord@gmail.com>
* Remove no longer needed function
Signed-off-by: Matt Lord <mattalord@gmail.com>
* Address review comments and test failures
Signed-off-by: Matt Lord <mattalord@gmail.com>
* Revert this bit as it changed behavior and caused some failures
Signed-off-by: Matt Lord <mattalord@gmail.com>
* Fix vttestserver unit tests
Signed-off-by: Matt Lord <mattalord@gmail.com>
* Fix vttestserver unit tests
Signed-off-by: Matt Lord <mattalord@gmail.com>
* Update vttestserver help output
Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>
2022-09-30 17:14:10 -04:00
00efe3b865
[cli] Begrudgingly shim `flag.Parse` call to trick glog ( #11382 )
...
* [cli] Begrudgingly shim `flag.Parse` call to trick glog
I applied this to everywhere I think needs it.
- Closes #11283 .
- Closes #11276 .
Signed-off-by: Andrew Mason <andrew@planetscale.com>
* update test data after rebase
Signed-off-by: Andrew Mason <andrew@planetscale.com>
2022-09-29 06:12:03 -04:00
8858cef1b2
[grpcclient] Migrate `--grpc_auth_static_client_creds` to pflag ( #11367 )
...
* [grpclient] Migrate `--grpc_auth_static_client_creds` to pflag
This was missed in #10806 .
Signed-off-by: Andrew Mason <andrew@planetscale.com>
* [grpcclient] Migrate test setters for `--grpc_auth_static_client_creds`
- Relates to #10934 .
- Relates to #10979 .
- Closes #10891 .
Signed-off-by: Andrew Mason <andrew@planetscale.com>
2022-09-28 14:47:05 -04:00
a984f9e624
[vtctlclient] Migrate `vtctl_client_protocol` to pflag ( #11368 )
...
* [vtctlclient] Migrate `vtctl_client_protocol` to pflag
Closes #10892 .
Signed-off-by: Andrew Mason <andrew@planetscale.com>
* forgot to update testdata
Signed-off-by: Andrew Mason <andrew@planetscale.com>
2022-09-28 11:15:30 -04:00
4f1ad8548e
[cli] Migrate miscellaneous components from flag to pflag ( #11347 )
...
* Migrate go/stats
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
* Migrate go/vt/binlog/binlogplayer
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
* go/vt/binlog/grpcbinlogplayer
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
* Migrate mysqlclient, throttlerclient and throttler demo
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
* Migrate vtctl/grpcclientcommon
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
* Update help output
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
* Fix test failures in vttestserver help output. Minor refactor
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
* Remove logs added for testing
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
* Address review comments
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
* use StringSliceVar for CommonTags
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
* Fix vtctldclient flags and update help output for vtctlclient
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
* Set zero duration correctly
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
* Fix help output test
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
* Fix help output test
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
* update help output
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
2022-09-27 12:54:32 +02:00
32d0df7727
[cli] [mysqlctl] Migrate mysqlctl flags to pflags ( #11314 )
...
* [cli] [topo/consultopo] Migrate mysqlctl flags to pflags
Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>
* Test fix
Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>
* code review
Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>
* Fix TestHelpOutput test
Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>
* Adding correct help file for TestHelpOutput
Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>
* code review feedback
Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>
* fixing help output files
Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>
* adding parseflag in vtctldclient main
Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>
* updating vtctldclient help file
Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>
Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>
2022-09-27 12:13:41 +05:30
375d2d7925
Delete deprecated flags ( #11360 )
...
* flags: remove deprecated from test comment
Signed-off-by: deepthi <deepthi@planetscale.com>
* flags: remove deprecated planner_version flag
Signed-off-by: deepthi <deepthi@planetscale.com>
* flags: remove deprecated master_connect_retry flag
Signed-off-by: deepthi <deepthi@planetscale.com>
Signed-off-by: deepthi <deepthi@planetscale.com>
2022-09-26 19:37:03 -07:00
682a62ec94
Fix adding flags to vtctlclient and vtctldclient ( #11322 )
...
* feat: fix adding flags to vtctlclient and vtctldclient
Signed-off-by: Manan Gupta <manan@planetscale.com>
* feat: add vtctlclient and vtctldclient to flag tests
Signed-off-by: Manan Gupta <manan@planetscale.com>
* feat: remove tracing from both binaries
Signed-off-by: Manan Gupta <manan@planetscale.com>
* feat: fix imports in vtctlclient
Signed-off-by: Manan Gupta <manan@planetscale.com>
* feat: fix test output
Signed-off-by: Manan Gupta <manan@planetscale.com>
* feat: fix vtctdclient output
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
2022-09-26 17:49:41 +05:30
Andrew Mason
Manan Gupta
Frances Thai
vitess-bot[bot]
Rohit Nayak
Rameez Sajwani
Matt Lord
Deepthi Sigireddi