Граф коммитов

23 Коммитов

Автор SHA1 Сообщение Дата
Rameez Sajwani 0f310322f3
[cli] [topo] Migrate topo flags to pflags (#11393)
* [cli] [topo] Migrate topo flags to pflags

Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>

* fix vtorc test

Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>

* feat: fix VTOrc test

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: remove binaries from the list that don't need the flags

Signed-off-by: Manan Gupta <manan@planetscale.com>

* test: update flag help outputs

Signed-off-by: Manan Gupta <manan@planetscale.com>

* code review

Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>

* fix import formatting

Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>

Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Co-authored-by: Manan Gupta <manan@planetscale.com>
2022-09-30 19:19:38 -07:00
Manan Gupta e7f98f859c
VTOrc Cleanup - Configs, APIs and old UI (#11356)
* feat: remove configurations that aren't needed like raft and initialization of database

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: use waitreplicastimeout for all timeouts related to waiting for execution on a replica

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: remove agents in vtorc since we don't use them

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: remove more unused configurations

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: cleanup post and pre processes that VTOrc doesn't intend to support

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: remove unused code and config for shell process

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: remove unused configurations

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: convert flags to pflag architecture

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: remove cli flags which aren't required

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: remove more unused configs

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: remove the old UI of orchestrator and cleanup app and http packages

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: remove web/vtorc files and fix Dockerfiles to not try to copy them

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: fix all the examples to not pass in the ListenAddress and not export port for the old UI

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: remove raft code and command applier

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: remove unused code and configs

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: remove more unused code

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: remove http configs that are no longer required

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: remove more unused configs and dead code

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: remove more unused configs

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: remove access tokens since they are unused

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: remove RecoveryPeriodBlockMinutes which was only for backward compatibility

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: remove unused package

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: remove replicas in instance since they weren't used anywhere

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: copy over vtorc things that vtgr was using to remove vtgr's dependency on vtorc package

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: change restart function to use tmc rpc calls

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: remove detection queries for vtorc since we read these from topo-server

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: improve read topology test to also verify the errantGTID set

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: use internal function to find difference in gtid sets instead of using the MySQL connection

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: remove population of group replication information

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: remove configs related to connecting to MySQL instances since it is no longer required

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: remove code to connect to MySQL backend since VTOrc now only uses SQLite3

Signed-off-by: Manan Gupta <manan@planetscale.com>

* cleanup: go mod tidy

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: remove unused/redundant flags, we are down to 0 :)

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: remove filtering configs

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: remove write buffering and associated config parameters

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: remove more miscellaneous configs

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: remove one more rejection parameter

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: move discovery queue parameters to be constants

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: move some more configs to be constants

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: add flags for all the configurations we have kept

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: fix imports in main.go

Signed-off-by: Manan Gupta <manan@planetscale.com>

* test: fix vtorc test output after so many changes

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: add release-notes docs for config changes

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: remove index definitions for tables that are already deleted

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: add API removal documentation as well to release notes

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: remove duplication of debug pages in release notes

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: use some flags in e2e test to verify they work

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: use sliceVar for the flag definition of cluster_to_watch

Signed-off-by: Manan Gupta <manan@planetscale.com>

Signed-off-by: Manan Gupta <manan@planetscale.com>
2022-09-30 22:11:02 +05:30
Harshit Gangal 5394719517
vtgate pflags migration (#11318)
* [go/cmd/vtgate] migrate to pflags

Signed-off-by: Harshit Gangal <harshit@planetscale.com>

* [go/vt/vtgate/vtgateconn] migrate to pflags

Signed-off-by: Harshit Gangal <harshit@planetscale.com>

* fix test

Signed-off-by: Harshit Gangal <harshit@planetscale.com>

* [go/vt/vtgate] migrate to pflags

Signed-off-by: Harshit Gangal <harshit@planetscale.com>

* move to non pointer

Signed-off-by: Harshit Gangal <harshit@planetscale.com>

* change test flag usage

Signed-off-by: Harshit Gangal <harshit@planetscale.com>

* update the test expectation for help output

Signed-off-by: Harshit Gangal <harshit@planetscale.com>

* addressed review comments

Signed-off-by: Harshit Gangal <harshit@planetscale.com>

* make vtgateprotcol flag variable as private

Signed-off-by: Harshit Gangal <harshit@planetscale.com>

* fix test usage

Signed-off-by: Harshit Gangal <harshit@planetscale.com>

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
2022-09-26 19:35:22 +05:30
Manan Gupta c0063166cd
Refactor: Rename Orchestrator to VTOrc in the codebase (#11231)
* feat: rename orchestrator package to vtorc

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: rename web/orchestrator to web/vtorc

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: changed usage of orchestrator to vtorc

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: changed usage of Orchestrator to VTOrc

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: refactor function names to move from orchestrator to vtorc

Signed-off-by: Manan Gupta <manan@planetscale.com>

* test: fix function name

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: change Vtorc to VTOrc

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: fix static check failures for not catching errors

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: create a symbolic link for web/vtorc

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: add web/vtorc to docker images and use it in the examples

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: rename orchestrator to vtorc in examples

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: rename VtOrc to VTOrc

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: remove redundant retrun statements

Signed-off-by: Manan Gupta <manan@planetscale.com>

Signed-off-by: Manan Gupta <manan@planetscale.com>
2022-09-18 14:37:31 +05:30
dependabot[bot] 4820a3ec35
Bump minimist and cypress in /vitess-mixin/e2e (#11201)
Bumps [minimist](https://github.com/substack/minimist) and [cypress](https://github.com/cypress-io/cypress). These dependencies needed to be updated together.

Updates `minimist` from 1.2.5 to 1.2.6
- [Release notes](https://github.com/substack/minimist/releases)
- [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6)

Updates `cypress` from 4.11.0 to 4.12.1
- [Release notes](https://github.com/cypress-io/cypress/releases)
- [Changelog](https://github.com/cypress-io/cypress/blob/develop/.releaserc.base.js)
- [Commits](https://github.com/cypress-io/cypress/compare/v4.11.0...v4.12.1)

---
updated-dependencies:
- dependency-name: minimist
  dependency-type: indirect
- dependency-name: cypress
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-09-12 13:48:47 -07:00
Manan Gupta ed9e6e33f2
Deprecate enable-semi-sync in favour of RPC parameter (#10695)
* feat: deprecate enable_semi_sync flag

Signed-off-by: Manan Gupta <manan@planetscale.com>

* docs: add the deprecation change to the summary

Signed-off-by: Manan Gupta <manan@planetscale.com>

* test: fix test expectation for vttablet flags

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: fix cnf files to not mention the deprecated flag

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: remove enable_semi_sync from scripts of examples

Signed-off-by: Manan Gupta <manan@planetscale.com>

* test: remove setting enable_semi_sync flag in testlib tests

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: remove enable_semi_sync from a bunch of tests

Signed-off-by: Manan Gupta <manan@planetscale.com>

* test: refactor setup to take in durability policy instead of a boolean and add a test for cross cell durability policy

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: add cross cell durability policy to the docs

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: fix flag help output

Signed-off-by: Manan Gupta <manan@planetscale.com>

* test: we shouldn't remove enable_semi_sync from tests which are testing upgrades

Signed-off-by: Manan Gupta <manan@planetscale.com>
2022-07-22 21:35:15 +05:30
Matt Lord a1f1f12be8
Delete all legacy sharding related code (#10278)
* Delete all legacy sharding related code

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Move used until functions from initialsharding to cluster

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Remove vtctl commands

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Kill vtworker and SetKeyspaceServedFrom cmd

Signed-off-by: Matt Lord <mattalord@gmail.com>

* WaitForDrain related stragglers

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Legacy local straggler workflow

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Get rid of SetKeyspaceShardingInfo & wait for drain stragglers

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Remove vtworker stragglers

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Update throttlerservice protobuf

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Rename test 24, add hashicorp vault test to it (now mysql_server_vault)

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Remove last mentiones of legacy sharding in vtctl

Signed-off-by: Matt Lord <mattalord@gmail.com>

* remove binlog_use_v3_resharding_mode

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Address review comments

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Address review comments

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Correct vtgate help output

Signed-off-by: Matt Lord <mattalord@gmail.com>
2022-07-07 13:52:32 -04:00
dependabot[bot] 1dc60e133c
Build(deps): Bump async from 3.2.0 to 3.2.4 in /vitess-mixin/e2e (#10515)
Bumps [async](https://github.com/caolan/async) from 3.2.0 to 3.2.4.
- [Release notes](https://github.com/caolan/async/releases)
- [Changelog](https://github.com/caolan/async/blob/master/CHANGELOG.md)
- [Commits](https://github.com/caolan/async/compare/v3.2.0...v3.2.4)

---
updated-dependencies:
- dependency-name: async
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-06-30 12:59:27 -07:00
Manan Gupta 67944bbe39
Use Durability Policy in the topo server in VTOrc and deprecate Durability config (#10423)
* feat: store keyspace information in the vtorc database

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: add code for refreshing keyspaces

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: remove the durability config from VTOrc and instead use the durability stored in the topo server

Signed-off-by: Manan Gupta <manan@planetscale.com>

* test: remove usage of Durability config from the tests

Signed-off-by: Manan Gupta <manan@planetscale.com>

* test: add a new test for checking that VTOrc works with keyspaces having different durability policies and verify it failed previously

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: remove usage of durability config in examples

Signed-off-by: Manan Gupta <manan@planetscale.com>

* test: parallel execution of test causes data race

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: add warning if no durability is specified

Signed-off-by: Manan Gupta <manan@planetscale.com>
2022-06-06 11:44:58 -07:00
Matt Lord 1de839e76e
Ensure all legacy sharding commands are clearly deprecated (#10281)
* Ensure all legacy sharding commands are clearly deprecated

Then they can be removed in v15

* Add deprecation notice for related flags

* Move single dashes to double in edited files

* Adjust vttablet --help output test

* Document new default in command help output

* Correct vttablet_process printf that I noticed in a test flake
2022-05-25 18:40:42 -04:00
FlorentP 5712981588
Remove the `Gateway` interface (#9852)
* refactor: removed the Gateway interface

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* refactor: removed gateway implementation flag

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* refactor: remove gateway_implementation usages

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* merge upstream/main

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* fix: revert unwanted change

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* fix: update TabletRouting documentation

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* fix: remove unused function waitTillAllTabletsAreHealthyInVtgate

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* removed: unrequired tests in tabletgateway

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* fix: applied review suggestions

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* chore: removed outdated sections in TabletRouting.md

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

Co-authored-by: Andres Taylor <andres@planetscale.com>
2022-03-31 16:12:36 +02:00
Arvind Murty c235f83131 Changed master to primary
Signed-off-by: Arvind Murty <arvind.murty@gmail.com>
2022-01-12 18:51:44 -08:00
Eng Zer Jun ecf27f44c4
refactor: move from io/ioutil to io and os package
The io/ioutil package has been deprecated as of Go 1.16, see
https://golang.org/doc/go1.16#ioutil. This commit replaces the existing
io/ioutil functions with their new definitions in io and os packages.

Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
2021-10-05 08:05:23 +08:00
deepthi b0c6fdc83b fix go fmt failure
Signed-off-by: deepthi <deepthi@planetscale.com>
2021-09-15 16:33:04 -07:00
dependabot[bot] 78361ce188
Bump ini from 1.3.5 to 1.3.8 in /vitess-mixin/e2e
Bumps [ini](https://github.com/isaacs/ini) from 1.3.5 to 1.3.8.
- [Release notes](https://github.com/isaacs/ini/releases)
- [Commits](https://github.com/isaacs/ini/compare/v1.3.5...v1.3.8)

---
updated-dependencies:
- dependency-name: ini
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-09-15 15:06:51 +00:00
Manuel Fontan 526956453c Cleanup:
- remove references to deprecated keyspace_overview dashboard
- update cypress dashboard specs
- update vitess-mixin-quickstart.md

Signed-off-by: Manuel Fontan <mfontangarcia@slack-corp.com>
2021-06-04 19:32:23 +01:00
Manuel Fontan 0f57d33829 Update recording rules names
Signed-off-by: Manuel Fontan <mfontangarcia@slack-corp.com>
2021-05-21 16:00:39 +01:00
Manuel Fontan ff1af0c37b Add make targets for testing with compose.
Remove references to Slack custom keyspace/shard prometheus labels"

Signed-off-by: Manuel Fontan <mfontangarcia@slack-corp.com>
2021-05-21 15:49:23 +01:00
Manuel Fontan 628ee0ba6e Update Docs > fix typos
Signed-off-by: Manuel Fontan <mfontangarcia@slack-corp.com>
2021-02-18 14:42:13 +00:00
Manuel Fontan bb62e15902 Update e2e tests > remove Region template assertions
Signed-off-by: Manuel Fontan <mfontangarcia@slack-corp.com>
2021-02-17 21:06:25 +00:00
Manuel Fontan 2f8d9daf81 Remove region filter,
Update README.mc,
Fix minor bug in make tools target

Signed-off-by: Manuel Fontan <mfontangarcia@slack-corp.com>
2021-02-17 20:55:36 +00:00
Manuel Fontan 42afcdf453 Add new dashboards,
Add recording rules,
Update dashboard folder structure,
Add e2e falpha code for local and automated testing,
Add go.mod,
Update scripts

Signed-off-by: Manuel Fontan <mfontangarcia@slack-corp.com>
2021-02-16 16:58:27 +00:00
Guido Iaquinti fdc7b222f2
vitess-mixin: add structure & first 2 dashboards
Signed-off-by: Guido Iaquinti <giaquinti@slack-corp.com>
2019-12-20 22:58:25 +01:00