For the sake of efficiency, we used to 'hack' some places
by coercing a []byte into a string. This hack is now officially
encapsulated safely by strings.Builder.
The last place where we're still using hack.String is in
sqltypes.Value. That will require some thinking.
I've also deleted code for other hacks that we don't use any more.
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Please refer to #2694 and #2670 for motivation and reasoning for
this change.
I've tried to follow best practice in inserting the copyright
headers. In other open source projects, not all files carry
the notice. For example documentation doesn't. I've followed
similar ground rules.
I did not change the php because there is a separate LICENSE
file there by Pixel Federation. We'll first need to notify
them our intent before changing anything there.
As for the presubmit check, it's going to be non-trivial
because of the number of exceptions, like file types,
directories and generated code. So, it will have to be
a separate project.
In go 1.5 empty strings have a unique representation. So, we
change hack.go to use the go-defined way rather than our own.
Some connection error strings have changed. Changed memcache
test to be more agnostic of that.
A new warning was printed for counting_listener_test.go, which indicated
a minor bug. Fixed.