5ec61648c5
[cli] [stats] Migrate stats/opentsdb + stats/statsd flags to pflag ( #11105 )
...
* [cli] [stats/statsd] Migrate flags to `pflag`
Closes #10745 .
Signed-off-by: Andrew Mason <andrew@planetscale.com>
* [cli] [stats/opentsdb] Migrate flags to pflag
Closes #10744 .
Signed-off-by: Andrew Mason <andrew@planetscale.com>
Signed-off-by: Andrew Mason <andrew@planetscale.com>
2022-08-26 21:00:00 -04:00
bddc71e8bf
Throttler: stats in /debug/vars ( #10443 )
...
* Tablet throttler: serve metrics on /throttler/metrics
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
* release notes
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
* GaugeFloat64
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
* counter map
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
* GaugeFloat64
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
* remove /throttler/metrics endpoint
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
* move away from rcrowley/go-metrics and into vitess's stats
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
* update release notes
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
* internal app name is 'vitess'
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
* internal app name is 'vitess'
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
* WingleWordCamel
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
* SingleWordCamel tests
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
* CamelCase for /debug/var metric names. Do not include app-specific metrics
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
* use testify
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
* copyright
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
* some code comments
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
2022-06-22 09:38:43 +03:00
8de235531d
all: gofmt -w -r 'interface{} -> any' src
...
Signed-off-by: Vicent Marti <vmg@strn.cat>
2022-03-22 09:39:55 +01:00
88aa3bd533
docs: add a comment to how to use set for a counter
...
Signed-off-by: Manan Gupta <manan@planetscale.com>
2022-02-10 13:31:55 +05:30
1f9db90c00
feat: store innodbRowsRead in a counter
...
Signed-off-by: Manan Gupta <manan@planetscale.com>
2022-02-01 20:31:28 +05:30
1b694ac6ae
Report Export BuildGitRev in statsd backend
...
Signed-off-by: Yang Wu <y.wu4515@gmail.com>
2021-10-11 21:02:45 -07:00
f0144ebedf
export memstats
...
Signed-off-by: Yang Wu <y.wu4515@gmail.com>
2021-09-07 19:04:56 -07:00
8a85842860
Address review comment: use ElementsMatch
...
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
2021-04-15 00:07:51 +02:00
ff45fb7f7c
sort the strings before assertion
...
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
2021-04-15 00:07:51 +02:00
2c4e7fc3dd
fix error
...
Signed-off-by: crowu <y.wu4515@gmail.com>
2021-03-19 00:46:55 -07:00
d962147765
rm useless log
...
Signed-off-by: crowu <y.wu4515@gmail.com>
2021-03-17 14:22:22 -07:00
2611c31a20
trim and improve test
...
Signed-off-by: crowu <y.wu4515@gmail.com>
2021-03-16 16:38:44 -07:00
a8234bb53e
Use MakeCommonTag
...
Signed-off-by: crowu <y.wu4515@gmail.com>
2021-03-09 08:50:46 -08:00
022b461a8a
Integate common tag with opentsdb as well
...
Signed-off-by: crowu <y.wu4515@gmail.com>
2021-03-09 07:51:18 -08:00
ebedbe1c75
Parse common tags for stats backend
...
Signed-off-by: crowu <y.wu4515@gmail.com>
2021-03-08 23:08:51 -08:00
ec34ab1bbf
add InitWithoutServenv
...
Signed-off-by: crowu <y.wu4515@gmail.com>
2021-03-08 22:32:28 -08:00
19f0598821
imp test
...
Signed-off-by: crowu <y.wu4515@gmail.com>
2021-02-05 13:49:51 -08:00
147bf6aa41
make labels
...
Signed-off-by: crowu <y.wu4515@gmail.com>
2021-02-03 10:16:41 -08:00
4ec076caf2
hook takes timings directly
...
Signed-off-by: crowu <y.wu4515@gmail.com>
2021-02-02 13:54:36 -08:00
1068fbca0a
make statsd integration better
...
Signed-off-by: crowu <y.wu4515@gmail.com>
2021-01-30 16:02:24 -08:00
47611bca39
goimports -local vitess.io/vitess -w .
...
Signed-off-by: Aditya Sharma <git@adi.run>
2021-01-04 18:27:04 -05:00
239b8688d4
sort to avoid flacky test
...
Signed-off-by: crowu <y.wu4515@gmail.com>
2020-11-24 09:30:04 -08:00
03740a6808
export timing as histogram
...
Signed-off-by: crowu <y.wu4515@gmail.com>
2020-11-24 08:52:46 -08:00
2c9b959269
race condition
...
Signed-off-by: crowu <y.wu4515@gmail.com>
2020-11-24 00:02:05 -08:00
308772c968
fix test
...
Signed-off-by: crowu <y.wu4515@gmail.com>
2020-11-23 20:39:40 -08:00
b5506f7497
ignore metrics that does not make sense to statsd
...
Signed-off-by: crowu <y.wu4515@gmail.com>
2020-11-23 19:12:26 -08:00
f546dd20c7
support statsd for vitess
...
Signed-off-by: crowu <y.wu4515@gmail.com>
2020-11-23 19:01:57 -08:00
e54822a5e9
histogram counts should not be cumulative
...
Signed-off-by: deepthi <deepthi@planetscale.com>
2020-08-27 10:39:15 -07:00
5c7ef2cdcd
Vrepl Metrics: improvements, more tests
...
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
2020-07-31 15:27:14 +02:00
34be289dfb
Merge pull request #6280 from hs0210/work
...
Add unit test for func stringMapToString.
2020-06-14 19:28:04 -07:00
9b187c8dae
Merge pull request #6289 from dweitzman/fix_opentsdb
...
Fix labels for opentsdb with single-label histograms
2020-06-14 19:19:13 -07:00
21775bd994
Add unit test for func stringMapToString.
...
Signed-off-by: Hu Shuai <hus.fnst@cn.fujitsu.com>
2020-06-10 10:09:23 +08:00
091a990df7
Fix labels for opentsdb with single-label histograms
...
Looks like the opentdb code missed out on #3879 from long ago and hasn't
been getting the latest and greatest labels for timing stats.
Signed-off-by: David Weitzman <dweitzman@pinterest.com>
2020-06-09 13:48:24 -07:00
25b4e4a385
fix flag docs to be more readable
...
Signed-off-by: deepthi <deepthi@planetscale.com>
2020-06-02 17:42:29 -07:00
d31082fd30
exporter: reuse vars where possible
...
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
2020-04-03 21:39:09 -07:00
47382877bc
Remove negative counter warnings, since we reuse the counter
...
implementation for Gauges, and then we spam logs unnecessarily
with warnings; even in vtexplain output...
Signed-off-by: Jacques Grove <aquarapid@gmail.com>
2020-03-28 01:03:12 -07:00
dd1b5698c7
stats: address review comments
...
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
2020-03-01 21:50:48 -08:00
308b4eca7c
stats: drop variables: ability to drop variables
...
It turns out that combining dimensions doesn't address all use cases.
Gauges are also susceptible to cause huge /debug/vars. This additional
feature allows you to drop specific variables from being exported.
Ideally, they should also not be tracked. But we can iterate on this
improvement later.
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
2020-02-14 05:46:06 -08:00
cb2f6aaf99
stats: drop dimension: address review comments
...
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
2020-02-09 23:27:57 -08:00
468ead013f
stats: dropped dimension: fix empty label bug
...
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
2020-02-09 23:02:42 -08:00
b5066e3f84
stats: drop dimension
...
This feature implements the drop dimension part of #5791 .
The dropping of dimensions is not applicable to all stats vars.
We drop dimensions for counters and timings, but not gauges.
This also doesn't work for func based vars, but those are now
unused for counters and timings.
The feature doesn't actually drop the dimension. Instead, it
consolidates all the different values into a single "all"
category. This approach is more backward compatible and allows
for going back and forth, because the label itself continues
to exist in both scenarios.
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
2020-02-09 02:18:41 -08:00
4a3a98bfea
stats: refactor counters for drop dimensions
...
Also, the old code was badly written.
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
2020-02-09 01:07:15 -08:00
52bbec04e2
Add test for issue #5599
...
Signed-off-by: Jacques Grove <aquarapid@gmail.com>
2019-12-19 19:27:40 -08:00
7b11b4a517
WIP fix for table names with dots in them.
...
- Crashed vttablet in the prometheus client code.
- Replace dots with underscores in tablenames on the way in
- Switch to prometheus non-panic functions.
- Add Makefile option to build non-optimized (debug) binaries.
Signed-off-by: Jacques Grove <aquarapid@gmail.com>
2019-12-19 13:26:58 -08:00
6593e5df30
Merge branch 'upstream-master' into vtshovel-poc
2019-11-22 17:09:45 -08:00
46c0fe47dd
Adds QPS chart to tablet vreplication section
...
Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
2019-10-21 10:07:19 -07:00
03e83d6c30
add license in /go file
...
Signed-off-by: yuxiaobo <yuxiaobogo@163.com>
2019-10-21 22:30:02 +08:00
63c969ca7d
add License in /go files
...
Signed-off-by: tanjunchen <2799194073@qq.com>
2019-10-12 00:31:28 +08:00
1f98c92b79
fix some spelling mistakes
...
Signed-off-by: hwdef <hwdef97@gmail.com>
2019-09-26 17:06:20 +08:00
d66ffcdf85
fix wrong spells in opentsdb.go
...
Signed-off-by: czm <zhongming.chang@daocloud.io>
2019-08-14 21:14:36 +08:00
Andrew Mason
Shlomi Noach
Vicent Marti
Manan Gupta
Yang Wu
Rohit Nayak
Harshit Gangal
Aditya Sharma
deepthi
Sugu Sougoumarane
Hu Shuai
David Weitzman
Jacques Grove
Rafael Chacon
yuxiaobo
tanjunchen
hwdef
AllenZMC