The only part of go/zk we were still using is go/zk/zkctl.
Moved it to go/vt/zkctl.
Removed the rest of go/zk code. The config part (ZK_CLIENT_CONF json
config) was moved to CellInfo.The Metaconn part was moved to the topo
service code (for the cell map) and to zk2topo (for the ZkConn retrying
part).
Note re-running bootstrap.sh is required here, as the path for zksrv.sh
has changed.
Please refer to #2694 and #2670 for motivation and reasoning for
this change.
I've tried to follow best practice in inserting the copyright
headers. In other open source projects, not all files carry
the notice. For example documentation doesn't. I've followed
similar ground rules.
I did not change the php because there is a separate LICENSE
file there by Pixel Federation. We'll first need to notify
them our intent before changing anything there.
As for the presubmit check, it's going to be non-trivial
because of the number of exceptions, like file types,
directories and generated code. So, it will have to be
a separate project.
fix the error : no java binary found
If I installed the java without yum or apt-get, but by setting the environment variable JAVA_HOME and PATH,the script with rise error :no java binary found
So we should consider the java binary installed manuelly
And using it in all tests that can use it.
Removing other fake zk connections in favor of launching a ZK server.
Refactoring zkcustomrule to use new zk2 library.
Create /zk root as necessary instead of relying on zkctl to do it.
This makes it easier to use Vitess with ZooKeeper servers that aren't
started via zkctl.