It was failing because the target path needs to be in PYTHONPATH already
before the install step. We need to add it in bootstrap like we do for
gRPC. After bootstrap, dev.env will find it automatically by searching
for all site-packages directories.
go/vt/proto/queryservice/queryservice.pb.go breaks if one does not
have the latest grpc installed. However, bootstrap script won't help
if there is a old grpc installed on your machine. By add the -u flag,
it forces go get command to install the latest version.
It should match the convention established with "MariaDB".
I looked into making them case-insensitive, but it would be more tricky
than it's worth because flavor IDs are used as part of the protocol
between servers. So an old server that is case-sensitive would choke on
a message from a new one.
for building. Also properly parsing the command line flag
in bootstrap.sh.
Should reduce te nuber of times we build proto from 4x to 1x, and
grpc from 2x to 1x. Doh.
We don't want to auto-remove the directory on failure, since the user
may need to investigate what went wrong. So we can't use the existence
of the directory to know whether the build finished.
Fixes#472
In response to feedback that it looked like an error saying,
"you should have run 'source dev.env' before bootstrap."
In fact, it is saying bootstrap is done.
Golint should never be required, as per the docs:
"""
The suggestions made by golint are exactly that: suggestions.
Golint is not perfect, and has both false positives and false negatives.
Do not treat its output as a gold standard. We will not be adding
pragmas or other knobs to suppress specific warnings, so do not expect or
require code to be completely "lint-free".
"""
This hook only shows the line count of the golint output for each file
modified in a commit. That way you don't get flooded just because you
changed one line in a file with a hundred pre-existing lint issues.
However, if we just print the warnings without stopping, you'll probably
never see them because your editor comes up to let you write a commit
message. So we try to steal back the keyboard and pause to let you know
you might want to look into the lint warnings. If the stealing ends up
being buggy, we'll have to think of something else.
Add travis configuration and dependencies script
Split integration test make targets to allow parallel execution in Travis
Add go packages required for coverage upload to Coveralls
Add coveralls and travis badges to README
Travis: Retry make targets to address flaky targets
Switch to using go install. Leads to faster and cleaner builds.
go install directly installs the binaries into $VTROOT/bin directly
because $GOPATH==$VTROOT. It also intalls intermediate libraries under
pkg, which results in reuse.
There is also no more clutter in the source dirs: cleaner .gitignore.
Anthony Yeh
Ammar Aijazi
Shengzhe Yao
Alain Jobart
Rushi Agrawal
Anand Henry
Peter Lobsinger
Ryszard Szopa
Sugu Sougoumarane