I believe this is more idiomatic golang, and it makes it
easier to work with the code base on modern IDEs.
Signed-off-by: Andres Taylor <antaylor@squareup.com>
* Extracted the opentracing wrapper to it's own file
* Commented all the public methods
* gofmt/goimports
* Made sure the two interceptor builders are similar
Signed-off-by: Andres Taylor <antaylor@squareup.com>
Before this change, the GRPC server could get started before tracing
had been initiated, which meant that the GRPC interceptors were not
hooked up properly.
Signed-off-by: Andres Taylor <antaylor@squareup.com>
* Java: tracing=[off,opentracing]
* go: tracing=[off,opentracing_jaeger]
In both environments, the default is no tracing.
Signed-off-by: Andres Taylor <antaylor@squareup.com>
Since we are not really following the OT conventions for
span annotation, I'm removing this method.
Signed-off-by: Andres Taylor <antaylor@squareup.com>
The old API had an issue with contexts not being passed
around correctly. This new API should make it easier to
remember to do it correctly.
Signed-off-by: Andres Taylor <antaylor@squareup.com>
Please refer to #2694 and #2670 for motivation and reasoning for
this change.
I've tried to follow best practice in inserting the copyright
headers. In other open source projects, not all files carry
the notice. For example documentation doesn't. I've followed
similar ground rules.
I did not change the php because there is a separate LICENSE
file there by Pixel Federation. We'll first need to notify
them our intent before changing anything there.
As for the presubmit check, it's going to be non-trivial
because of the number of exceptions, like file types,
directories and generated code. So, it will have to be
a separate project.
Sugu Sougoumarane
Andres Taylor
Gerald Kaszuba
Anthony Yeh