* Add mysql_server_pool_conn_read_buffers flag and thread through to listener and connection
Signed-off-by: Brian Ramos <brirams@users.noreply.github.com>
* review feedback: code style
Signed-off-by: Brian Ramos <brirams@users.noreply.github.com>
* fix endtoend test
Signed-off-by: Brian Ramos <brirams@users.noreply.github.com>
* run benchmarks with read buffer pooling, too
Signed-off-by: Brian Ramos <brirams@users.noreply.github.com>
* update flag name to match new conventions
Signed-off-by: Brian Ramos <brirams@users.noreply.github.com>
* update 15.0.0 summary with reference to new flag
Signed-off-by: Brian Ramos <brirams@users.noreply.github.com>
* an attempt at cleaning up branch for rebasing
Signed-off-by: Brian Ramos <brirams@users.noreply.github.com>
Signed-off-by: Brian Ramos <brirams@users.noreply.github.com>
* docs: fix logging in vtorc http
Signed-off-by: Manan Gupta <manan@planetscale.com>
* feat: add servenv and required flags to vtorc
Signed-off-by: Manan Gupta <manan@planetscale.com>
* feat: add vtorc port to local and region sharding example
Signed-off-by: Manan Gupta <manan@planetscale.com>
* test: add vtorc to flag help test
Signed-off-by: Manan Gupta <manan@planetscale.com>
* feat: simplify vtorc parsing of flags
Signed-off-by: Manan Gupta <manan@planetscale.com>
* feat: add redirect for unrecognized paths to /debug/status to vtorc
Signed-off-by: Manan Gupta <manan@planetscale.com>
* feat: add a component to debug/status page of vtorc to display recent recoveries
Signed-off-by: Manan Gupta <manan@planetscale.com>
* feat: simplify a condition in vtorc
Signed-off-by: Manan Gupta <manan@planetscale.com>
* feat: fix command used for invoking vtorc
Signed-off-by: Manan Gupta <manan@planetscale.com>
* feat: remove adding help flag and let servenv handle it
Signed-off-by: Manan Gupta <manan@planetscale.com>
* feat: add vtorc servenv page to docker-compose example too
Signed-off-by: Manan Gupta <manan@planetscale.com>
* feat: add prometheus plugin like we do for other binaries
Signed-off-by: Manan Gupta <manan@planetscale.com>
* feat: change vtorc debug port to not conflict with vttablet's port
Signed-off-by: Manan Gupta <manan@planetscale.com>
* feat: fix year in file license
Signed-off-by: Manan Gupta <manan@planetscale.com>
* docs: add summary docs
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
* refactor: move pool unsafe query test to query_engine test
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
* fix: changed the new flag to newer convention of dashes than underscore
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
* added release notes
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
* test: fix test expectation
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
* decouple olap tx timeout from oltp tx timeout
Since workload=olap bypasses the query timeouts
(--queryserver-config-query-timeout) and also row limits, the natural
assumption is that it also bypasses the transaction timeout.
This is not the case, e.g. for a tablet where the
--queryserver-config-transaction-timeout is 10.
This commit:
* Adds new CLI flag and YAML field to independently configure TX
timeouts for OLAP workloads (--queryserver-config-olap-transaction-timeout).
* Decouples TX kill interval from OLTP TX timeout via new CLI flag and
YAML field (--queryserver-config-transaction-killer-interval).
Signed-off-by: Max Englander <max@planetscale.com>
* decouple ol{a,t}p tx timeouts: pr comments #1
Signed-off-by: Max Englander <max@planetscale.com>
* decouple ol{a,t}p tx timeouts: pr comments #2 consolidate timeout logic in sc
Signed-off-by: Max Englander <max@planetscale.com>
* decouple ol{a,t}p tx timeouts: remove unused tx killer flag
Signed-off-by: Max Englander <max@planetscale.com>
* decouple ol{a,t}p tx timeouts: update 15_0_0_summary.md
Signed-off-by: Max Englander <max@planetscale.com>
* decouple ol{a,t}p tx timeouts: fix race cond
Signed-off-by: Max Englander <max@planetscale.com>
* decouple ol{a,t}p tx timeouts: pr comments #3 -txProps.timeout, +sc.expiryTime
Signed-off-by: Max Englander <max@planetscale.com>
* decouple ol{a,t}p tx timeouts: pr comments #4 -atomic.Value for expiryTime
Signed-off-by: Max Englander <max@planetscale.com>
* decouple ol{a,t}p tx timeouts: fix race cond (without atomic.Value)
Signed-off-by: Max Englander <max@planetscale.com>
* decouple ol{a,t}p tx timeouts: pr comments #5 -unused funcs, fix comments, set ticks interval once
Signed-off-by: Max Englander <max@planetscale.com>
* decouple ol{a,t}p tx timeouts: pr comments #5 +txkill tests
Signed-off-by: Max Englander <max@planetscale.com>
* revert fmt changes
Signed-off-by: Max Englander <max@planetscale.com>
* implement pr review suggestion
Signed-off-by: Max Englander <max@planetscale.com>
Signed-off-by: Max Englander <max@planetscale.com>
* [cli] [servenv] Un-export gRPC server flags and migrate to pflag
Signed-off-by: Andrew Mason <andrew@planetscale.com>
* [cli] [servenv] Remove deprecated profiling flags
Signed-off-by: Andrew Mason <andrew@planetscale.com>
* [cli] [servenv] Migrate flags used by Run, RunDefault, and Init to pflag
Signed-off-by: Andrew Mason <andrew@planetscale.com>
* [cli] [servenv] Migrate remaining flags used by Run/grpc-server
Signed-off-by: Andrew Mason <andrew@planetscale.com>
* [vttestserver] fix flag registration
Signed-off-by: Andrew Mason <andrew@planetscale.com>
* clean up package comment to remove reference to nonexistent code
Signed-off-by: Andrew Mason <andrew@planetscale.com>
* fix comment, add release note
Signed-off-by: Andrew Mason <andrew@planetscale.com>
* update relnotes with more deletion notices
Signed-off-by: Andrew Mason <andrew@planetscale.com>
* feat: added query logging to safe session
Signed-off-by: Andres Taylor <andres@planetscale.com>
* feat: added [explain format=vtexplain] parsing and AST
Signed-off-by: Andres Taylor <andres@planetscale.com>
* feat: add planning of vtexplain queries
Signed-off-by: Andres Taylor <andres@planetscale.com>
* feat: keep the logging even in the precense of autocommits
Signed-off-by: Andres Taylor <andres@planetscale.com>
* feat: use table result instead of warnings, and move the logging to scattercon
Signed-off-by: Andres Taylor <andres@planetscale.com>
* feat: log commit to vtexplain logger and added e2e test
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
* feat: vindex query to mark vindexExec in session
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
* test: run only for gen4 planner
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
* feat: vtexplain logs with bindvars replaces, and begin being counted with the real query
Signed-off-by: Andres Taylor <andres@planetscale.com>
* feat: add ACTUALLY_RUN_QUERIES as a comment directive to vtexplain and block dml queries if not specified
Signed-off-by: Manan Gupta <manan@planetscale.com>
* test: make sure we add the actually_runs_queries directive to inserts we want to inspect
Signed-off-by: Andres Taylor <andres@planetscale.com>
* docs: added info to release notes
Signed-off-by: Andres Taylor <andres@planetscale.com>
* typo: fix error message
Signed-off-by: Andres Taylor <andres@planetscale.com>
* feat: ignore cases on comment directives
Signed-off-by: Andres Taylor <andres@planetscale.com>
* fix: CommentDirective now hides internals so that the lower casing of keys can be preserved everywhere
Signed-off-by: Andres Taylor <andres@planetscale.com>
* test: improve assertion
Signed-off-by: Andres Taylor <andres@planetscale.com>
* chore: clean up accidental change
Signed-off-by: Andres Taylor <andres@planetscale.com>
* refactor: clean up so more responsibility for vtexplain ends up in the engine primitive
Signed-off-by: Andres Taylor <andres@planetscale.com>
* fix: no need to Unquote multiple times
Signed-off-by: Andres Taylor <andres@planetscale.com>
* fix: rename comment directive
Signed-off-by: Andres Taylor <andres@planetscale.com>
Co-authored-by: Harshit Gangal <harshit@planetscale.com>
Co-authored-by: Manan Gupta <manan@planetscale.com>
* feat: deprecate enable_semi_sync flag
Signed-off-by: Manan Gupta <manan@planetscale.com>
* docs: add the deprecation change to the summary
Signed-off-by: Manan Gupta <manan@planetscale.com>
* test: fix test expectation for vttablet flags
Signed-off-by: Manan Gupta <manan@planetscale.com>
* feat: fix cnf files to not mention the deprecated flag
Signed-off-by: Manan Gupta <manan@planetscale.com>
* feat: remove enable_semi_sync from scripts of examples
Signed-off-by: Manan Gupta <manan@planetscale.com>
* test: remove setting enable_semi_sync flag in testlib tests
Signed-off-by: Manan Gupta <manan@planetscale.com>
* feat: remove enable_semi_sync from a bunch of tests
Signed-off-by: Manan Gupta <manan@planetscale.com>
* test: refactor setup to take in durability policy instead of a boolean and add a test for cross cell durability policy
Signed-off-by: Manan Gupta <manan@planetscale.com>
* feat: add cross cell durability policy to the docs
Signed-off-by: Manan Gupta <manan@planetscale.com>
* feat: fix flag help output
Signed-off-by: Manan Gupta <manan@planetscale.com>
* test: we shouldn't remove enable_semi_sync from tests which are testing upgrades
Signed-off-by: Manan Gupta <manan@planetscale.com>
* refactor: move out plan into its own file
Signed-off-by: Andres Taylor <andres@planetscale.com>
* refactor: wrap primitive in a PlanResult struct
Signed-off-by: Andres Taylor <andres@planetscale.com>
* test: cleanup tests to move to using assert package
Signed-off-by: Manan Gupta <manan@planetscale.com>
* feat: add a tablesUsed field to logstats and use it in the output
Signed-off-by: Manan Gupta <manan@planetscale.com>
* feat: wireup the tables used from the planning phase to log stats
Signed-off-by: Manan Gupta <manan@planetscale.com>
* test: make sure to keep escapes in json strings
Signed-off-by: Andres Taylor <andres@planetscale.com>
* feat: add tables used field to the plan output
Signed-off-by: Andres Taylor <andres@planetscale.com>
* feat: add tables used to more plan types
Signed-off-by: Andres Taylor <andres@planetscale.com>
* refactor: move logstats to it's own package
Signed-off-by: Andres Taylor <andres@planetscale.com>
* chore: updated to newest version of cmp
Signed-off-by: Andres Taylor <andres@planetscale.com>
* test: refactor
Signed-off-by: Andres Taylor <andres@planetscale.com>
* feat: simplify logstats printing
Signed-off-by: Andres Taylor <andres@planetscale.com>
* feat: add tables used for INSERT queries
Signed-off-by: Andres Taylor <andres@planetscale.com>
* feat: add ks for dual queries
Signed-off-by: Andres Taylor <andres@planetscale.com>
* comment: add deprecation warning to logstats fields
Signed-off-by: Andres Taylor <andres@planetscale.com>
* docs: add deprecation warning
Signed-off-by: Andres Taylor <andres@planetscale.com>
Co-authored-by: Manan Gupta <manan@planetscale.com>
Deepthi Sigireddi
Brian Ramos
Manan Gupta
FlorentP
Harshit Gangal
Florent Poinsard
Max Englander
Andrew Mason
Renan Rangel
Rameez Sajwani
Andres Taylor
Matt Lord
vitess-bot[bot]
Phani Raj
Shlomi Noach