Michael Berlin
f7d05f2942
vtworker: Fix code after the logging Event was moved from vtctldata to logutil.
2015-07-06 13:12:50 -07:00
Michael Berlin
6feb668dfd
Merge branch 'master' into vtworker_rpc_interface_review1
2015-07-06 12:17:05 -07:00
Alain Jobart
5a11631d7d
Updating gRPC to 0.9.1.
...
Updating protobuf to v3.0.0-alpha-2 (to match gRPC's version)
Now the python vtctl client works as expected (!!!).
Also splitting up go and python vtctl client implementations
(will be used inside google3).
2015-07-06 11:54:04 -07:00
Alain Jobart
87ae86d514
new version of generated protos.
2015-07-06 10:59:02 -07:00
Michael Berlin
bac52ece5a
vtworker: Add panic handler to RPC service implementation.
...
(The execution of the vtworker command itself is already covered by another panic handler because it's run in its own go routine.)
2015-07-05 14:34:25 +02:00
Michael Berlin
b2a674464b
vtworker: Minor fix to not overwrite the subflags and use if/else instead.
2015-07-05 14:15:07 +02:00
Michael Berlin
b31c0500d6
utils.py: Remove indentation in docstrings again.
2015-07-05 13:59:49 +02:00
Michael Berlin
5fddd68237
vtworker: Move back comment to correct code after factoring out the Reset() function.
2015-07-05 13:00:16 +02:00
sougou
791dc4be39
Merge pull request #845 from youtube/suguwork
...
sqlparser: Limit nesting of parenthesized exprs
2015-07-03 23:56:59 -07:00
Sugu Sougoumarane
9f45f64fe0
sqplarser: Limit nesting for all parenthesized exprs
...
The previous change only handled nesting for one construt.
This change extends the limit to all parenthesized constructs.
2015-07-03 23:38:30 -07:00
Sugu Sougoumarane
ccf0fcec25
sqlparser: Limit nesting of parenthesized exprs
...
This addresses https://github.com/youtube/vitess/issues/767
as well as other situations where there's possibility of
indefinite nesting of SQL constructs. There may be other
non-aprentheszed constructs that allow nesting, but this fix
doesn't address them for now.
I've also made a few lint fixes. sql.go is still in violation,
but that requires bigger work.
2015-07-02 06:31:34 -07:00
Ammar Aijazi
a9d85bec8f
Merge pull request #841 from youtube/aaijazi_add_rpc_errors_to_vtgate
...
Add RPC errors to some VTGate calls
2015-07-01 03:09:50 -07:00
Ammar Aijazi
f26dfd66cb
Fix tests that depended on old schema_info.go behavior
2015-07-01 02:56:02 -07:00
Ammar Aijazi
b6bbd46af5
Fix bug where a TabletError was wrapping another TabletError and changing the severity level
2015-07-01 02:22:08 -07:00
Ammar Aijazi
6113de3674
Merge remote-tracking branch 'origin/master' into aaijazi_add_rpc_errors_to_vtgate
2015-06-30 15:42:20 -07:00
Anthony Yeh
fbefe76503
Merge pull request #844 from enisoc/k8s-addrs
...
[k8s] Add kvtctl.sh script to find vtctld address automatically
2015-06-30 11:56:03 -07:00
Anthony Yeh
8804620ab1
Merge pull request #843 from enisoc/lock_srvshard
...
Deprecate lock_srvshard flag.
2015-06-30 11:55:37 -07:00
Michael Berlin
99998ccc10
vtworker: Add vtworkerclient binary which is an RPC client for vtworker.
...
Add support for it to Python integration tests.
2015-06-30 15:05:05 +02:00
Michael Berlin
d7315ac96c
vtworker: Add tests for RPC client.
2015-06-30 15:01:00 +02:00
Michael Berlin
d65db08012
vtworker: Add gRPC client.
2015-06-30 14:58:45 +02:00
Michael Berlin
162b68a095
vtworker: Create vtworker gRPC client by copying the vtctl client code.
...
This makes it easier to review actual changes.
All files in this commit are copies and no new code.
2015-06-30 14:56:29 +02:00
Michael Berlin
28e149bf8a
vtworker: RPC Server: Fix panic handling.
...
vtworker commands are run in a new go routine, so handle panics in the same routine.
Added new vtworker command "Panic" to test correct handling of panics (vtworker should only log and not exit).
2015-06-30 14:27:07 +02:00
Michael Berlin
83fda797a3
vtworker: Add "Reset" command to RPC interface.
2015-06-30 14:18:50 +02:00
Michael Berlin
a6d2b89c25
vtworker.py: Add test to verify webinterface functionality.
2015-06-30 14:18:50 +02:00
Michael Berlin
799b00ae04
vtworker: Fix problem that the Wrangler logger was overwritten with a ConsoleLogger when combining it with a memory logger for the webserver status output.
...
This problem occurred in case of RPC requests where the Logger of the custom Wrangler has to be preserved.
Reduced visiblity of Instance fields.
2015-06-30 14:18:43 +02:00
Michael Berlin
f00de8bd05
vtworker: Adjust the interactive method signature to be more similar to the command line version.
...
Now, the interactiveCommand implementations contain less vtworker-specific logic (e.g. setting the worker, sending a redirect). This way, it's easier to pass the wrangler to Instance.setAndStartWorker(). Also, commands no longer have to duplicate the same code.
2015-06-30 14:07:04 +02:00
Michael Berlin
c09d05d131
vtworker: Print flags Usage on logger instead of stderr.
...
This way, we can also return the usage to the vtworker RPC client.
Do not exit (or panic) when flags.parse() returned an error unless we are run from the command line.
Commands now return the error of the flag parsing.
Commands now show the usage if an optional parameter is missing.
2015-06-30 14:00:19 +02:00
Ammar Aijazi
bec3a0ed90
Fix a comment
2015-06-30 01:53:32 -07:00
Ammar Aijazi
899442f681
Add tests for Begin2, Commit2, and Rollback2
2015-06-30 01:42:21 -07:00
Ammar Aijazi
051c12bfbf
Fix vtgate_proto_test
2015-06-30 00:11:44 -07:00
Ammar Aijazi
24975d342e
Add working Begin2, Commit2, and Rollback2 to VTGate
2015-06-29 23:59:26 -07:00
Ammar Aijazi
4216b97d40
Add server and client support for application errors in RPC response for VTGate.SplitQuery
2015-06-29 22:47:19 -07:00
Ammar Aijazi
dff0dc634a
Added server and client support for RPC errors in response of VTGate ExecuteBatch*
2015-06-29 19:38:41 -07:00
Anthony Yeh
a336bbe4c5
Describe how to tell if vtworker diff succeeds.
2015-06-29 16:42:40 -07:00
Anthony Yeh
dd3bd4ab80
TestRebuildShard doesn't need to test locking anymore.
...
There are no more locks in RebuildShard.
2015-06-29 16:17:13 -07:00
Anthony Yeh
79a1f47405
zktopo UpdateSrvShard should create parent if necessary.
...
This matches the behavior of the other topo flavors.
2015-06-29 16:08:53 -07:00
Anthony Yeh
ff648b5625
Deprecate lock_srvshard flag.
...
It was only needed for the transition to optimistic updates.
2015-06-29 15:41:42 -07:00
Anthony Yeh
4c8eb9cdfd
Fix kvtctl ApplySchema to use kvtctl.sh.
2015-06-29 15:07:04 -07:00
Anthony Yeh
52ff1562a9
Fix kvtctl.sh for multiple args.
2015-06-29 14:58:13 -07:00
Anthony Yeh
f21f5357d3
Kubernetes example: find address of vtctld automatically.
2015-06-29 14:52:43 -07:00
Anthony Yeh
26b54905b8
Add Sharding in Kubernetes guide to vitess.io.
2015-06-29 13:24:31 -07:00
Anthony Yeh
e365f0efb6
Merge pull request #842 from enisoc/keyspace_test
...
Deflake keyspace_test.
2015-06-29 13:03:35 -07:00
Anthony Yeh
50f3b13610
Deflake keyspace_test.
...
There's no need to assert that stderr is empty. The run_vtctl()
function will raise a TestError if the command returns an error code.
This check was making the test flaky because sometimes the spawned
process would emit an incidental log message despite succeeding.
2015-06-29 12:50:01 -07:00
Ammar Aijazi
bee894035b
vtgateconn correctly receieves errors when they're sent in the RPC response for Execute*, tests pass
2015-06-28 23:59:33 -07:00
Ammar Aijazi
86e72b84a3
Added unit tests for the --rpc_only_in_reply behavior for vtgateconn
2015-06-28 23:59:33 -07:00
Ammar Aijazi
b682400469
VTGate.Execute returns errors in RPC response
2015-06-28 23:59:32 -07:00
Ammar Aijazi
855854fb99
Extend vtgateconn tests to include error handling
2015-06-28 23:59:32 -07:00
Ammar Aijazi
6bd1e5e73f
No more need for error string parsing in gorpctabletconn
2015-06-28 23:59:32 -07:00
Ammar Aijazi
44b14802b4
More thorough testing of errors in tabletconntest.go
2015-06-28 23:59:32 -07:00
Ammar Aijazi
2a5a3b9a28
Merge pull request #840 from youtube/aaijazi_deflake_worker_test
...
Increase the timeout for worker tests to deflake them
2015-06-28 15:11:11 -07:00