00b4593ecc
Merge branch 'rk-newmult' of github.com:planetscale/vitess into rk-newmult
...
Signed-off-by: Rasika Kale <rasika@planetscale.com>
2019-09-12 13:18:55 -07:00
297345fc59
maintainers: add morgo and systay
...
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
2019-09-12 13:18:04 -07:00
ea327d7279
Improve errror when capabiility detect fails
...
ALso removes unused capabiltities code to silence staticcheck warning.
Signed-off-by: Morgan Tocker <tocker@gmail.com>
2019-09-12 13:18:04 -07:00
c5c67add62
making sure fresh state works before turning off query service during a split
...
Signed-off-by: Yufei Chen <yufei@squareup.com>
2019-09-12 13:18:04 -07:00
0cf6371f33
fix docker pre-fetch of go modules
...
Signed-off-by: Morgan Tocker <tocker@gmail.com>
2019-09-12 13:18:04 -07:00
cb9c05ec56
Fixed error checking for multiplication of uint*int and uint*int
...
Signed-off-by: Rasika Kale <rasika@planetscale.com>
2019-09-12 13:18:04 -07:00
ffd573a6d6
Completed error checking for uintTimesIntWithError()
...
- Added more tests in arithmetic_test.go to confirm code is covered and error checking works
Signed-off-by: Rasika Kale <rasika@planetscale.com>
2019-09-12 13:18:04 -07:00
bdb6bf8320
Fixed error checking for uintTimesIntWithError() in arithmetic.go
...
- Added more tests in TestMultiply() in arithmetic_test.go to increase code coverage
Signed-off-by: Rasika Kale <rasika@planetscale.com>
2019-09-12 13:18:04 -07:00
52b0974f0e
Changed error checking in uintTimesUintWithError() in arithmetic.go
...
Signed-off-by: Rasika Kale <rasika@planetscale.com>
2019-09-12 13:18:04 -07:00
e2558a66d5
Fixed error checking for overflow of integer multiplication
...
Signed-off-by: Rasika Kale <rasika@planetscale.com>
2019-09-12 13:18:04 -07:00
ba19e18573
Fixed runtime error in Multiply()
...
Signed-off-by: Rasika Kale <rasika@planetscale.com>
2019-09-12 13:18:04 -07:00
8975b4749d
Implemented Multiply() along with appropricate functions in arithmetic.go
...
- Added tests for Multiply() in arithmetic_test.go to cover code coverage
- Implemented additional function floatTimesAny() to account for float values
Signed-off-by: Rasika Kale <rasika@planetscale.com>
2019-09-12 13:18:04 -07:00
9afca1ca00
Fixed error print statements
...
Signed-off-by: Rasika Kale <rasika@planetscale.com>
2019-09-12 13:18:04 -07:00
9214c940cf
Fixed comment spacing and cleaned up code
...
Signed-off-by: Rasika Kale <rasika@planetscale.com>
2019-09-12 13:18:04 -07:00
32fa645344
Fixed spacing between // and comment
...
Signed-off-by: Rasika Kale <rasika@planetscale.com>
2019-09-12 13:18:04 -07:00
eeebadb297
Fixed code coverage in arithmetic.go
...
- Added more tests in arithmetic_test.go to fix code coverage
- Added error checking into arithmetic.go
- Implemented function floatMinusAny() for subtraction expression
Signed-off-by: Rasika Kale <rasika@planetscale.com>
2019-09-12 13:18:04 -07:00
9f9c2e04b0
sqltypes: Subtract functionality
...
Signed-off-by: Rasika Kale <rasika@planetscale.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
2019-09-12 13:18:04 -07:00
7ebf526e25
Merge remote-tracking branch 'origin/master' into rk-newmult
...
Signed-off-by: Rasika Kale <rasika@planetscale.com>
2019-09-12 13:09:18 -07:00
0426fc324f
Track number of times pool had zero available slots
...
Signed-off-by: Adam Saponara <as@php.net>
2019-09-12 15:30:06 -04:00
6b2d0d1443
fix/add descriptive comments, avoid unnecessary topo calls, merge 2 loops into 1 and remove use of channel that is no longer needed
...
Signed-off-by: deepthi <deepthi@planetscale.com>
2019-09-12 09:03:40 -07:00
0b9bcb8941
Merge pull request #5140 from planetscale/rk-newminus
...
WIP: Subtraction operation implementation
2019-09-11 22:10:44 -07:00
55157408f6
add comments explaining why some synchronization has been removed
...
Signed-off-by: deepthi <deepthi@planetscale.com>
2019-09-11 21:23:45 -07:00
ccba3dba83
make TER idempotent so that it can be called again if the first call does not complete all steps
...
Signed-off-by: deepthi <deepthi@planetscale.com>
2019-09-11 14:09:50 -07:00
6d730e5ddd
Merge pull request #5169 from planetscale/ds-4888
...
change fatal to error if we are unable to update local_metadata or shard_metadata
2019-09-10 18:54:12 -07:00
1f66f10fb6
Merge pull request #5175 from systay/tracing-clean
...
Use interfaces instead of functions
2019-09-10 18:53:24 -07:00
e68a3c5021
Fixed error checking for multiplication of uint*int and uint*int
...
Signed-off-by: Rasika Kale <rasika@planetscale.com>
2019-09-10 17:01:05 -07:00
6e1daea4fa
vreplication: more VReplicationExec constructs
...
Previously, only single row queries were allowed for VReplicationExec.
With this change, queries with arbitrary where clauses are supported.
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
2019-09-10 16:34:05 -07:00
8236bdb173
fix race condition, one more unit test
...
Signed-off-by: deepthi <deepthi@planetscale.com>
2019-09-10 15:52:39 -07:00
a9bd92593d
Merge pull request #5178 from planetscale/ss-vrepl-improved-identification
...
migrater: identify shard migration differently
2019-09-10 15:45:38 -07:00
8ec326606d
migrater: identify shard migration differently
...
Previously, we identifid a migration as SHARD of the source and
target keyspaces matched. But it's possible to have table migrations
within a keyspace.
This new way identifies a migration as SHARD only if the source and
target shards don't match.
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
2019-09-10 13:07:36 -07:00
767e15767c
Merge pull request #5163 from planetscale/ss-vrepl-exclude-tables
...
vreplication: ability to exclude tables
2019-09-10 13:04:59 -07:00
008395d277
Merge remote-tracking branch 'origin/master' into rk-newminus
...
Signed-off-by: Rasika Kale <rasika@planetscale.com>
2019-09-10 13:02:26 -07:00
dd2f51f945
Added test for uint - (- int)
...
Signed-off-by: Rasika Kale <rasika@planetscale.com>
2019-09-10 11:42:09 -07:00
2b718e9d93
check tablet is really master before changing type, add unit test
...
Signed-off-by: deepthi <deepthi@planetscale.com>
2019-09-10 10:57:27 -07:00
b37147c82b
Merge remote-tracking branch 'origin/master' into rk-newminus
...
Signed-off-by: Rasika Kale <rasika@planetscale.com>
2019-09-10 10:51:19 -07:00
ab425723d5
Merge pull request #5176 from yuxiaobo96/vitess-update
...
Grammar tweak
2019-09-10 10:37:16 -07:00
355c915a09
Changed error checking to account for corner cases
...
- checked if v1 < 0 in intMinusUintWithError()
- checked if v2 is greater that v1 and greater than 0 in uintMinusIntWithError()_
- within uintMinusIntWithError() checked if v2 < 0, then returned uintPlusIntWithError(v1, -v2)
- checked if v2 > v1 in uintMinusUintWithError()
- Added function floatMinusAny() in subtractNumericWithError() to account for float - value expressions
Signed-off-by: Rasika Kale <rasika@planetscale.com>
2019-09-10 09:51:40 -07:00
d53de4f4f2
xtrabackup: Make sure all files are closed before writing MANIFEST. ( #5177 )
...
* Update to latest GCS client.
Signed-off-by: Anthony Yeh <enisoc@planetscale.com>
* xtrabackup: Make sure all files are closed before writing MANIFEST.
We've observed a backup that was missing files, yet had a MANIFEST.
In the built-in backup engine, the contract was that the MANIFEST file
must not be written unless all files were confirmed to have been
uploaded successfully. In XtraBackup mode, we were not meeting this
contract because an error that occurred while closing a file would not
be noticed until after we had written the MANIFEST.
Signed-off-by: Anthony Yeh <enisoc@planetscale.com>
2019-09-10 09:36:10 -07:00
7d05ab564e
Grammar tweak
...
Signed-off-by: yuxiaobo <yuxiaobogo@163.com>
2019-09-10 15:07:52 +08:00
9db6df7057
Use interfaces instead of functions
...
I believe this is more idiomatic golang, and it makes it
easier to work with the code base on modern IDEs.
Signed-off-by: Andres Taylor <antaylor@squareup.com>
2019-09-10 07:41:07 +02:00
7bd6618620
address review comments
...
Signed-off-by: deepthi <deepthi@planetscale.com>
2019-09-09 20:10:19 -07:00
3b7f32792c
Merge pull request #5174 from planetscale/ss-add-maintainers
...
maintainers: add morgo and systay
2019-09-09 18:45:18 -06:00
bd17a00040
maintainers: add morgo and systay
...
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
2019-09-09 16:59:06 -07:00
a65a7f6fa7
along with old master also update any other tablet that thinks it is master to REPLICA
...
Signed-off-by: deepthi <deepthi@planetscale.com>
2019-09-09 16:25:49 -07:00
c024f956cc
change fatal to error if we are unable to update local_metadata or shard_metadata
...
Signed-off-by: deepthi <deepthi@planetscale.com>
2019-09-09 11:43:26 -07:00
0645e357d0
Merge pull request #5161 from planetscale/morgo-improve-capabilities
...
Improve error when capabiility detect fails
2019-09-08 21:08:10 -07:00
d28cb14ec5
Merge pull request #5165 from figocia/yufei/refresh-state-before-turning-off-query-service
...
RefreshMaster on both source and target before turning off query service on source during splitting
2019-09-08 21:07:33 -07:00
61a49ff32e
Merge pull request #5167 from planetscale/morgo-go-mod-followup
...
fix docker pre-fetch of go modules
2019-09-08 21:04:30 -07:00
de1ca3dc6e
making sure fresh state works before turning off query service during a split
...
Signed-off-by: Yufei Chen <yufei@squareup.com>
2019-09-09 09:07:13 +10:00
f955b700ae
Empty commit
...
Signed-off-by: Morgan Tocker <tocker@gmail.com>
2019-09-06 17:22:51 -06:00
Rasika Kale
Sugu Sougoumarane
Morgan Tocker
Yufei Chen
Adam Saponara
deepthi
Anthony Yeh
yuxiaobo
Andres Taylor
Derek Perkins