a52ce844ed
Completed error checking for uintTimesIntWithError()
...
- Added more tests in arithmetic_test.go to confirm code is covered and error checking works
Signed-off-by: Rasika Kale <rasika@planetscale.com>
2019-09-06 15:59:34 -07:00
0b191d648a
fix docker pre-fetch of go modules
...
Signed-off-by: Morgan Tocker <tocker@gmail.com>
2019-09-06 14:57:28 -06:00
95a52bdb95
Fixed error checking for uintTimesIntWithError() in arithmetic.go
...
- Added more tests in TestMultiply() in arithmetic_test.go to increase code coverage
Signed-off-by: Rasika Kale <rasika@planetscale.com>
2019-09-06 10:17:01 -07:00
0b85a9d32c
vreplication: ability to exclude tables
...
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
2019-09-05 17:24:57 -07:00
9f709a9e9c
Merge pull request #5157 from planetscale/replication-repair-self
...
replication_reporter: Don't try to reparent to yourself.
2019-09-05 17:23:07 -07:00
7820d4ebd8
Merge pull request #5159 from planetscale/ss-vrepl-unify-parsing
...
vreplication: refactor table_plan_builder
2019-09-05 17:21:33 -07:00
d15803ddf2
Merge pull request #5162 from tirsen/jontirsen/2019-09-06/no-cache-dns-again
...
Don't cache Zookeeper DNS
2019-09-05 16:00:39 -07:00
3b985e8ca6
Don't cache Zookeeper DNS
...
Make sure we re-resolve the DNS name every time we reconnect to a
server. In environments where DNS changes often such as Kubernetes we
can't cache the IP address.
Signed-off-by: Jon Tirsen <jontirsen@squareup.com>
2019-09-06 07:57:07 +10:00
00b3a085e3
Fixed error checking in arithmetic.go under uintPlusIntWithError()
...
- Fixed tests in TestAdd() in arithmetic_test.go
Signed-off-by: Rasika Kale <rasika@planetscale.com>
2019-09-05 14:54:59 -07:00
ed6d0ddcbf
Merge pull request #5154 from adsr/prevent-purge-symlink
...
Prevent log purging of symlinks
2019-09-05 11:33:10 -07:00
667e410506
Changed Error Checking for subtraction in intMinusUintWithError()
...
- Added test for method in arithmetic_test.go to maximize code coverage
Signed-off-by: Rasika Kale <rasika@planetscale.com>
2019-09-05 11:28:23 -07:00
c9987b73fd
Improve errror when capabiility detect fails
...
ALso removes unused capabiltities code to silence staticcheck warning.
Signed-off-by: Morgan Tocker <tocker@gmail.com>
2019-09-05 09:19:22 -06:00
e7f3ef81a8
Prevent log purging of symlinks
...
Signed-off-by: Adam Saponara <as@php.net>
2019-09-05 11:00:01 -04:00
18e0e98275
Merge pull request #5109 from planetscale/morgo-new-go-modules
...
Switch to go modules
2019-09-04 18:45:16 -07:00
178511ff92
Merge pull request #5158 from tanjunchen/fix-up-typo
...
fix-up typo
2019-09-04 17:49:17 -07:00
7fcca2e075
Merge pull request #5118 from systay/span_over_mysql
...
Make it possible to send span context over the MySQL end point
2019-09-04 17:48:40 -07:00
bbb32fe247
vreplication: refactor table_plan_builder
...
Unify the code path for wildcard and exact table name matches.
The diverging paths have been a source of bugs.
This unification will also help with the next feature that will
allow us to exclude tables in the filtering rules.
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
2019-09-04 11:43:16 -07:00
5b111fe6bd
Empty push
...
Signed-off-by: Morgan Tocker <tocker@gmail.com>
2019-09-04 11:56:17 -06:00
4c8a888b05
fix-up typo
...
Signed-off-by: chentanjun <2799194073@qq.com>
2019-09-05 00:20:10 +08:00
fb4eec3e3d
Add go mod download to Docker base
...
Signed-off-by: Morgan Tocker <tocker@gmail.com>
2019-09-04 09:31:43 -06:00
6f791c7a03
replication_reporter: Don't try to reparent to yourself.
...
We've seen it happen that a master tablet restarts and becomes a
replica. If the shard record still says we are master, we might end up
trying to reparent to ourselves.
I don't know yet how the tablet is getting forced to replica type, but
in any case we should enforce the invariant that we don't try to
reparent to ourselves.
Signed-off-by: Anthony Yeh <enisoc@planetscale.com>
2019-09-03 23:47:15 -07:00
ce89f736be
Merge pull request #5156 from vitessio/revert-5155-jontirsen/2019-09-04/no-dns-cache
...
Revert "Don't cache Zookeeper DNS"
2019-09-03 22:45:49 -07:00
189f5eb321
Revert "Don't cache Zookeeper DNS"
2019-09-04 15:36:39 +10:00
985695fd05
Fix CI test failing
...
Signed-off-by: Morgan Tocker <tocker@gmail.com>
2019-09-03 22:09:48 -06:00
ccdb796b2b
Make sure to use the timeout context
...
Signed-off-by: Andres Taylor <antaylor@squareup.com>
2019-09-04 05:49:54 +02:00
fb434bdff0
Merge pull request #5155 from tirsen/jontirsen/2019-09-04/no-dns-cache
...
Don't cache Zookeeper DNS
2019-09-03 18:33:26 -07:00
ca686af1f9
Merge pull request #5130 from planetscale/ss-vrepl-rowstreamer-fix
...
vreplication: improved rowstreamer
2019-09-03 18:31:29 -07:00
2299f941f0
Don't cache Zookeeper DNS
...
Make sure we re-resolve the DNS name every time we reconnect to a
server. In environments where DNS changes often such as Kubernetes we
can't cache the IP address.
Signed-off-by: Jon Tirsen <jontirsen@squareup.com>
2019-09-04 09:30:29 +10:00
45fb488af4
vtbackup: Stop slave before trying to change master address. ( #5153 )
...
Signed-off-by: Anthony Yeh <enisoc@planetscale.com>
2019-09-03 14:57:38 -07:00
1575b10012
Merge remote-tracking branch 'upstream/master' into morgo-new-go-modules
...
Signed-off-by: Morgan Tocker <tocker@gmail.com>
2019-09-03 15:11:10 -06:00
2172ab91c9
Changed error checking in uintTimesUintWithError() in arithmetic.go
...
Signed-off-by: Rasika Kale <rasika@planetscale.com>
2019-09-03 10:48:49 -07:00
971323bee6
Merge pull request #5150 from systay/fix-5148
...
Handle more situations with empty results and no grouping keys
2019-09-03 07:50:35 -07:00
d5860b312c
Handle more situations with empty results and no grouping keys
...
Fixes #5148
Signed-off-by: Andres Taylor <antaylor@squareup.com>
2019-09-02 04:23:42 +02:00
4dfa6a5478
Fixed error checking for overflow of integer multiplication
...
Signed-off-by: Rasika Kale <rasika@planetscale.com>
2019-08-30 16:43:12 -07:00
40af468221
vreplication: address review comments
...
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
2019-08-30 16:00:00 -07:00
1141f5ae4b
Deleted extra comments and tests in arithmetic.go and arithmetic_test.go
...
Signed-off-by: Rasika Kale <rasika@planetscale.com>
2019-08-30 14:54:49 -07:00
bbb4f977c8
Merge remote-tracking branch 'origin/master' into rk-newminus
...
Signed-off-by: Rasika Kale <rasika@planetscale.com>
2019-08-30 14:07:20 -07:00
79a22da759
Merge remote-tracking branch 'upstream/master' into morgo-new-go-modules
...
Signed-off-by: Morgan Tocker <tocker@gmail.com>
2019-08-30 12:52:33 -06:00
0a1a9afe48
Fixed arithmetic.go and arithmetic_test.go through comments via github
...
- Added intMinusUintWithError() in arithmetic.go
- Fixed error checking in arithmetic.go for intMinusIntWithError()
Signed-off-by: Rasika Kale <rasika@planetscale.com>
2019-08-30 11:22:47 -07:00
4d8a6a90c9
Change to use tools/tools.go for go get dependencies
...
Signed-off-by: Morgan Tocker <tocker@gmail.com>
2019-08-30 10:44:56 -06:00
74ae4e2806
Merge pull request #5141 from kalfonso/kalfonso.190828-later-vschema-keyspace
...
Execute "ALTER VSCHEMA" statements without specifying keyspace in the…
2019-08-29 20:35:45 -07:00
7d77f7d8ed
Merge pull request #5139 from tinyspeck/vtexplain-support-select-distinct
...
vtexplain support select distinct and other expressions
2019-08-29 19:18:03 -07:00
3ce4e0584d
Merge pull request #5149 from adsr/imm_handshake_err
...
Handle case where mysqld replies to Initial Handshake Packet with an ERR packet
2019-08-29 19:16:43 -07:00
f2ff0ae813
Merge pull request #5147 from planetscale/vtbackup-init
...
vtbackup: Make initial backup idempotent again.
2019-08-29 19:12:45 -07:00
f68189a7e8
Merge pull request #5144 from ConnorBarnhill/bugfix/orchestrator
...
Bugfix: Helm chart parse error when enabling orchestrator
2019-08-29 19:10:33 -07:00
67e3113643
Merge pull request #5146 from adsr/master
...
Fix bug in `sqlparser.Preview`
2019-08-29 19:04:03 -07:00
fc1ad423ba
Execute "ALTER VSCHEMA" statements without specifying keyspace in the target connection.
...
If the keyspace is not present in the target string, it will be derived in this case from the vindex and table qualifiers in the vschema sql statements
Signed-off-by: Karel Alfonso Sague <kalfonso@squareup.com>
2019-08-30 10:33:11 +10:00
7504082368
Handle case where mysqld replies to Initial Handshake Packet with an ERR packet.
...
From mysql docs:
```
It starts with the client connect()ing to the server which may send a
ERR packet and finish the handshake or send a Initial Handshake
Packet...
```
`sql_state` fields are skipped because they are not set according to docs.
```
Note
In case the server sent a ERR packet as first packet it will happen
before the client and server negotiated any capabilities. Therefore
the ERR packet will not contain the SQL-state.
```
Signed-off-by: Adam Saponara <as@php.net>
2019-08-29 18:35:05 -04:00
880072cc8f
Prioritize executable comment in `sqlparser.Preview`
...
Signed-off-by: Adam Saponara <as@php.net>
2019-08-29 18:03:10 -04:00
3a05a41b9f
vtbackup: Make initial backup idempotent again.
...
The check for a complete backup already existing was supposed to make
the initial backup idempotent, such that running it after an initial
backup already exists will simply do nothing and return success.
However, that property was broken when I added the check for serving
tablets above the check for a complete backup. I should have kept the
check for a complete backup first, because if there's already a complete
backup and we're doing nothing, then it's fine that some tablets may
already be serving.
Signed-off-by: Anthony Yeh <enisoc@planetscale.com>
2019-08-29 10:11:20 -07:00
Rasika Kale
Morgan Tocker
Sugu Sougoumarane
Jon Tirsen
Adam Saponara
chentanjun
Anthony Yeh
Jon Tirsen
Andres Taylor
Karel Alfonso Sague