This optimization would not pick up version changes (e.g. when we
upgrade the vendor'd "github.com/golang/protobuf/protoc-gen-go" repo
copy by running bootstrap.sh) and unnecessarily introduce confusion.
Without the optimization, "make proto" won't be slowed down noticeable
when the plugin was already installed.
Note that I have to copy the code from the vendor/ directory to $GOPATH because "govendor" currently has no command like "restore" which "godep" did have.
Add `--docker` flag to run preview/publish without needing to set up
Ruby or Jekyll:
``` sh
vitess$ ./preview-site.sh --docker
vitess$ ./publish-site.sh --docker
```
Before this, the command always succeeded, even if races were found.
I'm grepping over the output of go test -race to check if there is race because there is no other way to distinguish between a found race and a flaky test.
The Makefile previously listed tests explicitly for groups like
site_test and worker_test. These lists got out of date when tests were
removed from test/config.json, and the make rules broke. Now the groups
are defined in config.json itself, so there is one place to update
everything.
I can't get signals to work on the child processes launched by bash,
even if I use a helper script that explicitly signals its children.
That meant that test timeouts didn't actually terminate the test in
non-Docker mode.
We were only using bash to split the command line into args anyway.
Instead, let's just have the config give us the args pre-split.
Sending signals without bash in the way seems to work better.
(after adding a rule to build before tests).
Global build takes about 2s to build all binaries, and it saves
about 4s in one run of mysqlctl.py, so it's gonna be good!
Currently, the worker tests are hanging from time to time.
Travis kills these tests automatically after 10 minutes (of not
receiving any output). We can be more aggressive about it and kill them
ourselves after 5 minutes.
1. move common dependencies into parent pom.
2. upgrade com.google.guava to 18.0.
3. rename java build target to java_client_test.
4. fix makefile so java client test will run tests from each sub package.
We sporadically see that the worker.py test times out on Travis CI after 10 minutes. Enabling logging will give us better visibility to debug the problem.
1. Get rid of SetupCommand.java and move its logic to TestEnv.
2. Add getRpcClientFactory method in TestEnv.
3. Use setters & getters in TestEnv.
4. define vtgate.test.env and vtgate.rpcclient.factory properties in vtgate-client/pom.xml.
I removed functions from client.py because they need
to be rethought in light of the new API, but missed
removing them from client_test.py.
I've now added client_test to our integration tests
to make sure it doesn't get missed.
I'll submit this right away because it breaks import.
Alain Jobart
Michael Berlin
Anthony Yeh
Sugu Sougoumarane
Dean Yasuda
Shengzhe Yao