зеркало из https://github.com/github/vitess-gh.git
08b91ee65f
* Migrate tabletenv flags to pflags Signed-off-by: Rohit Nayak <rohit@planetscale.com> Export tabletenv flag registration so that tests that depend on some of those flags can find them. Also the change in logic using pflags allows http query handlers to be registered multiple times: added a sync.Once based fix. Signed-off-by: Rohit Nayak <rohit@planetscale.com> Fix TestTxPoolSize which requires flags to be parsed. Also parse flags with local scope in tests so that other parameters like --alsologtostderr don't cause the flag parsing to error Use _flag.ParseFlagsForTest() instead of cut/pasted code that had beena added for each test Fix TestHelpOutput Init tabletenv so that currentConfig equals defaultConfig. Remove unnecessary registration of tabletenv flags in vtadmin test since it can now find the default config values. Also added TestMain to vtadmin tests so that we can run/test individual tests Address review comments * Add new flag --queryserver_enable_settings_pool lost in merge Signed-off-by: Rohit Nayak <rohit@planetscale.com> * Move LoadTabletEnvFlags to a separate package for reuse across tests that require tabletenv flags' defaults to be setup. Signed-off-by: Rohit Nayak <rohit@planetscale.com> * Fix failing tests Signed-off-by: Rohit Nayak <rohit@planetscale.com> * Fix merge issue Signed-off-by: Rohit Nayak <rohit@planetscale.com> Signed-off-by: Rohit Nayak <rohit@planetscale.com> |
||
|---|---|---|
| .. | ||
| flagutil.go | ||
| flagutil_test.go | ||
| optional.go | ||
| sets.go | ||