vitess-gh/go
Harshit Gangal c1f79617e7
[15.0] Send errors in stream instead of a grpc error from streaming rpcs when transaction or reserved connection is acquired (#11687)
* Fix ordering when error happens during stream setup (#11592)

* Fix ordering when error happens during stream setup

When we already have an error during the stream setup, that errors needs
to be returned immediately.

Otherwise the stream will already be started and the error message is
never returned to the client and it silently looks like a success even
if it's a failure.

This in turn can result in an empty result for example when an error
would have been expected.

Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>

* Add a bunch of testing to verify stream execute behavior

Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>

Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>

* Send errors in stream instead of a grpc error from streaming rpcs when transaction or reserved connection is acquired (#11656)

* wip

Signed-off-by: Harshit Gangal <harshit@planetscale.com>

* feat: send errors in stream instead of a grpc error from streaming rpcs

Signed-off-by: Manan Gupta <manan@planetscale.com>

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Co-authored-by: Manan Gupta <manan@planetscale.com>

Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Co-authored-by: Dirkjan Bussink <d.bussink@gmail.com>
Co-authored-by: Manan Gupta <manan@planetscale.com>
2022-11-11 14:39:35 +05:30
..
acl Migrate ACL package to pflag (#11392) 2022-09-29 13:40:27 -04:00
bucketpool
bytes2
cache
cmd [15.0] Deprecate InitShardPrimary command (#11557) 2022-10-21 14:38:43 -07:00
event
exit
fileutil
flags/endtoend [15.0] Deprecate InitShardPrimary command (#11557) 2022-10-21 14:38:43 -07:00
flagutil [flagutil] Cleanup `flag` references (#11381) 2022-09-28 13:56:32 -04:00
hack
history
internal/flag Test flags: Update logic for parsing test flags to run unit tests within GoLand and to parse test flags in vtgate to allow running unit tests (#11551) 2022-10-21 13:44:35 +05:30
ioutil2
json2
jsonutil
mathstats
mysql Skip TestComparisonSemantics (#11474) (#11475) 2022-10-13 09:25:34 +02:00
netutil
pools test: deflake TestIdleTimeoutCreateFail (#11411) 2022-10-03 13:04:53 +05:30
protoutil
race
ratelimiter
sqlescape
sqltypes
stats Include stats flags in servenv so that those flags are included in the correct binary. (#11450) 2022-10-06 22:31:25 +02:00
streamlog
sync2
tb
test [15.0] Send errors in stream instead of a grpc error from streaming rpcs when transaction or reserved connection is acquired (#11687) 2022-11-11 14:39:35 +05:30
testfiles
textutil
timer
tools Back to dev mode (#11444) 2022-10-05 21:35:54 +02:00
trace
vt [15.0] Send errors in stream instead of a grpc error from streaming rpcs when transaction or reserved connection is acquired (#11687) 2022-11-11 14:39:35 +05:30
vtbench
yaml2
zk/zkctl
README.md

README.md

This directory contains all the Go code for Vitess.

Most of the packages at the top level are general-purpose and are suitable for use outside Vitess. Packages that are specific to Vitess are in the vt subdirectory. Binaries are in the cmd subdirectory.

Please see GoDoc for a listing of the packages and their purposes.

vt/proto contains the compiled protos for go, one per each directory. When importing these protos (for instance XXX.proto), we rename them on import to XXXpb. For instance:

import (
    topodatapb "vitess.io/vitess/go/vt/proto/topodata"
)