From 4450237612a183daf99e07aac3bff8c3ca340b2c Mon Sep 17 00:00:00 2001 From: Andrew Eisenberg Date: Fri, 1 Mar 2024 15:41:26 -0500 Subject: [PATCH] Add changelog note And fix linting error. --- extensions/ql-vscode/CHANGELOG.md | 1 + extensions/ql-vscode/src/databases/database-fetcher.ts | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/extensions/ql-vscode/CHANGELOG.md b/extensions/ql-vscode/CHANGELOG.md index 15cf3b357..2a7b30a1b 100644 --- a/extensions/ql-vscode/CHANGELOG.md +++ b/extensions/ql-vscode/CHANGELOG.md @@ -4,6 +4,7 @@ - Remove support for CodeQL CLI versions older than 2.13.5. [#3371](https://github.com/github/vscode-codeql/pull/3371) - Add a timeout to downloading databases and the CodeQL CLI. These can be changed using the `codeQL.addingDatabases.downloadTimeout` and `codeQL.cli.downloadTimeout` settings respectively. [#3373](https://github.com/github/vscode-codeql/pull/3373) +- Databases created from [CodeQL test cases](https://docs.github.com/en/code-security/codeql-cli/using-the-advanced-functionality-of-the-codeql-cli/testing-custom-queries) are now copied into a shared VS Code storage location. This avoids a bug where re-running test cases would fail if the test's database is already imported into the workspace. [#3433](https://github.com/github/vscode-codeql/pull/3433) ## 1.12.2 - 14 February 2024 diff --git a/extensions/ql-vscode/src/databases/database-fetcher.ts b/extensions/ql-vscode/src/databases/database-fetcher.ts index 70c6b1509..73367da91 100644 --- a/extensions/ql-vscode/src/databases/database-fetcher.ts +++ b/extensions/ql-vscode/src/databases/database-fetcher.ts @@ -370,7 +370,7 @@ async function fetchDatabaseToWorkspaceStorage( const unzipPath = await getStorageFolder(storagePath, databaseUrl); if (isFile(databaseUrl)) { - if (origin.type == "testproj") { + if (origin.type === "testproj") { await copyDatabase(origin.path, unzipPath, progress); } else { await readAndUnzip(databaseUrl, unzipPath, cli, progress);