From 46e73828328ead21408b14473992b3a32c919823 Mon Sep 17 00:00:00 2001 From: Andrew Eisenberg Date: Fri, 5 Jun 2020 13:28:41 -0700 Subject: [PATCH] Clarify log message (#430) --- extensions/ql-vscode/src/query-history.ts | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/extensions/ql-vscode/src/query-history.ts b/extensions/ql-vscode/src/query-history.ts index e4d917c67..ecbb75807 100644 --- a/extensions/ql-vscode/src/query-history.ts +++ b/extensions/ql-vscode/src/query-history.ts @@ -223,11 +223,16 @@ export class QueryHistoryManager { if (queryHistoryItem.logFileLocation) { const uri = vscode.Uri.file(queryHistoryItem.logFileLocation); try { - await vscode.window.showTextDocument(uri, { - }); + await vscode.window.showTextDocument(uri); } catch (e) { if (e.message.includes('Files above 50MB cannot be synchronized with extensions')) { - const res = await helpers.showBinaryChoiceDialog('File is too large to open in the editor, do you want to open it externally?'); + const res = await helpers.showBinaryChoiceDialog( + `VS Code does not allow extensions to open files >50MB. This file +exceeds that limit. Do you want to open it outside of VS Code? + +You can also try manually opening it inside VS Code by selecting +the file in the file explorer and dragging it into the workspace.` + ); if (res) { try { await vscode.commands.executeCommand('revealFileInOS', uri);