Handle query directory not existing

Also, fix some changelog notes.
This commit is contained in:
Andrew Eisenberg 2022-03-28 10:54:48 -07:00
Родитель 71aa3d145f
Коммит bb6ebe5750
2 изменённых файлов: 11 добавлений и 2 удалений

Просмотреть файл

@ -3,8 +3,8 @@
## [UNRELEASED]
- Fix a bug where the AST viewer was not synchronizing its selected node when the editor selection changes. [#1230](https://github.com/github/vscode-codeql/pull/1230)
- Open the directory in the finder/explorer (instead of just highlighting it) when running the command "Open query directory" command from the query history view. [#1235](https://github.com/github/vscode-codeql/pull/1235)
- Ensure query label changes are persisted across restarts. [#1235](https://github.com/github/vscode-codeql/pull/1235)
- Open the directory in the finder/explorer (instead of just highlighting it) when running the "Open query directory" command from the query history view. [#1235](https://github.com/github/vscode-codeql/pull/1235)
- Ensure query label in the query history view changes are persisted across restarts. [#1235](https://github.com/github/vscode-codeql/pull/1235)
## 1.6.1 - 17 March 2022

Просмотреть файл

@ -1,4 +1,5 @@
import * as path from 'path';
import * as fs from 'fs-extra';
import {
commands,
Disposable,
@ -747,6 +748,14 @@ export class QueryHistoryManager extends DisposableObject {
}
if (externalFilePath) {
if (!(await fs.pathExists(externalFilePath))) {
// timestamp file is missing (manually deleted?) try selecting the parent folder.
// It's less nice, but at least it will work.
externalFilePath = path.dirname(externalFilePath);
if (!(await fs.pathExists(externalFilePath))) {
throw new Error(`Query directory does not exist: ${externalFilePath}`);
}
}
try {
await commands.executeCommand('revealFileInOS', Uri.file(externalFilePath));
} catch (e) {