Use wider type for "reveal in model editor" (#3512)

This commit is contained in:
Shati Patel 2024-03-26 13:54:42 +00:00 коммит произвёл GitHub
Родитель 38e862c1e0
Коммит ccd53133a9
Не найден ключ, соответствующий данной подписи
Идентификатор ключа GPG: B5690EEEBB952194
4 изменённых файлов: 9 добавлений и 9 удалений

Просмотреть файл

@ -10,7 +10,7 @@ import type {
} from "../variant-analysis/shared/variant-analysis-filter-sort";
import type { ErrorLike } from "../common/errors";
import type { DataFlowPaths } from "../variant-analysis/shared/data-flow-paths";
import type { Method } from "../model-editor/method";
import type { Method, MethodSignature } from "../model-editor/method";
import type { ModeledMethod } from "../model-editor/modeled-method";
import type {
MethodModelingPanelViewState,
@ -681,7 +681,7 @@ export type FromModelEditorMessage =
interface RevealInEditorMessage {
t: "revealInModelEditor";
method: Method;
method: MethodSignature;
}
interface StartModelingMessage {

Просмотреть файл

@ -6,7 +6,7 @@ import { telemetryListener } from "../../common/vscode/telemetry";
import { showAndLogExceptionWithTelemetry } from "../../common/logging/notifications";
import type { App } from "../../common/app";
import { redactableError } from "../../common/errors";
import type { Method } from "../method";
import type { Method, MethodSignature } from "../method";
import type { ModelingStore } from "../modeling-store";
import { AbstractWebviewViewProvider } from "../../common/vscode/abstract-webview-view-provider";
import { assertNever } from "../../common/helpers-pure";
@ -163,7 +163,7 @@ export class MethodModelingViewProvider extends AbstractWebviewViewProvider<
}
}
private async revealInModelEditor(method: Method): Promise<void> {
private async revealInModelEditor(method: MethodSignature): Promise<void> {
if (!this.databaseItem) {
return;
}

Просмотреть файл

@ -36,7 +36,7 @@ import {
externalApiQueriesProgressMaxStep,
runModelEditorQueries,
} from "./model-editor-queries";
import type { Method } from "./method";
import type { MethodSignature } from "./method";
import type { ModeledMethod } from "./modeled-method";
import type { ExtensionPack } from "./shared/extension-pack";
import type { ModelConfigListener } from "../config";
@ -431,7 +431,7 @@ export class ModelEditorView extends AbstractWebview<
this.panel?.reveal();
}
public async revealMethod(method: Method): Promise<void> {
public async revealMethod(method: MethodSignature): Promise<void> {
this.panel?.reveal();
await this.postMessage({

Просмотреть файл

@ -2,7 +2,7 @@ import type { App } from "../common/app";
import { DisposableObject } from "../common/disposable-object";
import type { AppEvent, AppEventEmitter } from "../common/events";
import type { DatabaseItem } from "../databases/local-databases";
import type { Method, Usage } from "./method";
import type { Method, MethodSignature, Usage } from "./method";
import type { ModelEvaluationRun } from "./model-evaluation-run";
import type { ModeledMethod } from "./modeled-method";
import type { Mode } from "./shared/mode";
@ -58,7 +58,7 @@ interface ModelEvaluationRunChangedEvent {
interface RevealInModelEditorEvent {
dbUri: string;
method: Method;
method: MethodSignature;
}
interface FocusModelEditorEvent {
@ -285,7 +285,7 @@ export class ModelingEvents extends DisposableObject {
});
}
public fireRevealInModelEditorEvent(dbUri: string, method: Method) {
public fireRevealInModelEditorEvent(dbUri: string, method: MethodSignature) {
this.onRevealInModelEditorEventEmitter.fire({
dbUri,
method,