Merge pull request #3708 from github/koesie10/min-version-1.90

Bump minimum VS Code version for warnings
This commit is contained in:
Koen Vlaswinkel 2024-09-09 12:14:35 +02:00 коммит произвёл GitHub
Родитель f14b8cdf44 8aec438307
Коммит fba62a9dbc
Не найден ключ, соответствующий данной подписи
Идентификатор ключа GPG: B5690EEEBB952194
1 изменённых файлов: 3 добавлений и 3 удалений

Просмотреть файл

@ -300,12 +300,12 @@ const shouldUpdateOnNextActivationKey = "shouldUpdateOnNextActivation";
const codeQlVersionRange = DEFAULT_DISTRIBUTION_VERSION_RANGE; const codeQlVersionRange = DEFAULT_DISTRIBUTION_VERSION_RANGE;
// This is the minimum version of vscode that we _want_ to support. We want to update to Node 18, but that // This is the minimum version of vscode that we _want_ to support. We want to update to Node 20, but that
// requires 1.82 or later. If we change the minimum version in the package.json, then anyone on an older version of vscode will // requires 1.90 or later. If we change the minimum version in the package.json, then anyone on an older version of vscode will
// silently be unable to upgrade. So, the solution is to first bump the minimum version here and release. Then // silently be unable to upgrade. So, the solution is to first bump the minimum version here and release. Then
// bump the version in the package.json and release again. This way, anyone on an older version of vscode will get a warning // bump the version in the package.json and release again. This way, anyone on an older version of vscode will get a warning
// before silently being refused to upgrade. // before silently being refused to upgrade.
const MIN_VERSION = "1.82.0"; const MIN_VERSION = "1.90.0";
function sendConfigTelemetryData() { function sendConfigTelemetryData() {
const config: Record<string, string> = {}; const config: Record<string, string> = {};