app/appengine: delete yet more dead code

This is part of a series of CLs to clean up the build.golang.org App
Engine app in prep for it to be modernized, refactored, and replaced,
starting with deleting dead code.

Some of this was missed in CL 208319.

Updates golang/go#34744

Change-Id: I35adf4296b849dabed9d974e7eb58eeedc7d4293
Reviewed-on: https://go-review.googlesource.com/c/build/+/208397
Reviewed-by: Andrew Gerrand <adg@golang.org>
This commit is contained in:
Brad Fitzpatrick 2019-11-22 00:23:19 +00:00
Родитель 1380f86cc3
Коммит 757f20f639
6 изменённых файлов: 5 добавлений и 46 удалений

Просмотреть файл

@ -86,12 +86,10 @@ type Commit struct {
ParentHash string
Num int // Internal monotonic counter unique to this package.
User string
Desc string `datastore:",noindex"`
Time time.Time
NeedsBenchmarking bool
TryPatch bool
Branch string
User string
Desc string `datastore:",noindex"`
Time time.Time
Branch string
// ResultData is the Data string of each build Result for this Commit.
// For non-Go commits, only the Results for the current Go tip, weekly,

Просмотреть файл

@ -1,6 +0,0 @@
# To load, run ./cron.sh
- description: updates noise level for benchmarking results
url: /perflearn?update=1
schedule: every 24 hours
target: build

Просмотреть файл

@ -18,10 +18,3 @@ indexes:
properties:
- name: Time
direction: desc
- kind: Commit
ancestor: yes
properties:
- name: NeedsBenchmarking
- name: Num
direction: desc

Просмотреть файл

@ -41,19 +41,5 @@ func initHandler(w http.ResponseWriter, r *http.Request) {
// Create secret key.
key.Secret(c)
// Populate Go 1.4 tag. This is for bootstrapping the new feature of
// building sub-repos against the stable release.
// TODO(adg): remove this after Go 1.5 is released, at which point the
// build system will pick up on the new release tag automatically.
t := &Tag{
Kind: "release",
Name: "release-branch.go1.4",
Hash: "883bc6ed0ea815293fe6309d66f967ea60630e87", // Go 1.4.2
}
if _, err := datastore.Put(c, t.Key(c), t); err != nil {
logErr(w, r, err)
return
}
fmt.Fprint(w, "OK")
}

Просмотреть файл

@ -269,11 +269,6 @@ tr.subheading2 th {
padding: 2px 8px;
}
.diff-benchmark {
clear: both;
padding-top: 5px;
}
/* positioning elements */
.page {

Просмотреть файл

@ -429,10 +429,6 @@ func (s builderOrder) Less(i, j int) bool {
}
func builderPriority(builder string) (p int) {
// Put -temp builders at the end, always.
if strings.HasSuffix(builder, "-temp") {
defer func() { p += 20 }()
}
// Group race builders together.
if isRace(builder) {
return 2
@ -450,9 +446,6 @@ func isRace(s string) bool {
}
func unsupported(builder string) bool {
if strings.HasSuffix(builder, "-temp") {
return true
}
return unsupportedOS(builderOS(builder))
}
@ -688,7 +681,7 @@ func builderSpans(s []string) []builderSpan {
for len(s) > 0 {
i := 1
os := builderOSOrRace(s[0])
u := unsupportedOS(os) || strings.HasSuffix(s[0], "-temp")
u := unsupportedOS(os)
for i < len(s) && builderOSOrRace(s[i]) == os {
i++
}