• The /auth subdirectory wasn't downloading content from GCS.
• The zip extraction logic was failing for zip files that do not
contain explicit directory entries.
• The invocation of http.FileServer wasn't trimming the /auth prefix,
so rejections would work correctly but successful authentication
would return 404s instead of serving the file.
Updates golang/go#26232
Change-Id: I3a72d7dfca62435c53f4bc7efaebae3900f2c175
Reviewed-on: https://go-review.googlesource.com/c/build/+/170880
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Jay Conrod <jayconrod@google.com>
Make exp off by default, as it barely passes anywhere. Lock in the
places where it does pass.
Also disable x/net master combined with Go 1.11 on FreeBSD 32-bit. It
doesn't work on our builders and it'll never be fixed (we're not going
to make changes to Go 1.11) and there's resistance to skipping those
tests (my CL 170777), so I'm just turning off the builder. That's not
ideal, but it's better than people getting used to red on the
dashboard.
Fixesgolang/go#31221
Change-Id: Id0228e4b0ee73715a0c2da84f68dcfc989a48aaf
Reviewed-on: https://go-review.googlesource.com/c/build/+/170782
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
It was previously master, Go 1.11, then Go 1.12, which puts Go 1.11 in
the middle of two things that came after it.
Change-Id: I5c67bff7f0ab4269f1db3d4c7e8197df36dc12cb
Reviewed-on: https://go-review.googlesource.com/c/build/+/170779
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
This endpoint will be used for integration testing golang/go#26232.
Updates golang/go#26232
Change-Id: I70cab336b885b82abfe8b77839bc9163600f15b0
Reviewed-on: https://go-review.googlesource.com/c/build/+/170581
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Jay Conrod <jayconrod@google.com>
Ignore whitespace before/after buildkeys in ~/.gobuildkey. It worked
in the past because this was only sent in HTTP headers where net/http
cleaned it. But once we also started sending it in HTTP Basic Auth
headers (where it's base64'ed), the newlines then made it to the
server where it didn't match.
So also clean it in the server for old clients.
Fixesgolang/go#30749
Change-Id: I2d9b56909a0f616da670f4e41e63701a0872dff2
Reviewed-on: https://go-review.googlesource.com/c/build/+/170621
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
The plan9 port doesn't need to be tested against older Go releases.
Its userbase runs at master.
Change-Id: I710d98560b234c7555c7be526aa2efdb6473c439
Reviewed-on: https://go-review.googlesource.com/c/build/+/170519
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Exp is experimental. It's hard enough keeping it passing on master.
We're not going to fight release branches as well. If somebody wants
to see test coverage against three versions of Go, they can graduate
their code out of experimental.
Change-Id: I4695ce479c47bd56a4a58dba05d367d3de020c58
Reviewed-on: https://go-review.googlesource.com/c/build/+/170518
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Apparently Josh's intuition in CL 170339 was correct. We do need sudo.
Sometimes. It's weird. It works without sudo with gomote, but not
during start-up. The environment is slightly different.
In any case, sudo works. Verified on macOS 10.10, 10.11, 10.12, and 10.14.
Updates golang/go#31123
Change-Id: Idc4ace816a5d8e19bbb124663ca186fdf74b188c
Reviewed-on: https://go-review.googlesource.com/c/build/+/170438
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
This change adds support to generate amd64 Plan 9
image. Consequently the "plan9-386" directory was
renamed "plan9". The script handles either the
"386" or the "amd64" parameter to build the image.
This change also adds the possibility to chose to
build the image for QEMU or GCE by passing either
the "qemu" or the "gce" parameter.
Change-Id: Ic5aced903e0d1e7baa4ae7df2167c4d54cd6a66b
Reviewed-on: https://go-review.googlesource.com/c/build/+/4904
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Fixes a TODO that this was untested. (It used to be scattered all over
and hard to test, but now we have all the policy behind a single
method, so test it.)
And add tests for golang/go#29509 too, which seems like it should work.
Change-Id: I6d1f517e2014766c26538193c6b42106a4078a9b
Reviewed-on: https://go-review.googlesource.com/c/build/+/170398
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Don't assume that all repos have import path starting with "golang.org/x/".
Add a new func instead.
But in one place (finding GOPATH deps), just hard-code the old
behavior of only looking for golang.org/x/ deps. That code will be
deleted soonish anyway, so no point cleaning it up.
Fixesgolang/go#30852
Change-Id: Ic657549832da71d3915439875e456f323cf5ebdf
Reviewed-on: https://go-review.googlesource.com/c/build/+/170417
Reviewed-by: Bryan C. Mills <bcmills@google.com>
While debugging golang/go#25386 I found that the firewall defaulting
to on made debugging modules hard. So make gomote default to
no outbound firewall and make it opt-in for people who
want to reproduce the builder more.
Also in this CL: start to use server's builder config, not local state
(follow up to CL 169678 which was incomplete). It's still incomplete
in this CL, but there's now a panic with more useful information to
users telling them to update their binary.
Updates golang/go#30929
Change-Id: I17bded71919af1e7a9181866a1349eb72da40051
Reviewed-on: https://go-review.googlesource.com/c/build/+/170397
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Turns out I broke the linux-amd64 builder after CL 170282 because it
hadn't been deployed in a long time and there must've been some
refactoring in the Dockerfile meanwhile that didn't quite work.
Perhaps the --no-install-recommends was a recent addition and we were
previously getting the "netbase" package implicitly.
In any case, we need netbase to get /etc/services.
Deployed this & builds work again.
Change-Id: I9564d40a6bfe6f2606dafab10d66ffb914fcce18
Reviewed-on: https://go-review.googlesource.com/c/build/+/170283
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
We have limited Mac resources. It's not worth wasting time testing
portable things on them.
Change-Id: Iaaa1d02582da7f8435217fbb32dcb7235c560a41
Reviewed-on: https://go-review.googlesource.com/c/build/+/169681
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
There were some copy-paste mistakes affecting the documentation of
these two identifiers. This change corrects that.
Change-Id: Ic619f19c4a659a9357c816ff7fb6b0cd7b3bccd1
Reviewed-on: https://go-review.googlesource.com/c/build/+/169437
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
As of CL 169198 for golang/go#31040, the coordinator no longer supports
placing the x/tools files out for Go 1.11 and Go 1.12's cmd/vet/all to
find, so their misc-vet-vetall builds will start failing.
We could in theory still either backport CL 169237 to
release-branch.go1.11 and release-branch.go1.12, and/or we could keep
running the misc-vet-vetall builder for the future Go 1.13 release
branch, but it's not obviously even worth it; the vetall builder is
most useful during development anyway. The tree is pretty stable once
it's release branch time. The main use of misc-vet-vetall is catching
assembly vet failures (since go test now does most the other vet
checks), and assembly doesn't often change in release branches.
Updates golang/go#31040
Change-Id: I7b827ecbcd206f3dcf63e04cc94fb78854befd7d
Reviewed-on: https://go-review.googlesource.com/c/build/+/169339
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
No network support yet. But this implements the basic FUSE support
reading from a local stargz file.
Updates golang/go#30829
Change-Id: I342e957b3b36cded5aec8b1cdca65c3f5e788db3
Reviewed-on: https://go-review.googlesource.com/c/build/+/168799
Reviewed-by: Maisem Ali <maisem@google.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
And in testing converting the Debian base layer I found a hard link,
so add enough hardlink support (mostly in TODO form) for the tool to
run for now. Proper hardlink support later.
Size stats:
-rw-r--r-- 1 bradfitz bradfitz 51354364 Mar 3 03:32 debian.tar.gz
-rw-r--r-- 1 bradfitz bradfitz 55061714 Mar 21 20:37 debian.stargz
About 7.6% bigger. (Acceptable)
Updates golang/go#30829
Change-Id: I4d76850be68d32ea6e8c2bd81c4233df1b5fc7af
Reviewed-on: https://go-review.googlesource.com/c/build/+/168737
Reviewed-by: Jon Johnson <jonjohnson@google.com>
And add a test that indirectly verifies that the BuildConfig and
HostConfig are JSON serializable. They weren't due to an exported func.
But that exported func shouldn't be exported, so unexport it and move
more policy into dashboard/builders.go. (There's been a number of
recent cleanup CLs to move all policy into dashboard/builders.go
instead of sprinkled all over the coordinator)
A future CL will use this JSON in gomote create.
Updates golang/go#30929
Change-Id: I726eaf6a4f3eeaab27d31e2642cb7642111ccd67
Reviewed-on: https://go-review.googlesource.com/c/build/+/168341
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
This seems to be the last builder still using the old builder
binary and not buildlet. It needs an entry in here to switch
to buildlet and stage0.
Change-Id: If2fdd2298ab88d56b6850061050caf27ca7c8983
Reviewed-on: https://go-review.googlesource.com/c/build/+/168061
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
By now, there's no more need to be able to serve requests over http
instead of https, so start always redirecting to https instead.
Fixesgolang/go#27870
Change-Id: I257ce732597839dc511c3e9ce440340494c62191
Reviewed-on: https://go-review.googlesource.com/c/build/+/168138
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
It's convenient to be able to build and run tests for cmd/coordinator
on macOS, in addition to Linux. Add the build tags and make appropriate
changes to the README to document the level of support.
I've tested running locally on macOS and the limited basic functionality
seems to work okay. If there's something specific that doesn't work on
macOS but works on Linux, we can update the README accordingly.
Start using go run instead of go install to combine two commands into
one. If someone prefers to use go install and run the installed binary,
they can infer the instructions to do so from the go run command.
Change-Id: I823b21a8c790c77045638b53c204ce10b60f40b2
Reviewed-on: https://go-review.googlesource.com/c/build/+/168137
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
It's not important to run the new "reboot" bootstrapping test on all
builders; a few is fine. Skip it on plan9-arm, etc, and on trybots that aren't
super widely sharded.
Change-Id: I35d5408eb5e034f42df5976f2b9b7f7d478d580a
Reviewed-on: https://go-review.googlesource.com/c/build/+/167998
Reviewed-by: David du Colombier <0intro@gmail.com>
The NetBSD builders apparently have a tiny filesystem.
And this test doesn't need to be run everywhere. A few builders is enough.
Fixesgolang/go#30839
Change-Id: I60df10173112ef9957c0e4cd6d414a4c5efaa940
Reviewed-on: https://go-review.googlesource.com/c/build/+/167637
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Bryan C. Mills
Brad Fitzpatrick
Elias Naur
David du Colombier
Rebecca Stambler
Dmitri Shuralyov
Yuval Pavel Zholkover
Benny Siegert