Otherwise, if we use debugnewvm with credentials for a standard
service account, the server rejects the instance creation request with
“Empty or missing scope not allowed.”
Change-Id: Id7546636edcce7e2b3f25b56c75e6dedf0887520
Reviewed-on: https://go-review.googlesource.com/110615
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
cmd/go takes ~188 seconds on windows-amd64, which is over the
default 180 second limit. Bump up the timout rate.
Change-Id: Ib0e5289ab6c4d6127d18375e3a72453818b984a8
Reviewed-on: https://go-review.googlesource.com/110415
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Currently "go test" on tip fails because there's no argument passed
for Printf.
Change-Id: I66a028bcb0f10f106c0dcc9643ba878363521127
Reviewed-on: https://go-review.googlesource.com/109458
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
There is a reasonable use case for going back and backporting a fix for
a closed issue, or the user might have forgotten to open the backport
issues sooner.
Change-Id: I5b9afd10764c7b1438f163ff512ec1e2961b1afa
Reviewed-on: https://go-review.googlesource.com/108915
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
The mismatch in the prefix search made gopherbot always try to open
issues, but the duplicate issue safety engaged.
Also tweak the language a bit.
Change-Id: I26b3aa02b9a3a041bee2343097a535dfacf85d08
Reviewed-on: https://go-review.googlesource.com/108835
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
From the "gcloud docker" output:
WARNING: `gcloud docker` will not be supported for Docker client
versions above 18.03. Please use `gcloud auth configure-docker` to
configure `docker` to use `gcloud` as a credential helper, then use
`docker` as you would for non-GCR registries.
Not adding "gcloud auth configure-docker" to the Makefiles as it spams
and there are implicit required authentication steps already anyway.
Change-Id: I5bd1177e82d30a6590126a307bee01d0acee9d6a
Reviewed-on: https://go-review.googlesource.com/108560
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Make sure dry-run does not require credentials, logs the skipped action,
and is applied uniformly.
Also, add instructions on how to use it from Docker.
Change-Id: I05ed681f7dd070e68a85638bf08fc7ee4a7705b6
Reviewed-on: https://go-review.googlesource.com/108235
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
It was working because the key that exists is the last one.
Change-Id: I632bf7fdecc5124f4f1e2f8297daed7493771bf1
Reviewed-on: https://go-review.googlesource.com/108176
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
They didn't compile before when added in CL 103856
Fixesgolang/go#24874
Change-Id: I9bf547248d1cdaa84c8e5f4a299a2efcc93e37c9
Reviewed-on: https://go-review.googlesource.com/107303
Reviewed-by: Andrew Bonventre <andybons@golang.org>
The Docker build didn't have the x/time/rate dependency. Also run Go
1.10 instead of Go 1.8.
Verified that this works by building the Dockerfile locally.
Change-Id: Id55bbb3e8cb81ba112351d4558a318939c22d8a5
Reviewed-on: https://go-review.googlesource.com/106985
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
They were of type GitCommit, but we want to hang the useful methods
off the existing GerritMeta wrapper.
This was the plan earlier (when the GerritMeta type was added), but
that earlier CL didn't go all the way and convert callers.
This will likely break some maintner-using code, but there aren't many
callers.
Also, document & enforce that Meta & Commit are always non-nil when
enumerating CLs and when looking up CLs. Previously, two deleted CLs
didn't have this property, as the Gerrit server was returning a ref
for a version of the commit, but no meta ref. Filter those out.
Fixesgolang/go#22060Fixesgolang/go#21984
Change-Id: I67727977c7a25e750f51a6ff7f3e00aaf960ef9f
Reviewed-on: https://go-review.googlesource.com/107296
Reviewed-by: Dmitri Shuralyov <dmitri@shuralyov.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Also update deps to pull in golang.org/x/time/rate for maintner.
Change-Id: I67ceef2eb16ccc0ce3ae4da8e8e07c07c1a8825f
Reviewed-on: https://go-review.googlesource.com/106916
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
GitHub gets upset when you send it too many requests. We do have some
backoff, but it's handled per-repo, rather than across all GitHub
requests. This adds a global GitHub limiter to add more control.
Change-Id: I42898d25cf66a93970d96e922743b766f9a21c3f
Reviewed-on: https://go-review.googlesource.com/101919
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Issue golang/go#22852 modifies formatting for Go tables. If the
code stays as is, users running Go 1.9 will format the file one way
and users running tip will format the file a different way. This is
problematic when git-codereview attempts to check the file is gofmt'ed
correctly, and does not let you mail commits that aren't.
Adding another newline makes the file compatible with tip and the
stable release branch and avoids this problem.
Change-Id: I0dbfe01db6e07578993e793e3710702ff2518436
Reviewed-on: https://go-review.googlesource.com/104836
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Load style.css so we share some styles with the Go Build Coordinator
homepage. Add some custom styles so text in tables is a little bigger
- there's less of it on the trybot page.
Instead of formatting to the nearest tenth of a minute, we can round
to the nearest second - Duration.Round() is now two Go versions old
- and use more natural duration formatting.
Instead of issuing many small writes to the ResponseWriter, write HTML
to a buffer and then write it to the ResponseWriter all at once. (We
should just use a template but that's a bigger project.)
Add a "/try-dev" handler you can enable with the `-dev` build tag
which makes it easy to view and test the "trybot status" page locally,
without requiring a builder.
Change-Id: I28617d02ed857c28d2bb2d9ccfb05ca9dc572212
Reviewed-on: https://go-review.googlesource.com/103870
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
The error value returned from os.Stat call was not being checked.
This change fixes that.
Change-Id: I640c59275aa7adf21fa5ba52e1d114473ff3c82d
Reviewed-on: https://go-review.googlesource.com/103855
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
It now expects an int64 for the id.
Fixesgolang/go#24598
Change-Id: I40ac273087234bcf5d8726e8e4dce6350fa562ac
Reviewed-on: https://go-review.googlesource.com/103475
Reviewed-by: Kevin Burke <kev@inburke.com>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Replace our current builder pattern (Dockerfile.0) in favor
of multi-stage builds. This simplifies maintenance by not
having builder artifacts exist outside of the image, reducing
the number of files to maintain and steps to take in the Makefile.
Change-Id: I5c90acc3ed4a302bd8d0850ed0ffe243c07a6c08
Reviewed-on: https://go-review.googlesource.com/99557
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Allow any origin to make cross-origin requests to get builder
statuses.
Also fixes a bug with an ineffectual Header().Set(...) call since
WriteHeader was called before it.
Change-Id: Ic2867624a286dad7268ddb94c3bb5afb52bf84ac
Reviewed-on: https://go-review.googlesource.com/98995
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Pull requests are now in the maintner corpus via *maintner.GitHubIssue.
We don't want to count them as issues, since they're not issues in a
strict sense.
Follows https://golang.org/cl/69590
and ecd998cade.
Change-Id: Ia89e89e263626e661633f888c24070073f6fe567
Reviewed-on: https://go-review.googlesource.com/97797
Run-TryBot: Dmitri Shuralyov <dmitri@shuralyov.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
This reverts the status changes to devapp from CL 96416
This will go into its own server instead.
Updates golang/go#21315
Updates golang/go#22603
Change-Id: Icb17a5915124241b2ef97a1ee2e9a0e4298784ce
Reviewed-on: https://go-review.googlesource.com/97516
Reviewed-by: Andrew Bonventre <andybons@golang.org>
Instead of checking only against the last revision of a GitHub PR,
check to see if the Gerrit commit message matches that of the one
determined by the PR, which is the source of truth due to
GerritBot’s one-way nature.
Also deletes some dead code and adds a dry-run flag.
Fixesgolang/go#23756
Change-Id: Ib2f93ebaf3f6af274f62d0e6b1e8bcab89fb7109
Reviewed-on: https://go-review.googlesource.com/96999
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Bryan C. Mills
Andrew Bonventre
Filippo Valsorda
Kevin Burke
Brad Fitzpatrick
Emil Hessman
Chris Broadfoot
Felix Kollmann
Felix Kollmann
Dmitri Shuralyov
Filippo Valsorda