mergeIDs makes the assumption that the first email seen for a
gopher is the one used for Gerrit. In the last update to gophers.go,
the first email for Filippo was changed to be invalid, causing
errors when automatic assignment was attempted in gopherbot.
Update golang/go#31919
Change-Id: Ief9115d1aed8ab998e92cfed792444d1a6463df8
Reviewed-on: https://go-review.googlesource.com/c/build/+/176037
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
The Googler field is determined via heuristics and represents whether
the person is known to be at Google now or has been in the past. It
can be used for gathering statistics about contributions that are
internal or external, but not for security related checks.
Make this more clear by documenting the field.
Change-Id: I966d3fa7a107c2db7b6898084db22a1d064c87cc
Reviewed-on: https://go-review.googlesource.com/c/build/+/175198
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Move rsc and iant to secondary for cmd/go (to reduce CC and
review-spam for them).
Updates golang/go#27586
Change-Id: I0601d4b50202708726a666d774413d90452c02cd
Reviewed-on: https://go-review.googlesource.com/c/build/+/171036
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
This change updates information related to mikioh to ensure hitless
switching; I'll delete the account mikioh.mikioh soon.
Change-Id: Id29705e59b12ca4633f700bd1303dbb7ac08b823
Reviewed-on: https://go-review.googlesource.com/c/144877
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
CL 132995 made a lot of changes to the gophers table based on
the output of gopherstats -mode=find-gerrit-gophers, which is
a new cmd/gopherstats mode added in that very CL.
The current implementation of Person.mergeIDs makes it so that
the first email seen is considered the Gerrit email.
Many of the additions of CL 132995 did not take that into account,
causing the Gerrit field to change for some gophers incorrectly.
Overall, that CL caused the following changes to gophers:
Github field changes:
tal@whatexit.org: GitHub="" -> "TomOnTime"
Carl Henrik Lunde: GitHub="" -> "chlunde"
Dieter Plaetinck: GitHub="" -> "Dieterbe"
Diogo Pinela: GitHub="" -> "dpinela"
Frank Schroeder: GitHub="" -> "magiconair"
Gregory Man: GitHub="" -> "gregory-m"
Jan Berktold: GitHub="" -> "JanBerktold"
Jean de Klerk: GitHub="" -> "jadekler"
Josselin Costanzi: GitHub="" -> "josselin-c"
Martin Garton: GitHub="MartinGarton" -> "mjgarton"
Matt Harden: GitHub="" -> "nerdatmath"
Michael Darakananda: GitHub="" -> "pongad"
Mostyn Bramley-Moore: GitHub="" -> "mostynb"
Nicholas Maniscalco: GitHub="" -> "nicholasmaniscalco"
Roland Illig: GitHub="" -> "rillig"
Yasha Bubnov: GitHub="" -> "ybubnov"
Zheng Xu: GitHub="" -> "Zheng-Xu"
ltnwgl: GitHub="" -> "gengliangwang"
oiooj: GitHub="" -> "oiooj"
thoeni: GitHub="" -> "thoeni"
Gerrit field changes:
Andrew Bonventre: Gerrit="andybons@golang.org" -> "365204+andybons@users.noreply.github.com"
Carl Mastrangelo: Gerrit="notcarl@google.com" -> "carl.mastrangelo@gmail.com"
Chris McGee: Gerrit="sirnewton_01@yahoo.ca" -> "newton688@gmail.com"
Eric Lagergren: Gerrit="ericscottlagergren@gmail.com" -> "eric@ericlagergren.com"
Filippo Valsorda: Gerrit="filippo@golang.org" -> "6195@62eb7196-b449-3ce5-99f1-c037f21e1705"
Guillaume J. Charmes: Gerrit="guillaume@charmes.net" -> "gcharmes@magicleap.com"
Harshavardhana: Gerrit="hrshvardhana@gmail.com" -> "harsha@minio.io"
Jean de Klerk: Gerrit="jadekler@gmail.com" -> "deklerk@google.com"
Joe Tsai: Gerrit="joetsai@google.com" -> "joetsai@digital-static.net"
Martin Möhrmann: Gerrit="moehrmann@google.com" -> "martisch@uos.de"
Matthew Dempsky: Gerrit="mdempsky@google.com" -> "matthew@dempsky.org"
Olivier Poitrey: Gerrit="rs@dailymotion.com" -> "rs@netflix.com"
Paul Jolly: Gerrit="paul@myitcv.org.uk" -> "paul@myitcv.io"
Ralph Corderoy: Gerrit="ralph@inputplus.co.uk" -> "ralph.corderoy@gmail.com"
Raul Silvera: Gerrit="rsilvera@google.com" -> "rauls5382@gmail.com"
Richard Miller: Gerrit="miller.research@gmail.com" -> "millerresearch@gmail.com"
Sebastien Binet: Gerrit="seb.binet@gmail.com" -> "binet@cern.ch"
Tobias Klauser: Gerrit="tobias.klauser@gmail.com" -> "tklauser@distanz.ch"
Vitor De Mario: Gerrit="vitordemario@gmail.com" -> "vitor.demario@mendelics.com.br"
Googler field changes:
Aaron Kemp: Googler=false -> true
Jason Hall: Googler=false -> true
Jean de Klerk: Googler=false -> true
(It also caused many emails to be added, but I'm not considering
those changes since they're not relevant to golang/go#27517 and
aren't causing harm.)
All of the Github and Googler field changes are good,
but not all of the Gerrit field changes are good.
I've manually checked them against the
go-review.googlesource.com Gerrit server,
and classified them as follows:
bad Andrew Bonventre: Gerrit="andybons@golang.org" -> "365204+andybons@users.noreply.github.com"
bad Carl Mastrangelo: Gerrit="notcarl@google.com" -> "carl.mastrangelo@gmail.com"
ok Chris McGee: Gerrit="sirnewton_01@yahoo.ca" -> "newton688@gmail.com"
bad Eric Lagergren: Gerrit="ericscottlagergren@gmail.com" -> "eric@ericlagergren.com"
bad Filippo Valsorda: Gerrit="filippo@golang.org" -> "6195@62eb7196-b449-3ce5-99f1-c037f21e1705"
bad Guillaume J. Charmes: Gerrit="guillaume@charmes.net" -> "gcharmes@magicleap.com"
bad Harshavardhana: Gerrit="hrshvardhana@gmail.com" -> "harsha@minio.io"
ok Jean de Klerk: Gerrit="jadekler@gmail.com" -> "deklerk@google.com"
bad Joe Tsai: Gerrit="joetsai@google.com" -> "joetsai@digital-static.net"
bad Martin Möhrmann: Gerrit="moehrmann@google.com" -> "martisch@uos.de"
bad Matthew Dempsky: Gerrit="mdempsky@google.com" -> "matthew@dempsky.org"
ok Olivier Poitrey: Gerrit="rs@dailymotion.com" -> "rs@netflix.com"
bad Paul Jolly: Gerrit="paul@myitcv.org.uk" -> "paul@myitcv.io"
bad Ralph Corderoy: Gerrit="ralph@inputplus.co.uk" -> "ralph.corderoy@gmail.com"
bad Raul Silvera: Gerrit="rsilvera@google.com" -> "rauls5382@gmail.com"
ok Richard Miller: Gerrit="miller.research@gmail.com" -> "millerresearch@gmail.com"
bad Sebastien Binet: Gerrit="seb.binet@gmail.com" -> "binet@cern.ch"
bad Tobias Klauser: Gerrit="tobias.klauser@gmail.com" -> "tklauser@distanz.ch"
bad Vitor De Mario: Gerrit="vitordemario@gmail.com" -> "vitor.demario@mendelics.com.br"
I considered any @google.com -> non-@google.com changes as bad.
For the rest, it was based on which email was recognized by the
Gerrit server and had more activity overall, as well as recently.
This CL undoes all the bad Gerrit field changes, reverting them
to their original pre-CL 132995 values. It also changes the Gerrit
email for Gopherbot, and cleans up my own entry. That leaves just:
Gerrit field changes:
Chris McGee: Gerrit="sirnewton_01@yahoo.ca" -> "newton688@gmail.com"
Jean de Klerk: Gerrit="jadekler@gmail.com" -> "deklerk@google.com"
Olivier Poitrey: Gerrit="rs@dailymotion.com" -> "rs@netflix.com"
Richard Miller: Gerrit="miller.research@gmail.com" -> "millerresearch@gmail.com"
In future CLs, we'll need to be careful with the order in which
emails are added, until golang/go#27631 is resolved.
Updates golang/go#27631.
Fixesgolang/go#27517.
Change-Id: I6bd289af6ea2c50c293c4576de3873658994b98a
Reviewed-on: https://go-review.googlesource.com/135456
Reviewed-by: Andrew Bonventre <andybons@golang.org>
It's perf time at Google, so it's time to answer the ol' "What Would
You Say You Do Here?" question.
So, time to update gopherstats with more stats & update the gophers
package in the process.
Change-Id: I0e0981f40a1229f943130621bd55acedffc7a583
Reviewed-on: https://go-review.googlesource.com/132995
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Andrew Bonventre <andybons@golang.org>
My primary (preferred) email has changed,
and it's also my Gerrit email now.
Change-Id: I82bb5bb48a99ae12a646eec1a2ab08966199d62d
Reviewed-on: https://go-review.googlesource.com/112995
Reviewed-by: Andrew Bonventre <andybons@golang.org>
x/tools/cmd/godoc and x/playground. I add myself as secondary to both
of them since I cannot do +2 votes, but I would like to participate in
reviews with the best of my knowledge.
Change-Id: Iedeb9320b6f76c67a9d15eb8f6f8956e4d2e2957
Reviewed-on: https://go-review.googlesource.com/112695
Reviewed-by: Andrew Bonventre <andybons@golang.org>
My e-mail address has changed.
Change-Id: I09b1d82dbf2044ab1cd7791a20e24a3e62bf87d0
Reviewed-on: https://go-review.googlesource.com/75030
Reviewed-by: Ian Lance Taylor <iant@golang.org>
it's hard to find consistent usernames with a name like Jeff Johnson
Change-Id: I66852b9266ef4ac77dc6e167dc883a28477312c3
Reviewed-on: https://go-review.googlesource.com/70090
Reviewed-by: Joe Tsai <thebrokentoaster@gmail.com>
Added drchase -> dr2chase, for ssh access
Change-Id: Id36cf3cde94f785db0202d0100d528f4f7e017f6
Reviewed-on: https://go-review.googlesource.com/56270
Run-TryBot: David Chase <drchase@google.com>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
And some cleanups in the originally-auto-generated tables used by
stats above.
Change-Id: Ie2279e1926fa05cfc124e04ce074e05df4af2a0c
Reviewed-on: https://go-review.googlesource.com/53230
Reviewed-by: Sarah Adams <shadams@google.com>
So Ian can ssh to gomote instances.
Change-Id: If03187f9038bc3753e0cc69479ce71d260409044
Reviewed-on: https://go-review.googlesource.com/53190
Reviewed-by: Ian Lance Taylor <iant@golang.org>
This adds an SSH server to farmer.golang.org on port 2222 that proxies
SSH connections to users' gomote-created buildlet instances.
For example:
$ gomote create openbsd-amd64-60
user-bradfitz-openbsd-amd64-60-1
$ gomote ssh user-bradfitz-openbsd-amd64-60-1
Warning: Permanently added '[localhost]:33351' (ECDSA) to the list of known hosts.
OpenBSD 6.0 (GENERIC.MP) golang/go#2319: Tue Jul 26 13:00:43 MDT 2016
Welcome to OpenBSD: The proactively secure Unix-like operating system.
Please use the sendbug(1) utility to report bugs in the system.
Before reporting a bug, please try to reproduce it with the latest
version of the code. With bug reports, please try to ensure that
enough information to reproduce the problem is enclosed, and if a
known fix for it exists, include that as well.
$
As before, if the coordinator process is restarted (or crashes, is
evicted, etc), all gomote instances die.
Not yet supported:
* scp (help wanted)
* not all host types are configured. most are. some will need slight
config tweaks to the Docker image (e.g. adding openssh-server)
Supports currently:
* linux-amd64 (host type shared by 386, nacl)
* linux-arm
* linux-arm64
* darwin
* freebsd
* openbsd
* plan9-386
* windows
Implementation details:
* the ssh server process listens on port 2222 in the coordinator
(farmer.golang.org), which is behind a GKE TCP load balancer.
* the ssh server library is github.com/gliderlabs/ssh
* authentication is done via Github users' public keys. It's assumed
that gomote user == github user. But there's a mapping in the code
for known exceptions.
* we can't give out access to this too widely. too many things are
accessible from within the host environment if you look in the right
places. Details omitted. But the Go team and other trusted gomote
users can use this.
* the buildlet binary has a new /connect-ssh handler that acts like a
CONNECT request but instead of taking an explicit host:port, just
says "give me your machine's SSH connection". The buildlet can also
start sshd if needed for the environment. The /connect-ssh handler
also installs the coordinator's public key.
* a new buildlet client library method "ConnectSSH" hits the /connect-ssh
handler and returns a net.Conn.
* the coordinator's ssh.Handler is just running the OpenSSH ssh client.
* because the OpenSSH ssh child process can't connect to a net.Conn,
an emphemeral localhost port is created on the coordinator to proxy
between the ssh client and the net.Conn returned by ConnectSSH.
* The /connect-ssh handler requires http.Hijacker, which requires
fully compliant net.Conn implementations as of Go 1.8. So I needed
to flesh out revdial too, testing it with the
golang.org/x/net/nettest package.
* plan9 doesn't have an ssh server, so we use 0intro's new conterm
program (drawterm without GUI support) to connect to plan9 from the
coordinator ssh proxy instead of using the OpenSSH ssh client
binary.
* windows doesn't have an ssh server, so we enable the telnet service
and the coordinator ssh proxy uses telnet instead on the backend
on the private network. (There is a Windows ssh server but only in
new versions.)
Happy debugging over ssh!
Fixesgolang/go#19956
Change-Id: I80a62064c5f85af1f195f980c862ba29af4015f0
Reviewed-on: https://go-review.googlesource.com/50750
Reviewed-by: Herbie Ong <herbie@google.com>
Reviewed-by: Jessie Frazelle <me@jessfraz.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Total mess, but a functional mess, and a starting point for the future.
Change-Id: Ifcc72660f30a0ee2692668b4ea53acd1c4015777
Reviewed-on: https://go-review.googlesource.com/41077
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Andrew Bonventre
Dmitri Shuralyov
Bryan C. Mills
Brad Fitzpatrick
Elias Naur
Mikio Hara
Dmitri Shuralyov
Filippo Valsorda
Yury Smolsky
Agniva De Sarker
Emil Hessman
Michael Munday
Jeff Johnson
Joe Tsai
David Chase