Add the windows-arm64 builder to the dashboard and coordinator with a
known issue until we can verify builds are succeeding regularly.
Also, tweak the logic around validating ec2 configurations. The arm64
buildlet sets VMImage but not ContainerImage, unlike other ec2
buildlets. This should work for both.
For golang/go#42604
Change-Id: I7176b8f6bba837830a0565e7713c9e9a0eb76e90
Reviewed-on: https://go-review.googlesource.com/c/build/+/322656
Trust: Alexander Rakoczy <alex@golang.org>
Run-TryBot: Alexander Rakoczy <alex@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
There are only 3 possible configurations for a builder: a TryBot
and a post-submit builder, a post-submit only builder, or neither.
Make all test cases in TestBuilderConfig more precise by selecting
one of those available combinations to reduce the chance of future
refactors making an unintentional configuration change.
Change-Id: I6deafa19f2a48a7b5bc576ecd20d16463f46fa93
Reviewed-on: https://go-review.googlesource.com/c/build/+/317976
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
This sets the GO_TEST_TIMEOUT_SCALE=2 for dragonfly builders in order
to try to solve intermittent test failures.
For golang/go#45215.
For golang/go#34034.
Fixesgolang/go#45216.
Change-Id: I81dae533c137ff1903bf6b1a52cf9752e8921b7c
GitHub-Last-Rev: 9b4fb8017b
GitHub-Pull-Request: golang/build#35
Reviewed-on: https://go-review.googlesource.com/c/build/+/315329
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Trust: Carlos Amedee <carlos@golang.org>
The windows/arm64 port has been completed in golang.org/issue/36439
recently. Add pre-submit compile-only coverage via a misc-compile
TryBot for the new port. It can be upgraded to a normal TryBot that
also executes tests after a windows/arm64 builder becomes available.
Tested locally by running 'buildall.bash windows-arm64' on a recent
Go tip commit (CL 313849), which passed.
For golang/go#36439.
Updates golang/go#42604.
Change-Id: Ie4988a876aa18392a583eb407c6c3621eb30a4f8
Reviewed-on: https://go-review.googlesource.com/c/build/+/314430
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Trust: Alexander Rakoczy <alex@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Between Go 1.15, 1.16 and tip, the following 29 ports don't have
a real TryBot and instead rely on misc-compile TryBots for their
pre-submit coverage:
• aix/ppc64
• darwin/amd64
• darwin/arm64
• dragonfly/amd64
• freebsd/386
• freebsd/arm
• freebsd/arm64
• illumos/amd64
• linux/mips
• linux/mips64
• linux/mipsle
• linux/mips64le
• linux/ppc64
• linux/ppc64le
• linux/riscv64
• linux/s390x
• netbsd/386
• netbsd/amd64
• netbsd/arm
• netbsd/arm64
• openbsd/386
• openbsd/arm
• openbsd/arm64
• openbsd/mips64
• plan9/386
• plan9/amd64
• plan9/arm
• solaris/amd64
• windows/arm
The previous approach for misc-compile target selection was to break
them up primarily by GOOS value. However, as new architectures were
added over time, some misc-compile TryBots got to a point where they
were testing upwards of 5 ports (for example, misc-compile-openbsd
was testing 386, amd64, arm, arm64, and mips64 architectures).
Since each port is tested sequentially, allocating too many to one
misc-compile TryBot can cause it to become the bottleneck of an
entire TryBot run, exceeding the 10 minute completion time goal.
Arrange it so misc-compile TryBot target selection is done explicitly
in x/build, and pick 3 as max number of targets per TryBot for now.
Based on recent timing observations, that should strike a decent balance
between resource use (spinning up a builder) vs chance of a misc-compile
TryBot becoming a bottleneck. It will also give us an opportunity to
compare timing of 1, 2 and 3 targets per misc-compile in the future.
(When we start tracking timing for TryBot completion time holistically,
we'll be in a better position to refine this strategy further.)
Making misc-compile target selection explicit in x/build also enables
removing unnecessary duplicate misc-compile coverage from ports that
already have a real TryBot (for example, openbsd/amd64 was previously
tested via both the openbsd-amd64-68 TryBot and misc-compile-openbsd).
This shouldn't be needed, so it's no longer done.
For golang/go#17104.
Fixesgolang/go#32632.
Change-Id: Iac918377b91af3e48780b38ffdf3153e213eeba2
Reviewed-on: https://go-review.googlesource.com/c/build/+/313210
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Some TryBot builders are disabled or configured with a custom
try policy that doesn't test the master branch of the main Go
repository. For example, openbsd-386-68 is configured with:
tryBot: explicitTrySet("sys"),
So it's only a TryBot for the x/sys repo, not the main one.
Modify TestTryBotsCompileAllPorts to not consider such TryBots
when determining whether a port has sufficient pre-submit test
coverage.
This will help in the next change which re-arranges target
selection between misc-compile TryBots.
For golang/go#32632.
Change-Id: If393610d11b04b75133a4f10f89cfdfff9dbaece
Reviewed-on: https://go-review.googlesource.com/c/build/+/313533
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Issue 39782 is closed because we have darwin-arm64 builders by now.
A misc-compile TryBot currently provides pre-submit test coverage
for the darwin-arm64 port. So remove "darwin-arm64" known missing
entry since it's obsolete.
Also improve the test to report a problem when a port is marked as
having a known missing TryBot, yet it's not actually missing. This
should help humans not forget to keep the knownMissing map updated.
Change-Id: Ic5c981a81c2e6016a56c6d872db458c98f215a0e
Reviewed-on: https://go-review.googlesource.com/c/build/+/313209
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
With this change:
- The default FreeBSD builders used on master are 11.4 and 12.2.
- The FreeBSD 12.0 builders have been removed.
- The FreeBSD 11.2 builders have been set to run on at most Go 1.16.
They will continue to be used for Go 1.16.x and 1.15.x minor releases.
- The freebsd-amd64-race builder has been updated to use the FreeBSD
12.2 host.
- The slowbot aliases for FreeBSD have been updated to use 12.2.
Fixesgolang/go#44431
Update golang/go#45727
Update golang/go#40561
Change-Id: Ib558fca65c2de1916b4633711d3e320c390bd2b2
Reviewed-on: https://go-review.googlesource.com/c/build/+/313070
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Now that GOEXPERIMENT includes regabi by default, there is a need to
make sure that the non-regabi paths for the compiler and runtime
continue to function correctly (in case for some reason we need to
turn regabi off). Switch the *-regabi builders to "noregabi" builders,
so that we have test coverage for this scenario.
Updates golang/go#40724.
Change-Id: Id5c0d4fda2f56393992c90ace463674e86b941ee
Reviewed-on: https://go-review.googlesource.com/c/build/+/313071
Trust: Than McIntosh <thanm@google.com>
Run-TryBot: Than McIntosh <thanm@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
macOS will not be supported after go1.16. This change limits the macOS
10.12 builders to build previous to go1.17.
Updates golang/go#44303
For golang/go#23011
Change-Id: Ib6b4e7939ffb9032b255574d3f0b4fffaad97803
Reviewed-on: https://go-review.googlesource.com/c/build/+/312692
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
This change adds builders for amd64 FreeBSD 11.4 and 12.2. These
builders are labeled with a known issue until they have been tested.
They will not be used in trybots until the known issue label has been removed.
Updates golang/go#44431
Change-Id: I902f2f6bd887135bf247feb1be0e0fd49f732614
Reviewed-on: https://go-review.googlesource.com/c/build/+/311869
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
The builder name was misleading, because plan9-amd64-9front
hasn't been running 9front anymore since 2016, but is running
the 9k kernel from Bell Labs.
Change-Id: I6929583b784d076a86b818649c64b821a538ed1c
Reviewed-on: https://go-review.googlesource.com/c/build/+/307409
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Trust: Carlos Amedee <carlos@golang.org>
Trust: David du Colombier <0intro@gmail.com>
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
This change removes the known issue from the darwin-amd64-11_0 builder.
Fixesgolang/go#40762
Change-Id: I9914c8153abf3b9078579e8829374ee09f84e6e3
Reviewed-on: https://go-review.googlesource.com/c/build/+/307822
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
This change updates the desired host counts for darwin amd64 hosts.
The numbers require changing because:
- Migration to the new cluster with diffrent counts for amd64
machines.
- The addition of macOS 11.0 builders.
Updates golang/go#40762
Change-Id: I4a0dfcc8bd812ede38acbb98c0b317e03059b525
Reviewed-on: https://go-review.googlesource.com/c/build/+/307474
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
This change adds linux-arm64-aws to the set of trybots. It also
removes linux-arm and linux-arm64 from the list of builds attempted in
the misc-compile-linuxarm builder.
Updates golang/go#36170Fixesgolang/go#45065
Change-Id: If25fed08e35b2a91c9c9dbbf31701ff5464dc913
Reviewed-on: https://go-review.googlesource.com/c/build/+/303232
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
This change adds linux-arm-aws to the set of trybots. The related
changes include:
- Renaming the linux-arm builder to linux-arm-scaleway.
- Adding slowbot aliases which use linux-arm-aws as the default
builder for linux-arm builds.
Fixesgolang/go#35628Fixesgolang/go#40872
Updates golang/go#45064
Change-Id: Ib49f50e03fc4f766015fdd78080b804c2784a398
Reviewed-on: https://go-review.googlesource.com/c/build/+/303230
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
This adds a builder for the GOEXPERIMENT=regabi configuration of the
compiler. We'll want this builder until we enable regabi by default.
Update comments and buildsRepo test, since it's now merged with master.
Updates golang/go#40724.
Change-Id: I424ca7bf6243e6b4660f4ec54c248a1813b3a83d
Reviewed-on: https://go-review.googlesource.com/c/build/+/305849
Trust: David Chase <drchase@google.com>
Run-TryBot: David Chase <drchase@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Austin Clements <austin@google.com>
This sets the GO_TEST_TIMEOUT_SCALE=2 for ppc64 builders. The
runtime tests have been timing out intermittently on ppc64le
power8; it has happened on ppc64 and ppc64le power9 but
very rarely.
Updates golang/go#44422
Change-Id: I663f3f211a368a59e38fbff9ce43c925c6c7a209
Reviewed-on: https://go-review.googlesource.com/c/build/+/300870
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Trust: Lynn Boger <laboger@linux.vnet.ibm.com>
This improves the selection of slowbot aliases for ppc64.
Updates golang/go#42067
Change-Id: I180fe2f49a1e44c422e64c311e601dd93b07f7a7
Reviewed-on: https://go-review.googlesource.com/c/build/+/301769
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Trust: Carlos Amedee <carlos@golang.org>
Some of README.md files were initially generated by update-readmes.go,
but later had some additional information appended. Re-running update-
readmes.go blasts away those changes, and requires manually reverting
the deletions. This makes it expensive to re-run update-readmes.go to
add new READMEs or update existing ones.
Solve this problem by adding support for a special "<!-- End of auto-
generated section -->" comment and making update-readmes.go preserve
any content after it.
After this change, re-running update-readmes.go produces a zero diff.
Also set the working directory when using build.Import so that packages
inside nested modules work okay.
Add the missing first word 'Package' to ./internal/datastore/fake doc.
Change-Id: If7ba92a297eebeec8029d48d760acb1daa7f263e
Reviewed-on: https://go-review.googlesource.com/c/build/+/300229
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
We can drop the 32-bit and 10.11 macOS builders, they're unused.
Remove FreeBSD 11.1 builder, it's unused.
Update freebsd-amd64-race to use the latest available FreeBSD builder.
Simplify build policy and comments, removing anything that mentioned
Go version 1.14 or older, since they're not relevant anymore.
Drop Go 1.14 support from minSupportedMacOSVersion, and add support
for the future Go 1.17 release, which will increase minimum macOS
version requirement to macOS 10.13.
Fixesgolang/go#40562.
Change-Id: I7beeec0952a516afe99a5154b22c7f25ceeb3da1
Reviewed-on: https://go-review.googlesource.com/c/build/+/293771
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
The Go 1.17 tree has started adding the windows/arm64 port.
Change-Id: Id9557160704688feea3667d5b18b0a37371aa0cd
Reviewed-on: https://go-review.googlesource.com/c/build/+/293772
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
This change adds macOS 11.0 Big Sur builder to the dashboard. It will
not spawn an instance on the older MacStadium cluster which we are
migrating away from. It will be marked with a known issue until until
we have migrated away from the old cluster and makemac has been
updated to process the new macOS versioning convention.
Updates golang/go#40762
Updates golang/go#40757
Updates golang/go#40761
Change-Id: I24ce615a2c0c55dd75beed4f821119d4058ad8af
Reviewed-on: https://go-review.googlesource.com/c/build/+/288192
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
The goal in CL 279512 was to reduce numTryTestHelpers from 5 to 4,
but it unintentionally set the field only in the 386 builder, not
the amd64 one. This caused the amd64 OpenBSD TryBot to get very
slow (20-25 minutes), making it very much a bottleneck for overall
TryBot completion time.
Also stop explicitly setting some fields in openbsd-amd64-62
builder that have no effect by now, to simplify configuration.
For golang/go#17104.
Updates golang/go#35712.
Change-Id: I22823e4848cab65f11bde2a1cc70527929d0792d
Reviewed-on: https://go-review.googlesource.com/c/build/+/279723
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Based on the data we have so far, 4 helpers seems like a good number
to pick. It provides a balance between resource use and diminishing
returns. We may need to adjust it as future work for issue 42661,
but a first step will be to reduce overhead in accessing historical
build timing data.
Fixesgolang/go#37439.
Updates golang/go#42661.
Change-Id: I1bfddf85f2dba8b42dc7b8f8749bbf45b614e93d
Reviewed-on: https://go-review.googlesource.com/c/build/+/279513
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
The known issue with OpenBSD 6.8 builders appears to be resolved
via CL 278732 and CL 279134. Promote them to the primary OpenBSD
post-submit builders and TryBots.
Having test coverage from OpenBSD 6.8 and 6.4 builders gives us
us more confidence that Go works on supported OpenBSD versions
(which are 6.8 and 6.7 at this time, per past policy decision
in https://golang.org/issue/15227#issuecomment-293319876).
Reduce numTryTestHelpers from 5 to 4 based on some data from
golang.org/issue/37439 showing that going from 3 to 5 helpers
doesn't make a significant difference. We can adjust further
if we learn that OpenBSD TryBots become the bottleneck.
Fixesgolang/go#35712.
For golang/go#42542.
For golang/go#42064.
Updates golang/go#42426.
Change-Id: Id2fa4be7c3161f89752c1428146846fe06ca63db
Reviewed-on: https://go-review.googlesource.com/c/build/+/279512
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Trust: Dmitri Shuralyov <dmitshur@golang.org>
This adds a builder for the GOEXPERIMENT=regabi configuration of the
compiler. We'll want this builder until we enable regabi by default.
Updates golang/go#40724.
Change-Id: Ib1c7ae1e914116dd8a4440db8ee46d6af3ed1ad6
Reviewed-on: https://go-review.googlesource.com/c/build/+/279673
Trust: Austin Clements <austin@google.com>
Run-TryBot: Austin Clements <austin@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
These images were regenerated after the fix in CL 278732.
For golang/go#35712.
Updates golang/go#42542.
Updates golang/go#42426.
Change-Id: Ib9c9dc316e4f68e7fed2cafe5400942a94ba8fd2
Reviewed-on: https://go-review.googlesource.com/c/build/+/279134
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Joel Sing <joel@sing.id.au>
The builder successfully passes all.bash and produces binary releases.
Updates golang/go#42756Fixesgolang/go#39782
Change-Id: I554a1e3541d185958103e11dcc4b2514445d8275
Reviewed-on: https://go-review.googlesource.com/c/build/+/278772
Trust: Alexander Rakoczy <alex@golang.org>
Run-TryBot: Alexander Rakoczy <alex@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
The openbsd/mips64 port is now functional and stable.
Fixesgolang/go#40995
Change-Id: I959e6ab53777a3e048d89434f60aec365b0900b4
Reviewed-on: https://go-review.googlesource.com/c/build/+/275333
Trust: Joel Sing <joel@sing.id.au>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
These builders are run by the Go team. They are non-hermetic.
For golang/go#39782
Change-Id: Ie402faf9a92ff6c667c8da6fc0dac8528331df48
Reviewed-on: https://go-review.googlesource.com/c/build/+/278432
Trust: Alexander Rakoczy <alex@golang.org>
Run-TryBot: Alexander Rakoczy <alex@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
update-readmes.go is updated to add a pkg.go.dev badge instead of a
godoc.org badge.
The GoDoc badge is added or changed in all READMEs by running
update-readmes.go
For golang/go#42251
Change-Id: I0c49df26a6c695f938c98c9a7b26325d991b3cfb
Reviewed-on: https://go-review.googlesource.com/c/build/+/276032
Trust: Julie Qiu <julie@golang.org>
Run-TryBot: Julie Qiu <julie@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
This CL changes the owner for host-linux-s390x as
Michael will be leaving IBM at the end of this week.
See https://groups.google.com/g/golang-dev/c/obUDaYbaxXw.
Change-Id: Ic140743387cff02be7c0471f803c5a30d812d0c3
Reviewed-on: https://go-review.googlesource.com/c/build/+/274512
Reviewed-by: Michael Munday <michael.munday@live.co.uk>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Trust: Michael Munday <michael.munday@live.co.uk>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
See https://golang.org/issues/40561#issuecomment-731482962
for the plan description and rationale.
Add new builder definitions that are needed for the plan.
Don't rely on generic builder name like "linux-amd64" to
avoid a repeat of golang.org/issue/31293; use a specific
builder name instead.
Remove support and test cases for Go 1.13, it's unsupported
per release policy.
For golang/go#40561.
Change-Id: I070744e15be9f1932d649a27ee7e4599e467553f
Reviewed-on: https://go-review.googlesource.com/c/build/+/276034
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
This builder has very slow I/O and could benefit from some extra time on
a few tests. At the moment, the tests for x/review/git-codereview are
failing with a time out, for example.
Updates golang/go#42925.
Change-Id: I532f4ddd3b9e7fd0a66ea9631b3fa7ce363e05a4
Reviewed-on: https://go-review.googlesource.com/c/build/+/274572
Trust: Jason A. Donenfeld <Jason@zx2c4.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
We originally left the issue attached to the builder, before we knew
that it worked. But it appears to be working well, with no shortage of
work to do from farmer.
Fixesgolang/go#38607.
Change-Id: I0e654c825a92b64132efbc409b768e5e83967802
Reviewed-on: https://go-review.googlesource.com/c/build/+/273786
Trust: Jason A. Donenfeld <Jason@zx2c4.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
This change adds the netbase package to the host. The netbase package
includes several components necessary for TCP/IP based networking.
Network related unit tests were failing on builders using this host
without this package.
Fixesgolang/go#42750
Change-Id: Id98d46efac4fe98ecf475035218be181c3d8dec0
Reviewed-on: https://go-review.googlesource.com/c/build/+/272486
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
This change adds a Debian Buster builder.
Fixesgolang/go#42410
Change-Id: If11ebe6df3bad88aac40b0a6f841edc5fb3a5b4a
Reviewed-on: https://go-review.googlesource.com/c/build/+/267937
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
This partially reverts CL 229559, while adjusting it to use a new
builder. The builder will be used now for windows/arm and later for
windows/arm64.
Updates golang/go#42604.
Updates golang/go#38607.
Updates golang/go#36439.
Change-Id: I1ab661a6585e64de8196955c077715b32dc732b8
Reviewed-on: https://go-review.googlesource.com/c/build/+/272106
Run-TryBot: Jason A. Donenfeld <Jason@zx2c4.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Trust: Alex Brainman <alex.brainman@gmail.com>
Trust: Jason A. Donenfeld <Jason@zx2c4.com>
The linux-arm-aws builder was initially labeled with a known issue
because it was experimental. The builder has been tested and is no
longer considered experimental.
Fixesgolang/go#41867
Updates golang/go#40872
Updates golang/go#35628
Change-Id: I61f43f2c2651c26d3f5d4db01b779686ddb6a92b
Reviewed-on: https://go-review.googlesource.com/c/build/+/270517
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
This change builds on top of CL 268297, using the updated env script
to build OpenBSD 6.8 images, and adding new builders that use them.
This has been tested with cmd/debugnewvm on a recent Go tip commit,
as well as Go 1.15.4 and 1.14.11 commits. It passed, although there
were also some failures seen. Once the builder is added, we'll know
the test results for a wider set of commits, and can decide how to
proceed from there.
Minimize the configuration to a bare minimum. Specifically, remove
MinCPUPlatform since setting it "Intel Skylake" was found not to
have a noticeable effect on the speed of the build compared to the
zero value:
# With MinCPUPlatform = "Intel Skylake":
$ time debugnewvm -run-build=openbsd-amd64-68 -rev=go1.15.4
[...]
real 17m8.308s
# With a zero MinCPUPlatform value:
$ time debugnewvm -run-build=openbsd-amd64-68 -rev=go1.15.4
[...]
real 16m28.518s
For golang/go#35712.
Updates golang/go#42426.
Change-Id: I517a85738a034a3a4074488ccecd4408a91a4a07
Reviewed-on: https://go-review.googlesource.com/c/build/+/269577
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
For golang/go#42426.
Change-Id: Id8a87ef1952291e06f0076f27ae019bf7ef0e6a2
Reviewed-on: https://go-review.googlesource.com/c/build/+/268880
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
This change adds the linux-arm-aws builder. This builder will be
started on a EC2 instance which will spawn a single instance
of the container. After the builder work is done, the instance will be
destroyed.
Updates golang/go#41867
Change-Id: I09d911c2f99d1dff8fe02feb458457e07e7d0cdd
Reviewed-on: https://go-review.googlesource.com/c/build/+/260797
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
The longtest builders are currently primarily post-submit builders,
where it's okay for them to be as slow as they need to be in order
to provide additional test coverage. In this context, whether they
take 40 minutes or 50 makes little difference.
The longtest builders are also sometimes requested via SlowBots for
changes that are riskier than usual, or otherwise desire additional
coverage beyond the normal TryBots. They're also always enabled for
CLs to release branches. In such contexts, speeding up SlowBot runs
from 40 minutes to 20 or less would be appreciated and in turn help
people use longtest SlowBots more frequently.
Longtest builders are already configured to use sharded tests.
Configure them to use additional helpers to speed up test execution.
Try out 3, 5, and 9 helpers to see how much it helps before settling.
For golang/go#37439.
Change-Id: I425bc0257b7a54bb32c0eb1719fea7ba3f4fd461
Reviewed-on: https://go-review.googlesource.com/c/build/+/268037
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Testing shows that misc-compile-darwinarm64 is working as expected
on recent commits. Promote it to a normal misc-compile TryBot now,
with the exception that it needs to run on Go 1.16 and newer only.
Fixesgolang/go#42341.
Change-Id: Ib4de19a2ff904fb9de056db5076ac63690eb934c
Reviewed-on: https://go-review.googlesource.com/c/build/+/267123
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
Create the builder as a post-submit builder with a non-zero KnownIssue
value first. Once we know it works well, we'll have the confidence to
be able to safely promote it to a normal TryBot, without the risk of
causing disruption for contributors.
It's different from misc-compile-darwin since it needs to run on recent
Go 1.16 commits only.
For golang/go#42341.
Change-Id: I67170988d7323cb73439755a3961532c668040e7
Reviewed-on: https://go-review.googlesource.com/c/build/+/267105
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
This change updates which source ami is used as a base for the
creation of the linux-arm64-aws builder. Packer will now search for
the latest version of the arm64 Debian image to use as the source ami.
For golang/go#36841
Change-Id: I036dbaf7ee65d4e7028cd6a0cdf6710bf898fdd2
Reviewed-on: https://go-review.googlesource.com/c/build/+/266697
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Alexander Rakoczy
Dmitri Shuralyov
Antonio Huete Jimenez
Carlos Amedee
Than McIntosh
David du Colombier
David Chase
Lynn Boger
Baokun Lee
Austin Clements
Joel Sing
Julie Qiu
Ruixin Bao
Jason A. Donenfeld
Meng Zhuo