Most of the time, fetchlogs can get by with cached maintner data.
However, rarely the data may become too stale while fetching logs,
resulting in a log entry with an unknown GoRevision.
If that occurs, it seems preferable to pay the latency hit of
reloading the maintner data than to ignore log entries or fail
completely.
Change-Id: I16298448b3b67b7f23bc73cd316c4a0552a1abec
Reviewed-on: https://go-review.googlesource.com/c/build/+/408937
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Bryan Mills <bcmills@google.com>
Auto-Submit: Bryan Mills <bcmills@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
The -branch flag can be used to download non-default branches of the
main 'go' repo, which are otherwise not included in its repo results.
Change-Id: Id501870ea24aa5509496953f734eb8bcc727548e
Reviewed-on: https://go-review.googlesource.com/c/build/+/407395
Run-TryBot: Bryan Mills <bcmills@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Auto-Submit: Bryan Mills <bcmills@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
This will hopefully help in diagnosing an occasional panic I observe
in cmd/fetchlogs. It also brings the API more in line with
https://go.dev/wiki/CodeReviewComments#in-band-errors.
Fixesgolang/go#50474.
Change-Id: Idc644ec8ef7a22332f9cea8fb15c67eac5676e7f
Reviewed-on: https://go-review.googlesource.com/c/build/+/407394
Run-TryBot: Bryan Mills <bcmills@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Bryan Mills <bcmills@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
This better amortizes the cost of loading the maintner database when
fetching logs for multiple repositories (such as an “incremental
fetch” to pick up logs for all recent changes): we only need to load
the maintner data once instead of once per repo, and we can even hide
some of the latency during the fetch for the "go" repo (which does not
need maintner data).
The '-repo' flag now accepts either a comma-separated list or the
special token 'all'.
Change-Id: I33b0c780f53fca7734b6a0cc56f1b67ccce7dfc9
Reviewed-on: https://go-review.googlesource.com/c/build/+/360354
Run-TryBot: Bryan Mills <bcmills@google.com>
Reviewed-by: Robert Findley <rfindley@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
Auto-Submit: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Gofmt to update doc comments to the new formatting.
For golang/go#51082.
Change-Id: Ie063c2fd890641b551c0f304fee5fa19121f1b38
Reviewed-on: https://go-review.googlesource.com/c/build/+/399555
Run-TryBot: Russ Cox <rsc@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Russ Cox <rsc@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Prior to this change, we would link only one (arbitrary) Go revision
for each subrepo revision, causing greplogs to under-report subrepo
failures.
Change-Id: Id36360005283e85d2c0077958d5839901db921f8
Reviewed-on: https://go-review.googlesource.com/c/build/+/340170
Trust: Bryan C. Mills <bcmills@google.com>
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
update-readmes.go is updated to add a pkg.go.dev badge instead of a
godoc.org badge.
The GoDoc badge is added or changed in all READMEs by running
update-readmes.go
For golang/go#42251
Change-Id: I0c49df26a6c695f938c98c9a7b26325d991b3cfb
Reviewed-on: https://go-review.googlesource.com/c/build/+/276032
Trust: Julie Qiu <julie@golang.org>
Run-TryBot: Julie Qiu <julie@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
The repo flag for fetchlogs is not currently that useful because it
queries the main Go dashboard data, which only has a few commits for
each subrepo. This was probably because the data at
https://build.golang.org/?repo=<import path>&mode=json
was incorrect due to golang/go#35515.
With golang.org/cl/232897, this data should be corrected. Update
fetchlogs to now query data from the subrepo dashboard.
Change-Id: I352662abf7da6abb7bc23888b11e03927f567cab
Reviewed-on: https://go-review.googlesource.com/c/build/+/232898
Run-TryBot: Robert Findley <rfindley@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
OS X uses $HOME/Library/Caches instead of $HOME/.cache.
Also make the copyright notice not a doc comment,
which is the real reason I opened this file.
Change-Id: I3af75465a3831aed4d38e2c667c813440e20d0e1
Reviewed-on: https://go-review.googlesource.com/19000
Run-TryBot: Russ Cox <rsc@golang.org>
Reviewed-by: Austin Clements <austin@google.com>
Currently fetchlogs downloads logs to a directory structure created in
the current directory. This makes it difficult to run (you have to
make sure you're in the right directory) and makes it hard for other
tools (e.g., log processing tools) to find these logs.
This change adds a -dir flag to fetchlogs to specify a download
directory. The default value of this flag is derived from the cache
directory of the XDG Base Directory Specification.
Change-Id: I05f01a3db7423250cfef18c42ff38b599b097b35
Reviewed-on: https://go-review.googlesource.com/16818
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
This tool downloads build failure logs from the Go dashboard so they
can be accessed and searched from the local file system.
Change-Id: I9d3f90dd8886cb5446d2fb7276c5d24da5c9a8e3
Reviewed-on: https://go-review.googlesource.com/10671
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Bryan C. Mills
Russ Cox
Julie Qiu
Rob Findley
Brad Fitzpatrick
Austin Clements