update-readmes.go is updated to add a pkg.go.dev badge instead of a
godoc.org badge.
The GoDoc badge is added or changed in all READMEs by running
update-readmes.go
For golang/go#42251
Change-Id: I0c49df26a6c695f938c98c9a7b26325d991b3cfb
Reviewed-on: https://go-review.googlesource.com/c/build/+/276032
Trust: Julie Qiu <julie@golang.org>
Run-TryBot: Julie Qiu <julie@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
We previously hard-coded a Linux-only static map of 2015 data in for
the critical path scheduling of cmd/dist tests over N sharded
buildlets. That worked well only for Linux and only in 2015.
Instead, query BigQuery to find out what the recent timing data looks
like for all builders.
I'd started to work on this back in CL 30716 (Oct 2016) but apparently
never finished. Yay me. But skip the writing-to-CSV step. BigQuery is
much faster than I remember (maybe it got faster?), so just query it
directly. The query takes about 2 seconds, and we only do it every
hour (which is still overkill; daily is probably fine).
Change-Id: I498fc09dfaf24fb1f11b2c0ab4b952b2f15f9c32
Reviewed-on: https://go-review.googlesource.com/c/160037
Reviewed-by: Andrew Bonventre <andybons@golang.org>
SyncBuilds and SyncSpans are invoked by cmd/coordinator/*
without invoking Close for the various bigquery and datastore
clients instantiations. In syncBuildStatsLoop, SyncSpans is
invoked in a [5min, 16min) loop, which will leave a bunch of
underlying resources and HTTP connections unclosed.
Change-Id: I8713c26c31daef3fc1b2c65a2d1bbfc74c8a63ba
Reviewed-on: https://go-review.googlesource.com/138695
Run-TryBot: Emmanuel Odeke <emm.odeke@gmail.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Around Oct 20th, we stopped syncing build stats to BigQuery.
Either the client library was updated around Oct 20th, or the server
changed behavior.
In any case, update the deps (to get a newer version of the bigquery
package) and update the code to work with the new SQL syntax.
This also fixes a bogus loop that was harmless but made the sync
slower than it could've been. (The logic was correct in the nearly
identical span sync later in the file.)
Also adds some TODOs for other log spam I see.
Change-Id: I2aa73084aeb19378bf260839555103fb48eac168
Reviewed-on: https://go-review.googlesource.com/78455
Reviewed-by: Andrew Bonventre <andybons@golang.org>
Bigquery update-table calls are out-of-date with current API.
Fixesgolang/go#21925
Change-Id: I2a21bb1c53dcdb1da8b2da4329f89273e28b600b
Reviewed-on: https://go-review.googlesource.com/64450
Reviewed-by: Andrew Bonventre <andybons@golang.org>
This CL is almost entirely code movement. There is new code in
cmd/coordinator/gce.go.
This library-itizes the buildstats code and makes it used by both
cmd/buildstats (when run by hand) and cmd/coordinator, which now runs
it in a loop in the background.
Running cmd/buildstats by hand is still pretty useless because it
doesn't yet(?) have any query subcommands. It only has the original
-sync command, which is now automatic in the coordinator. But it could
still be useful for debugging or running manually in the staging
environment.
This will permit running BigQuery queries at any time, without Brad or
somebody first manually running cmd/buildstats -sync.
This also means we'll be able to get rid of a bunch of the static (and
stale) timing information in the coordinator code and use empirical
numbers instead for buildlet creation times and per-test durations.
This will help the test sharding schedule things better and result in
faster builds.
Updates golang/go#12669
Change-Id: If9a3b414f8d458a65305c4916ea16d59e5a3971c
Reviewed-on: https://go-review.googlesource.com/53072
Reviewed-by: Sarah Adams <shadams@google.com>
Julie Qiu
Brad Fitzpatrick
Emmanuel T Odeke
Andrew Bonventre
Sarah Adams