The storage client and bucket are needed while the program is running,
not for any of the tests. Move the init code to main so x/build tests
can work okay on a machine without Application Default Credentials.
Change-Id: I3da39cace35588ffa0fb7cc2b5a93b8bfc3f594e
Reviewed-on: https://go-review.googlesource.com/c/build/+/447300
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
After CL 427914 is merged, the tests for cmd/go will no longer depend
on the server hosted at vcs-test.golang.org. The release branch for Go
1.19 will continue to need that server until Go 1.19 is no longer
supported, but after that point the server can be permanently turned
down and its code deleted.
The test in this CL will remind us to do that deletion by failing on
the -longtest builders when the Go version in the main repo is updated
for the Go 1.22 development cycle. The Go 1.22 cycle will begin after
Go 1.21 is released, and (assuming our current release policy remains
in effect) that coincides with the end of support for Go 1.19.
Updates golang/go#27494.
Change-Id: I1e98b88060e303ae75e2f3fb86d6f34bd7765326
Reviewed-on: https://go-review.googlesource.com/c/build/+/428835
Reviewed-by: Heschi Kreinick <heschi@google.com>
Auto-Submit: Bryan Mills <bcmills@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Now that I've turned down the VM-based vcs-test server we don't need
some code. Also disable autocert on the GKE version, which I think in
retrospect I never needed.
For golang/go#53889.
Change-Id: I005bc61228c04a37765895decd485b10167b994e
Reviewed-on: https://go-review.googlesource.com/c/build/+/423342
Run-TryBot: Heschi Kreinick <heschi@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
The bug we were working around is fixed in Kubernetes 1.22, which we
have finally upgraded to.
Change-Id: Ic51a80521d72cb81ceb125586632e1101da795aa
Reviewed-on: https://go-review.googlesource.com/c/build/+/422594
Run-TryBot: Heschi Kreinick <heschi@google.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Reviewed-by: Jenny Rakoczy <jenny@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
When I updated to the latest version of Debian, the container got
python3 instead of 2. Update the hgweb script to work with 3.
For golang/go#53889.
Change-Id: Ieccb24f06841f1e69806b5a6500d065c64c3b04d
Reviewed-on: https://go-review.googlesource.com/c/build/+/419080
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Heschi Kreinick <heschi@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Heschi Kreinick <heschi@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
We currently run vcs-test as a VM image. Build it out as a GKE service.
We run a pod with two containers, one for Apache serving SVN and one for
the vcweb server. Because it needs to serve HTTP, not just HTTPS, we use
a new ingress that doesn't force HTTPS redirects.
Remove /tls, which will be useless now that it's behind a load balancer.
AFAICT it's not used anywhere.
The server is up and running at 34.110.184.62.
$ tail -n1 /etc/hosts
34.110.184.62 vcs-test.golang.org
$ git clone https://vcs-test.golang.org/git/gitrepo1
Cloning into 'gitrepo1'...
remote: Enumerating objects: 19, done.
remote: Counting objects: 100% (19/19), done.
remote: Compressing objects: 100% (10/10), done.
remote: Total 19 (delta 1), reused 0 (delta 0)
Unpacking objects: 100% (19/19), 1.40 KiB | 476.00 KiB/s, done.
$ svn co https://vcs-test.golang.org/svn/hello
A hello/hello.go
Checked out revision 1.
For golang/go#53889.
Change-Id: I3e3e5078b81867689a8b8dc49dd5914c4a6181f0
Reviewed-on: https://go-review.googlesource.com/c/build/+/418298
Run-TryBot: Heschi Kreinick <heschi@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Jenny Rakoczy <jenny@golang.org>
Auto-Submit: Heschi Kreinick <heschi@google.com>
go fmt the entire repo with Go 1.18 go fmt.
Change-Id: I9b9c77796d67dce6de9ceb154dd88058b9b8200f
Reviewed-on: https://go-review.googlesource.com/c/build/+/399039
Trust: Michael Pratt <mpratt@google.com>
Run-TryBot: Michael Pratt <mpratt@google.com>
Auto-Submit: Michael Pratt <mpratt@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
I don't know when the default Cache-Control policy was added, but it
makes it very difficult to fix mistakes in zipfiles uploaded to
vcs-test. Fortunately, the docs for 'gsutil setmeta' give a recipe for
how to fix it, if the user remembers to do so.
For golang/go#35671
Change-Id: I86d365dfae127f3a5230ef4a3c772b17db261096
Reviewed-on: https://go-review.googlesource.com/c/build/+/382594
Trust: Bryan Mills <bcmills@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Enable self-signed HTTPS, and configure the Service and Ingress to do
HTTP/2 over that port.
Also fix various silly mistakes and typos that I discovered while
rolling out the previous change.
For #49191.
Change-Id: If4f308d0e79a94a480ba97b27b5a503cf2aeff2e
Reviewed-on: https://go-review.googlesource.com/c/build/+/358914
Trust: Heschi Kreinick <heschi@google.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
We're gearing up to put most everything behind Cloud load balancers, at
which point Autocert serving will be unnecessary. To support HTTP/2 we
still need to serve TLS, but we can do it using a self-signed
certificate.
Unify the configuration of all that stuff behind a single set of flags
and clean up all the copied and tweaked code I could find.
The self-signed serving is dormant for now; I'll activate it in a later
change.
I didn't understand the need to tweak keepalive intervals everywhere;
keepalives have been on by default since 1.13. So I dropped them.
Change-Id: I0016211f1032a6c64375aad9e34e4e2e62861c5b
Reviewed-on: https://go-review.googlesource.com/c/build/+/358654
Trust: Heschi Kreinick <heschi@google.com>
Trust: Alexander Rakoczy <alex@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Run-TryBot: Alexander Rakoczy <alex@golang.org>
We should have similar performance for these machines, and increased
memory availability in some areas.
This is also compliant with an internal policy change.
Change-Id: I07a452a07431322d6fdd4edbb98c5914045d34ed
Reviewed-on: https://go-review.googlesource.com/c/build/+/354757
Trust: Alexander Rakoczy <alex@golang.org>
Run-TryBot: Alexander Rakoczy <alex@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Add golang-dev as the Autocert notification email so Let's Encrypt can
send us emails. golang-dev is not an ideal choice, but we need something
publicly accessible and there isn't an obvious better option. My
understanding is we should expect essentially no emails so I don't want
to worry too much about it.
Updates golang/go#47108.
Change-Id: I22951984e0d48a59787d110b9cef32cbe3d9bc4a
Reviewed-on: https://go-review.googlesource.com/c/build/+/334532
Trust: Heschi Kreinick <heschi@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
• The /auth subdirectory wasn't downloading content from GCS.
• The zip extraction logic was failing for zip files that do not
contain explicit directory entries.
• The invocation of http.FileServer wasn't trimming the /auth prefix,
so rejections would work correctly but successful authentication
would return 404s instead of serving the file.
Updates golang/go#26232
Change-Id: I3a72d7dfca62435c53f4bc7efaebae3900f2c175
Reviewed-on: https://go-review.googlesource.com/c/build/+/170880
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Jay Conrod <jayconrod@google.com>
This endpoint will be used for integration testing golang/go#26232.
Updates golang/go#26232
Change-Id: I70cab336b885b82abfe8b77839bc9163600f15b0
Reviewed-on: https://go-review.googlesource.com/c/build/+/170581
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Jay Conrod <jayconrod@google.com>
Part of getting the x/build repo passing on the builders.
Change-Id: I3f2055cbe91c03ddc0a5152bfdbc0f377f354f47
Reviewed-on: https://go-review.googlesource.com/c/157441
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
The SNI challenge is not supported by Let's Encrypt anymore, replaced by
the ALPN one, which requires an extra config entry.
Also, autocert now knows how to do RSA fallback, so remove that code.
Updates golang/go#27127
Change-Id: I45f907101a7c7a57d1a8376208dba4afb10ed6fd
Reviewed-on: https://go-review.googlesource.com/130418
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Dmitri Shuralyov
Bryan C. Mills
Heschi Kreinick
Michael Pratt
Alexander Rakoczy
Brad Fitzpatrick
Filippo Valsorda
Lonnie Liu
Russ Cox