For easier copy/pasting into GitHub issues.
Change-Id: I924b3e7a930dfe322594640b291af2baf3176d5f
Reviewed-on: https://go-review.googlesource.com/c/build/+/179417
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
We need to add this manually in order to enable the tls-alpn-01
challenge, since we're using GetCertificate directly instead of
via Manager.TLSConfig. We also don't have the http-01 challenge
enabled (HTTPHandler isn't being used), so this is the only way
for a Let's Encrypt certificate to be acquired now that tls-sni-*
challenges have been deprecated.
In the future, this code can probably be simplified by using
higher-level APIs of autocert, but this fixes the immediate issue.
Updates golang/go#32272
Change-Id: Ia72bca3e44bc585b0dfe5c7bcd3e4f544272d1ab
Reviewed-on: https://go-review.googlesource.com/c/build/+/179097
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
CL 176257 refactored the Dockerfile to remove the use of gitlock but I
forgot to include ca-certificates here.
Updates golang/go#32272 (fixes maybe)
Updates golang/go#26872
Change-Id: I7b0e3a756bc9805e81e499b8b7d7c6ed0defb871
Reviewed-on: https://go-review.googlesource.com/c/build/+/179077
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
There are so few release-blockers compared to total issues,
so that line on the chart ends up being hard to see.
Give it its own axis on the right, and allow it to scale independently.
Change-Id: Id2cd417b88dca8ae23405b7484d40e34b11e2094
Reviewed-on: https://go-review.googlesource.com/c/build/+/175117
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
This is a re-apply of CL 171360, but this time with support for gradual
migration for existing clients. Use redirect with status 308, so that
POST requests to /owners/ preserve POST method after being redirected
to /owners.
This should make it possible to make this change without breaking
current clients (see CL 171460).
After all clients have been updated to use the new /owners URL,
deployed, and enough time passes, the old redirect can be removed.
Update ./devapp/owners tests to use the new URL, and drop the trailing
slash from an unrelated go.googlesource.com link, for consistency.
Change-Id: Idd5615987392c2bdb612f719ace08db895b7cf3a
Reviewed-on: https://go-review.googlesource.com/c/build/+/172668
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
These components have had recent activity in the issue tracker, so
it's helpful to add explicit owners, even if their primary role as
such is to dispatch issues to more-specific owners who are not yet
listed.
Updates golang/go#27586
Change-Id: Ib77b6d1d02b49b9709f1f58797acf2b64ce95e48
Reviewed-on: https://go-review.googlesource.com/c/build/+/172278
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
The runtime package contains multitudes.
I only care about a few of them.
The signal to noise ratio on changes is currently too low.
I hope that we will someday resume work on golang/go#11647,
and/or implement some devapp filters. (Keyword-based? File-based?)
Until then, I'm tapping out.
Change-Id: Ib3baabb44f3a9ee48d78dcb8234c3752e0e42278
Reviewed-on: https://go-review.googlesource.com/c/build/+/171702
Reviewed-by: Josh Bleecher Snyder <josharian@gmail.com>
None of the other handlers for this server require trailing slashes,
so the requirement for this one is surprising.
Change-Id: If4ad2958b3549a849a5af9ee47490a4c47295abe
Reviewed-on: https://go-review.googlesource.com/c/build/+/171360
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Without this step, 'make push-staging' fails for me.
Change-Id: I4563775762671e39dc6a2cb2c5def403e908dfc7
Reviewed-on: https://go-review.googlesource.com/c/build/+/171359
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
The owners table is consumed by gopherbot to assign reviewers and
escalate triaged issues.
Gopherbot has its own fallback behavior for unowned paths, which
should generally be to escalate to whichever member of the Go team is
on triage duty (or to escalate to the Go Open Source Project subteam
in general to update the owners table).
Due to the explicit entry for the root of the 'go' repository, when
gopherbot encounters an issue or CL for any standard-library package
without an owner, it will instead escalate to rsc, ianlancetaylor, and
bradfitz. That doesn't seem like a great use of their time, and also
masks the missing entry in the owners table.
This CL removes that top-level entry, so that unknown paths within the
Go repo will appear to gopherbot as such.
Updates golang/go#27586
Change-Id: I469028f7ec5f4b357ae33bca125da2323fc3e0d2
Reviewed-on: https://go-review.googlesource.com/c/build/+/171358
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Andrew Bonventre <andybons@golang.org>
Remove trailing slashes uniformly from table entries.
Previously, we used string prefixes, which could over-match if two
packages' final elements share a prefix, and used trailing slashes to
compensate, but it's remarkably easy to omit a trailing slash and end
up with a pattern that usually-but-not-always works.
Updates golang/go#27586
Change-Id: Id029a706653e2ba42e83d68f789b65fca34be623
Reviewed-on: https://go-review.googlesource.com/c/build/+/171242
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Move rsc and iant to secondary for cmd/go (to reduce CC and
review-spam for them).
Updates golang/go#27586
Change-Id: I0601d4b50202708726a666d774413d90452c02cd
Reviewed-on: https://go-review.googlesource.com/c/build/+/171036
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
To ease Robert's load and help out with a first pass review.
Change-Id: I3e0aa1fe7211429de4352358073870c4c8be7f8e
Reviewed-on: https://go-review.googlesource.com/c/build/+/166057
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
This change adds a filter input field to the /reviews page,
allowing people to refine what is shown. When updating the reviews
data, it collects search terms that are then rendered by the
template in data- attributes of the corresponding rows.
Filtering then does a match based on whether the row's
data attribute contains the terms entered (with the exception
being when one would like to exclude a term using a minus
sign (-) prefix.
A how-to is added to the UI as well, along with some aesthetic
changes to the rows.
Future work would involve including everything from a change
such as the commit message, hashtags, etc.
Also removes a superfluous log from maintner.
Change-Id: Ia6cbafcd08442dee1b48244725c09ea3575e69df
Reviewed-on: https://go-review.googlesource.com/c/163218
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Change https://dev.golang.org/reviews page to be more helpful
at displaying CLs that are in need of a general code review.
Don't hide CLs containing DO NOT SUBMIT. Per Interim Code Review
and Issue Tracker Conventions¹:
DO NOT SUBMIT means that while the CL is okay to review,
the author wants Gerrit to make sure the CL is not submitted
in its current form.
That means we should not be excluding CLs containing DO NOT SUBMIT
from the reviews page.
Remove a log line from GerritMeta.LabelVotes method. It's not serving
a helpful purpose at this time, but produces a large amount of output.
¹ https://groups.google.com/d/msg/golang-dev/YU56eKYiXJg/K1CkXo7Iy0gJ
Change-Id: Ibe40f756e6a0dab0a13c75fa53998e2d56d287e3
Reviewed-on: https://go-review.googlesource.com/c/163159
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
This change largely reuses the logic to parse CL subjects used
on gochanges.org. There is no support for expanding curly brackets
like "image/{png,jpeg}", but this wasn't implemented here previously
either.
There is room for performance improvement by performing less
allocations, but performance is not a bottleneck for current
needs, so I am currently prioritizing adding support for edge
cases (unless performance proves to be a blocker).
For brevity, use x/subrepo instead of golang.org/x/subrepo form.
Omit displaying the path prefix in the title when displaying CLs
grouped under their full import path, to reduce stutter.
Fixesgolang/go#30096
Change-Id: I957661724d1a26af4dfebea1eee20e6a7595c7b9
Reviewed-on: https://go-review.googlesource.com/c/161219
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Using Chart.js and embedded JSON rendered within the template, the
total number of issues and the number of release blockers in the
current development milestone (hard-coded right now) are graphed in
a line chart.
Change-Id: Icaefc1ff46f976f857f22f07f2934ad32aaf9547
Reviewed-on: https://go-review.googlesource.com/c/150639
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
This change deletes the OwnerName method on GerritCL, since Gerrit's
format for its NoteDB backing store changed to display "Gerrit User NNN"
instead of the proper display name in the meta commit.
Update golang/go#28663
Change-Id: Ifa64ca2b2694b17e888451582b9c63f3f37280a9
Reviewed-on: https://go-review.googlesource.com/c/148557
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Separate performance issues (those with the "Performance" label) from
the rest of the issues on the release dashboard. Performance issues
tend to be those which are not critical to fix for any particular
release, so separating them and putting them later in order helps to
deprioritize them.
Kind of a hack, but it works.
Change-Id: I6fa0f85629504c298691b492e50e03c817c62a1b
Reviewed-on: https://go-review.googlesource.com/c/145937
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Done more stuff there recently and it needs attention, so it seems like
a right fit.
Change-Id: I6344ccc5da83c0cfecd7a7f2ecc1399497e0de03
Reviewed-on: https://go-review.googlesource.com/131285
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Empirically, the maintner client uses just under 2 GB RAM while running.
However, during a maintner.ErrSplit situation, the RAM need spikes
beyond 2 GB, causing the apps to crash due to a hard limit of 2 GB RAM.
Increasing it to 4 GB should let them run crash-free during net splits.
Change-Id: I79deec74c0ddac4afb9e2ffb2ab19747a06bd53a
Reviewed-on: https://go-review.googlesource.com/128361
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
This will allow for zero-downtime deployments, which will be
important for when services start relying on the /owners endpoint.
Change-Id: I4671dbbbf473ba07dbab585222d12832c3193fac
Reviewed-on: https://go-review.googlesource.com/127036
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
This makes it easier for client logic by making all responses
(even errors) JSON.
Change-Id: I7e0682627d16294421ef440b82a86f9a042a79a8
Reviewed-on: https://go-review.googlesource.com/114837
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
My primary (preferred) email has changed,
and it's also my Gerrit email now.
Change-Id: I82bb5bb48a99ae12a646eec1a2ab08966199d62d
Reviewed-on: https://go-review.googlesource.com/112995
Reviewed-by: Andrew Bonventre <andybons@golang.org>
net/lex has been merged into net/http in golang/net@cbb82b59bc,
and bradfitz is already the primary for that.
Updates golang/go#23908.
Change-Id: Icf5eca0751829e26d1951ec6c0eb2d22348695e9
Reviewed-on: https://go-review.googlesource.com/112996
Reviewed-by: Matt Layher <mdlayher@gmail.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Matt Layher <mdlayher@gmail.com>
x/tools/cmd/godoc and x/playground. I add myself as secondary to both
of them since I cannot do +2 votes, but I would like to participate in
reviews with the best of my knowledge.
Change-Id: Iedeb9320b6f76c67a9d15eb8f6f8956e4d2e2957
Reviewed-on: https://go-review.googlesource.com/112695
Reviewed-by: Andrew Bonventre <andybons@golang.org>
Katie Hockman
kawakami
Brad Fitzpatrick
Dmitri Shuralyov
Josh Bleecher Snyder
Bryan C. Mills
Elias Naur
Rebecca Stambler
Agniva De Sarker
Andrew Bonventre
Keith Randall
Than McIntosh
Tobias Klauser
Filippo Valsorda
Kevin Burke
Daniel Martí
Martin Möhrmann
Dmitri Shuralyov
Yury Smolsky