This is a follow-up to CL 199800. That change started to consider more
builders as active to allow release-branch-only builders to run.
However, it also made those builders show up as new empty columns when
viewing builds for the master branch. There are quite a few old FreeBSD
builders that only run on release-branch.go1.12, and it's too disruptive
to have them appear everywhere. So, hide them when viewing the master
branch of Go repo in the UI.
There can be more UI improvements to be made, and this can become too
much of a whack-a-mole to address them one by one. The scope of this CL
is to fix the most disruptive high priority problem for now. Further
improvements will happen later, with merging of app/appengine and
cmd/coordinator codebases in mind.
Updates golang/go#34738
Updates golang/go#34744
Change-Id: I3df75f8b2bbd5f6fe8097c181ee8a1b1b4354dc9
Reviewed-on: https://go-review.googlesource.com/c/build/+/199878
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
The filtering of builders in commitBuilders was too strict,
causing post-submit builders that are configured to run on
release-branches only to not get included in the list of
builders.
This change makes the following builders no longer skipped:
darwin-amd64-10_10
freebsd-386-10_3
freebsd-386-10_4
freebsd-386-11_1
freebsd-amd64-10_3
freebsd-amd64-10_4
freebsd-amd64-11_1
nacl-386
nacl-amd64p32
We may need to adjust the build.golang.org UI after to avoid
including unhelpful columns, but this is a first step to get
nacl builders to run on release branches again.
Updates golang/go#34738
Updates golang/go#34744
Change-Id: Iaf2b93aedd5f44b48b9a63b57f12549fe50b1637
Reviewed-on: https://go-review.googlesource.com/c/build/+/199800
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Also, because this is the first CL in this package to add tests, add a
helper to return the right template filename depending on the
environment (go test vs prod) so tests don't panic in init.
Fixesgolang/go#34097
Updates golang/go#34116
Change-Id: I4b3e83c2417611cfbdc32e27941dbb90687eb509
Reviewed-on: https://go-review.googlesource.com/c/build/+/194643
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Deploying in GOPATH mode is not supported, so explicitly specify
GO111MODULE=on to use module mode regardless of local setup.
Fixesgolang/go#34107
Change-Id: I5bc2518c4cd4c329eea65684fec96aae5b0bf808
GitHub-Last-Rev: 93f780cd58
GitHub-Pull-Request: golang/build#23
Reviewed-on: https://go-review.googlesource.com/c/build/+/193597
Reviewed-by: Andrew Bonventre <andybons@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Per release policy¹, we only support and test the two latest
major versions (currently Go 1.13 and Go 1.12).
Previously:
• CL 164218 removed Go 1.10.
• CL 133895 removed Go 1.9.
• CL 95555 removed Go 1.8.
• CL 77931 removed Go 1.7.
• CL 37466 removed Go 1.6.
• CL 31767 removed Go 1.5.
• CL 20843 removed Go 1.4.
¹ https://golang.org/doc/devel/release.html#policyFixesgolang/go#34096
Change-Id: I8ac7fcb6527e86706bdb7f140e3f05d3262f2476
Reviewed-on: https://go-review.googlesource.com/c/build/+/193477
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Starting October 1, App Engine will not allow apps using the 1.9
runtime to be deployed.
In module mode on go111 AppEngine, paths have changed to be relative to
the go.mod file.
More information can be found at
https://cloud.google.com/appengine/docs/standard/go111/go-differences
Change-Id: I3e291f20559ec8d3c5e8f51b756bd3b23b0c70bd
Reviewed-on: https://go-review.googlesource.com/c/build/+/192103
Run-TryBot: Alexander Rakoczy <alex@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Andrew Bonventre <andybons@golang.org>
This app is now running as a service called "build" instead of
on a named version in the default service. Update the app.yaml and
deployment instructions to account for this.
Change-Id: I5d68128e89bad6782982380b2012300a492ddb34
Reviewed-on: https://go-review.googlesource.com/c/build/+/191975
Reviewed-by: Alexander Rakoczy <alex@golang.org>
This reverts commit CL 190902.
Reason for revert: it breaks deploys due to filesystem changes in go111
Change-Id: Ic357050da2707be1c53d79af6f0062ff4feaffbb
Reviewed-on: https://go-review.googlesource.com/c/build/+/191974
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Currently, the subheading2 cells in the subrepo tables are shifted by
one to the left due to the additional cell for the Go commit. There are
4 fixed <th> cells while there are 5 <td> cells (subrepo commit, Go
commit, user, time and description).
Make the first <th> have a colspan of 2 in case of the subrepo table so
the subheading2 cells align correctly.
Change-Id: I1ca7157cecf6530cff5883154f367684b0695081
Reviewed-on: https://go-review.googlesource.com/c/build/+/183217
Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Make the headers fill the screen's width by making the body have
display: inline-block and min-width: 100%. Before, scrolling to
the right extended past the screen's width, which caused the
blue table headers to cut off.
Change-Id: I2f186ca044d07a4dfd3ec6cbe3f57a9feee05c99
Reviewed-on: https://go-review.googlesource.com/c/build/+/125475
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
It was previously master, Go 1.11, then Go 1.12, which puts Go 1.11 in
the middle of two things that came after it.
Change-Id: I5c67bff7f0ab4269f1db3d4c7e8197df36dc12cb
Reviewed-on: https://go-review.googlesource.com/c/build/+/170779
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
I forgot the sub-repo sub-heading in CL 160657. This adds it.
Change-Id: I5cab4fe978ae662a9150e34acc802caff61de54a
Reviewed-on: https://go-review.googlesource.com/c/164677
Reviewed-by: Andrew Bonventre <andybons@golang.org>
So people can see linux-amd64-nocgo vs linux-amd64-noopt, etc.
Currently it only works on mouseover on desktop, and few people know that.
Add a new row to make it explicit.
While at it:
* remove some dead code
* make this testable locally, detecting dev_appserver mode and populating some
fake data
* remove the s/amd64/x86/ in the subheadings. that's just confusion and we don't
do that to other longer fields like arm64 or ppc64le, etc
Change-Id: Id3de9406f383c93202be2e298f07d5c4fef8ae85
Reviewed-on: https://go-review.googlesource.com/c/160657
Reviewed-by: Andrew Bonventre <andybons@golang.org>
They're causing unnecessary work and clutter on the build.golang.org page.
Fixesgolang/go#29513
Change-Id: Ieb9bbe4caf0041dd2a2f0e34b4d52a283de56224
Reviewed-on: https://go-review.googlesource.com/c/157817
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Go 1.9 is the latest offered on App Engine, which at least is new
enough to get us type aliases.
Fixesgolang/go#26115
Change-Id: I4de3062cf2f7df70216536a05b7150324c1a5e91
Reviewed-on: https://go-review.googlesource.com/121418
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
We want to pass this down to the coordinator so each
dashboard.BuildConfig can have its own policy on which branches to
build. For example, we'll have NetBSD skip building subrepos for Go
versions that are too old.
Updates golang/go#23102
Change-Id: I40d35c9c5a6d4455772430c169dbea054929545e
Reviewed-on: https://go-review.googlesource.com/83536
Reviewed-by: Andrew Bonventre <andybons@golang.org>
Per policy, we only support & test the past two releases (currently Go
1.8 and Go 1.9).
Change-Id: I3d35d47c9053ffc34a0d175815b7227532579aad
Reviewed-on: https://go-review.googlesource.com/77931
Reviewed-by: Andrew Bonventre <andybons@golang.org>
+ Renames build/ to appengine/ as it contains the main entry point
for the app.
+ Moves app.yaml files to the appengine/ folder as gcloud app deploy
will complain if it can’t find any go files to build in the same
directory as the app.yaml file (previously I think it recursively
looked for them in the directory tree).
+ Update deploy steps in app.yaml.
+ Remove application and version fields in app.yaml as gcloud deploy
doesn’t allow them anymore.
+ Update to use go1.8, including using the context package as
appropriate. In some cases the x/net/context package must be
used to match the function types specified by GAE.
Change-Id: Ib38563ba7245f37de1a2f8d7f034f02c0cd77863
Reviewed-on: https://go-review.googlesource.com/70410
Reviewed-by: Chris Broadfoot <cbro@golang.org>
build.golang.org does't use any cookies or allow any non-read actions,
but fix anyway.
Change-Id: Ib9002753de268083d7e16ce41cd7ff950f7f28a4
Reviewed-on: https://go-review.googlesource.com/47091
Reviewed-by: Chris Broadfoot <cbro@golang.org>
Go policy is to support the past two released Go version, which is
currently Go 1.7 and Go 1.8. Most of the Go repos are broken for Go 1.6 now
because everybody is using subtests and contexts.
Previously:
https://golang.org/cl/31767 removed Go 1.5.
https://golang.org/cl/20843 removed Go 1.4.
Change-Id: I64b4af609a8be79a0f25a855430b73ba4d442ae0
Reviewed-on: https://go-review.googlesource.com/37466
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
This is particularly useful for mode=json; this way, you can fetch
specific commits instead of having to page through results.
Change-Id: I756315e08665ba5b84a212384b01bdad26a6824d
Reviewed-on: https://go-review.googlesource.com/35790
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Normal Go policy is to support the past two released Go version, which
is currently Go 1.6 and Go 1.7.
Change-Id: I8db9495582d40e82ceb4ccf52ea22ec3969f6ae5
Reviewed-on: https://go-review.googlesource.com/31767
Reviewed-by: Quentin Smith <quentin@golang.org>
The favicon is hotlinked from golang.org/favicon.ico, which is now
larger.
Resize it to 16x16.
Fixesgolang/go#17022.
Change-Id: Id74eb3bd8c855a042d033664359f04089d7857ff
Reviewed-on: https://go-review.googlesource.com/28770
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
This uses the godash command/library to serve release dashboards, on a
new app to be hosted at dev.golang.org.
The dashboards are automatically updated by a cron job every 30 minutes.
Change-Id: I2e1e6a270e26fd93a9c767b0168e2c8c520e8ace
Reviewed-on: https://go-review.googlesource.com/23210
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>
Most of these are documentation fixes.
Change-Id: If100cc2ef0ee0b8b47a1e96e4c51a2be8caf5842
Reviewed-on: https://go-review.googlesource.com/22366
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
This expands the JSON dashboard output to include everything that's
visible on the HTML dashboard (which includes all of the obviously
meaningful fields from the Commit objects).
Change-Id: Ib0437bec276a78ca9efd57fcc16041e40ccd3d4c
Reviewed-on: https://go-review.googlesource.com/16632
Reviewed-by: Andrew Gerrand <adg@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Dmitri Shuralyov
Brad Fitzpatrick
Alexander Rakoczy
Andrew Bonventre
Tobias Klauser
Akhil Indurti
Hana Kim
Quentin Smith
Russ Cox
Chris Broadfoot
Andrew Gerrand
Christian Couder
Austin Clements