This removes the last two gitlock users, so this also deletes gitlock.
And update to multi-stage Dockerfiles, simplifying the build and
making it more consistent with others.
Updates golang/go#26872
Change-Id: I1e38c65eccfe9b8b7cb2d9acd6eb02aa33f8b877
Reviewed-on: https://go-review.googlesource.com/c/build/+/176604
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Andrew Bonventre <andybons@golang.org>
And update to multi-stage Dockerfiles, simplifying the build and
making it more consistent with others.
Updates golang/go#26872
Change-Id: If26e19d73c9bdb996343468cd1cff8edc574cb17
Reviewed-on: https://go-review.googlesource.com/c/build/+/176603
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Also, along for the ride:
* update from jessie to stretch
* update from Go 1.10 to Go 1.12
* move to multi-stage Dockerfile, including drawterm, reducing image size
* remove the static linking which was resulting in build warnings
* clean up Makefile
Updates golang/go#26872
Updates golang/go#27719
Change-Id: Ic4dc9b8539fb8662c9621c113fa94b70bc7de061
Reviewed-on: https://go-review.googlesource.com/c/build/+/175985
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
mergeIDs makes the assumption that the first email seen for a
gopher is the one used for Gerrit. In the last update to gophers.go,
the first email for Filippo was changed to be invalid, causing
errors when automatic assignment was attempted in gopherbot.
Update golang/go#31919
Change-Id: Ief9115d1aed8ab998e92cfed792444d1a6463df8
Reviewed-on: https://go-review.googlesource.com/c/build/+/176037
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
The cmd/go tests are timing out on the plan9/amd64
builder because they take more than 20m to complete.
This change disables the cmd/go tests on the
plan9/amd64 builder, like it was done on the
plan9/386 builder.
Updates golang/go#31910.
Change-Id: I157b472da8498ddce0f641cccb79bc50ae65ca3b
Reviewed-on: https://go-review.googlesource.com/c/build/+/175898
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
5 seconds is too slow on linux-arm it seems (starting sshd,
conditionally creating a host key, etc)
Change-Id: I2015908eb892d0b2dd580db8ba96c10726502cbb
Reviewed-on: https://go-review.googlesource.com/c/build/+/175998
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Make the headers fill the screen's width by making the body have
display: inline-block and min-width: 100%. Before, scrolling to
the right extended past the screen's width, which caused the
blue table headers to cut off.
Change-Id: I2f186ca044d07a4dfd3ec6cbe3f57a9feee05c99
Reviewed-on: https://go-review.googlesource.com/c/build/+/125475
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
The Googler field is determined via heuristics and represents whether
the person is known to be at Google now or has been in the past. It
can be used for gathering statistics about contributions that are
internal or external, but not for security related checks.
Make this more clear by documenting the field.
Change-Id: I966d3fa7a107c2db7b6898084db22a1d064c87cc
Reviewed-on: https://go-review.googlesource.com/c/build/+/175198
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
And delete our old, incomplete vendor directory. We already rely on
modules, so we can rely on modules for that one package too.
Fixesgolang/go#31815
Change-Id: I7cb97df2045a0719963b2eea538f9182427393f1
Reviewed-on: https://go-review.googlesource.com/c/build/+/175139
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Building with GOHOSTARCH=arm on a GOHOSTARCH=arm64 android device
should work in theory, but results in an error about text relocations:
Building Go cmd/dist using /data/data/com.termux/files/home/go-android-arm64-bootstrap.
Building Go toolchain1 using /data/data/com.termux/files/home/go-android-arm64-bootstrap.
Building Go bootstrap cmd/go (go_bootstrap) using Go toolchain1.
warning: unable to find runtime/cgo.a
Building Go toolchain2 using go_bootstrap and Go toolchain1.
CANNOT LINK EXECUTABLE "/data/data/com.termux/files/usr/tmp/workdir-host-android-arm64-corellium-android/go/pkg/tool/android_arm/go_bootstrap": /data/data/com.termux/files/usr/tmp/workdir-host-android-arm64-corellium-android/go/pkg/tool/android_arm/go_bootstrap: has text relocations
go tool dist: FAILED: /data/data/com.termux/files/usr/tmp/workdir-host-android-arm64-corellium-android/go/pkg/tool/android_arm/go_bootstrap install -gcflags=all= -ldflags=all= -i cmd/asm cmd/cgo cmd/compile cmd/link: signal: aborted
I tried switching linker to gold, lld to no avail. Drop GOHOSTARCH
as a workaround.
Updates golang/go#31722
Change-Id: Id00564406582122f254c08b357668d7d0a9bae43
Reviewed-on: https://go-review.googlesource.com/c/build/+/175078
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
There are so few release-blockers compared to total issues,
so that line on the chart ends up being hard to see.
Give it its own axis on the right, and allow it to scale independently.
Change-Id: Id2cd417b88dca8ae23405b7484d40e34b11e2094
Reviewed-on: https://go-review.googlesource.com/c/build/+/175117
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Also remove dead nacl-arm. It hasn't run in ages.
And update netbsd comment about why 386 doesn't run. And correct its
VM image name.
Updates golang/go#31705
Updates golang/go#31726
Change-Id: I9de4605f34a052d0a84684fca098388d75602a82
Reviewed-on: https://go-review.googlesource.com/c/build/+/174637
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Revert CL 173517 and replace with a similar but different mechanism.
Now that the new revdial is out, only penalize the old revdial users
(a few stragglers who haven't updated). In practice the limit of 10 at
once won't be a problem but will protect the coordinator during submit
floods.
Fixesgolang/go#31639
Change-Id: I6b6c3567205fdd98e0b80def96d75827e986fe4f
Reviewed-on: https://go-review.googlesource.com/c/build/+/174325
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
The old revdial has a simple multiplexing protocol that was like
HTTP/2 but without flow control, etc. But it was too simple (no flow
control) and too complex. Instead, just use one TCP connection per
reverse dialed connection. For now, the NAT'ed machine needs to go
re-connect for each incoming connection, but in practice that's just
once.
The old implementation is retained for now until all the buildlets are
updated.
Updates golang/go#31639
Change-Id: Id94c98d2949e695b677531b1221a827573543085
Reviewed-on: https://go-review.googlesource.com/c/build/+/174082
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Otherwise, the resulting binary refuses to run on a multicore machine,
stating that the use of atomic synchronization instructions is needed.
Change-Id: Ie1a626e064a77c4fd80abbdc597ddbc62e3ffb95
Reviewed-on: https://go-review.googlesource.com/c/build/+/174141
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
To mitigate bug in revdial that's retaining way too much memory and
causing coordinator evictions.
Also double memory limit for now.
Updates golang/go#31639
Change-Id: I19b6df92df9905b087c29884140096946037fa38
Reviewed-on: https://go-review.googlesource.com/c/build/+/173517
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>
This is a re-apply of CL 171360, but this time with support for gradual
migration for existing clients. Use redirect with status 308, so that
POST requests to /owners/ preserve POST method after being redirected
to /owners.
This should make it possible to make this change without breaking
current clients (see CL 171460).
After all clients have been updated to use the new /owners URL,
deployed, and enough time passes, the old redirect can be removed.
Update ./devapp/owners tests to use the new URL, and drop the trailing
slash from an unrelated go.googlesource.com link, for consistency.
Change-Id: Idd5615987392c2bdb612f719ace08db895b7cf3a
Reviewed-on: https://go-review.googlesource.com/c/build/+/172668
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
This will allow long tests to use/test delve.
Delve is built in its own stage with go1.12, then copied out.
Updates golang/go#18144
Change-Id: I346729c945a95d5e34616500913a43bbe03b524c
Reviewed-on: https://go-review.googlesource.com/c/build/+/172959
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
The HTTP response object contains an indication of how much (or until
when) to wait before the next successful API call.
This makes the code use this information to obey the rate limit
constraints.
Change-Id: I22cf851220db6f361f8663be28d49179f52dd623
Reviewed-on: https://go-review.googlesource.com/c/build/+/170959
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Brad Fitzpatrick
Elias Naur
Andrew
David du Colombier
LE Manh Cuong
Akhil Indurti
Dmitri Shuralyov
Josh Bleecher Snyder
Damien Neil
Benny Siegert
David Chase
Nikhil Benesch