This change fixes a copy-paste mistake from CL 38137, where the wrong
time variable was set to UTC when cmut.Updated is non-nil.
Change-Id: I4dc62abf9b70b52b700e3b6b688fa8adbc502d98
Reviewed-on: https://go-review.googlesource.com/111645
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Once containers run on COS instead of Kubernetes, one name (Kube*) is
wrong and the other (GCE) is ambiguous. So rename them now to be more
specific.
No behavior changes. Just renaming in this step, to reduce size of
next CL.
Updates golang/go#25108
Change-Id: Ib09eb682ef74acbbf6ed50b46074f834ef5e0c0b
Reviewed-on: https://go-review.googlesource.com/111639
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
This removes some duplication of scopes and how to get the
TokenSource and which credentials to use.
And update the coordinator deps, since its rev of
golang.org/x/oauth2/google was too old to have the new type.
I want to clean this up more, but I need to make some changes to to
the oauth2/google package first. More later.
Change-Id: Ic2799ec2ec62f67c65de6380b373fe915a43003e
Reviewed-on: https://go-review.googlesource.com/111266
Reviewed-by: Andrew Bonventre <andybons@golang.org>
Includes changes mistakenly omitted from 110996
Change-Id: I3e3da2590120f810d0413606c77cc0afa76029a9
Reviewed-on: https://go-review.googlesource.com/111115
Reviewed-by: Andrew Bonventre <andybons@golang.org>
The current logic returns the entry with the deepest path matched
to the given resource. Entries have Primary and Secondary fields
for indicating who should be in the Reviewer and CC fields in a
code review, respectively.
Change-Id: Icf315f7964326a2549146f2b0558de80749f0b5e
Reviewed-on: https://go-review.googlesource.com/110996
Reviewed-by: Bryan C. Mills <bcmills@google.com>
This updates both the 386 and the amd64 builder to the latest
NetBSD 8 release candidate, using the current versions of anita
(1.44) and pkgsrc packages (2018Q1).
Tested: ran both resulting images on GCE with buildlets.
Also added clang packages for use in golang/go#24354.
Change-Id: I00812f2ec315bca68fdfec14a6db1200d4f80d32
Reviewed-on: https://go-review.googlesource.com/109035
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Rename the 8branch builders from “8branch” to “8_0” (in keeping with
the version suffixes for FreeBSD and Darwin), and fix an apparent typo
in the 386 SSHUsername field.
Updates golang/go#25206.
Updates golang/go#25109.
Change-Id: I6053c8de17dcb3c7ff32da05c51902ac4bcc45fe
Reviewed-on: https://go-review.googlesource.com/110626
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
As this file should be kept in sync with x/tools/godoc/dl, update
the File struct accordingly (added JSON tags).
Change-Id: Ia23fe501282563ff6eec2cd0a590b6ce9193a674
Reviewed-on: https://go-review.googlesource.com/110628
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
GitHub reviews can be assigned to teams.
Change-Id: I675944c40619635e554d083cfa4fd6e332315f9b
Reviewed-on: https://go-review.googlesource.com/101955
Reviewed-by: Chris Broadfoot <cbro@golang.org>
Otherwise, if we use debugnewvm with credentials for a standard
service account, the server rejects the instance creation request with
“Empty or missing scope not allowed.”
Change-Id: Id7546636edcce7e2b3f25b56c75e6dedf0887520
Reviewed-on: https://go-review.googlesource.com/110615
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
cmd/go takes ~188 seconds on windows-amd64, which is over the
default 180 second limit. Bump up the timout rate.
Change-Id: Ib0e5289ab6c4d6127d18375e3a72453818b984a8
Reviewed-on: https://go-review.googlesource.com/110415
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Currently "go test" on tip fails because there's no argument passed
for Printf.
Change-Id: I66a028bcb0f10f106c0dcc9643ba878363521127
Reviewed-on: https://go-review.googlesource.com/109458
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
There is a reasonable use case for going back and backporting a fix for
a closed issue, or the user might have forgotten to open the backport
issues sooner.
Change-Id: I5b9afd10764c7b1438f163ff512ec1e2961b1afa
Reviewed-on: https://go-review.googlesource.com/108915
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
The mismatch in the prefix search made gopherbot always try to open
issues, but the duplicate issue safety engaged.
Also tweak the language a bit.
Change-Id: I26b3aa02b9a3a041bee2343097a535dfacf85d08
Reviewed-on: https://go-review.googlesource.com/108835
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
From the "gcloud docker" output:
WARNING: `gcloud docker` will not be supported for Docker client
versions above 18.03. Please use `gcloud auth configure-docker` to
configure `docker` to use `gcloud` as a credential helper, then use
`docker` as you would for non-GCR registries.
Not adding "gcloud auth configure-docker" to the Makefiles as it spams
and there are implicit required authentication steps already anyway.
Change-Id: I5bd1177e82d30a6590126a307bee01d0acee9d6a
Reviewed-on: https://go-review.googlesource.com/108560
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Make sure dry-run does not require credentials, logs the skipped action,
and is applied uniformly.
Also, add instructions on how to use it from Docker.
Change-Id: I05ed681f7dd070e68a85638bf08fc7ee4a7705b6
Reviewed-on: https://go-review.googlesource.com/108235
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
It was working because the key that exists is the last one.
Change-Id: I632bf7fdecc5124f4f1e2f8297daed7493771bf1
Reviewed-on: https://go-review.googlesource.com/108176
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
They didn't compile before when added in CL 103856
Fixesgolang/go#24874
Change-Id: I9bf547248d1cdaa84c8e5f4a299a2efcc93e37c9
Reviewed-on: https://go-review.googlesource.com/107303
Reviewed-by: Andrew Bonventre <andybons@golang.org>
The Docker build didn't have the x/time/rate dependency. Also run Go
1.10 instead of Go 1.8.
Verified that this works by building the Dockerfile locally.
Change-Id: Id55bbb3e8cb81ba112351d4558a318939c22d8a5
Reviewed-on: https://go-review.googlesource.com/106985
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
They were of type GitCommit, but we want to hang the useful methods
off the existing GerritMeta wrapper.
This was the plan earlier (when the GerritMeta type was added), but
that earlier CL didn't go all the way and convert callers.
This will likely break some maintner-using code, but there aren't many
callers.
Also, document & enforce that Meta & Commit are always non-nil when
enumerating CLs and when looking up CLs. Previously, two deleted CLs
didn't have this property, as the Gerrit server was returning a ref
for a version of the commit, but no meta ref. Filter those out.
Fixesgolang/go#22060Fixesgolang/go#21984
Change-Id: I67727977c7a25e750f51a6ff7f3e00aaf960ef9f
Reviewed-on: https://go-review.googlesource.com/107296
Reviewed-by: Dmitri Shuralyov <dmitri@shuralyov.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Also update deps to pull in golang.org/x/time/rate for maintner.
Change-Id: I67ceef2eb16ccc0ce3ae4da8e8e07c07c1a8825f
Reviewed-on: https://go-review.googlesource.com/106916
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
GitHub gets upset when you send it too many requests. We do have some
backoff, but it's handled per-repo, rather than across all GitHub
requests. This adds a global GitHub limiter to add more control.
Change-Id: I42898d25cf66a93970d96e922743b766f9a21c3f
Reviewed-on: https://go-review.googlesource.com/101919
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Issue golang/go#22852 modifies formatting for Go tables. If the
code stays as is, users running Go 1.9 will format the file one way
and users running tip will format the file a different way. This is
problematic when git-codereview attempts to check the file is gofmt'ed
correctly, and does not let you mail commits that aren't.
Adding another newline makes the file compatible with tip and the
stable release branch and avoids this problem.
Change-Id: I0dbfe01db6e07578993e793e3710702ff2518436
Reviewed-on: https://go-review.googlesource.com/104836
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Andrew Bonventre
Dmitri Shuralyov
Brad Fitzpatrick
Benny Siegert
Bryan C. Mills
Chris Broadfoot
Filippo Valsorda
Kevin Burke
Emil Hessman
Felix Kollmann
Felix Kollmann