This lets us set a timeout on the HTTP request, which lets us time out the
writeSnapshot call in cmd/coordinator.
Fixesgolang/go#18812.
Change-Id: I370448df4d95130c9c5b30ba32459ce844a6c967
Reviewed-on: https://go-review.googlesource.com/36897
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Windows installer will not broadcast WM_SETTINGCHANGE when a reboot is
pending. This message is required for explorer.exe to reload the PATH
from the registry so future cmd.exe processes will launch with go/bin in
the PATH.
Use the Wix extension to always broadcast this message after install.
More info:
http://wixtoolset.org/documentation/manual/v3/customactions/wixsettingchange.htmlFixesgolang/go#18680
Change-Id: I4f3af49f167f3875bbf8e898f4d50ee358b4e35d
Reviewed-on: https://go-review.googlesource.com/36324
Reviewed-by: Chris Broadfoot <cbro@golang.org>
So it really builds an ARMv6 binary when GOARM=6.
Tried "release -rev go1.8rc2 -tools release-branch.go1.8 -version go1.8rc2 -target linux-armv6l -watch"
and the generated binary works on my Raspberry Pi 1.
Fixesgolang/go#18748.
Change-Id: I11113f98703049dc9990fe8c8abf505dcfd980f2
Reviewed-on: https://go-review.googlesource.com/35501
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Our builders are named of the form "GOOS-GOARCH" or
"GOOS-GOARCH-suffix".
Over time we've grown many builders. This CL doesn't change
that. Builders continue to be named and operate as before.
Previously the build configuration file (dashboard/builders.go) made
each builder type ("linux-amd64-race", etc) define how to create a
host running a buildlet of that type, even though many builders had
identical host configs. For example, these builders all share the same
host type (a Kubernetes container):
linux-amd64
linux-amd64-race
linux-386
linux-386-387
And these are the same host type (a GCE VM):
windows-amd64-gce
windows-amd64-race
windows-386-gce
This CL creates a new concept of a "hostType" which defines how
the buildlet is created (Kube, GCE, Reverse, and how), and then each
builder itself references a host type.
Users never see the hostType. (except perhaps in gomote list output)
But they at least never need to care about them.
Reverse buildlets now can only be one hostType at a time, which
simplifies things. We were no longer using multiple roles per machine
once moving to VMs for OS X.
gomote continues to operate as it did previously but its underlying
protocol changed and clients will need to be updated. As a new
feature, gomote now has a new flag to let you reuse a buildlet host
connection for different builder rules if they share the same
underlying host type. But users can ignore that.
This CL is a long-standing TODO (previously attempted and aborted) and
will make many things easier and faster, including the linux-arm
cross-compilation effort, and keeping pre-warmed buildlets of VM types
ready to go.
Updates golang/go#17104
Change-Id: Iad8387f48680424a8441e878a2f4762bf79ea4d2
Reviewed-on: https://go-review.googlesource.com/29551
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
After https://golang.org/cl/21701 is in the tree,
cmd/go won't put godoc in $GOROOT/bin automatically.
This should be submitted once the dependent CL is in,
shortly before rolling the 1.7 beta,
as it will break cmd/release for building Go 1.6 and below.
Fixesgolang/go#15106
Change-Id: I1de1b658291d1d031f123fa12c18893e538d7e8f
Reviewed-on: https://go-review.googlesource.com/21703
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Also update all users, and rename another template field.
Includes changes to coordinator, gomote, and release.
Change-Id: I1c4408eadbcb83d61063a910dfa18cc395952bc2
Reviewed-on: https://go-review.googlesource.com/20976
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
This makes it easier to programmatically verify the
integrity of the binaries.
Fixesgolang/go#14385
Change-Id: Ie3688d9b07412018b74d6189ab0d7bc72ef50398
Reviewed-on: https://go-review.googlesource.com/19783
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Fixes#13769
When copying source files for the OSX pkgbuilder (and others) make
sure the atime/mtime of the source is respected.
Change-Id: I75d463d6a3a350f95c5ab4d8b943b60c8cbf2715
Reviewed-on: https://go-review.googlesource.com/18355
Reviewed-by: Andrew Gerrand <adg@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
On Windows, the ProductCode must be different¹ for different versions of
the same product while the UpgradeCode must remain the same².
By setting the Id-field in the Product-tag in installer.wxs file to "*"
(instead of the static GUID), a new ProductCode will be generated by the
WiX-Toolkit on each run of the building process. This allows to upgrade
from previously installed versions of Go without uninstalling them
manually.
Quotes from MSDN
¹) https://msdn.microsoft.com/en-us/library/aa370854(v=vs.85).aspx:
" The ProductCode property is a unique identifier for the particular
product release, [...]. This ID must vary for different versions and
languages. "
²) https://msdn.microsoft.com/en-us/library/aa372375(v=vs.85).aspx:
" The UpgradeCode property is a GUID representing a related set of
products. The UpgradeCode is used in the Upgrade Table to search for
related versions of the product that are already installed. "
Fixesgolang/go#12213
Change-Id: I5d04eef7786107d0d7d4a913e8799838e8788a4f
Reviewed-on: https://go-review.googlesource.com/18071
Reviewed-by: Alex Brainman <alex.brainman@gmail.com>
Now Close always means destroy.
The old code & API was a half-baked implementation of a (lack of)
design where there was a difference between being done with a buildlet
(with it possibly being reused by somebody else?) and you wanting to
nuke it completely. Unfortunately this just grew messier and more
broken over time.
This attempts to clean it all up.
We can add the sharing ideas back later when there's actually a design
and implementation. (We're not losing anything with this CL, because
nothing ever shared buildlets)
In fact, this CL fixes a problem where reverse buildlets weren't
getting their underlying net.Conns closed when their healthchecks
failed, leading to 4+ hour (and counting) build hangs due to buildlets
getting killed at inopportune moments (e.g. me testing running a
reverse buildlet on my home mac to help out with the dashboard
backlog)
Change-Id: I07be09f4d5f0f09d35e51e41c48b1296b71bb9b5
Reviewed-on: https://go-review.googlesource.com/14585
Reviewed-by: David Crawshaw <crawshaw@golang.org>
Reviewed-by: Andrew Gerrand <adg@golang.org>
This allows the release command to be run from any directory.
Change-Id: Ia0cac8ad32fb5a232bdf429ec2d8901ffd773d57
Reviewed-on: https://go-review.googlesource.com/12915
Reviewed-by: Andrew Gerrand <adg@golang.org>
This ensures that each release actually passes the tests.
Fixesgolang/go#11943
Change-Id: Ia7bb34a611389fe0d529bdb76ff4d0cd68d3d7cd
Reviewed-on: https://go-review.googlesource.com/12914
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Chris Broadfoot
Brad Fitzpatrick
Kevin Burke
Jeff Johnson
Cherry Zhang
shawnps
Daniel Theophanes
Jonathan Amsterdam
Chris Broadfoot
Andrew Gerrand
Shenghou Ma
Dave Cheney
Özgür Kesim
Brad Fitzpatrick
Alex Brainman