s390x notably was missing. Also add the mobile ones.
Change-Id: Id6be52b73fac897980d4e94ac5c5b07027f5b4e7
Reviewed-on: https://go-review.googlesource.com/114315
Reviewed-by: Bryan C. Mills <bcmills@google.com>
The new "kicktrain" mode is disabled by default and needs to be run
by hand with --only-run=kicktrain so we can use this in the future.
I just used this to move 132 Go 1.11 issues to Unplanned.
Change-Id: Id6d9d2065fc6970ed14151fe368d3ae5ccaf9957
Reviewed-on: https://go-review.googlesource.com/114011
Reviewed-by: Ian Lance Taylor <iant@golang.org>
We used to build the buildlet/stage0 binary once, upload it to GCS,
and then future Docker builds of environments would slurp it down back
off the network (unversioned) and back that copy into its image
forever.
Now the buildlet/stage0 binary gets hermetically built as part of
env/*/Dockerfiles and GCS uploads/downloads aren't involved.
While we're at it, move more docker logic out of Makefiles and into
xb, including things like building dependent images (stage0) and
verifying the versions of dependent layers (e.g. that "golang:1.10" is
Go 1.10.2, and not Go 1.10 or Go 1.10.1).
Change-Id: I2a08d951b9fa8143fb3aee3ec7c2cc78d216962e
Reviewed-on: https://go-review.googlesource.com/113135
Reviewed-by: Andrew Bonventre <andybons@golang.org>
We usually do this manually via the GCP Datastore console. Provide
a binary to do it more easily.
Change-Id: I30dca595a4f81781bcb63ed8b09365b09961efcc
Reviewed-on: https://go-review.googlesource.com/113718
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
This change downloads/extracts the Visual Studio Build Tools to C:\godep\vs
Verified by running C:\godep\vs\VC\Tools\MSVC\14.14.26428\bin\Hostx64\x86\cl.exe
Related: golang/go#20982
Change-Id: I9dcb4afc0971317ff39381f089867a08c402974a
Reviewed-on: https://go-review.googlesource.com/112036
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
My primary (preferred) email has changed,
and it's also my Gerrit email now.
Change-Id: I82bb5bb48a99ae12a646eec1a2ab08966199d62d
Reviewed-on: https://go-review.googlesource.com/112995
Reviewed-by: Andrew Bonventre <andybons@golang.org>
net/lex has been merged into net/http in golang/net@cbb82b59bc,
and bradfitz is already the primary for that.
Updates golang/go#23908.
Change-Id: Icf5eca0751829e26d1951ec6c0eb2d22348695e9
Reviewed-on: https://go-review.googlesource.com/112996
Reviewed-by: Matt Layher <mdlayher@gmail.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Matt Layher <mdlayher@gmail.com>
Note that compiler-rt/lib/tsan/go/build.bat has been broken since
https://reviews.llvm.org/D28596 (git commit
6ef4606343358c8f0365f7741b5033c42fbabb0e), so we have to use an older
version until it can be fixed.
compiler-rt commit ae08a22cc215448aa3ad5a6fb099f6df77e9fa01 is the
most recent one that builds, but it fails tests (golang/go#22687).
Updates golang/go#24354.
Updates golang/go#22687.
Change-Id: I36ba47fc955111143707224068e687168dbda4ff
Reviewed-on: https://go-review.googlesource.com/112895
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Print output directly to the racebuild log instead of separate log
files per builder.
Cancel all builders at the first error: if there is something wrong
with the Go or compiler-rt commit, it's probably wrong globally.
Add a --platforms flag to attempt only a subset of builds: that way,
we can update only a subset (e.g., to work around OS-specific bugs) or
iterate on a single failing platform without attempting all the other
platforms at the same time.
Sanity-check the platforms table at init to ensure that there are no
duplicates for the same OS/arch combination.
Updates golang/go#24354.
Change-Id: Ic4d4ab32ca6cc13a150c9bbfcc2e5fbd3742d704
Reviewed-on: https://go-review.googlesource.com/112876
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
LLVM uses Subversion for their primary repository, so one might expect
that the rev passed to racebuild would be a Subversion revision
number. It is actually a git commit hash.
Updates golang/go#24354.
Change-Id: I8528f4f80477e256d889e3bbc98de6309f449c1c
Reviewed-on: https://go-review.googlesource.com/112875
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Google's Container-Optimized Linux's konlet container start-up program
creates any requested tmpfs mounts as noexec. That doesn't work for
doing builds in, so remount it as executable.
This is required to run builds on COS instead of GKE.
Updates golang/go#25108
Change-Id: I9b719caf9180a03bafefa5b3b4b47ee43b9e5c1c
Reviewed-on: https://go-review.googlesource.com/112715
Reviewed-by: Andrew Bonventre <andybons@golang.org>
x/tools/cmd/godoc and x/playground. I add myself as secondary to both
of them since I cannot do +2 votes, but I would like to participate in
reviews with the best of my knowledge.
Change-Id: Iedeb9320b6f76c67a9d15eb8f6f8956e4d2e2957
Reviewed-on: https://go-review.googlesource.com/112695
Reviewed-by: Andrew Bonventre <andybons@golang.org>
This page shows all entries with instructions on how to edit them.
It replaces the GET API that only allowed for matching a single
path in favor of using the POST endpoint for all requests.
Change-Id: I38e46d2ce01419fd030a743c669a9ffc482aeadd
Reviewed-on: https://go-review.googlesource.com/112617
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
* adds new buildgo.Client type to hold primarily a
buildenv.Environment and a google.Credentials
* starts to unify, document, and otherwise clean up
how we look up authentication info.
* use the new buildgo.Client type in the "buildongce"
(poorly named) cluster bootstrap tool.
* moves the "basepin" creation code from buildongce into
a new method on buildgo.Client, for later use in the
coordinator for golang/go#21305
Change-Id: I976b60c992bf67589e7f85fc5a9133f8cbb32e70
Reviewed-on: https://go-review.googlesource.com/112162
Reviewed-by: Bryan C. Mills <bcmills@google.com>
cmd/doc, cmd/vet, text/template/..., and x/tools/cmd/stringer. As a
secondary for now, as I generally don't +2 CLs, and most of them already
have owners.
Change-Id: Ib2163cc605995c71515a3e7873b7225981f53041
Reviewed-on: https://go-review.googlesource.com/112076
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Install qemu-user on the sid x86 builders to enable the QEMU user-mode
emulation tests added in CL 111477.
Change-Id: I28be452a843b7526b7d452b085e6fbfeb3a19ae7
Reviewed-on: https://go-review.googlesource.com/112077
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Note that I duplicated the contents of math to math/rand,
in order to be able to add myself to math/rand without math.
I have generally moved myself out of Primary into Secondary,
because I sometimes disappear without warning for non-trivial lengths of time.
I also saw lots of places where I thought the table was missing other folks,
but I was unsure about the appropriateness of making changes on their behalf.
Change-Id: Ie826f9909870d780dec51d0c825304025cb65219
Reviewed-on: https://go-review.googlesource.com/111915
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Previously, the ids[i].Owner < ids[i].Owner condition would never
be true due to the typo.
Found with staticcheck tool by Dominik Honnef.
Change-Id: Ia067e68909c7f30968c927d4bfa68ca5f7653959
Reviewed-on: https://go-review.googlesource.com/111878
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
This change fixes a copy-paste mistake from CL 38137, where the wrong
time variable was set to UTC when cmut.Updated is non-nil.
Change-Id: I4dc62abf9b70b52b700e3b6b688fa8adbc502d98
Reviewed-on: https://go-review.googlesource.com/111645
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Once containers run on COS instead of Kubernetes, one name (Kube*) is
wrong and the other (GCE) is ambiguous. So rename them now to be more
specific.
No behavior changes. Just renaming in this step, to reduce size of
next CL.
Updates golang/go#25108
Change-Id: Ib09eb682ef74acbbf6ed50b46074f834ef5e0c0b
Reviewed-on: https://go-review.googlesource.com/111639
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
This removes some duplication of scopes and how to get the
TokenSource and which credentials to use.
And update the coordinator deps, since its rev of
golang.org/x/oauth2/google was too old to have the new type.
I want to clean this up more, but I need to make some changes to to
the oauth2/google package first. More later.
Change-Id: Ic2799ec2ec62f67c65de6380b373fe915a43003e
Reviewed-on: https://go-review.googlesource.com/111266
Reviewed-by: Andrew Bonventre <andybons@golang.org>
Includes changes mistakenly omitted from 110996
Change-Id: I3e3da2590120f810d0413606c77cc0afa76029a9
Reviewed-on: https://go-review.googlesource.com/111115
Reviewed-by: Andrew Bonventre <andybons@golang.org>
The current logic returns the entry with the deepest path matched
to the given resource. Entries have Primary and Secondary fields
for indicating who should be in the Reviewer and CC fields in a
code review, respectively.
Change-Id: Icf315f7964326a2549146f2b0558de80749f0b5e
Reviewed-on: https://go-review.googlesource.com/110996
Reviewed-by: Bryan C. Mills <bcmills@google.com>
This updates both the 386 and the amd64 builder to the latest
NetBSD 8 release candidate, using the current versions of anita
(1.44) and pkgsrc packages (2018Q1).
Tested: ran both resulting images on GCE with buildlets.
Also added clang packages for use in golang/go#24354.
Change-Id: I00812f2ec315bca68fdfec14a6db1200d4f80d32
Reviewed-on: https://go-review.googlesource.com/109035
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Rename the 8branch builders from “8branch” to “8_0” (in keeping with
the version suffixes for FreeBSD and Darwin), and fix an apparent typo
in the 386 SSHUsername field.
Updates golang/go#25206.
Updates golang/go#25109.
Change-Id: I6053c8de17dcb3c7ff32da05c51902ac4bcc45fe
Reviewed-on: https://go-review.googlesource.com/110626
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Brad Fitzpatrick
Andrew Bonventre
Jeff Johnson
Dmitri Shuralyov
Lonnie Liu
Bryan C. Mills
Yury Smolsky
Elias Naur
Agniva De Sarker
Daniel Martí
Alberto Donizetti
Josh Bleecher Snyder
Benny Siegert