Including the fix for the XSAVE kernel bug.
For golang/go#46272.
Change-Id: Ie3a74db9199ac18c256447847c6cbd39105a8d00
Reviewed-on: https://go-review.googlesource.com/c/build/+/375374
Trust: Heschi Kreinick <heschi@google.com>
Run-TryBot: Heschi Kreinick <heschi@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Alex Rakoczy <alex@golang.org>
This change adds new flags to allow us to continue to release if a
builder for a given platform is down or inoperable. In any scenario,
releases will not be performed unless tests have been confirmed to pass
on a given architecture prior to using these flags.
Change-Id: I8b6093c0362edd1636cee65e617d48746db25245
Reviewed-on: https://go-review.googlesource.com/c/build/+/370615
Trust: Alex Rakoczy <alex@golang.org>
Run-TryBot: Alex Rakoczy <alex@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
We added a workaround in runtime/race on all supported versions
of Go (tip, 1.17, 1.16). This should not be necessary now.
Fixesgolang/go#49940.
Updates golang/go#49138.
Change-Id: Idd337785571fa6f429435b31d22d34bf3b346ff2
Reviewed-on: https://go-review.googlesource.com/c/build/+/374334
Trust: Cherry Mui <cherryyz@google.com>
Run-TryBot: Cherry Mui <cherryyz@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
This change adds the implementation for gomote instance alive. This
endpoint enables the caller to check if an instance is alive. If the
instance is alive, it will extend the gomote timeout time. A renew
timeout method has been added to the session pool. This differs from
the existing keep alive method in that it is an single call to renew
the timeout for an instance instead of a continuous renewal of the
timeout tied to the lifetime of a context.
Updated golang/go#48742
Change-Id: I3b3462407d9f4a02c4e2cea0f14950c8c9f21060
Reviewed-on: https://go-review.googlesource.com/c/build/+/374115
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
This change removes the default timeout set for gomote instance
creation. It also cleans up some gomote instance destruction logic.
Updates golang/go#48742
Change-Id: I888142facae23fbb12352c45e3740826b921f61a
Reviewed-on: https://go-review.googlesource.com/c/build/+/374114
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Alex Rakoczy <alex@golang.org>
This change adds the implementation for the gomote destroy instances endpoint.
Updates golang/go#48742
Change-Id: I8168c6f10583cb6609bce9daafd69e599cd1a349
Reviewed-on: https://go-review.googlesource.com/c/build/+/371814
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Alex Rakoczy <alex@golang.org>
This change implements the list instances endpoint for the gomote service.
Updates golang/go#48742
Change-Id: Ib59b9f70a399b4795aa33b9234227b50d08b12f5
Reviewed-on: https://go-review.googlesource.com/c/build/+/371817
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
Reviewed-by: Alex Rakoczy <alex@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
This change adds the authenticate implementation for the gomote
service. The endpoint will be used to verify that the user is
authenticated and authorized to use the service.
Updates golang/go#48742
Change-Id: Ic6ab4cfa7eeccc37c12c6c0d002464053f1708dc
Reviewed-on: https://go-review.googlesource.com/c/build/+/371719
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
Reviewed-by: Alex Rakoczy <alex@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
This change implements the endpoint to create gomote instances for the
gomote GRPC service. In the process of implementing creates, various
other changes were needed:
- Refactoring the remote session pool.
- Extending the fake schedule used for testing.
Updates golang/go#48742
Change-Id: I0c74e38539428d028917200ccd6bd0c58fa14801
Reviewed-on: https://go-review.googlesource.com/c/build/+/370662
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
The first beta release takes place after all issues that are both
release-blocking and not okay after beta1 are resolved. After the
release goes out, releasebot removes the 'okay-after-beta1' label
from all issues in that milestone to reduce noise, since the label
by that time loses its original meaning.
However, some release-blocking issues that are okay after beta 1
sometimes end up being unmarked as release-blockers. Improve the
removeOkayAfterBeta1 behavior to clean up such issues too.
Updates golang/go#50168.
Change-Id: Id04c0dabf35d928c86ababd46d6eb97b1fb83621
Reviewed-on: https://go-review.googlesource.com/c/build/+/372535
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Alex Rakoczy <alex@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
It's unexpected for there to be multiple release milestones that differ
only in case, but GitHub's data model allows for it to happen.
When it does, report a fatal error and let the human release coordinator
resolve it, since there's no one-size-fits-all automated resolution.
Fixesgolang/go#50199.
Updates golang/go#50168.
Change-Id: I752a913258cbdd78f15efdabb5d473ca4a2562d1
Reviewed-on: https://go-review.googlesource.com/c/build/+/372534
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Alex Rakoczy <alex@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
This change introduces the use of a buildlet client interface in
existing functions. This is being introduced in order to facilitate
testing.
Change-Id: I41cd5a372fc31edbd9bcba1859cdf84308360174
Reviewed-on: https://go-review.googlesource.com/c/build/+/371818
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Alex Rakoczy <alex@golang.org>
It has identical behavior but makes the code shorter and easier
to see that it's just a form POST, rather than something custom.
Also cap the body size it's willing to read for error reporting.
(Spotted while reading over this code.)
For golang/go#48739.
Change-Id: I586925d1a0c7e9a7e1efc93d121337a16fcee725
Reviewed-on: https://go-review.googlesource.com/c/build/+/371014
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
The CLA checker is no longer setting the 'cla: yes' label. Instead, it
functions as a standard GitHub Checker which we have to look at.
Rather than manually caching the ListCheckRunsForRef call, replace the
existing manual caching with httpcache, which I've verified prevents us
from consuming quota on repeated checks.
Fixesgolang/go#49696.
Change-Id: I362e8bc34bf503bf04771f5da0de7a7e53942f29
Reviewed-on: https://go-review.googlesource.com/c/build/+/371815
Trust: Heschi Kreinick <heschi@google.com>
Run-TryBot: Heschi Kreinick <heschi@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Gerritbot's duplicate suppression includes the full name of the
commenter, which means that if a commenter changes their name their
comments get reposted. This would be a mild irritation except that we
just changed gerritbot's name. Exclude the header from duplicate
detection.
To make it easier to test this change, add -single-pr, which ignores all
but one PR. Also do a TODO to move the config files to .config and cache
to .cache.
Fixesgolang/go#41997.
Change-Id: I807efec79f423fe8fded5d08770919fde279b2e5
Reviewed-on: https://go-review.googlesource.com/c/build/+/371455
Trust: Heschi Kreinick <heschi@google.com>
Run-TryBot: Heschi Kreinick <heschi@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
This change removes the go1.13 and go1.16 build constraints since they are no
longer needed.
Change-Id: I4428d4bc6df7d02d788dbdf6a5329dbd0d5e095b
Reviewed-on: https://go-review.googlesource.com/c/build/+/371454
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
This change adds functions which assists in the testing of authentication.
Updates golang/go#48729
Change-Id: Ibff9c758e97c5fd3584c6e68612e4d9db99baa5e
Reviewed-on: https://go-review.googlesource.com/c/build/+/371396
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
This moves the coordinator scheduler into a package. The span has also
been moved into the schedule package. It also adds a mostly
uimplemented fake scheduler.
Updates golang/go#38337
Updates golang/go#48742
Change-Id: I980241e8e8ba2acafa38f732fe480e66d9d3a4f3
Reviewed-on: https://go-review.googlesource.com/c/build/+/368676
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
This change adds a privileged flag for builders.
Updates golang/go#47521
Change-Id: Icbc72bc21dd4345da65c2e231f0f59af5dd05ca1
Reviewed-on: https://go-review.googlesource.com/c/build/+/370661
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
Reviewed-by: Alex Rakoczy <alex@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
This change moves the function which returns the appropriate pool for
the configuration passed in into the pool package. This work is being
done as part of a project to break the coordinator into seperate parts.
Updates golang/go#48742
Updates golang/go#38337
Change-Id: Ie5b3fc2da6534fca6e55ba6bb710db5e206efe00
Reviewed-on: https://go-review.googlesource.com/c/build/+/368674
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Reviewed-by: Alex Rakoczy <alex@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
The tooltip for builders with a known issue is displayed consistently
as of the last commit, but accessing a link in a tooltip is not easy.
It's reasonable to expect that known issues would be linked on the
builders page. Add a column with links there to make it so.
For golang/go#42405.
Change-Id: I5e915132f2ca05efc69bc76da1f25b897569be5d
Reviewed-on: https://go-review.googlesource.com/c/build/+/370335
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Now that both "ok" and "fail" cells have a link to the build log,
their presentation has become more similar than dissimilar.
Combine their previously-distinct presentation into one large block
with nested if statements to show "ok" vs "fail" states appropriately.
Always include a paragraph about a known builder issue, if any,
in all the cells that are dimmed out.
While here, apply the same change to the golang.org/x repo section,
bringing them to feature parity. (Previously, builders with a known
issue weren't dimmed out down there.)
Fixesgolang/go#42405.
Fixesgolang/go#42063.
Change-Id: I601fcfdc1aa67ad43665624b6894f213cf5b251b
Reviewed-on: https://go-review.googlesource.com/c/build/+/370334
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
The other thing I was surprised by was the builder key but I think
that's basically general knowledge.
Change-Id: I20db06a9e89d0e224a1d0e195cd848c3ed88459f
Reviewed-on: https://go-review.googlesource.com/c/build/+/365774
Trust: Heschi Kreinick <heschi@google.com>
Run-TryBot: Heschi Kreinick <heschi@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
The work to add macOS 12 builders for amd64 and arm64 was completed
ahead of Go 1.18 Beta 1, so we have the opportunity to pick between
starting to use them or stay with existing macOS 11 builders longer.
As part of go.dev/issue/40561 we discussed our available options and
opted to select macOS 12 releaselets for Go 1.18 on both architectures,
starting with first beta release. This CL implements that decision.
Tested:
I ran 'release -target=darwin-amd64 -version=go1.18beta123 -rev=HEAD'
locally and it completed successfully; all.bash release tests passed.
For golang/go#40561.
Change-Id: Ia80c4862a5137b5264c7a855452be25bddd79840
Reviewed-on: https://go-review.googlesource.com/c/build/+/369958
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
The builder has been missing for a number of weeks and isn't showing
signs of coming back. We have test coverage for linux/riscv64 via two
other builders, and Brad said he was happy to stop running this one,
so removing it is a good next step. Thanks for the service it provided!
Fixesgolang/go#49325.
Change-Id: I077edaa9b0155201f08f6a59d3e4b6d69a633797
Reviewed-on: https://go-review.googlesource.com/c/build/+/369214
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
The work needed to resolve go.dev/issue/49616 looks
to be complete, and the builder is passing reliably.
Updates golang/go#49616.
Change-Id: I90253c7751f97f081496abe90b1e827992afaf6e
Reviewed-on: https://go-review.googlesource.com/c/build/+/369255
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Start using the new shorter go.dev domain name where applicable,
such as when making announcement tweets. The previous name will
always work too, but we want to be consistent and up to date in
our external communication.
Continue to use golang.org/dl when it refers to the module path
since that hasn't changed.
Change-Id: I897ae4cdfb0b4af396923691887e701b95b8f93b
Reviewed-on: https://go-review.googlesource.com/c/build/+/368975
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
This change increases the resources requested for the coordinator. It
also adds hard limits for the resources.
Change-Id: Iac5f4f0158c9c9ce0293167b2a27972be1460ae1
Reviewed-on: https://go-review.googlesource.com/c/build/+/368874
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
This change also fixes up a bunch of comments and logged messages.
Note that this is necessary because although the golang.org URL leads to
a redirect, it's a 301, which causes the POST to turn into a GET,
resulting in a 405 bad method error.
Change-Id: Ib8521a63b612f293491669b141d068929697ecaf
Reviewed-on: https://go-review.googlesource.com/c/build/+/368894
Reviewed-by: Carlos Amedee <carlos@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Trust: Michael Knyszek <mknyszek@google.com>
We don't make Go 1.15 minor releases by now, so including the
darwin-arm64 build "for Go 1.16 Beta 1 and newer" is the same
as always including it.
Also update test coverage that the list of builds for Go 1.18
is the same as Go 1.17, as expected.
Change-Id: If89a25e8179de48a2c2fabe78248897a67785416
Reviewed-on: https://go-review.googlesource.com/c/build/+/368414
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
CL 365736 updated the builder to macOS 12 out of necessity, since
the macOS 11 builder was not available then. Based on discussion
since, the builder is back though in limited capacity. Continue
to use it for Go 1.17 and 1.16 minor releases, with the plan to
start using macOS 12 builder for Go 1.18 and onwards.
Fixesgolang/go#49889.
Updates golang/go#40561.
Change-Id: Ie9b6341b7c1f378e26e2226fc2bb4c3cb7042f9b
Reviewed-on: https://go-review.googlesource.com/c/build/+/368394
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
This change updates the builders used for go1.18 by:
- Using FreeBSD 12.2
It also removes unused releaselets (Go version < 1.16).
Updates golang/go#40561
Change-Id: I3f46d197e9d235cf4577a1687848f8b52981c5e3
Reviewed-on: https://go-review.googlesource.com/c/build/+/365694
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Plan 9 has a non-standard "git" CLI,
and x/review contains only a git hook.
Change-Id: I9b77ae772afa714e95d814b038a4ebedbd95151c
Reviewed-on: https://go-review.googlesource.com/c/build/+/368154
Trust: Bryan C. Mills <bcmills@google.com>
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: David du Colombier <0intro@gmail.com>
This change removes an unnecessary builder from the logic used to run
a build on boring crypto changes.
Updates golang/go#47845
Change-Id: I2223db8907feea72a80cdeb5629abc02512ee0f2
Reviewed-on: https://go-review.googlesource.com/c/build/+/368155
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
This tracks CPU quota when scheduling instances, and shows quota use in
the coordinator UI.
Change-Id: I60f2382657757a4a1dd1952327934f8f6a44e414
Reviewed-on: https://go-review.googlesource.com/c/build/+/367555
Trust: Alexander Rakoczy <alex@golang.org>
Run-TryBot: Alexander Rakoczy <alex@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
The configuration directory must be created before the token is stored
in it. This change ensures that the directory exists before attempting
to store the newly created token in it.
Updates golang/go#48739
Change-Id: I2db71485c166ba094e61690533849c33913a5530
Reviewed-on: https://go-review.googlesource.com/c/build/+/367535
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
This change ensures the buildenv is set when the coordinator is
running in production.
Updates golang/go#47521
Change-Id: Ibd1a31609f5e85ac6445bad5daec5222a06b13e4
Reviewed-on: https://go-review.googlesource.com/c/build/+/367554
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
We recently migrated in CL 354757 from n1 to e2 hosts around the same
time issues started appearing with these builders. n1 hosts are notably
different in that they are older generation CPUs with hyperthreading
disabled.
e2 hosts may sometimes be AMD CPUs. n2d hosts are always AMD,
so this helps bisect the problem. n2 hosts are always Intel.
For golang/go#49209
Change-Id: I60334b44e192b0b95293891b380f2a89227b9235
Reviewed-on: https://go-review.googlesource.com/c/build/+/367534
Trust: Alexander Rakoczy <alex@golang.org>
Run-TryBot: Alexander Rakoczy <alex@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
CL 363474 added a 2012 builder, which is good, but it also took a major
step in sunsetting Windows 7 support by removing all 2008 builders from
trybots and for Go 1.18+. This will surely bitrot Windows 7 support and
force us to remove support for it, which isn't okay. Rather than line up
dominoes to force our hand on policy, such huge policy changes with
sweeping ramifications should be properly decided.
So, this commit keeps the 2008 builders in the running, alongside the
2012 ones.
Updates golang/go#47845.
Updates golang/go#49490.
Change-Id: I574f51ea22f638d2f9b09fcd00fdfc3097631771
Reviewed-on: https://go-review.googlesource.com/c/build/+/366656
Trust: Jason A. Donenfeld <Jason@zx2c4.com>
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Jason A. Donenfeld <Jason@zx2c4.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
This change mounts the gomote and coordinator servers in the proper
locations.
Updates golang/go#47521
Updates golang/go#49191
Change-Id: I7c0054028fa928ba025b3c511701512e183894fd
Reviewed-on: https://go-review.googlesource.com/c/build/+/365735
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
This change:
- Adds a simple GRPC gomote server.
- Updates the documentation for the audiance required for IAP authentication.
- Adds a field for the backend service id in the build enviornment package.
- Creates middleware for the GRPC server use in the existing HTTP servers.
Updates golang/go#47521
Updates golang/go#48742
Change-Id: I2a56e39b96bf1b429f807f79c58aee3f72a45a33
Reviewed-on: https://go-review.googlesource.com/c/build/+/361098
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
The x/talks repository followed suit after x/blog and x/tour
and has been merged into x/website. CL 366177 removes all of
its moved content, leaving just a README.
Stop displaying it on the build dashboard and running post-submit
tests. Keep TryBots enabled in case a CL is sent with new Go code.
Change-Id: I8c13945b5ae04560d254ba679bf80696f44bed25
Reviewed-on: https://go-review.googlesource.com/c/build/+/366574
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Accidentally removed in the fix for an accidental removal because I am
in too much of a hurry today.
Change-Id: I67a5518f36b051c2e99c0d3cabed3d61ce3401e9
Reviewed-on: https://go-review.googlesource.com/c/build/+/366234
Trust: Heschi Kreinick <heschi@google.com>
Run-TryBot: Heschi Kreinick <heschi@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
This change refactors the existing remote buildlet session management
implementation. It implements logic which was originally found in the
HTTP handlers and moves it into a session manager. This change also
introduces a fake buildlet client intended to be used for testing when
additional functionality is added to the session pool.
Updates golang/go#48735
Change-Id: Ib7d66cefb9847cf2659e7049f707d78536fbbbea
Reviewed-on: https://go-review.googlesource.com/c/build/+/361097
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
This change updates the version of FreeBSD used for the
freebsd-amd64-race builder to 13.0. The slowbot aliases have been
updated to use FreeBSD 13.0.
Updates golang/go#46272
Updates golang/go#45903
Change-Id: I1092f9e6bf66a9f429b463dce5d0d5647d44eec8
Reviewed-on: https://go-review.googlesource.com/c/build/+/365616
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
We need this on every build and I forgot to put it on the new ones. Move
it to the host where it's not forgettable.
Hopefully fixesgolang/go#49723.
Change-Id: I9263f8aa9d847250bb438f59c04fe48bcfd5b1da
Reviewed-on: https://go-review.googlesource.com/c/build/+/366136
Trust: Heschi Kreinick <heschi@google.com>
Run-TryBot: Heschi Kreinick <heschi@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Heschi Kreinick
Alexander Rakoczy
Cherry Mui
Carlos Amedee
Michael Pratt
Dmitri Shuralyov
Michael Anthony Knyszek
Changkun Ou
Bryan C. Mills
Roland Shoemaker
Jason A. Donenfeld