зеркало из https://github.com/golang/build.git
8bad2a8c99
Now Close always means destroy. The old code & API was a half-baked implementation of a (lack of) design where there was a difference between being done with a buildlet (with it possibly being reused by somebody else?) and you wanting to nuke it completely. Unfortunately this just grew messier and more broken over time. This attempts to clean it all up. We can add the sharing ideas back later when there's actually a design and implementation. (We're not losing anything with this CL, because nothing ever shared buildlets) In fact, this CL fixes a problem where reverse buildlets weren't getting their underlying net.Conns closed when their healthchecks failed, leading to 4+ hour (and counting) build hangs due to buildlets getting killed at inopportune moments (e.g. me testing running a reverse buildlet on my home mac to help out with the dashboard backlog) Change-Id: I07be09f4d5f0f09d35e51e41c48b1296b71bb9b5 Reviewed-on: https://go-review.googlesource.com/14585 Reviewed-by: David Crawshaw <crawshaw@golang.org> Reviewed-by: Andrew Gerrand <adg@golang.org> |
||
|---|---|---|
| .. | ||
| buildletclient.go | ||
| gce.go | ||
| keypair.go | ||
| remote.go | ||