crypto/ssh
Dave Cheney 77de70a8d4 ssh: fix flake in TestHostKeyCert
Update golang/go#11811

The increased default concurrency in Go 1.5 showed up a test flake in
the TestHostKeyCert test. Under load, when the client provided incorrect
data, both sides would race to tear down the connection, which would often
lead to the server side, running in its own goroutine to see an unexpected
EOF or connection reset.

Fix this flake (and the incorrect use of t.Fatalf) by passing the error back
to the main goroutine for inspection. This also lets us ignore the expected
error in the unsuccessful path

Change-Id: I5a95c6d240479e9d537f34177e5ca8023b1b08e9
Reviewed-on: https://go-review.googlesource.com/12916
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
2015-08-02 23:53:45 +00:00
..
agent crypto/ssh: allow identities to be constrained. 2015-07-16 17:35:58 +00:00
terminal ssh/terminal: fix SetSize when nothing on current line 2014-12-19 22:48:49 +00:00
test crypto/ssh: allow identities to be constrained. 2015-07-16 17:35:58 +00:00
testdata crypto/ssh: update references to the old code.google.com repo 2015-04-22 11:59:31 +00:00
benchmark_test.go go.crypto/ssh: import gosshnew. 2014-04-09 13:57:52 -07:00
buffer.go go.crypto/ssh: import gosshnew. 2014-04-09 13:57:52 -07:00
buffer_test.go go.crypto/ssh: import gosshnew. 2014-04-09 13:57:52 -07:00
certs.go ssh: Add explicit type in comparison with constant to make go-fuzz happy 2015-06-22 23:34:07 +00:00
certs_test.go ssh: fix flake in TestHostKeyCert 2015-08-02 23:53:45 +00:00
channel.go go.crypto/ssh: reuse packet buffer for channel writes. 2014-09-16 12:30:05 -07:00
cipher.go x/crypto/ssh: add padding oracle countermeasures for AES-CBC. 2015-05-30 19:27:53 +00:00
cipher_test.go crypto/ssh: fix format string error in test. 2015-06-08 19:52:49 +00:00
client.go ssh: return session ID in ConnMeta.SessionID. 2015-02-04 17:27:33 +00:00
client_auth.go go.crypto/ssh: fix authentication after all public keys are rejected by a server. 2014-05-13 10:51:53 -07:00
client_auth_test.go go.crypto/ssh: use permissions from public key cache when accepting a key. 2014-05-12 11:19:56 -07:00
client_test.go go.crypto/ssh: import gosshnew. 2014-04-09 13:57:52 -07:00
common.go ssh: add hmac-sha2-256. 2015-05-14 18:39:32 +00:00
connection.go x/crypto/ssh: fix comment 2015-07-06 16:48:17 +00:00
doc.go crypto/ssh: fix the links to the SSH protocol documents 2015-04-16 17:18:06 +00:00
example_test.go ssh: make godoc examples easier to reuse 2015-02-02 06:42:08 +00:00
handshake.go ssh: fix deadlock during error path 2015-07-30 21:10:58 +00:00
handshake_test.go ssh: skip TestHandshakeBasic on Plan 9 2015-07-30 09:22:02 +00:00
kex.go go.crypto/ssh: import gosshnew. 2014-04-09 13:57:52 -07:00
kex_test.go go.crypto/ssh: import gosshnew. 2014-04-09 13:57:52 -07:00
keys.go go.crypto/ssh: import gosshnew. 2014-04-09 13:57:52 -07:00
keys_test.go go.crypto: use golang.org/x/... import paths 2014-11-10 08:50:25 +11:00
mac.go ssh: add hmac-sha2-256. 2015-05-14 18:39:32 +00:00
mempipe_test.go ssh: fix spelling of test so that it runs 2015-07-15 23:39:58 +00:00
messages.go x/crypto/ssh: fix bounds check in parseString 2015-06-27 22:03:05 +00:00
messages_test.go x/crypto/ssh: fix bounds check in parseString 2015-06-27 22:03:05 +00:00
mux.go go.crypto/ssh: only offset channel IDs when debugMux is 2014-04-14 09:23:18 -07:00
mux_test.go go.crypto/ssh: reuse packet buffer for channel writes. 2014-09-16 12:30:05 -07:00
server.go x/crypto/ssh: bail early if a server has no auth methods configured. 2015-05-11 18:34:55 +00:00
session.go go.crypto/ssh: import gosshnew. 2014-04-09 13:57:52 -07:00
session_test.go x/crypto/ssh: bail early if a server has no auth methods configured. 2015-05-11 18:34:55 +00:00
tcpip.go go.crypto/ssh: clean up address parsing in forward code. 2014-09-16 12:34:31 -07:00
tcpip_test.go go.crypto/ssh: import gosshnew. 2014-04-09 13:57:52 -07:00
testdata_test.go go.crypto: use golang.org/x/... import paths 2014-11-10 08:50:25 +11:00
transport.go crypto/ssh: add support for aes128-cbc cipher. 2015-04-10 21:42:31 +00:00
transport_test.go go.crypto/ssh: import gosshnew. 2014-04-09 13:57:52 -07:00