go
/
dep
зеркало из https://github.com/golang/dep.git
1
0
Форкнуть 0
Код Задачи Пакеты Проекты Релизы Вики Активность
dep/internal/gps/cmd_windows.go

15 строки
356 B
Go
Исходник Обычный вид История

Split proc termination paths for UNIX vs. Windows This allows us to rely on gentler termination semantics (os.Interrupt) for UNIX-y systems, as such interrupts do not work on Windows. Terminations are triggered by e.g. ctrl-C interrupts. Relying generally on Process.Kill() for such purposes was causing git to often exit in unclean ways, resulting in a dirty cache dir and putting users in an awkward position. We maintain the invariant that we ensure the process IS either exited, or forcibly Process.Kill()ed, before exiting monitoredCmd.run(). This allows us to ensure we do not have orphan subprocesses that exist beyond the lifetime of the parent sourceMgr.
2017-07-20 05:11:06 +03:00
// Copyright 2017 The Go Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.
// +build windows
package gps
import "os/exec"
Update sig of killProcess() for windows
2017-07-21 17:53:21 +03:00
func killProcess(cmd *exec.Cmd, isDone *int32) error {
Split proc termination paths for UNIX vs. Windows This allows us to rely on gentler termination semantics (os.Interrupt) for UNIX-y systems, as such interrupts do not work on Windows. Terminations are triggered by e.g. ctrl-C interrupts. Relying generally on Process.Kill() for such purposes was causing git to often exit in unclean ways, resulting in a dirty cache dir and putting users in an awkward position. We maintain the invariant that we ensure the process IS either exited, or forcibly Process.Kill()ed, before exiting monitoredCmd.run(). This allows us to ensure we do not have orphan subprocesses that exist beyond the lifetime of the parent sourceMgr.
2017-07-20 05:11:06 +03:00
// TODO it'd be great if this could be more sophisticated...
return cmd.Process.Kill()
}