Граф коммитов

2681 Коммитов

Автор SHA1 Сообщение Дата
sam boyer 83789e236d Prep CHANGELOG for release 2017-09-18 20:55:13 -04:00
sam boyer f19f31967a Merge pull request #1179 from darkowlzz/changelog
add CHANGELOG.md
2017-09-18 20:53:40 -04:00
Tamir Duberstein 7d388fa747
gps: use commandContext 2017-09-18 19:47:51 -04:00
Tamir Duberstein a374f1cebd
gps: DRY 2017-09-18 19:47:43 -04:00
Tamir Duberstein 2b5ebb1ced
gps: include output in error 2017-09-18 19:46:29 -04:00
Sunny 8ef8b74206 add CHANGELOG.md 2017-09-19 01:30:08 +05:30
sam boyer 418356b629 Merge pull request #1178 from darkowlzz/gps-sourcemanager-doc-typo
docs(gps): DeduceRootProject -> DeduceProjectRoot
2017-09-18 09:16:29 -04:00
Jordan Krage 58a88e9508 hack: update validate-license to include *.proto and exclude *.pb.go 2017-09-18 07:32:51 -05:00
Sunny c4b0dcf63e docs(gps): DeduceRootProject -> DeduceProjectRoot 2017-09-18 17:46:35 +05:30
sam boyer 166626d8a8 Merge pull request #1138 from jmank88/multi_cache
gps: source cache: adding multiCache
2017-09-17 23:05:22 -04:00
sam boyer 92657ba181 Merge pull request #1165 from jmank88/discard_logger
testing: de-globalize discard loggers
2017-09-17 22:39:31 -04:00
sam boyer 5aa4ffe3c2 Merge pull request #1079 from sdboyer/warn-case-mismatch
Add satisfiability check for case variants
2017-09-17 22:27:17 -04:00
sam boyer cbf031832d gps: don't fold inputs to root deduction
But, still preserve the rule that we record the canonical folded URL in
memory, so that we can have non-canonical inputs come in first and still
converge with subsequent canonical, or other-case-variant forms later.
2017-09-17 22:16:34 -04:00
sam boyer 101c2d9664 gps: Add helpful debugging info to test logging
Keeping track of what maps to what in the sourceGateway setup can be
really tricky with all the combinations; in the event of failures in
this test, this will show the mapping tables, which helps a lot with
understanding the actual final state.
2017-09-17 22:11:51 -04:00
Jordan Krage 8008324d65 gps: source cache: protobuf integration 2017-09-15 10:50:17 -05:00
Jordan Krage d61fa38258 testing: de-globalize discard loggers 2017-09-14 14:57:02 -05:00
Carolyn Van Slyck d62440d304 Merge pull request #1145 from carolynvs/importers-package
cmd/dep: Move importers under internal/importers
2017-09-14 14:31:29 -05:00
sam boyer 95db3e188f Merge pull request #1110 from tamird/remove-timeouts
gps: remove arbitrary command timeouts
2017-09-13 23:14:11 -04:00
Michael Gokhman cacb8ff9c2 add SourceURLsForPath to SourceManager ineterface
to expose the deduced possible source URLs for a given import path.
This information is useful for importing configuration from other tools
that support vendoring forks
2017-09-13 18:32:14 +03:00
Tamir Duberstein 9e660334de
gps: remove arbitrary command timeouts
Use better context plumbing while I'm here.
2017-09-12 23:46:46 -04:00
Carolyn Van Slyck 02bf38cf28
importers: add missing license header 2017-09-12 20:51:00 -05:00
sam boyer eac1f47d33 Merge pull request #1155 from tamird/simplify-errors
gps: use golang.org/x/sync/errgroup
2017-09-12 21:47:20 -04:00
Tamir Duberstein 01209b5e7d
gps: use golang.org/x/sync/errgroup
...instead of custom code that does the same thing. Return
informative errors rather than logging directly (into the abyss).

Also remove sourceFailure{,s} while I'm here, which are unnecessary.

Also `dep prune` real quick.
2017-09-12 14:13:59 -04:00
sam boyer 35e1a38565 Merge pull request #1161 from sdboyer/require-pruning
ci: enforce that dep prune is run
2017-09-12 13:24:02 -04:00
Vedhavyas Singareddi 16cfaf9f11 ensure-add/avoid panic when adding current project as its own dependency (#1147)
* add failing test for self add

* check if the import project is current project and bail out

* add init test case

* use strings.EqualFold for path check
2017-09-12 19:47:29 +03:00
sam boyer 50bcf4ce75 CI: enforce that dep prune is run 2017-09-12 12:24:42 -04:00
Carolyn Van Slyck 9469f9e532
Update codeowners for importers 2017-09-11 22:02:28 -05:00
Carolyn Van Slyck 8de823b7c4
internal/importers: fix filename stutter 2017-09-11 22:02:27 -05:00
Carolyn Van Slyck 4eac4ce179
cmd/dep: Move importers under internal/importers 2017-09-11 22:02:27 -05:00
sam boyer d1f8b3837e Merge pull request #1157 from tamird/static-checker
Add static checkers
2017-09-11 21:03:13 -04:00
Tamir Duberstein 3a25b0b519
Add golint
/Users/tamird/src/go/src/github.com/golang/dep/context.go:86:1: exported method Ctx.SourceManager should have comment or be unexported
/Users/tamird/src/go/src/github.com/golang/dep/internal/gps/cmd.go:75:13: should omit type *int32 from declaration of var isDone; it will be inferred from the right-hand side
/Users/tamird/src/go/src/github.com/golang/dep/internal/gps/version.go:122:1: exported method Revision.ImpliedCaretString should have comment or be unexported
/Users/tamird/src/go/src/github.com/golang/dep/internal/test/test.go:27:2: exported var ExeSuffix should have comment or be unexported
/Users/tamird/src/go/src/github.com/golang/dep/internal/test/test.go:29:15: should omit type *bool from declaration of var PrintLogs; it will be inferred from the right-hand side
/Users/tamird/src/go/src/github.com/golang/dep/internal/test/test.go:30:15: should omit type *bool from declaration of var UpdateGolden; it will be inferred from the right-hand side
/Users/tamird/src/go/src/github.com/golang/dep/internal/test/test.go:194:1: comment on exported method Helper.Run should be of the form "Run ..."
/Users/tamird/src/go/src/github.com/golang/dep/internal/test/test.go:449:1: comment on exported method Helper.GetFile should be of the form "GetFile ..."
/Users/tamird/src/go/src/github.com/golang/dep/internal/test/test.go:611:1: exported method Helper.GetCommit should have comment or be unexported
2017-09-11 19:22:23 -04:00
Tamir Duberstein 38a0b24462
Use megacheck 2017-09-11 19:22:23 -04:00
Tamir Duberstein d9c8bd6dd1
Add honnef.co/go/tools/cmd/unused
cmd/dep/ensure.go:138:2: field overrides is unused (U1000)
cmd/dep/ensure.go:702:6: type stringSlice is unused (U1000)
internal/gps/bridge.go:60:2: field crp is unused (U1000)
internal/gps/pkgtree/pkgtree_test.go:36:3: field Internal is unused (U1000)
internal/gps/pkgtree/pkgtree_test.go:36:13: field External is unused (U1000)
internal/gps/selection.go:76:21: func (*selection).setDependenciesOn is unused (U1000)
internal/gps/selection.go:99:21: func (*selection).getSelectedPackagesIn is unused (U1000)
internal/gps/solve_basic_test.go:1356:33: func (*depspecSourceManager).ExternalReach is unused (U1000)
internal/gps/solve_basic_test.go:1571:16: func fixLock.SolverVersion is unused (U1000)
internal/gps/solve_basic_test.go:1588:18: func dummyLock.SolverVersion is unused (U1000)
internal/gps/solve_failures.go:20:2: const warning is unused (U1000)
internal/gps/solve_failures.go:21:2: const mustResolve is unused (U1000)
internal/gps/solve_failures.go:22:2: const cannotResolve is unused (U1000)
internal/gps/source_manager.go:217:4: func Temporary is unused (U1000)
internal/gps/source_manager.go:712:2: const ctCheckoutVersion is unused (U1000)
internal/gps/typed_radix.go:34:23: func (*deducerTrie).Delete is unused (U1000)
internal/gps/vcs_repo.go:201:6: type svnRepo is unused (U1000)
internal/gps/vcs_repo_test.go:122:6: func testSvnRepo is unused (U1000)
internal/gps/vcs_source.go:573:6: type repo is unused (U1000)
internal/gps/version_queue_test.go:30:23: func (*fakeBridge).ListVersions is unused (U1000)
internal/gps/version_queue_test.go:45:27: func (*fakeFailBridge).ListVersions is unused (U1000)
internal/test/integration/testproj.go:34:2: field h is unused (U1000)
2017-09-11 19:22:23 -04:00
sam boyer aa8e0765ed Merge pull request #1154 from tamird/remove-unnecessary-once
gps: simplify shutdown cleanup
2017-09-11 19:19:46 -04:00
Jordan Krage 586f5a19df Merge pull request #1158 from tamird/travis-lint
Build all packages before running linters
2017-09-11 17:55:50 -05:00
Tamir Duberstein 45da465d4c
gps: simplify shutdown cleanup
The previous code here was doing some odd things with CAS, none of
which was necessary. There's no functional change here, it's just
simpler.
2017-09-11 15:39:09 -04:00
Tamir Duberstein a0b325d96e
gps: avoid a goroutine using time.AfterFunc 2017-09-11 15:35:35 -04:00
Tamir Duberstein e5685bfbd9
Build all packages before running linters
`go vet`, in particular, is known for relying on the package cache
for code analysis.

Fix addional `go vet` warnings revealed by this.
2017-09-11 15:32:26 -04:00
Tamir Duberstein 0d49338683
gps: remove useless loop 2017-09-11 15:24:56 -04:00
Tamir Duberstein 43326804e4
gps: use atomic.LoadInt32 instead of CAS 2017-09-11 13:34:37 -04:00
sam boyer beb6bb13a1 Merge pull request #1153 from tamird/remove-ununused-cancel
gps: remove unused context.WithCancel
2017-09-11 12:25:55 -04:00
sam boyer 9e038e69dc Ensure URLs are folded as well
Also add an up-front check for case variant map lookup misses, and
update the map accordingly.
2017-09-10 23:22:07 -04:00
Tamir Duberstein 02eed27ce1
gps: remove unused context.WithCancel
Remove unnecessary getLifetimeContext method while I'm here.
2017-09-10 20:45:22 -04:00
sam boyer a665a6e85a Accommodate case folding in older mgr test 2017-09-10 19:31:52 -04:00
sam boyer bddd3f4bba Treat ProjectRoot as case-insensitive in srcCoord 2017-09-10 19:31:52 -04:00
sam boyer 70d2f5b695 Tests for combined source & case variance 2017-09-10 19:29:25 -04:00
sam boyer 56ce3a4513 Add test for import path case-sense handling in SM 2017-09-10 19:29:25 -04:00
sam boyer 3d369c50a9 Add the wrongCaseFailure, and scads more fixtures 2017-09-10 19:29:25 -04:00
sam boyer 6592101eeb Case insensitivity magic for roots in fixtures
This effectively makes them case-insensitive, case-preserving.
2017-09-10 19:29:25 -04:00
sam boyer 8670e66f5a Add wrongCaseFailure
May or may not end up using this right away, but it'll be in place for
when we have the slightly stronger failure case of a project being
addressed with an incorrect case, as indicated by the project's way
of referencing its own packages.
2017-09-10 19:29:25 -04:00